Re: [libav-devel] ff_combine_frame usage fixes

2014-11-24 Thread Vittorio Giovara
On Mon, Nov 24, 2014 at 3:22 PM, Luca Barbato wrote: > On 24/11/14 14:49, Hendrik Leppkes wrote: >> >> On Sun, Nov 23, 2014 at 10:52 PM, Luca Barbato wrote: >> >>> On 20/11/14 16:41, Vittorio Giovara wrote: >>> And with the power of git am and sed, here is the updated set, with small >>

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-24 Thread Luca Barbato
On 24/11/14 14:49, Hendrik Leppkes wrote: On Sun, Nov 23, 2014 at 10:52 PM, Luca Barbato wrote: On 20/11/14 16:41, Vittorio Giovara wrote: And with the power of git am and sed, here is the updated set, with small cosmetic fixes here and there. I reorder the set in three "chapters", and I'd n

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-24 Thread Hendrik Leppkes
On Sun, Nov 23, 2014 at 10:52 PM, Luca Barbato wrote: > On 20/11/14 16:41, Vittorio Giovara wrote: > >> And with the power of git am and sed, here is the updated set, with small >> cosmetic fixes here and there. I reorder the set in three "chapters", and >> I'd not mind to squash the cosmetics in

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-23 Thread Luca Barbato
On 20/11/14 16:41, Vittorio Giovara wrote: And with the power of git am and sed, here is the updated set, with small cosmetic fixes here and there. I reorder the set in three "chapters", and I'd not mind to squash the cosmetics in a single one. Vittorio If there isn't any other comment I'd me

[libav-devel] ff_combine_frame usage fixes

2014-11-20 Thread Vittorio Giovara
And with the power of git am and sed, here is the updated set, with small cosmetic fixes here and there. I reorder the set in three "chapters", and I'd not mind to squash the cosmetics in a single one. Vittorio Luca Barbato (21): cosmetics: Format mjpeg_parser cosmetics: Format aac_ac3_parser

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-20 Thread Luca Barbato
On 20/11/14 07:03, Anton Khirnov wrote: > Quoting Luca Barbato (2014-11-19 22:18:41) >> On 19/11/14 18:42, Vittorio Giovara wrote: > [...] >> >> For public function sure, for small utility functions that will change >> totally in the next month or two, I'd say *discussing* is overkill. >> >>> A bet

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-19 Thread Anton Khirnov
Quoting Luca Barbato (2014-11-19 22:18:41) > On 19/11/14 18:42, Vittorio Giovara wrote: [...] > > For public function sure, for small utility functions that will change > totally in the next month or two, I'd say *discussing* is overkill. > > > A better grouping could be > > > > ff_ + ${obje

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-19 Thread Luca Barbato
On 19/11/14 18:42, Vittorio Giovara wrote: > On Wed, Nov 19, 2014 at 11:00 AM, Luca Barbato wrote: >> On 19/11/14 07:22, Vittorio Giovara wrote: >>> On Tue, Nov 18, 2014 at 2:27 PM, Vittorio Giovara >>> wrote: On Tue, Nov 18, 2014 at 10:00 AM, Luca Barbato wrote: > On 18/11/14 09:16, He

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-19 Thread Vittorio Giovara
On Wed, Nov 19, 2014 at 11:00 AM, Luca Barbato wrote: > On 19/11/14 07:22, Vittorio Giovara wrote: >> On Tue, Nov 18, 2014 at 2:27 PM, Vittorio Giovara >> wrote: >>> On Tue, Nov 18, 2014 at 10:00 AM, Luca Barbato wrote: On 18/11/14 09:16, Hendrik Leppkes wrote: > On Tue, Nov 18, 2014 at

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-19 Thread Luca Barbato
On 19/11/14 07:22, Vittorio Giovara wrote: > On Tue, Nov 18, 2014 at 2:27 PM, Vittorio Giovara > wrote: >> On Tue, Nov 18, 2014 at 10:00 AM, Luca Barbato wrote: >>> On 18/11/14 09:16, Hendrik Leppkes wrote: On Tue, Nov 18, 2014 at 8:56 AM, Luca Barbato wrote: > On 18/11/14 00:57, K

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-18 Thread Vittorio Giovara
On Tue, Nov 18, 2014 at 2:27 PM, Vittorio Giovara wrote: > On Tue, Nov 18, 2014 at 10:00 AM, Luca Barbato wrote: >> On 18/11/14 09:16, Hendrik Leppkes wrote: >>> On Tue, Nov 18, 2014 at 8:56 AM, Luca Barbato wrote: >>> On 18/11/14 00:57, Kieran Kunhya wrote: >> I added ff_combine_packet

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-18 Thread Vittorio Giovara
On Tue, Nov 18, 2014 at 10:00 AM, Luca Barbato wrote: > On 18/11/14 09:16, Hendrik Leppkes wrote: >> On Tue, Nov 18, 2014 at 8:56 AM, Luca Barbato wrote: >> >>> On 18/11/14 00:57, Kieran Kunhya wrote: > I added ff_combine_packet since it reduces the number of lines > and makes the code sl

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-18 Thread Luca Barbato
On 18/11/14 09:16, Hendrik Leppkes wrote: > On Tue, Nov 18, 2014 at 8:56 AM, Luca Barbato wrote: > >> On 18/11/14 00:57, Kieran Kunhya wrote: I added ff_combine_packet since it reduces the number of lines and makes the code slightly less verbose. >>> >>> This is very confusing since ff_

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-18 Thread Hendrik Leppkes
On Tue, Nov 18, 2014 at 8:56 AM, Luca Barbato wrote: > On 18/11/14 00:57, Kieran Kunhya wrote: > >> I added ff_combine_packet since it reduces the number of lines > >> and makes the code slightly less verbose. > > > > This is very confusing since ff_combine_packet suggests an AVPacket is > involv

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-17 Thread Luca Barbato
On 18/11/14 00:57, Kieran Kunhya wrote: >> I added ff_combine_packet since it reduces the number of lines >> and makes the code slightly less verbose. > > This is very confusing since ff_combine_packet suggests an AVPacket is > involved. It will and it is not less confusing that using "frame" si

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-17 Thread Kieran Kunhya
> I added ff_combine_packet since it reduces the number of lines > and makes the code slightly less verbose. This is very confusing since ff_combine_packet suggests an AVPacket is involved. Kieran ___ libav-devel mailing list libav-devel@libav.org https

[libav-devel] ff_combine_frame usage fixes

2014-11-17 Thread Luca Barbato
The function may return a non-fatal error (needs more data) and a fatal error (not enough memory). I went over the codebase and fixed that all over and not just where coverity spotted it. I added ff_combine_packet since it reduces the number of lines and makes the code slightly less verbose. __