Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-08 Thread Diego Biurrun
On Sat, Dec 08, 2012 at 08:42:36AM -0800, Ronald S. Bultje wrote: > On Sat, Dec 8, 2012 at 8:41 AM, Måns Rullgård wrote: > > "Ronald S. Bultje" writes: > >> Use this in VP8/H264-8bit loopfilter functions so they can be used if > >> there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). > >> ---

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-08 Thread Luca Barbato
On 12/09/2012 02:05 AM, Luca Barbato wrote: > I was waiting for the local x86 experts to chip in, did you test it on > win64 and mac I take, I can try it on linux if nobody did already. on amd64 seems fine as well. I guess can be pushed tomorrow. lu _

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-08 Thread Luca Barbato
On 12/9/12 1:14 AM, Ronald S. Bultje wrote: Hi, On Sat, Dec 8, 2012 at 4:12 PM, Ronald S. Bultje wrote: From: "Ronald S. Bultje" Use this in VP8/H264-8bit loopfilter functions so they can be used if there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). --- libavcodec/x86/h264_deblock.as

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-08 Thread Ronald S. Bultje
Hi, On Sat, Dec 8, 2012 at 4:12 PM, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > Use this in VP8/H264-8bit loopfilter functions so they can be used if > there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). > --- > libavcodec/x86/h264_deblock.asm | 27 ++ > libavcodec/x86/h264

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-08 Thread Ronald S. Bultje
Hi, On Sat, Dec 8, 2012 at 8:41 AM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> From: "Ronald S. Bultje" >> >> Use this in VP8/H264-8bit loopfilter functions so they can be used if >> there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). >> --- >> libavcodec/x86/h264_deblock.asm

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-08 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > Use this in VP8/H264-8bit loopfilter functions so they can be used if > there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). > --- > libavcodec/x86/h264_deblock.asm | 27 ++ > libavcodec/x86/h264dsp_init.c | 4 +- > libavcod

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-07 Thread Ronald S. Bultje
Hi, On Fri, Dec 7, 2012 at 2:08 PM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> Hi, >> >> On Fri, Dec 7, 2012 at 2:01 PM, Måns Rullgård wrote: >>> "Ronald S. Bultje" writes: On Fri, Dec 7, 2012 at 1:01 PM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> +

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-07 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > On Fri, Dec 7, 2012 at 2:01 PM, Måns Rullgård wrote: >> "Ronald S. Bultje" writes: >>> On Fri, Dec 7, 2012 at 1:01 PM, Måns Rullgård wrote: "Ronald S. Bultje" writes: > +%if mmsize <= 16 && HAVE_ALIGNED_STACK How much ov

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-07 Thread Ronald S. Bultje
Hi, On Fri, Dec 7, 2012 at 2:01 PM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: >> On Fri, Dec 7, 2012 at 1:01 PM, Måns Rullgård wrote: >>> "Ronald S. Bultje" writes: >>> +%if mmsize <= 16 && HAVE_ALIGNED_STACK >>> >>> How much overhead would it be to drop HAVE_ALIGNED_S

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-07 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > On Fri, Dec 7, 2012 at 1:01 PM, Måns Rullgård wrote: >> "Ronald S. Bultje" writes: >> >>> +%if mmsize <= 16 && HAVE_ALIGNED_STACK >> >> How much overhead would it be to drop HAVE_ALIGNED_STACK entirely? > > Well, for now, we still have a ton of f

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-07 Thread Ronald S. Bultje
Hi, On Fri, Dec 7, 2012 at 1:01 PM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> +%if mmsize <= 16 && HAVE_ALIGNED_STACK > > How much overhead would it be to drop HAVE_ALIGNED_STACK entirely? Well, for now, we still have a ton of functions that don't use the cglobal-method

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-12-07 Thread Måns Rullgård
"Ronald S. Bultje" writes: > +%if mmsize <= 16 && HAVE_ALIGNED_STACK How much overhead would it be to drop HAVE_ALIGNED_STACK entirely? -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org https://lists.libav

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-10-24 Thread Ronald S. Bultje
Hi, On Wed, Oct 24, 2012 at 10:07 AM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> From: "Ronald S. Bultje" >> >> Use this in VP8/H264-8bit loopfilter functions so they can be used if >> there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). >> --- >> libavcodec/x86/h264_deblock.as

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-10-24 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > Use this in VP8/H264-8bit loopfilter functions so they can be used if > there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). > --- > libavcodec/x86/h264_deblock.asm | 27 ++- > libavcodec/x86/h264dsp_init.c | 4 +- > libavco

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-10-05 Thread Ronald S. Bultje
Hi, On Fri, Oct 5, 2012 at 1:46 PM, Diego Biurrun wrote: > On Fri, Oct 05, 2012 at 01:38:44PM -0700, Ronald S. Bultje wrote: >> From: "Ronald S. Bultje" >> >> Use this in VP8/H264-8bit loopfilter functions so they can be used if >> there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). >> ---

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-10-05 Thread Diego Biurrun
On Fri, Oct 05, 2012 at 01:38:44PM -0700, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > Use this in VP8/H264-8bit loopfilter functions so they can be used if > there is no aligned stack (e.g. MSVC 32bit or ICC 10.x). > --- > libavcodec/x86/h264_deblock.asm | 27 ++- > libavcodec/x8

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-09-16 Thread Loren Merritt
On Fri, 14 Sep 2012, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > Use this in VP8 DSP functions so they can be used if there is no > aligned stack (e.g. MSVC 32bit). > > Note: it is currently slightly ugly, we need a register to store the > unaligned stack; there may be better solutions

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-09-15 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > On Fri, Sep 14, 2012 at 6:19 PM, Måns Rullgård wrote: >> "Ronald S. Bultje" writes: >> >>> From: "Ronald S. Bultje" >>> >>> Use this in VP8 DSP functions so they can be used if there is no >>> aligned stack (e.g. MSVC 32bit). >>> >>> Note: it is currently s

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-09-14 Thread Ronald S. Bultje
Hi, On Fri, Sep 14, 2012 at 6:19 PM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> From: "Ronald S. Bultje" >> >> Use this in VP8 DSP functions so they can be used if there is no >> aligned stack (e.g. MSVC 32bit). >> >> Note: it is currently slightly ugly, we need a register to store

Re: [libav-devel] [PATCH] x86inc: support stack mem allocation and re-alignment in PROLOGUE.

2012-09-14 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > Use this in VP8 DSP functions so they can be used if there is no > aligned stack (e.g. MSVC 32bit). > > Note: it is currently slightly ugly, we need a register to store the > unaligned stack; there may be better solutions for this. Please