[Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread Lars Hammarstrand
Hello, can someone please explain the reason (and how to cope with) that * ff_log2_tab* is defined multiple times with *#include "libavutil/log2_tab.c*" in the ffmpeg v1.1 libraries like libavcodec 54.91.102 and companions ?? This results in "duplicate symbols" while linking as listed below. To ge

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread Alexey Belkevich
> Hello, can someone please explain the reason (and how to cope with) that > ff_log2_tab is defined multiple times with #include "libavutil/log2_tab.c" in > the ffmpeg v1.1 libraries like libavcodec 54.91.102 and companions ?? > > This results in "duplicate symbols" while linking as listed below

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread Lars Hammarstrand
Hello Alexey! Thank you very much for the pointer which of course is permanently book marked for some time ago ;-). I'm quite aware of the workaround but I'm rather looking for the root cause of this change and what long term solution we should use since the ffmpeg libraries for XBMC needs to work

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread Alexey Belkevich
> Hello Alexey! > > Thank you very much for the pointer which of course is permanently book > marked for some time ago ;-). I'm quite aware of the workaround but I'm > rather looking for the root cause of this change and what long term solution > we should use since the ffmpeg libraries for XBM

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread Lars Hammarstrand
Hi, that is of course very true ;-) But the intention of the question was more technical oriented. /Lars. 2013/2/13 Alexey Belkevich > Hello Alexey! > > Thank you very much for the pointer which of course is permanently book > marked for some time ago ;-). I'm quite aware of the workaround but

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread Carl Eugen Hoyos
Lars Hammarstrand writes: > Hello, can someone please explain the reason (and how to > cope with) that ff_log2_tab is defined multiple times > with #include "libavutil/log2_tab.c" in the ffmpeg v1.1 > libraries like libavcodec 54.91.102 and companions ?? > > > This results in "duplicate symb

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread René J.V. Bertin
On Feb 13, 2013, at 16:47, Alexey Belkevich wrote: >> Hello, can someone please explain the reason (and how to cope with) that >> ff_log2_tab is defined multiple times with #include "libavutil/log2_tab.c" >> in the ffmpeg v1.1 libraries like libavcodec 54.91.102 and companions ?? You have iden

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread Lars Hammarstrand
Hello Carl! Since I'm using the google mail "in-line" reply I'm not sure if it will produce top-posts or not, please let me know if that's the case. Regarding the link problem, I'm not sure how you manage to link ffplay without this problem but i'll have a look. In general doing "#include ../comm

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread René J.V. Bertin
On Feb 13, 2013, at 18:14, Lars Hammarstrand wrote: > In general doing "#include ../common/source.c" with global variables is > probably a bad idea if you want to avoid duplicate symbols in "public" > libraries. Agreed, hence my question if there's a reason for the duplicate definition. I'm g

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread Lars Hammarstrand
> There's your explanation (from `man gcc`): > -all_load > Loads all members of static archive libraries. See man ld(1) for more information. Good eyes and a very observant mind, thank you very much ;-) I'll check the reason behind and if we can disable "-all_load" since this fee

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread René J.V. Bertin
On Feb 13, 2013, at 18:55, Lars Hammarstrand wrote: > > There's your explanation (from `man gcc`): > > -all_load > > Loads all members of static archive libraries. See man ld(1) for > > more information. > > Good eyes and a very observant mind, thank you very much ;-) Bah, who

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread Lars Hammarstrand
Apparently there are some issues with ios 64-bit osx: " http://stackoverflow.com/questions/2906147/what-does-the-all-load-linker-flag-do ": *"Important:* For 64-bit and iPhone OS applications, there is a linker bug that prevents -ObjC from loading objects files from static libraries that contain o

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread Lars Hammarstrand
Btw, are there any ffmpeg-devs on this list? 2013/2/13 Lars Hammarstrand > Apparently there are some issues with ios 64-bit osx: " > http://stackoverflow.com/questions/2906147/what-does-the-all-load-linker-flag-do > ": > > *"Important:* For 64-bit and iPhone OS applications, there is a linker >

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread Michael Niedermayer
Hi On Wed, Feb 13, 2013 at 04:36:38PM +0100, Lars Hammarstrand wrote: > Hello, can someone please explain the reason (and how to cope with) that * > ff_log2_tab* is defined multiple times with *#include "libavutil/log2_tab.c*" > in the ffmpeg v1.1 libraries like libavcodec 54.91.102 and companions

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread Lars Hammarstrand
Hello Michael - great news, thank you very much !! Which branch and repo is this patch applied to? /Thanks in advance, Lars. 2013/2/13 Michael Niedermayer > Hi > > On Wed, Feb 13, 2013 at 04:36:38PM +0100, Lars Hammarstrand wrote: > > Hello, can someone please explain the reason (and how to cop

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread René J.V. Bertin
On Feb 13, 2013, at 20:01, Michael Niedermayer wrote: > > duplicating the tables causes a small performance increase in some > linking configurations. If that's the case, why not do something like this? in libavutil/log2_tab.c : #ifndef cdh_GLUE # define cdh_GLUE(a,b) a##b #endif

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-13 Thread Michael Niedermayer
On Wed, Feb 13, 2013 at 08:16:14PM +0100, Lars Hammarstrand wrote: > Hello Michael - great news, thank you very much !! Which branch and repo > is this patch applied to? /Thanks in advance, Lars. patch is based on master, its not applied yet [...] -- Michael GnuPG fingerprint: 9FF2128B147EF

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-14 Thread Lars Hammarstrand
Hello folks! I found the original patch: avutil: Duplicate ff_log2_tab instead of sharing it across libs . The objectives for this patch was: "*The table is so small that the space gain is not worth the performance overhead of cr

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-14 Thread René J.V. Bertin
On Feb 14, 2013, at 22:53, Lars Hammarstrand wrote: > The objectives for this patch was: "The table is so small that the space gain > is not worth the performance overhead of cross-library access" (:uhu:). I > have never heard of such a thing as "cross-library access" that "auto-magic" > gives

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-14 Thread Hendrik Leppkes
On Thu, Feb 14, 2013 at 10:53 PM, Lars Hammarstrand wrote: > Hello folks! > > I found the original patch: avutil: Duplicate ff_log2_tab instead of sharing > it across libs. > > The objectives for this patch was: "The table is so small that the space > gain is not worth the performance overhead of

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-14 Thread René J.V. Bertin
Lars, Since you clearly have the your-ended problem of working in a context where multiple ff_log2_tabs bite, I suggest the open libavutil/intmath.h , and on line 53 or so you replace extern const uint8_t ff_log2_tab[256]; by static const uint8_t ff_log2_tab[256]={ 0,0,1,1,2,2,2,2,3,

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-14 Thread Lars Hammarstrand
2013/2/14 Hendrik Leppkes > In any case, this patch was focused on shared library builds, and > importing data symbols from shared libraries does add an extra level > of indirection. > This problem is new to me, please tell me what os and run-time loader you are referring to that has this issue

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-15 Thread Hendrik Leppkes
On Fri, Feb 15, 2013 at 1:27 AM, Lars Hammarstrand wrote: > >> However, not only that, it would also require exporting a ff* private >> symbol from avutil, and adds a lot of complexity when dealing with >> shared library builds on some systems (eg. MSVC) > > > This is one part that I don't underst

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-15 Thread René J . V . Bertin
>Everything prefixed with ff are private symbols in ffmpeg, and as such >are not supposed to be exposed in link libraries, because they are not >part of the public API/ABI. >There are already too many exceptions to this, and this avoided even >more. This pleads for static local copies. BTW, would

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-15 Thread Lars Hammarstrand
2013/2/15 René J.V. Bertin > > This pleads for static local copies. > > Yeah, this is what I would suggest too. If the objective is to have portable static libraries, don't define global symbol multiple times, it's just the wrong way of working. This is especially true for static libraries in ru

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-15 Thread Lars Hammarstrand
2013/2/14 "René J.V. Bertin" > Since you clearly have the your-ended problem of working in a context > where multiple ff_log2_tabs bite, I suggest the open libavutil/intmath.h , > and on line 53 or so you replace > > extern const uint8_t ff_log2_tab[256]; > > by > > static const uint8_t ff_log2_t

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-15 Thread Lars Hammarstrand
2013/2/15 Lars Hammarstrand > 2013/2/14 "René J.V. Bertin" > >> Since you clearly have the your-ended problem of working in a context >> where multiple ff_log2_tabs bite, I suggest the open libavutil/intmath.h , >> and on line 53 or so you replace >> >> I'm kind of lazy so I used a slightly diff

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-17 Thread Carl Eugen Hoyos
Lars Hammarstrand writes: > Ive posted a patch to ffmpeg-dev, which may fix this: > 0213 19:51 To FFmpeg devel (3.0K) [FFmpeg-devel] > [PATCH] buildsys: only include log2_tab per library for shared builds > please test and comments welcome Could one of you (who is affected by the problem, reme

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-18 Thread René J.V. Bertin
On Feb 17, 2013, at 19:16, Carl Eugen Hoyos wrote: > > Could one of you (who is affected by the problem, > remember that it cannot be reproduced on same > environments) please test mentioned patch? > > Your problem unfortunately will not be fixed as > long as you don't comment on the patch;-(

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-18 Thread Carl Eugen Hoyos
René J.V. Bertin writes: > On Feb 17, 2013, at 19:16, Carl Eugen Hoyos wrote: > > > > Could one of you (who is affected by the problem, > > remember that it cannot be reproduced on same (this should have been "sane") > > environments) please test mentioned patch? [...] > I'm not sure if yo

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-18 Thread René J.V. Bertin
On Feb 18, 2013, at 11:53, Carl Eugen Hoyos wrote: > (Or in other words: If nobody wants to test the > patch, the developers will assume that there is > nobody for whom this problem is important and the > developers will move on to other problems.) Which is understandable, though on the other

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-18 Thread Lars Hammarstrand
2013/2/17 Carl Eugen Hoyos > > Could one of you (who is affected by the problem, > remember that it cannot be reproduced on same > environments) please test mentioned patch? > > Your problem unfortunately will not be fixed as > long as you don't comment on the patch;-( > > Hi, it's for 64-bit OSX

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-18 Thread Lars Hammarstrand
2013/2/18 Lars Hammarstrand > 2013/2/17 Carl Eugen Hoyos > >> >> Could one of you (who is affected by the problem, >> remember that it cannot be reproduced on same >> environments) please test mentioned patch? >> >> Your problem unfortunately will not be fixed as >> long as you don't comment on

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-20 Thread Carl Eugen Hoyos
Lars Hammarstrand writes: > 2013/2/17 Carl Eugen Hoyos > > Could one of you (who is affected by the problem, > remember that it cannot be reproduced on same > environments) please test mentioned patch? > Your problem unfortunately will not be fixed as > long as you don't comment on the patch;-(

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-22 Thread Lars Hammarstrand
2013/2/20 Carl Eugen Hoyos > You reported a bug [1] that cannot easily be reproduced a buggy toolchain > appears to be necessary. Less than four hours after your report, a patch > was posted that is intended to fix this bug and a message was sent to > this mailing list to ask if the patch fixes y

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-22 Thread Carl Eugen Hoyos
Lars Hammarstrand writes: > > 2013/2/20 Carl Eugen Hoyos > > > > You reported a bug [1] that cannot easily be reproduced a > > buggy toolchain appears to be necessary. Less than four hours > > after your report, a patch was posted that is intended to fix > > this bug and a message was sent to

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-22 Thread René J.V. Bertin
On Feb 22, 2013, at 16:35, Carl Eugen Hoyos wrote: > > Please fix your quoting, Carl Eugen Works here. Please fix your MUA :P R. ___ Libav-user mailing list Libav-user@ffmpeg.org http://ffmpeg.org/mailman/listinfo/libav-user

Re: [Libav-user] ff_log2_tab defined multiple times in the fmpeg 1.1 libraries, bug or feature ??

2013-02-22 Thread Carl Eugen Hoyos
René J.V. Bertin writes: > On Feb 22, 2013, at 16:35, Carl Eugen Hoyos wrote: > > > > Please fix your quoting, Carl Eugen > > Works here. Please fix your MUA :P Should have been: "Please set your mailer to plain-text." Sorry, Carl Eugen ___ Lib