Re: [PATCH] fix build error with automake-1.14, dnl comment need start at newline

2013-12-22 Thread Marc Lehmann
On Mon, Dec 23, 2013 at 12:49:01PM +0800, "Dennis Lan (dlan)" wrote: > > debug hacked libev versions in distros if you silently modify libev, you > > are on your own). > > Since this is a build error(which I think it's trivial), so we fix it > *first* instead of discussing with upstream The pro

Re: [PATCH] fix build error with automake-1.14, dnl comment need start at newline

2013-12-22 Thread Dennis Lan (dlan)
On Sun, Dec 22, 2013 at 2:42 PM, Marc Lehmann wrote: > If you regenerate the configure script you need to use the exact same > version of automake as libev uses - unfortunately, automake doesn't have > much backwards or forwards compatibility, as you have seen. > Yes, we regenerate the configure s

Re: [PATCH] fix build error with automake-1.14, dnl comment need start at newline

2013-12-21 Thread Marc Lehmann
On Sun, Dec 22, 2013 at 08:44:22AM +0800, "Lan Yixun (dlan)" wrote: > with changes AM_INIT_AUTOMAKE, dnl trucate the end of trailing newline > thus make next macro append to same line, result in weird error And as a last comment, this is a bug (or another incompatible change) in either automake

Re: [PATCH] fix build error with automake-1.14, dnl comment need start at newline

2013-12-21 Thread Marc Lehmann
On Sun, Dec 22, 2013 at 08:44:22AM +0800, "Lan Yixun (dlan)" wrote: > From: "Lan Yixun (dlan)" sorry, didn't see the subject line: Subject: [PATCH] fix build error with automake-1.14, dnl comment need start at newline Indeed, automake-1.14 is the wrong version a

Re: [PATCH] fix build error with automake-1.14, dnl comment need start at newline

2013-12-21 Thread Marc Lehmann
On Sun, Dec 22, 2013 at 08:44:22AM +0800, "Lan Yixun (dlan)" wrote: > with changes AM_INIT_AUTOMAKE, dnl trucate the end of trailing newline > thus make next macro append to same line, result in weird error I don't see anything related in these lines in our configure script - are you sure you us

[PATCH] fix build error with automake-1.14, dnl comment need start at newline

2013-12-21 Thread Lan Yixun (dlan)
From: "Lan Yixun (dlan)" with changes AM_INIT_AUTOMAKE, dnl trucate the end of trailing newline thus make next macro append to same line, result in weird error --- ./configure: line 2816: syntax error near unexpected token `ac_config_headers="$ac_config_headers config.h"' ./configure: line 2816