Re: Warnings from gcc

2007-12-23 Thread Marc Lehmann
On Sun, Dec 23, 2007 at 08:17:18AM -0500, Jeff Squyres <[EMAIL PROTECTED]> wrote: > If you haven't tested OS X Leopard, here's a datapoint for you: I > downloaded EV 2.0 and ran "make test" on an OS X 10.5.1 intel machine > with LIBEV_FLAGS environment variable values of , 1, 2, and 8. Tha

Re: Warnings from gcc

2007-12-23 Thread Jeff Squyres
On Dec 22, 2007, at 9:16 PM, Marc Lehmann wrote: Fair enough. Is OS X one of those platforms? (I couldn't find an official list of supported platforms -- did I miss it?) OS X is not one of those, but since afaics only gcc is used the warnings should be comparable to similar platforms. Th

Re: Warnings from gcc

2007-12-22 Thread Marc Lehmann
On Sat, Dec 22, 2007 at 06:18:12PM -0500, Jeff Squyres <[EMAIL PROTECTED]> wrote: > >>static struct ev_loop * > >>ev_default_loop (unsigned int flags) { ... } > >> > >>Should that function be marked as inline? > > > >No, because inline semantics are not portable at the moment (C99 vs. > >gcc), >

Re: Warnings from gcc

2007-12-22 Thread Jeff Squyres
On Dec 22, 2007, at 10:31 AM, Marc Lehmann wrote: >> 1. Only instantiate the have_monotonic variable #if EV_USE_MONOTONIC >> (have_monotonic's usage seems to be protected by EV_USE_MONOTONIC) >> >> 2. Only declare infy_fork() #if EV_USE_INOTIFY (infy_fork()'s >> definition is surrounded by #if EV_

Re: Warnings from gcc

2007-12-22 Thread Marc Lehmann
On Sat, Dec 22, 2007 at 08:28:50AM -0500, Jeff Squyres <[EMAIL PROTECTED]> wrote: > 1. Only instantiate the have_monotonic variable #if EV_USE_MONOTONIC > (have_monotonic's usage seems to be protected by EV_USE_MONOTONIC) > > 2. Only declare infy_fork() #if EV_USE_INOTIFY (infy_fork()'s > def

Re: Warnings from gcc

2007-12-22 Thread Jeff Squyres
On Dec 22, 2007, at 5:31 AM, Marc Lehmann wrote: No. Warnings are warnings, and every compiler has different ones and different tastes. If you know how to silence those warnings a) without introducing slowdowns and b) on every compiler, then I would like to hear about them. Here's some pre

Re: Warnings from gcc

2007-12-22 Thread Marc Lehmann
On Fri, Dec 21, 2007 at 05:18:56PM -0500, Jeff Squyres <[EMAIL PROTECTED]> wrote: > libev that was configured with "./configure CFLAGS='-Wall - > pedantic'" (or even just -Wall). I didn't compare closely, but I see Read the documentation on -pedantic. I know you don't like reading documentati

Warnings from gcc

2007-12-21 Thread Jeff Squyres
I notice that there are a bunch of warnings emitted when compiling a libev that was configured with "./configure CFLAGS='-Wall - pedantic'" (or even just -Wall). I didn't compare closely, but I see the same general kinds of warnings from both the CVS trunk and the 1.86 tarball. Some warnin