Re: [Libevent-users] Undefined reference

2007-09-20 Thread Scott Lamb
Marcelo Estanislau Geyer wrote: Hi, I'm development small program in C++ on Linux (Fedora 7 and Kdevelop). When compiling the program, is appearing the following message: undefined reference to `event_init' I have add header event.h, but I am with difficulties to work with this library due to

[Libevent-users] Undefined reference

2007-09-20 Thread Marcelo Estanislau Geyer
Hi, I'm development small program in C++ on Linux (Fedora 7 and Kdevelop). When compiling the program, is appearing the following message: undefined reference to `event_init' I have add header event.h, but I am with difficulties to work with this library due to these errors. Thanks, Marcelo E

Re: [Libevent-users] [PATCH] Do not call gettime in timeout_process if the timetree is empty

2007-09-20 Thread Nick Mathewson
On Thu, Sep 20, 2007 at 03:14:51PM +0200, Trond Norbye wrote: [...] > > > >Why not just return if RB_EMPTY() is true rather than adding another level > >of indention? > Some people (I'm not one of them) dislikes multiple return statements > from a function, so I just added the extra level to avo

Re: [Libevent-users] [PATCH] Fix syntax error in autogen.sh

2007-09-20 Thread Hannah Schroeter
Hi! On Thu, Sep 20, 2007 at 03:23:32PM +0200, Trond Norbye wrote: >Magne Mæhre wrote: >>Changing to /bin/bash isn't a good solution, since you're not >>guaranteed to have bash on every system (nor that it's in /bin) >>I would suggest to have the script Bourne shell compliant instead : >>SYSNAME

Re: [Libevent-users] [PATCH] Fix syntax error in autogen.sh

2007-09-20 Thread Trond Norbye
Magne Mæhre wrote: Changing to /bin/bash isn't a good solution, since you're not guaranteed to have bash on every system (nor that it's in /bin) I would suggest to have the script Bourne shell compliant instead : SYSNAME=`uname` if [ "$SYSNAME" = "Darwin" ] ; then LIBTOOLIZE=glibtoolize fi

Re: [Libevent-users] [PATCH] Do not call gettime in timeout_process if the timetree is empty

2007-09-20 Thread Trond Norbye
Christopher Layne wrote: Index: event.c === --- event.c (revision 440) +++ event.c (working copy) @@ -804,24 +804,26 @@ void timeout_process(struct event_base *base) { - struct timeval now; - struct event *ev

Re: [Libevent-users] [PATCH] Fix syntax error in autogen.sh

2007-09-20 Thread Magne Mæhre
Trond Norbye wrote: /bin/sh does not recognize == as a valid test operator, but /bin/bash does... Changing to /bin/bash isn't a good solution, since you're not guaranteed to have bash on every system (nor that it's in /bin) I would suggest to have the script Bourne shell compliant instead :

Re: [Libevent-users] [PATCH] Fix syntax error in autogen.sh

2007-09-20 Thread Mathieu Sauve-Frankel
On Thu, Sep 20, 2007 at 01:43:59PM +0200, Trond Norbye wrote: > /bin/sh does not recognize == as a valid test operator, but /bin/bash > does... Don't you think it's perhaps a more sane and portable approach to just fix the erroneous operator than change to a non-standard shell ? Making bash a bui

Re: [Libevent-users] [PATCH] Do not call gettime in timeout_process if the timetree is empty

2007-09-20 Thread Christopher Layne
On Thu, Sep 20, 2007 at 01:52:31PM +0200, Trond Norbye wrote: > The result of gettime is not used if the timetree is empty (and might > cause a context switch to get the system clock). > > --Trond > Index: event.c > === > --- event.

[Libevent-users] [PATCH] Do not call gettime in timeout_process if the timetree is empty

2007-09-20 Thread Trond Norbye
The result of gettime is not used if the timetree is empty (and might cause a context switch to get the system clock). --Trond Index: event.c === --- event.c (revision 440) +++ event.c (working copy) @@ -804,24 +804,26 @@ void

[Libevent-users] [PATCH] Fix syntax error in autogen.sh

2007-09-20 Thread Trond Norbye
/bin/sh does not recognize == as a valid test operator, but /bin/bash does... --Trond Index: autogen.sh === --- autogen.sh (revision 440) +++ autogen.sh (working copy) @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash LIBTOOLIZE=libtoolize