Re: [Libguestfs] [PATCH 1/2] windows: fix detection of qemu-ga installer on RHV

On Thursday, 21 November 2019 12:11:01 CET Tomáš Golembiovský wrote: > The detection was incorrectly matching only 32-bit installer on all > architectures. > > Signed-off-by: Tomáš Golembiovský > --- > v2v/windows_virtio.ml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff

Re: [Libguestfs] [PATCH 0/2] Fixes and tweak to the installation of qemu-ga MSI

On Thursday, 21 November 2019 12:11:00 CET Tomáš Golembiovský wrote: > This, together with the changes to common repo are fixes to the installation > qemu-ga MSI. I pushed patch #1 because it is OK for me. I did not push patch #2 because I do not have experience with powershell, so I cannot

Re: [Libguestfs] [PATCH 1/2] windows: fix detection of qemu-ga installer on RHV

On Thursday, 21 November 2019 12:11:01 CET Tomáš Golembiovský wrote: > The detection was incorrectly matching only 32-bit installer on all > architectures. > > Signed-off-by: Tomáš Golembiovský > --- > v2v/windows_virtio.ml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff

Re: [Libguestfs] [PATCH 3/3] docs: don't perform lookup on absolute paths

On Mon, Jan 27, 2020 at 01:46:03PM +0100, Pino Toscano wrote: > On Monday, 27 January 2020 12:37:38 CET Tomáš Golembiovský wrote: > > On Mon, Jan 27, 2020 at 12:17:42PM +0100, Pino Toscano wrote: > > > On Monday, 27 January 2020 10:39:34 CET Tomáš Golembiovský wrote: > > > > Signed-off-by: Tomáš

Re: [Libguestfs] [PATCH 3/3] docs: don't perform lookup on absolute paths

On Monday, 27 January 2020 12:37:38 CET Tomáš Golembiovský wrote: > On Mon, Jan 27, 2020 at 12:17:42PM +0100, Pino Toscano wrote: > > On Monday, 27 January 2020 10:39:34 CET Tomáš Golembiovský wrote: > > > Signed-off-by: Tomáš Golembiovský > > > --- > > > podwrapper.pl.in | 2 ++ > > > 1 file

[Libguestfs] [PATCH v2 1/2] mltools, options: support --allow-discards when decrypting LUKS devices

--- mltools/tools_utils-c.c | 8 mltools/tools_utils.ml | 6 +++--- mltools/tools_utils.mli | 8 ++-- options/decrypt.c | 5 +++-- options/inspect.c | 2 +- options/options.h | 2 +- 6 files changed, 18 insertions(+), 13 deletions(-) diff --git

[Libguestfs] [PATCH v2 2/2] sparsify: support LUKS-encrypted partitions

--- daemon/listfs.ml | 18 +++--- daemon/luks.c | 9 + generator/actions_core.ml | 3 ++- gobject/Makefile.inc | 2 ++ inspector/inspector.c | 2 +- sparsify/in_place.ml | 2 +- 6 files changed, 26 insertions(+), 10 deletions(-) diff

Re: [Libguestfs] [PATCH 3/3] docs: don't perform lookup on absolute paths

On Mon, Jan 27, 2020 at 12:17:42PM +0100, Pino Toscano wrote: > On Monday, 27 January 2020 10:39:34 CET Tomáš Golembiovský wrote: > > Signed-off-by: Tomáš Golembiovský > > --- > > podwrapper.pl.in | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/podwrapper.pl.in

Re: [Libguestfs] [PATCH 2/3] build: run ocaml-link.sh from build directory

On Monday, 27 January 2020 10:39:33 CET Tomáš Golembiovský wrote: > ocaml-link.sh is generated file. It means that for out-of-tree builds it > is located in a build directory which is different from source tree dir. > > Signed-off-by: Tomáš Golembiovský > --- LGTM. What about doing the same

Re: [Libguestfs] [PATCH 3/3] docs: don't perform lookup on absolute paths

On Monday, 27 January 2020 10:39:34 CET Tomáš Golembiovský wrote: > Signed-off-by: Tomáš Golembiovský > --- > podwrapper.pl.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/podwrapper.pl.in b/podwrapper.pl.in > index f12a173f..1e4aa149 100755 > --- a/podwrapper.pl.in > +++

Re: [Libguestfs] [v2v PATCH 2/2] rhv-upload: Check that rhv-disk-uuid is not already taken (RHBZ#1789279)

On Thursday, 23 January 2020 23:12:23 CET Martin Kletzander wrote: > This makes the code fail with a sensible error message instead of cryptic > error > from ovirtsdk. > > Signed-off-by: Martin Kletzander > --- > v2v/rhv-upload-plugin.py | 12 > 1 file changed, 12 insertions(+) >

[Libguestfs] [PATCH 1/3] build: perform gnulib check from source directory

Signed-off-by: Tomáš Golembiovský --- cfg.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/cfg.mk b/cfg.mk index a303ee72..4bd2d006 100644 --- a/cfg.mk +++ b/cfg.mk @@ -132,6 +132,7 @@ ifeq (0,$(MAKELEVEL)) # b653eda3ac4864de205419d9f41eec267cb89eeb _submodule_hash = sed 's/^[

[Libguestfs] [PATCH 3/3] docs: don't perform lookup on absolute paths

Signed-off-by: Tomáš Golembiovský --- podwrapper.pl.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/podwrapper.pl.in b/podwrapper.pl.in index f12a173f..1e4aa149 100755 --- a/podwrapper.pl.in +++ b/podwrapper.pl.in @@ -689,6 +689,8 @@ sub find_file my $use_path = shift; local

[Libguestfs] [PATCH 0/3] Fixing out-of-tree builds

Building virt-v2v out-of-tree does not work and requires several small fixes here and there. Tomáš Golembiovský (3): build: perform gnulib check from source directory build: run ocaml-link.sh from build directory docs: don't perform lookup on absolute paths cfg.mk | 1 +

[Libguestfs] [PATCH 2/3] build: run ocaml-link.sh from build directory

ocaml-link.sh is generated file. It means that for out-of-tree builds it is located in a build directory which is different from source tree dir. Signed-off-by: Tomáš Golembiovský --- v2v/Makefile.am | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git