Re: [Libguestfs] [PATCH] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Richard W.M. Jones
On Sun, Feb 13, 2022 at 05:13:37PM +0200, Nir Soffer wrote: > This can be done in nbdcopy by adding http-ops. The pipeline in > rhv-upload case will be: > > nbdkit (any input) -> nbdcopy (nbd-ops/http-ops) -> imageio server > > Another way is to drop nbdcopy for rhv-upload - if we provide nbd

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Richard W.M. Jones
This change slowed things down (slightly) for me, although the change is within the margin of error so it probably made no difference. Before: $ time ./run virt-v2v -i disk /var/tmp/fedora-35.qcow2 -o rhv-upload -oc https://ovirt4410/ovirt-engine/api -op /tmp/ovirt-passwd -oo rhv-direct -os ovi

Re: [Libguestfs] [libguestfs-common PATCH 3/3] add common ("standard") option -w / --wrap

2022-02-14 Thread Laszlo Ersek
On 02/12/22 19:18, Richard W.M. Jones wrote: > On Fri, Feb 11, 2022 at 04:32:25PM +0100, Laszlo Ersek wrote: >> Similarly to how users can can force ANSI colorization with "--colors" >> even when stdout / stderr are redirected to a non-tty, allow them to force >> wrapping with "--wrap". >> >> Bugzi

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Nir Soffer
On Mon, Feb 14, 2022 at 11:56 AM Richard W.M. Jones wrote: > > This change slowed things down (slightly) for me, although the change > is within the margin of error so it probably made no difference. > > Before: ... > [ 79.3] Copying disk 1/1 > █ 100% [] >

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Laszlo Ersek
On 02/13/22 20:56, Nir Soffer wrote: > Output modules can specify now request_size to override the default > request size in nbdcopy. > > The rhv-upload plugin is translating every NBD command to HTTP request, > translated back to NBD command on imageio server. The HTTP client and > server, and th

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Laszlo Ersek
On 02/14/22 10:56, Richard W.M. Jones wrote: > This change slowed things down (slightly) for me, although the change > is within the margin of error so it probably made no difference. > > Before: > > $ time ./run virt-v2v -i disk /var/tmp/fedora-35.qcow2 -o rhv-upload -oc > https://ovirt4410/ovi

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Richard W.M. Jones
On Mon, Feb 14, 2022 at 01:11:52PM +0200, Nir Soffer wrote: > On Mon, Feb 14, 2022 at 11:56 AM Richard W.M. Jones wrote: > > > > This change slowed things down (slightly) for me, although the change > > is within the margin of error so it probably made no difference. > > > > Before: > ... > > [ 7

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Richard W.M. Jones
On Mon, Feb 14, 2022 at 12:53:01PM +0100, Laszlo Ersek wrote: > On 02/14/22 10:56, Richard W.M. Jones wrote: > > This change slowed things down (slightly) for me, although the change > > is within the margin of error so it probably made no difference. > > > > Before: > > > > $ time ./run virt-v2v

Re: [Libguestfs] [PATCH libnbd v2 1/9] golang: tests: Add test for AioBuffer

2022-02-14 Thread Eric Blake
On Fri, Feb 11, 2022 at 03:21:21AM +0200, Nir Soffer wrote: > Add unit tests and benchmarks for AioBuffer. The tests are trivial but > they server as running documentation, and they point out important serve > details about the type. > > The benchmarks show the efficiency of allocating a new buf

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Nir Soffer
On Mon, Feb 14, 2022 at 3:01 PM Richard W.M. Jones wrote: > > On Mon, Feb 14, 2022 at 12:53:01PM +0100, Laszlo Ersek wrote: > > On 02/14/22 10:56, Richard W.M. Jones wrote: > > > This change slowed things down (slightly) for me, although the change > > > is within the margin of error so it probabl

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Richard W.M. Jones
On Mon, Feb 14, 2022 at 03:59:34PM +0200, Nir Soffer wrote: > On Mon, Feb 14, 2022 at 3:01 PM Richard W.M. Jones wrote: > > > > On Mon, Feb 14, 2022 at 12:53:01PM +0100, Laszlo Ersek wrote: > > > On 02/14/22 10:56, Richard W.M. Jones wrote: > > > > This change slowed things down (slightly) for me,

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Laszlo Ersek
On 02/14/22 14:01, Richard W.M. Jones wrote: > On Mon, Feb 14, 2022 at 12:53:01PM +0100, Laszlo Ersek wrote: >> On 02/14/22 10:56, Richard W.M. Jones wrote: >>> This change slowed things down (slightly) for me, although the change >>> is within the margin of error so it probably made no difference.

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Richard W.M. Jones
On Mon, Feb 14, 2022 at 04:52:17PM +0100, Laszlo Ersek wrote: > On 02/14/22 14:01, Richard W.M. Jones wrote: > > But nbdcopy needs to be reworked to make the input and output requests > > separate, so that nbdcopy will coalesce and split blocks as it copies. > > This is difficult. > > > > Another

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

2022-02-14 Thread Richard W.M. Jones
On Mon, Feb 14, 2022 at 04:08:21PM +, Richard W.M. Jones wrote: > There is a limit on the number of parallel requests in flight > (nbdcopy --requests, default 64). This limits the implicit buffer to > max_requests * request_size. That's 16MB in the default > configuration. Quite small actual

Re: [Libguestfs] [libguestfs-common PATCH 3/3] add common ("standard") option -w / --wrap

2022-02-14 Thread Laszlo Ersek
On 02/12/22 19:18, Richard W.M. Jones wrote: > On Fri, Feb 11, 2022 at 04:32:25PM +0100, Laszlo Ersek wrote: >> Similarly to how users can can force ANSI colorization with "--colors" >> even when stdout / stderr are redirected to a non-tty, allow them to force >> wrapping with "--wrap". >> >> Bugzi

Re: [Libguestfs] [PATCH libnbd v2 1/9] golang: tests: Add test for AioBuffer

2022-02-14 Thread Nir Soffer
On Mon, Feb 14, 2022 at 3:22 PM Eric Blake wrote: > On Fri, Feb 11, 2022 at 03:21:21AM +0200, Nir Soffer wrote: > > Add unit tests and benchmarks for AioBuffer. The tests are trivial but > > they server as running documentation, and they point out important > > serve > Fixed > > > details abou