Re: [Libreoffice] [PATCH 3/4] Translate german comments

2011-04-22 Thread Korrawit Pruegsanusak
Hello Martin, On Fri, Apr 22, 2011 at 03:00, Martin Kepplinger wrote: > diff --git a/sw/source/ui/inc/frmmgr.hxx b/sw/source/ui/inc/frmmgr.hxx > -    SW_DLLPRIVATE void _UpdateFlyFrm();        //Nacharbeit nach Einfuegen > oder Update > +    SW_DLLPRIVATE void _UpdateFlyFrm();        // post-tre

Re: [Libreoffice] [PATCH 4/4] Translate german code comments

2011-04-22 Thread Chr. Rossmanith
Am 21.04.2011 22:13, schrieb Júlio Hoffimann: Nice patches Martin! :-) Next time you could attach the files, instead of put them in the mail body. So, the developers just download and apply your changes. ;-) Martin has already pushed them. He just posted them for reviewing. Christina

Re: [Libreoffice] [PATCH 4/4] Translate german code comments

2011-04-22 Thread Chr. Rossmanith
Hm, I should have read the whole thread first...sorry for the noise. Christina Am 22.04.2011 09:27, schrieb Chr. Rossmanith: Am 21.04.2011 22:13, schrieb Júlio Hoffimann: Nice patches Martin! :-) Next time you could attach the files, instead of put them in the mail body. So, the developers j

[Libreoffice] Tinderbox testing more branches

2011-04-22 Thread Jan Holesovsky
Hi, I have updated the tinbuild script a bit so that more instances can co-exist conveniently on platforms where 'flock' is available. This way, you can tinderbox both eg. master and libreoffice-3-4, and do not have to worry that they would eat all the resources. http://cgit.freedesktop.org/libr

Re: [Libreoffice] Some smoketests failed

2011-04-22 Thread Julien Nabet
Hello Júlio, Thanks for your response. I tried your advice with a "rm -rf unxlng*" before and the compilation goes further. Now I've got this : /home/maryline/compile-libreoffice/libo/solver/300/unxlngi6/installation/opt/program/../basis-link/program/libsofficeapp.so(+0x25891)[0xb76cc891] /home

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36262, which changed state. Bug 36262 Summary: Undo BrOffice, return to LibreOffice https://bugs.freedesktop.org/show_bug.cgi?id=36262 What|Old Value |New Value --

Re: [Libreoffice] [PATCH][PUSHED] cppcheck variableScope

2011-04-22 Thread Cedric Bosdonnat
On Tue, 2011-04-19 at 14:40 -0300, Kayo Hamid wrote: > cppcheck variableScope Many thanks for the patch! I just pushed it. For the next patches it would be great if you could use git format-patch to generate the patches from the commits in the git repos. That would save us quite some work picking

[Libreoffice] Installing beta versions replacing stable versions

2011-04-22 Thread Ed. Drinkwater
I downloaded 3.4 Beta 1 and 3.4 Bata 2 under Windows 7, and in both cases installing the beta version overwrote the stable version I already had installed, and even if I set it to install in a different folder the installer still removed the stable version. Similarly installing the DEB package

Re: [Libreoffice] cppcheck inefficient checking for emptiness

2011-04-22 Thread Cedric Bosdonnat
On Tue, 2011-04-19 at 16:23 -0300, Kayo Hamid wrote: > From cppcheck: Using .empty() instead of .size() can be faster. > .size() can take linear time but .empty() is guaranteed to take > constant time Many thanks for that other patch. I just pushed it too! -- Cédric Bosdonnat

Re: [Libreoffice] [PUSHED] cppcheck inefficient checking for emptiness

2011-04-22 Thread Cedric Bosdonnat
Forgot to add the PUSHED flag. On Tue, 2011-04-19 at 16:23 -0300, Kayo Hamid wrote: > From cppcheck: Using .empty() instead of .size() can be faster. > .size() can take linear time but .empty() is guaranteed to take > constant time > > Sending for review. > > revol_ > _

Re: [Libreoffice] [PATCH] should fix bugs fdo#36080 and fdo#34666

2011-04-22 Thread Cedric Bosdonnat
Hello Anthony, Many thanks for your patch. I just pushed it in the master branch. Keep providing good patches like this! Regards, On Tue, 2011-04-19 at 15:27 +0300, Anthony Durity wrote: > Hello good people, > > > If someone related to this area could give this patch the once over. > Please fi

Re: [Libreoffice] [PATCH] [PUSHED] po2oo --skipsource support

2011-04-22 Thread Cedric Bosdonnat
Hi KAMI, I just pushed your patch in the repos. Thanks for it. Regards, On Tue, 2011-04-19 at 10:06 +0200, KAMI911 KAMI911 wrote: > > Hi Andras, > > I tried to use internal toolkit: > " > checking which translate-toolkit to use... internal > " > But when I try to build translations I got this

Re: [Libreoffice] [PATCH] [PUSHED] Easy Hack - Improve git pre-commit hook

2011-04-22 Thread Cedric Bosdonnat
Hello Maxime, Many thanks for your patch. I haven't tried it yet, but I pushed it. If anyone complains we'll see it quickly, but it looked good to me. Regards, On Mon, 2011-04-18 at 22:11 -0400, Maxime Côté wrote: > Hi all, > > This is my first easy hack. I made change in the function > check_a

Re: [Libreoffice] [PATCH] [PUSHED] should fix bugs fdo#36080 and fdo#34666

2011-04-22 Thread Cedric Bosdonnat
forgotten PUSHED flag again On Fri, 2011-04-22 at 11:38 +0200, Cedric Bosdonnat wrote: > Hello Anthony, > > Many thanks for your patch. I just pushed it in the master branch. Keep > providing good patches like this! > > Regards, > > On Tue, 2011-04-19 at 15:27 +0300, Anthony Durity wrote: > > H

Re: [Libreoffice] Installing beta versions replacing stable versions

2011-04-22 Thread Tor Lillqvist
> Can you please make sure that future developer builds are compiled to > install in a separate folder and do not disturb previously installed > stable versions. Anything is possible. It is just a small matter of programming. Maybe you could help? --tml __

Re: [Libreoffice] Installing beta versions replacing stable versions

2011-04-22 Thread Ed. Drinkwater
Not sure how I could help. I'm not a programmer, but as I understand it settings like where to install and whether to replace other packages are set when compiling the product. I'm not sure how anyone other than the person compiling the packages can help, or indeed why any help is needed. To

Re: [Libreoffice] Installing beta versions replacing stable versions

2011-04-22 Thread Tor Lillqvist
> set when compiling the product. I'm not sure [...] why any help is needed. Yeah. Maybe if you just wish hard enough your dream will come true. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Libreoffice] [PATCH 4/4] Translate german code comments

2011-04-22 Thread Júlio Hoffimann
Hi Martin, Sorry for my bad interpretation. :-) Regards, Júlio. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Installing beta versions replacing stable versions

2011-04-22 Thread Cor Nouws
PS: Ed: this is a list where developers discuss developer issues. It is not intended for people to bring up ideas/wishes .. You may do so, but (part of) the answer always is: can you help ;-) Cor Tor Lillqvist wrote (22-04-11 12:21) set when compiling the product. I'm not sure [...] why any

Re: [Libreoffice] Installing beta versions replacing stable versions

2011-04-22 Thread Ed. Drinkwater
What is that supposed to mean? It certainly doesn't sound like a coherent, constructive contribution to the issue! What "help" do you need? I am not the one who compiles that packages, so I am not in a position to change settings that have to be changed while compiling. When the code for L

Re: [Libreoffice] Installing beta versions replacing stable versions

2011-04-22 Thread Tor Lillqvist
> What is that supposed to mean? It certainly doesn't sound like a > coherent, constructive contribution to the issue! That is because I am basically an incoherent dribbling idiot, la la la, na na splutgh xzbbpfft! Me wants more porridge! --tml ___

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Rainer Bielefeld changed: What|Removed |Added Depends on||36451 -- Configure bugmail: https://

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Allen changed: What|Removed |Added Version|unspecified |LibO 3.4 Beta2 -- Configure bugmail: https://bu

Re: [Libreoffice] Two services.rdb files in postprocess/packcomponents/makefile.mk ?!

2011-04-22 Thread Hanno Meyer-Thurow
I made the attached patches to get rid of the 'ooo-services.rdb' file and fix the disabled-python build. Though, now I get a general configuration error. stderr shows following message: Error: File /mnt/data/tmp/portage/app-office/libreoffice-3.3.99.1/work/libreoffice-bootstrap-3.3.99.1/d

Re: [Libreoffice] [PUSHED] Easy Hack completed - All bogus comments removed

2011-04-22 Thread Júlio Hoffimann
Hi Cédric, These are the left arrow comments // <-- if you want to remove them all. :-) ~1500 lines discarded. The big one is in bugzilla: https://bugs.freedesktop.org/attachment.cgi?id=45945 Under the LGPLv3+ / MPL license. Regards, Júlio. From 34155f656ff5bab268f65f92e2d2ba1f76868bc5 Mon Sep

Re: [Libreoffice] Help on fixing set_soenv so that it uses configure --build options

2011-04-22 Thread Jan Holesovsky
Hi Pablo, On 2011-04-21 at 15:17 -0400, Pablo Duboue wrote: > I somehow feel the current LibO build scripts are doing things in two > places. The parameters to the configure script plus the set_soenv > script. From a conceptual perspective, it bothers me but if I'm the > only one feeling like tha

[Libreoffice] cppcheck "Found duplicate branches for if and else" in libs-core

2011-04-22 Thread Julien Nabet
Hello, I've runned a cppcheck last git version on libs-core (master branch updated today) and found this oddity : [basic/source/app/mybasic.cxx:265] -> [basic/source/app/mybasic.cxx:260]: (style) Found duplicate branches for if and else. [embeddedobj/source/msole/olepersist.cxx:1835] -> [embe

Re: [Libreoffice] Some smoketests failed

2011-04-22 Thread Júlio Hoffimann
Hi Julien, I'm too busy right now, but i tried to see what is happening. Look the error message, it refers to /libo/clone/testing/test/source/cpp/officeconnection.cxx with this assertion: CPPUNIT_ASSERT_EQUAL( osl_Process_E_TimedOut, osl_joinProcessWith

Re: [Libreoffice] [PATCH 3/4] Translate german comments

2011-04-22 Thread Martin Kepplinger
Am 22.04.2011 09:16, schrieb Korrawit Pruegsanusak: > Hello Martin, > > On Fri, Apr 22, 2011 at 03:00, Martin Kepplinger > wrote: >> diff --git a/sw/source/ui/inc/frmmgr.hxx b/sw/source/ui/inc/frmmgr.hxx >> -SW_DLLPRIVATE void _UpdateFlyFrm();//Nacharbeit nach Einfuegen >> oder Updat

Re: [Libreoffice] OSL_ASSERT - remove backtrace or make abort

2011-04-22 Thread Jan Holesovsky
Hi Lubos, On 2011-04-21 at 17:12 +0200, Lubos Lunak wrote: > > Then, there's sal-disable-backtrace.diff, > > which I can happily merge - just set DISABLE_SAL_BACKTRACE then. > > Again, it's more about the default being wrong, as in the usual case the > current default is about spamming the ou

[Libreoffice] Bug in main function libs-core/desktop/source/app/app.cxx ?

2011-04-22 Thread Julien Nabet
Hello, Following a discussion on IRC with Llunak, here is a problem. In the main function of libs-core/desktop/source/app/app.cxx Line 1599, there's a declaration+init variable : int nAcquireCount( 0 ); then nothing until this line 1880 : if (nAcquireCount) Application::AcquireSolarMutex(

[Libreoffice] minutes of tech steering call ...

2011-04-22 Thread Michael Meeks
Present: Thorten, Norbert, Kendy, Bjoern, Petr, Michael, Andras, Kohei, Mitch * AA completed: + Thorsten to fix last vmethod warnings (done) + update release plan page based on minutes + get some graphite2 screenshot / feature foo (done) + add Unity

[Libreoffice] [PATCH] Error dialog when a component is missing

2011-04-22 Thread Lubos Lunak
Hello, could somebody review the attached patch for bnc#689116? When e.g. Writer is not installed (which can happen with split rpms) and one tries to open a text document, LO simply quits without saying anything. Guessing from the surrounding code it's correct, but I'd prefer it to be checke

Re: [Libreoffice] [PUSHED] Easy Hack completed - All bogus comments removed

2011-04-22 Thread Katarina Machalkova
Hi, > These are the left arrow comments // <-- if you want to remove them all. > :-) > > ~1500 lines discarded. > > The big one is in bugzilla: > https://bugs.freedesktop.org/attachment.cgi?id=45945 Thanks, pushed all of the above (from the previous two messages + the big one from bugzilla). K

Re: [Libreoffice] OSL_ASSERT - remove backtrace or make abort

2011-04-22 Thread Lubos Lunak
On Friday 22 of April 2011, Jan Holesovsky wrote: > Hi Lubos, > > On 2011-04-21 at 17:12 +0200, Lubos Lunak wrote: > > > Then, there's sal-disable-backtrace.diff, > > > which I can happily merge - just set DISABLE_SAL_BACKTRACE then. > > > > Again, it's more about the default being wrong, as in th

Re: [Libreoffice] [Patch] Make ScVbaWorksheet work with sheet local DBRanges

2011-04-22 Thread Kohei Yoshida
On Thu, 2011-04-21 at 22:34 +0200, Markus Mohrhard wrote: > Hello, > > here a short patch that reworks the > ScVbaWorksheet::getAutoFilterMode/setAutoFilterMode methods. Hi Markus, Just a minor thing. In ScVbaWorksheet::setAutoFilterMode(), you do +if (bAutoFilterMode && pDoc) but you

[Libreoffice] [PATCH] Initial steps to support extras - download

2011-04-22 Thread KAMI911 KAMI911
Hi, Please review the attached stuffs. I would like to add it to master and libreoffice-3-4. Not affecting LibreOffice. It adds support to download extra stuffs. Can anyone help me how can I unpack these files in extras module. Should I create makefile.mk here? Should I unpack it to extras/source

[Libreoffice] KeyID build

2011-04-22 Thread Sophie Gautier
Hi all, Just a short reminder that we will now need the KeyID build to check our localization. Would it be possible Petr that you provide it in the next week or so? Only one en_US build is needed and the corresponding sdf. Thanks in advance Kind regards Sophie

Re: [Libreoffice] KeyID build

2011-04-22 Thread Andras Timar
Hi Sophie, 2011/4/22 Sophie Gautier : > Just a short reminder that we will now need the KeyID build to check our > localization. Would it be possible Petr that you provide it in the next week > or so? > Only one en_US build is needed and the corresponding sdf. I tried to build a key ID build but

Re: [Libreoffice] KeyID build

2011-04-22 Thread Sophie Gautier
On 22/04/2011 18:45, Andras Timar wrote: Hi Sophie, 2011/4/22 Sophie Gautier: Just a short reminder that we will now need the KeyID build to check our localization. Would it be possible Petr that you provide it in the next week or so? Only one en_US build is needed and the corresponding sdf.

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 André Schnabel changed: What|Removed |Added Depends on||36496 -- Configure bugmail: https://bu

Re: [Libreoffice] [Patch] Make ScVbaWorksheet work with sheet local DBRanges

2011-04-22 Thread Markus Mohrhard
Hello Kohei, yes you're right. This part was copied from another method and I didn't notice it. But I don't think that you must check for ScDocShell, because the whole class is build without any check for it. Should I send a reworked patch? There are just the two occurences of this check. Only th

Re: [Libreoffice] [Patch] Make ScVbaWorksheet work with sheet local DBRanges

2011-04-22 Thread Kohei Yoshida
Hi Markus, On Fri, 2011-04-22 at 19:29 +0200, Markus Mohrhard wrote: > Hello Kohei, > > yes you're right. This part was copied from another method and I > didn't notice it. But I don't think that you must check for > ScDocShell, because the whole class is build without any check for it. Agreed.

Re: [Libreoffice] [PATCH] Initial steps to support extras - download

2011-04-22 Thread Katarina Machalkova
Hey, > Please review the attached stuffs. I would like to add it to master and > libreoffice-3-4. Not affecting LibreOffice. It adds support to download > extra stuffs. Didn't you forget to actually attach something? :) ;) B. ___ LibreOffice mailing li

Re: [Libreoffice] [PATCH] Error dialog when a component is missing

2011-04-22 Thread Kohei Yoshida
Hi Lubos, On Fri, 2011-04-22 at 15:36 +0200, Lubos Lunak wrote: > Hello, > > could somebody review the attached patch for bnc#689116? When e.g. Writer is > not installed (which can happen with split rpms) and one tries to open a text > document, LO simply quits without saying anything. Guessin

Re: [Libreoffice] [PATCH][PUSHED] cppcheck variableScope

2011-04-22 Thread Kayo Hamid
Many thanks for the patch! I just pushed it. For the next patches it would be great if you could use git format-patch to generate the patches from the commits in the git repos. That would save us quite some work picking up the email and commit message. Regards, understood, thanks to review

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 --- Comment #30 from mhonline 2011-04-22 11:54:41 PDT --- https://bugs.freedesktop.org/show_bug.cgi?id=32672 no chance to get DBF-files to work as dataexchange-format, This bug: LO corruptes N0-field, which were used as counters, and will cause d

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 --- Comment #31 from Zack 2011-04-22 11:56:13 PDT --- Bug 36301 You can't ship a program that crashes on exit every time. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: -

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Zack changed: What|Removed |Added Depends on||36301 -- Configure bugmail: https://bugs.freedes

Re: [Libreoffice] Some smoketests failed

2011-04-22 Thread Julien Nabet
Hello Júlio, Concerning your last message about missing headers, I haven't taken a look for the moment. I won't be available for 1 week from now. So I'll give it a try later. Julien. Le 22/04/2011 00:51, Júlio Hoffimann a écrit : Hi Julien, Just a guess, i think the relevant options you're

Re: [Libreoffice] [libreoffice-design] Git Artwork guide

2011-04-22 Thread Thorsten Behrens
Christoph Noack wrote: > Since, we already have a "Tools" page I've started at OOo, so ... > * linked to the GitArtworkGuide from there and also added a link > to the artwork repository (cgit) > * moved Thorsten's description (icon workflow) to this page > * linked to the

Re: [Libreoffice] Installing beta versions replacing stable versions

2011-04-22 Thread Bernhard Dippold
Tor Lillqvist schrieb: Ed Drinkwater wrote: What is that supposed to mean? It certainly doesn't sound like a coherent, constructive contribution to the issue! That is because I am basically an incoherent dribbling idiot, la la la, na na splutgh xzbbpfft! Me wants more porridge! Sometimes i

Re: [Libreoffice] Git Artwork guide

2011-04-22 Thread Bernhard Dippold
Hi Björn, Christoph, all Bjoern Michaelsen schrieb: Hi designers, Hi developers, following the discussion on: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/756895 I created a short tutorial for designers on how to get setup to contribute artwork directly to the project at witho

Re: [Libreoffice] Installing beta versions replacing stable versions

2011-04-22 Thread NoOp
On 04/22/2011 04:02 PM, Bernhard Dippold wrote: > Tor Lillqvist schrieb: > > Ed Drinkwater wrote: >>> What is that supposed to mean? It certainly doesn't sound like a >>> coherent, constructive contribution to the issue! >> >> That is because I am basically an incoherent dribbling idiot, la la la

Re: [Libreoffice] Compilation failed in external; Ubuntu 11.04 beta

2011-04-22 Thread KAMI911 KAMI911
Hi Caolán, I have same problem. gcc -print-file-name=libgcc_s.so.1 libgcc_s.so.1 locate libgcc_s.so.1 /lib/i386-linux-gnu/libgcc_s.so.1 When I copy /lib/i386-linux-gnu/libgcc_s.so.1 to unxlngi6.pro/lib it solves the problem. Can you please provide a patch for this issue? Ubuntu 11.04B2/32 bit