Re: [Libreoffice] [PATCH] resubmitted: Some more OSL_* love and debug.hxx removal in writer/sw

2011-05-17 Thread Kohei Yoshida
On Fri, 2011-05-13 at 12:43 +0200, Jacek Wolszczak wrote: > Resubmitting the mail in case it got lost somewhere in the spam filter. Just let you know that I've reviewed and checked in the first of your patches. I haven't had a chance to review your 2nd and 3rd ones but I plan to do that shortly (

[Libreoffice] Debugging Make Fetch bash scripts on Mac OS X 10.6.7

2011-05-17 Thread Peter Teeson
As part of my exploring a Mac OS X 10.6.7 Xcode 3.2.4 project I setup a clean libo environment and did Make fetch The file libo/src/fetch.log has entries such as this: % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload

Re: [Libreoffice] VBA link error ...

2011-05-17 Thread Andreas Radke
Testing now with 3.4rc1 I'm running into a similar break even on x86_64: Entering /build/src/build/helpcontent2/source/text/shared/guide /build/src/build/swext/mediawiki/build.xml:79: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable bu

[Libreoffice] [REVIEW] Crasher fix for fdo#37252

2011-05-17 Thread Kohei Yoshida
The attached patch fixes a crasher reported in https://bugs.freedesktop.org/show_bug.cgi?id=37252 The original code always assumed that the find call on the map container always finds a match (as it didn't check against the end iterator after the call returns), but apparently in some cases no mat

Re: [Libreoffice] [REVIEW] Crasher fix for fdo#37252

2011-05-17 Thread Norbert Thiebaud
On Tue, May 17, 2011 at 8:09 PM, Kohei Yoshida wrote: > The attached patch fixes a crasher reported in > > https://bugs.freedesktop.org/show_bug.cgi?id=37252 > > The original code always assumed that the find call on the map > container always finds a match (as it didn't check against the end > it

[Libreoffice] Pay less for wonderful healthiness.

2011-05-17 Thread Edith
The only wonder med you need to get bigger love toy. http://bestgaminghardware.com/smqurvk.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Fix out of bounds access in ScTableConditionalFormat

2011-05-17 Thread Rafael Dominguez
Fix accessing vector out of its boundaries preventing possible crash, this is for 3.4 branch and master. From 95f73056bdf9e4b0e0f45bf46376dae5128f11d3 Mon Sep 17 00:00:00 2001 From: Rafael Dominguez Date: Tue, 17 May 2011 23:17:10 -0430 Subject: [PATCH] Fix index out of bounds in ScTableConditiona

Re: [Libreoffice] [REVIEW] [PUSHED] Crasher fix for fdo#37252

2011-05-17 Thread Kohei Yoshida
Hi Norbert, On Tue, May 17, 2011 at 10:52 PM, Norbert Thiebaud wrote: > +1 > Looks sane to me. Thanks. Pushed to the -3-4 branch with your sign-off. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/ma

Re: [Libreoffice] [PATCH] [PUSHED] Fix out of bounds access in ScTableConditionalFormat

2011-05-17 Thread Kohei Yoshida
On Tue, 2011-05-17 at 23:21 -0430, Rafael Dominguez wrote: > Fix accessing vector out of its boundaries preventing possible crash, > this is for 3.4 branch and master. Looks good. Pushed to master, and to -3-4 branch with my sign-off. Thanks a lot. Kohei -- Kohei Yoshida, LibreOffice hacker,

Re: [Libreoffice] [PATCH] [PUSHED] Fix out of bounds access in ScTableConditionalFormat

2011-05-17 Thread Michael Meeks
On Wed, 2011-05-18 at 00:02 -0400, Kohei Yoshida wrote: > Looks good. Pushed to master, and to -3-4 branch with my sign-off. And double reviewed for -3-4-0 I guess. ATB, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___

Re: [Libreoffice] [PATCH] [PUSHED] resubmitted: Some more OSL_* love and debug.hxx removal in writer/sw

2011-05-17 Thread Kohei Yoshida
On Tue, 2011-05-17 at 17:24 -0400, Kohei Yoshida wrote: > Just let you know that I've reviewed and checked in the first of your > patches. I haven't had a chance to review your 2nd and 3rd ones but I > plan to do that shortly (unless someone beats me to it). The 2nd and 3rd patches are now on ma

Re: [Libreoffice] [PATCH] resubmitted: Some more OSL_* love and debug.hxx removal in writer/sw

2011-05-17 Thread Kohei Yoshida
On Fri, 2011-05-13 at 12:43 +0200, Jacek Wolszczak wrote: > BTW, do you think I should create a bug in bugzilla for align ASSERT (& > friends) macro foo easy hack? Hmm... This I'm not sure. I don't have a strong opinion either way. Bjoern? -- Kohei Yoshida, LibreOffice hacker, Calc _

[Libreoffice] [PUSHED] Updated tango and galaxy mimetype toolbar icons

2011-05-17 Thread Michael Meeks
On Tue, 2011-05-17 at 16:46 +0200, Thorsten Behrens wrote: > New patch attached. Reviewed on IRC and pushed - right ? :-) Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing l

Re: [Libreoffice] [REVIEW] [PUSHED] Crasher fix for fdo#37252

2011-05-17 Thread Kohei Yoshida
On Tue, 2011-05-17 at 23:57 -0400, Kohei Yoshida wrote: > Hi Norbert, > > On Tue, May 17, 2011 at 10:52 PM, Norbert Thiebaud > wrote: > > > +1 > > Looks sane to me. > > Thanks. Pushed to the -3-4 branch with your sign-off. Shoot. I didn't realize we already branched. Can I get two more sig

Re: [Libreoffice] [REVIEW] Crasher fix for fdo#37252

2011-05-17 Thread Michael Meeks
On Tue, 2011-05-17 at 21:09 -0400, Kohei Yoshida wrote: > The attached patch fixes a crasher reported in .. > I'd like to commit this into the 3.4 branch and the 3.4.0 branch as > well (if we've already branched). second review from me :-) Thanks ! Michael. --

[Libreoffice] [REVIEW] FMR on shutdown ...

2011-05-17 Thread Michael Meeks
Fixes a potential crash on shutdown with gtk+ - prolly been there for years, would love to have the attached cherry-picked to the libreoffice-3-4 branch (but avoid 3.4.0). Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot >Fro

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36510, which changed state. Bug 36510 Summary: Consistent crash with Linux Libertine G font and Spanish locale https://bugs.freedesktop.org/show_bug.cgi?id=36510 What|Old Value |New Valu

Re: [Libreoffice] [PUSHED] Updated tango and galaxy mimetype toolbar icons

2011-05-17 Thread Thorsten Behrens
Michael Meeks wrote: > Reviewed on IRC and pushed - right ? :-) > Right :) -- Thorsten pgpGI1KRX2zoA.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libr

Re: [Libreoffice] [PATCH] [WIP] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

2011-05-17 Thread Albert Thuswaldner
Hi Kohei, Thanks for your help. On Mon, May 9, 2011 at 21:19, Kohei Yoshida wrote: > On Sun, 2011-05-08 at 17:09 +0200, Albert Thuswaldner wrote: >> Dear List, >> As a first attempt to contribute some code to LO, I've started hacking >> on his: >> >> https://bugs.freedesktop.org/show_bug.cgi?id=3

Re: [Libreoffice] Debugging Make Fetch bash scripts on Mac OS X 10.6.7

2011-05-17 Thread Tor Lillqvist
> The file libo/src/fetch.log has entries such as this: > > % Total% Received % Xferd Average Speed TimeTime Time > Current > But my copy of the terminal log shows this: Clearly this kind of output is useful only when running the download interactively. For some reason I don'

Re: [Libreoffice] [REVIEW] [PUSHED] Crasher fix for fdo#37252

2011-05-17 Thread Tor Lillqvist
> Can I get two more sign-offs for the -3-4-0 branch too? +1 Is there some rule the sign-off providers have to be from different organisations? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Libreoffice] HTML_UNKNOWNCONTROL_OFF

2011-05-17 Thread Chr. Rossmanith
Am 16.05.2011 16:23, schrieb Michael Meeks: Hi Christina, On Mon, 2011-03-14 at 16:33 +0100, Christina Roßmanith wrote: I'm playing with bug 34666 and observed that the token HTML_UNKNOWNCONTROL_OFF is never encountered: Ho hum - did this get fixed - it seems that 34666 is now closed w

Re: [Libreoffice] Oracle Report Builder corrupting chart objects

2011-05-17 Thread Fernand Vanrie
Kohei, Please, not option 3, ORB is the only descent way to have some reports out of the Base app. Greetz Fernand Hi there, This is concerning the following bug report: https://bugs.freedesktop.org/show_bug.cgi?id=36339 where chart objects get corrupted pretty much 100% of the time for

Re: [Libreoffice] [GSOC] Wizards, Java to Python report #2

2011-05-17 Thread Xisco Faulí
AFAICS this line causes troubles: xResource = smgr.createInstance("com.sun.star.resource.VclStringResourceLoader") . When I try to use any XInvocation method on it, i get a Segmentation Fault error ( I have the OS in german so the current message is Speicherzugriffsfehler. I don't speak much german

Re: [Libreoffice] HTML_ColorEntry sal_uLong->sal_uInt32

2011-05-17 Thread Chr. Rossmanith
Am 16.05.2011 17:05, schrieb Michael Meeks: On Fri, 2011-05-06 at 21:53 +0200, Chr. Rossmanith wrote: I think the variable nColor from struct HTML_ColorEntry in htmlkywd.cxx can be changed from sal_uLong to sal_uInt32. Continue to change return type of GetHTMLColor as well and remove #include af

Re: [Libreoffice] [REVIEW] alternative fix for #36703

2011-05-17 Thread Fridrich Strba
I rubber-stamp this one too. Fridrich On Mon, 2011-05-16 at 20:26 +0100, Michael Meeks wrote: > On Mon, 2011-05-16 at 20:13 +0200, Petr Mladek wrote: > > Thanks a lot for backporting the fix for graphite2-0.9.2. I have > > reviewed and pushed it to the libreoffice-3-4 branch, see > > http://cgit

Re: [Libreoffice] Oracle Report Builder corrupting chart objects

2011-05-17 Thread Sophie Gautier
Hi Kohei, all, On 17/05/2011 10:15, Fernand Vanrie wrote: Kohei, Please, not option 3, ORB is the only descent way to have some reports out of the Base app. ++1, this extension is largely used in companies for this purpose. Kind regards Sophie __

Re: [Libreoffice] Oracle Report Builder corrupting chart objects

2011-05-17 Thread Alexander Thurgood
Le 17/05/11 04:14, Kohei Yoshida a écrit : Hi Kohei, > Now, 3.3 also had ORB installed by default, and it didn't cause this > problem. When it saves a document with chart, it saves the chart object > using the opendocument.chart mime type, not the report.chart mime type. > So I assume that's th

[Libreoffice] problems with component registration

2011-05-17 Thread Noel Power
Hi David, It seems that http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=f9496177a4c942f2acc39a978a3cd65689f14d8d is causing some problems with component registration with at least basic on master. I have a temporary fix for this here http://cgit.freedesktop.org/libreoffice/libs-co

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 vitriol changed: What|Removed |Added Depends on||37277 --- Comment #104 from vitriol 2011-05-1

Re: [Libreoffice] [REVIEW][PUSHED] alternative fix for #36703

2011-05-17 Thread Petr Mladek
Michael Meeks píše v Po 16. 05. 2011 v 20:26 +0100: > On Mon, 2011-05-16 at 20:13 +0200, Petr Mladek wrote: > > Thanks a lot for backporting the fix for graphite2-0.9.2. I have > > reviewed and pushed it to the libreoffice-3-4 branch, see > > http://cgit.freedesktop.org/libreoffice/libs-extern-sys/

[Libreoffice] [REVIEW] Oracle Report Builder corrupting chart objects

2011-05-17 Thread Michael Meeks
Hi Kohei, On Mon, 2011-05-16 at 22:14 -0400, Kohei Yoshida wrote: > 1. Promote the chart8 filter as the preferred filter for the > chart2.Document type. This can be done by the attached > chart8-is-preferred-for-chart-document.diff patch. Patch looks great to me :-) can we get that into

Re: [Libreoffice] [REVIEW] Oracle Report Builder corrupting chart objects

2011-05-17 Thread Fridrich Strba
Hello, On Tue, 2011-05-17 at 10:24 +0100, Michael Meeks wrote: > Patch looks great to me :-) can we get that into -3-4 and get some more > reviews for -3-4-0 ? Once the masters decided which of those patches are to be rubber-stamped, I am rubber-stamping The Chosen One :) Fridrich __

Re: [Libreoffice] [GSOC] Wizards, Java to Python report #2

2011-05-17 Thread Michael Meeks
Hi Xisco, On Tue, 2011-05-17 at 09:21 +0200, Xisco Faulí wrote: > AFAICS this line causes troubles: xResource = > smgr.createInstance("com.sun.star.resource.VclStringResourceLoader") . > When I try to use any XInvocation method on it, i get a Segmentation > Fault error ( I have the OS in german so

Re: [Libreoffice] HTML_ColorEntry sal_uLong->sal_uInt32

2011-05-17 Thread Michael Meeks
Hi Christina, On Tue, 2011-05-17 at 09:29 +0200, Chr. Rossmanith wrote: > Am 16.05.2011 17:05, schrieb Michael Meeks: > > On Fri, 2011-05-06 at 21:53 +0200, Chr. Rossmanith wrote: > >> I think the variable nColor from struct HTML_ColorEntry in htmlkywd.cxx > >> can be changed from sal_uLong to sal

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 --- Comment #105 from sasha.libreoff...@gmail.com 2011-05-17 03:44:18 PDT --- Very annoying, but not blocker Bug 32861 - Impress hangs part way through slide show Linux specific bug, Impress hangs if slide contains gif animation -- Configure bu

Re: [Libreoffice] [REVIEW] Oracle Report Builder corrupting chart objects

2011-05-17 Thread Fernand Vanrie
Michael, Others, In our Compagny, editing house, we uses OO and LO as the one and only application. Base is here used as a frontend for getting data out of flat-text-datbases and MySQL. Data we need to produce documents in Writer, Calc etc... For producing reports we found ORB pretty stable,

Re: [Libreoffice] Libreoffice not builds

2011-05-17 Thread Michael Meeks
Hi there, On Thu, 2011-05-12 at 06:48 +0400, Гуляев Гоша wrote: > /usr/local/bin/bash > cd /var/XXX/libreoffice-build-3.3.2.2/build/libreoffice > source ./FreeBSDX86Env.Set.sh > export LANG=C > export DEBUGCPPUNIT=TRUE :-) > /var/XXX/libreoffice-build-3.3.2.2/build/libreoffice/solenv/bin

Re: [Libreoffice] UI Libre Office used 'PI'

2011-05-17 Thread Michael Meeks
Hi there, On Wed, 2011-05-11 at 08:31 -0700, ape wrote: > UI Libre Office used 'pi'... The unit of measure 'pica' is the abbreviated > name 'pi'. This is not compliant with CSS1 ('pica' = 'pc'). Why? No idea - where is it used ? is it a space issue ? do you have a tested patch to the rele

Re: [Libreoffice] How to get cell vertical orientation property?

2011-05-17 Thread Michael Meeks
Hi Alexander, On Wed, 2011-05-11 at 16:14 +0600, Alexander O. Anisimov wrote: > I need to work with cells in text tables using UNO API from Java. Riight :-) so - you get to use the UNO API - fun ... > XCell xCell = xCellRange.getCellByPosition(j, i); > XPropertySet cellSe

[Libreoffice] valgrind under Wine ...

2011-05-17 Thread Michael Meeks
Hi guys, So ... it seems that Julian has some cool stuff to allow valgrind to be run under windows (sort of): not as nice as Tor's native port of course (a great end-goal), but pretty sexy. Apparently the wine allocators have been marked up and it should be possible to valgrind li

[Libreoffice] [REVIEW] Updated 'Removed en-US duplicate dicts in langpacks'

2011-05-17 Thread Thorsten Behrens
Hi, since moving all dicts into the main installer was causing some troubles here and there (see fdo#36907), and also does not permit selective installation of dictionaries on the Mac, I reverted the original fix for fdo#34910, and only remove en-US from the non-English langpacks (see patch number

[Libreoffice] [REVIEW] Get nice background image back to Mac dmg folder

2011-05-17 Thread Thorsten Behrens
Hi, with the m101 merge, the Mac .dmg installer volume no longer contains the version - that broke the internal path for the binary DS_Store that holds folder config on Mac. Manually fixed, to look the same as 3.3 did - sadly a binary blob here ... Would like to have that in -3-4-0. Thanks, --

Re: [Libreoffice] [REVIEW] Oracle Report Builder corrupting chart objects

2011-05-17 Thread Michael Meeks
Hi Fernand, On Tue, 2011-05-17 at 13:00 +0200, Fernand Vanrie wrote: > For producing reports we found ORB pretty stable, so > please keep LO-Base-ORB at least at the current OO level Again - this is a developers list. Begging people to fix bugs does not belong here :-) no matter how impa

Re: [Libreoffice] [REVIEW] Updated 'Removed en-US duplicate dicts in langpacks'

2011-05-17 Thread Andras Timar
2011.05.17. 13:49 keltezéssel, Thorsten Behrens írta: > since moving all dicts into the main installer was causing some > troubles here and there (see fdo#36907), and also does not permit > selective installation of dictionaries on the Mac, I reverted the > original fix for fdo#34910, and only remo

Re: [Libreoffice] [REVIEW] Updated 'Removed en-US duplicate dicts in langpacks'

2011-05-17 Thread Fridrich Strba
Apart that, you have my blessing for this, son F. On Tue, 2011-05-17 at 14:00 +0200, Andras Timar wrote: > 2011.05.17. 13:49 keltezéssel, Thorsten Behrens írta: > > since moving all dicts into the main installer was causing some > > troubles here and there (see fdo#36907), and also does not perm

Re: [Libreoffice] [REVIEW] Get nice background image back to Mac dmg folder

2011-05-17 Thread Fridrich Strba
>From a pure reading of the patch, it looks sane. Go ahead and push. F. On Tue, 2011-05-17 at 13:55 +0200, Thorsten Behrens wrote: > Hi, > > with the m101 merge, the Mac .dmg installer volume no longer > contains the version - that broke the internal path for the binary > DS_Store that holds fo

[Libreoffice] [REVIEW] Updated tango and galaxy mimetype toolbar icons

2011-05-17 Thread Thorsten Behrens
Hi, as requested in fdo#33229, the toolbar icons for tango and galaxy needed a bit of polish to fit into the theme. Please refer to https://bugs.freedesktop.org/show_bug.cgi?id=33229#c33 for links to how the updated artwork looks. I'd like to have this in -3-4-0 Thanks, -- Thorsten From d08ae5

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36676, which changed state. Bug 36676 Summary: sourroundig lines in paragraphs are missing https://bugs.freedesktop.org/show_bug.cgi?id=36676 What|Old Value |New Value ---

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36915, which changed state. Bug 36915 Summary: Beanshell scripts don't work https://bugs.freedesktop.org/show_bug.cgi?id=36915 What|Old Value |New Value --

Re: [Libreoffice] [REVIEW] Get nice background image back to Mac dmg folder

2011-05-17 Thread Michael Meeks
On Tue, 2011-05-17 at 13:55 +0200, Thorsten Behrens wrote: > with the m101 merge, the Mac .dmg installer volume no longer > contains the version - that broke the internal path for the binary > DS_Store that holds folder config on Mac. Manually fixed, to look > the same as 3.3 did - sadly a binary

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37015, which changed state. Bug 37015 Summary: Scripting other than Basic unavailable https://bugs.freedesktop.org/show_bug.cgi?id=37015 What|Old Value |New Value

Re: [Libreoffice] [REVIEW] missing desktop icons (fdo#37160)

2011-05-17 Thread Christian Lohmaier
Hi *, On Tue, May 17, 2011 at 5:27 AM, Yifan Jiang wrote: > On Mon, May 16, 2011 at 09:17:07PM +0200, Petr Mladek wrote: >> >> LO-3.4 can be installed in parallel with LO-3.3 on Linux (fdo#36551). > > If this is a new feature, shall we release note it to spread the word? :) > Thanks! > > http://w

Re: [Libreoffice] [REVIEW] Updated 'Removed en-US duplicate dicts in langpacks'

2011-05-17 Thread Thorsten Behrens
Andras Timar wrote: > Use 'en' instead of 'en-US' in spellchecker_selection.txt because of > http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?h=libreoffice-3-4&id=838aba9d2f29464ffbecbdd12fa9e39ec7ce6dd6 > (you did not revert this). The rationale is that 'en' dict pack contains > en-US, en

Re: [Libreoffice] [REVIEW] Updated 'Removed en-US duplicate dicts in langpacks'

2011-05-17 Thread Thorsten Behrens
I wrote: > Good catch - amended patch #3 attached. > Or so I thought. Now with the updated patch ... -- Thorsten From 24e64d31c410cd8ba8855384c3c8211f1b36fe78 Mon Sep 17 00:00:00 2001 From: Thorsten Behrens Date: Tue, 17 May 2011 13:40:58 +0200 Subject: [PATCH] Removed en-US duplicate dicts in la

Re: [Libreoffice] [REVIEW] Updated tango and galaxy mimetype toolbar icons

2011-05-17 Thread Michael Meeks
Hi there, On Tue, 2011-05-17 at 14:02 +0200, Thorsten Behrens wrote: > as requested in fdo#33229, the toolbar icons for tango and galaxy > needed a bit of polish to fit into the theme. Indeed :-) > Please refer to > https://bugs.freedesktop.org/show_bug.cgi?id=33229#c33 for links to > ho

Re: [Libreoffice] [REVIEW] missing desktop icons (fdo#37160)

2011-05-17 Thread Petr Mladek
Christian Lohmaier píše v Út 17. 05. 2011 v 14:36 +0200: > Hi *, > > On Tue, May 17, 2011 at 5:27 AM, Yifan Jiang wrote: > > On Mon, May 16, 2011 at 09:17:07PM +0200, Petr Mladek wrote: > >> > >> LO-3.4 can be installed in parallel with LO-3.3 on Linux (fdo#36551). > > > > If this is a new featur

Re: [Libreoffice] [REVIEW] Updated 'Removed en-US duplicate dicts in langpacks'

2011-05-17 Thread Andras Timar
2011/5/17 Thorsten Behrens : > I wrote: >> Good catch - amended patch #3 attached. >> > Or so I thought. Now with the updated patch ... > > -- Thorsten > OK for me. Cheers, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lis

Re: [Libreoffice] Cppcheck Same expression on both sides of '<'

2011-05-17 Thread Michael Meeks
Hi Julien, On Mon, 2011-05-16 at 19:08 +0200, Julien Nabet wrote: > Here a line I get in cppcheck (updated today) : > [source/core/layout/flycnt.cxx:1194] -> > [source/core/layout/flycnt.cxx:1194]: (style) Same expression on both > sides of '<'. What fun :-) > I checked the file git hi

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 35671, which changed state. Bug 35671 Summary: help: not linking to pages correctly ... https://bugs.freedesktop.org/show_bug.cgi?id=35671 What|Old Value |New Value --

Re: [Libreoffice] [REVIEW] missing desktop icons (fdo#37160)

2011-05-17 Thread Cor Nouws
Christian Lohmaier wrote (17-05-11 14:36) It should be added, but not because of the "new feature", but rather because of the limitations it has: As both share the same user-configuration-directory, a user cannot run them both at the same time. When one version is running already, trying to start

Re: [Libreoffice] [REVIEW] Oracle Report Builder corrupting chart objects

2011-05-17 Thread Alexander Thurgood
Le 17/05/11 11:24, Michael Meeks a écrit : Hi Michael, > And for those complaining about the idea of removing ORB altogether: > doing some work to help out improve the stability of the implementation > sounds like it would be a good plan. Rather than just wishing it was > better, we need (n

Re: [Libreoffice] [PUSHED] [REVIEW] Updated 'Removed en-US duplicate dicts in langpacks'

2011-05-17 Thread Thorsten Behrens
Andras Timar wrote: > OK for me. > Thx, squashed into one & pushed to -3-4 -- Thorsten pgpG6qVWwVjw3.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffic

Re: [Libreoffice] [REVIEW] Oracle Report Builder corrupting chart objects

2011-05-17 Thread Fernand Vanrie
Michael , sorry, I was not Begging, just tryed to explain the quality's from OO and LO. No funder for the moment because we are still OO-users :-) but we follow with interest the discussions about paid-bug-repair. Greetz Fenand On Tue, 2011-05-17 at 13:00 +0200, Fernand Vanrie wrote: In

Re: [Libreoffice] [GSoc] Progress report - Visio import filter

2011-05-17 Thread Fridrich Strba
Eilidh, I created a git repository http://cgit.freedesktop.org/libreoffice/contrib/libvisio/ It has a skeleton of a library whose api is taking basically this class: namespace libvisio { class VisioDocument { public: static bool isSupported(WPXInputStream* input); static bool parse(WPXInputStrea

[Libreoffice] License for Artwork

2011-05-17 Thread Sophie Gautier
Hi all, Working with Andras on the doc listing the different licenses, I wonder if there is something about Artwork to add? Do we use Artwork containing a specific license? Libraries, fonts and dictionaries are already covered. Thanks in advance Kind regards Sophie ___

Re: [Libreoffice] Cppcheck Same expression on both sides of '<'

2011-05-17 Thread Julien Nabet
Le 17/05/2011 15:04, Michael Meeks a écrit : ... nDownLst< nDownLst So - this is the guy. sal_Bool operator<( const SwDistance& rTwo ) { return nMain< rTwo.nMain || ( So - we end up with: that equating to: nDownLst.nSub&& nDownLst.nSub&& nDownLst.n

[Libreoffice] LO with clean configuration unusable

2011-05-17 Thread Lubos Lunak
Hello, current master, with ~/.libreoffice removed, fails on the first startup, showing a dialog about not being able to lauch the application. Subsequent launches are successful, but LO is unable to load or save any document (I assume the first run resulted in a corrupted internal database

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Petr Mladek changed: What|Removed |Added Depends on||32861 --- Comment #106 from Petr Mladek 2

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36907, which changed state. Bug 36907 Summary: Extremely slow after installation https://bugs.freedesktop.org/show_bug.cgi?id=36907 What|Old Value |New Value -

Re: [Libreoffice] LO with clean configuration unusable

2011-05-17 Thread Noel Power
On 17/05/11 15:13, Lubos Lunak wrote: Hello, current master, with ~/.libreoffice removed, fails on the first startup, showing a dialog about not being able to lauch the application. Subsequent launches are successful, but LO is unable to load or save any document (I assume the first run resu

[Libreoffice] [REVIEW] fix for fdo#37277

2011-05-17 Thread Cedric Bosdonnat
Hi all, could someone review, sign-off and push to 3.4 branch this patch fixing fdo#37277? Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr >From 63d51247bff1fdb6eebbc19983b881d8b5af8728 Mon Sep 17 00:

Re: [Libreoffice] [REVIEW] Updated tango and galaxy mimetype toolbar icons

2011-05-17 Thread Thorsten Behrens
Michael Meeks wrote: > Interestingly, while the artwork is no doubt an improvement - the icons > are 24x24 instead of the originals which are 32x32 - perhaps that was > the cause of the underlying bug ? :-) My feeling was that the icons were > simply too large wrt. filling the rectangular are

Re: [Libreoffice] [REVIEW] [PUSHED]fix for fdo#37277

2011-05-17 Thread Noel Power
On 17/05/11 15:37, Cedric Bosdonnat wrote: m_bResetUndo = sal_False ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37277, which changed state. Bug 37277 Summary: Formulas in table are inserted into the wrong cell https://bugs.freedesktop.org/show_bug.cgi?id=37277 What|Old Value |New Value

Re: [Libreoffice] [REVIEW] Oracle Report Builder corrupting chart objects

2011-05-17 Thread Michael Meeks
Hi Alex, First - your support is appreciated :-) don't think I'm saying it is not. On Tue, 2011-05-17 at 15:14 +0200, Alexander Thurgood wrote: > I think the point that most users are making is that it actually used to > work, and was fairly stable, "in previous times". This is what peopl

[Libreoffice] [REVIEW] Fix for fdo#37226

2011-05-17 Thread Kohei Yoshida
Hi there, The attached patch fixes the crasher reported in the following bug: https://bugs.freedesktop.org/show_bug.cgi?id=37226 and also several other usage of standard algorithms which I believe is incorrect, since the existing code passes the result of an evaluation which is always boolean (u

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36915, which changed state. Bug 36915 Summary: Beanshell scripts don't work https://bugs.freedesktop.org/show_bug.cgi?id=36915 What|Old Value |New Value --

[Libreoffice] .doc and .docx support in master

2011-05-17 Thread Jonathan Aquilina
Hey guys I am trying to test out the master branch, and im noticing a major issue with the .docx as well as the .doc import filters. .docx im guessing is still not implemented, and if that is the case what stage is it at before we will have support for working with .docx documents. Also whe

[Libreoffice] [REVIEW]

2011-05-17 Thread Bjoern Michaelsen
Hi Caolan, Hi all, can somebody please review this commit on master for cherrypicking on 3.4? http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?id=33b25c9c7ac5c960991c71d641740dbc8fa432b5 The build breaks without it on Ubuntu Natty. Caolan got selected for cc'ing by git blame heuristic

[Libreoffice] REVIEW for fix#37211

2011-05-17 Thread Noel Power
Hi, following patch fixes regressions reported in https://bugs.freedesktop.org/show_bug.cgi?id=37211 & https://bugs.freedesktop.org/show_bug.cgi?id=37170 https://bugs.freedesktop.org/attachment.cgi?id=46831 it would be great to get the 1 review for libreoffice-3-4 ( not critical so no poin

Re: [Libreoffice] [REVIEW] Oracle Report Builder corrupting chart objects

2011-05-17 Thread Kohei Yoshida
On Tue, 2011-05-17 at 10:24 +0100, Michael Meeks wrote: > On Mon, 2011-05-16 at 22:14 -0400, Kohei Yoshida wrote: > > 1. Promote the chart8 filter as the preferred filter for the > > chart2.Document type. This can be done by the attached > > chart8-is-preferred-for-chart-document.diff patch. > >

Re: [Libreoffice] [REVIEW] Oracle Report Builder corrupting chart objects

2011-05-17 Thread Kohei Yoshida
On Tue, 2011-05-17 at 10:24 +0100, Michael Meeks wrote: > > 2. Remove the type detection definition for the chart2.Document type > > from the report builder itself. This can be done by the > > report-builder-dont-act-like-chart-handler.diff patch. This will > > prevent ORB from advertising itsel

[Libreoffice] [REVIEW] always request an unversioned lib from gcc in gccinstlib.pl

2011-05-17 Thread Bjoern Michaelsen
On Tue, 17 May 2011 18:43:28 +0200 Bjoern Michaelsen wrote: > > http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?id=33b25c9c7ac5c960991c71d641740dbc8fa432b5 replying to myself, because I forgot to fill up the subject after the "[REVIEW]" ... again. Sorry about the noise. Best, Bjoer

Re: [Libreoffice] build breaks on i686

2011-05-17 Thread Andreas Radke
Am Sun, 24 Apr 2011 14:43:44 +0200 schrieb Andreas Radke : > of > /build/src/build/solver/300/unxlngi6.pro/workdir/CxxObject/sc/source/ui/vba/vbasheetobjects.o > collect2: ld returned 1 exit status > make[1]: *** > [/build/src/build/solver/300/unxlngi6.pro/workdir/LinkTarget/Library/v

Re: [Libreoffice] build breaks on i686

2011-05-17 Thread Jonathan Aquilina
I can confirm i have seen this in building as well on 64bit, running gcc 4.5 on kubuntu natty 11.04, the only difference is that the build continues for me and somehow successfully completes. If you take a look at my last tinbuild the dmake error appears somewhere in the tinbuild log. On 05/17

Re: [Libreoffice] [REVIEW] always request an unversioned lib from gcc in gccinstlib.pl

2011-05-17 Thread Michael Meeks
On Tue, 2011-05-17 at 19:03 +0200, Bjoern Michaelsen wrote: > > > > http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?id=33b25c9c7ac5c960991c71d641740dbc8fa432b5 > > replying to myself, because I forgot to fill up the subject after the > "[REVIEW]" ... again. Sorry about the noise.

Re: [Libreoffice] [REVIEW] Oracle Report Builder corrupting chart objects

2011-05-17 Thread Michael Meeks
On Tue, 2011-05-17 at 15:23 +0200, Fernand Vanrie wrote: > No funder for the moment because we are still OO-users :-) but we follow > with interest the discussions about paid-bug-repair. Yep - it is a good topic that; I wonder ... there are people that would like to fix things, and there

Re: [Libreoffice] Libreoffice not builds

2011-05-17 Thread Гуляев Гоша
Michael Meeks, thank a lot for your help, and for that you dont leave me alone with that ununderstandable errors :) And for your words about gdb in freebsd, maybe i need to install any additional soft for that? Or setup debug options in kernel? In kernel config have such options that i disable:

Re: [Libreoffice] [REVIEW] always request an unversioned lib from gcc in gccinstlib.pl

2011-05-17 Thread Bjoern Michaelsen
On Tue, 17 May 2011 18:17:59 +0100 Michael Meeks wrote: > Ho hum - if you certain this will not break anything, and > that it returns the original results elsewhere; I hardly can, given the size of the linux ecosystem. But if somebody has different versioned libs for libgcc_s.so or libstdc

[Libreoffice] VBA link error ...

2011-05-17 Thread Michael Meeks
Hi there, On Fri, 2011-05-06 at 20:29 +0200, Andreas Radke wrote: > non-smp fails also. I'm attaching the end of the log. So - this was still a threaded build, and the real link error was in sc, best to paste the commands in (that show which module to build inside): [ build CXX ] sc/sour

Re: [Libreoffice] Libreoffice not builds

2011-05-17 Thread Michael Meeks
Hi there, On Tue, 2011-05-17 at 21:32 +0400, Гуляев Гоша wrote: > Michael Meeks, thank a lot for your help Really, my pleasure - thanks for persisting. > And for your words about gdb in freebsd, maybe i need to install any > additional soft for that? Or setup debug options in kernel?

Re: [Libreoffice] VBA link error ...

2011-05-17 Thread Andreas Radke
Am Tue, 17 May 2011 18:36:15 +0100 schrieb Michael Meeks : > And - well ;-) yes, it looks like a nastily odd linking / > compiling / assembling error. > > You tried re-building from 'make clean' in sc/ ? Either way > hopefully Kohei can chase it on IRC with you. I'm always trying to

[Libreoffice] [ANNOUNCE] libreoffice-3.4.0.1 tag created (3.4.0-rc1)

2011-05-17 Thread Petr Mladek
Hi, there have been created the libreoffice-3.4.0.1 tag for 3.4.0-rc1 release. The corresponding official builds will be available by the end of the week. See the attached list of changes against 3.4.0-beta5. You might switch your current 3-4 source tree to it using: ./g fetch --tags ./g checko

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 vitriol changed: What|Removed |Added Depends on||37252 --- Comment #107 from vitriol 2011-05-1

[Libreoffice] [ANNOUNCE] Branch libreoffice-3-4-0 created

2011-05-17 Thread Petr Mladek
Hi all, there have been created the libreoffice-3-4-0 branch. It will be used for fine tuning of the 3.4.0 release. It is based on the the tag libreoffice-3.4.0.1 for 3.4.0-rc1 release. The following rules apply: + any commit has to be reviewed by 3 people + preferably commit onl

Re: [Libreoffice] HTML_ColorEntry sal_uLong->sal_uInt32

2011-05-17 Thread Chr. Rossmanith
Hi, It looks nice :-) then again - I noticed this mess: #if defined( WNT ) __cdecl #endif #if defined( ICC ) _Optlink #endif Which (you would hope) would be implied by the extern "C" { } construct on Windows - with a SAL_CALL macro annotation instead :-) That won't work for

Re: [Libreoffice] REVIEW for fix#37211

2011-05-17 Thread Clio
17.05.2011 12:47, Noel Power пишет: ( not critical so no point pushing for the release branch I think ) If it is not fixed in 3.4.0, you can't Select All neither with the menu nor with Ctrl A. And Delete key not working would be very annoing too. __

Re: [Libreoffice] VBA link error ...

2011-05-17 Thread Michael Meeks
On Tue, 2011-05-17 at 19:55 +0200, Andreas Radke wrote: > I'm always trying to build packages for ArchLinux with your upstream > source tarballs. No git or 2nd run builds. Ah ! how exciting :-) I imagine as we get closer to release, that has even more of a chance of working - but clearly,

[Libreoffice] Hовые сxемы c 1.04.2011

2011-05-17 Thread Дeятельность в сфере инфоpмaтизации
--- | Oптимизaция нaлогoобложения и aнтиoптимизaция | | (pисковые oпepaции, кoтopыx дeлaть нe cтoит) - HДC, пpибыль, HДФЛ. | | «Пpoбoины» cтapыx c

  1   2   >