Re: [Libreoffice] about the removing of binfilter

2011-05-31 Thread Cedric Bosdonnat
Hi Jean-Baptiste, On Mon, 2011-05-30 at 22:51 +0200, Jean-Baptiste Faure wrote: > But the removing of the import of old formats is another story. I am > already hearing end-users complaining against this decision. Indeed it > is not so evident that the users can convert their old files to > OpenDo

Re: [Libreoffice] [PATCH] fdo#32263 - Config file location

2011-05-31 Thread Noel Power
On 31/05/11 01:41, Takeshi Abe wrote: Hi Noel, [...] Well the change against common_brand.scp is surrounded with #ifdef, so will not affect to WNT nor to MACOSX. Or am I misunderstanding something? yes that's what I said ( probably not clearly enough ) e.g. I realised that "the config changed

Re: [Libreoffice] smoketest fail, N12_GLOBAL__N_14TestE::test

2011-05-31 Thread Caolán McNamara
On Tue, 2011-05-31 at 08:22 +0200, Julien Nabet wrote: > Hello, > > in smoketestoo_native, I've got this : > > officeconnection.cxx:140:Assertion > Test name: N12_GLOBAL__N_14TestE::test > setUp() failed > - equality assertion failed > - Expected: 2 > - Actual : 0 > > So I used export DEBUGCPPU

Re: [Libreoffice] Platform-specific DLL suffix usefulness

2011-05-31 Thread Caolán McNamara
On Tue, 2011-05-31 at 08:10 +0200, Francois Tigeot wrote: > Is there a canonical list of them I could check ? In an install set these should be in /path/to/libreoffice/ure/lib and/or dig around for SCP2_URE_foo in scp2 C. ___ LibreOffice mailing list L

Re: [Libreoffice] [GSoC 2011][svgexport] weekly report #1

2011-05-31 Thread Thorsten Behrens
Marco wrote: > >> if( mpSdrModel ) > >> { > >> SdrOutliner& rOutl = mpSdrModel->GetDrawOutliner(NULL); > >> > >> maOldFieldHdl = rOutl.GetCalcFieldValueHdl(); > >> rOutl.SetCalcFieldValueHdl( LINK( this, SVGFilter, > >>CalcFieldHdl) ); > >>

[Libreoffice] Workflow proposal

2011-05-31 Thread Jan Holesovsky
Hi Bjorn, On 2011-05-30 at 19:13 +0200, Bjoern Michaelsen wrote: > > So - as long as you don't force people to do this [ie. don't force > > this as a rule, but instead let them decide if they are willing to > > wait for the merge of the branch into the master (working mostly on > > the branch bef

Re: [Libreoffice] about the removing of binfilter

2011-05-31 Thread Michael Meeks
Hi Jean, On Mon, 2011-05-30 at 22:51 +0200, Jean-Baptiste Faure wrote: > But the removing of the import of old formats is another story. I am > already hearing end-users complaining against this decision. Where, can you give some links to that ? and why are they still using a file format

Re: [Libreoffice] Platform-specific DLL suffix usefulness

2011-05-31 Thread Michael Meeks
On Tue, 2011-05-31 at 08:10 +0200, Francois Tigeot wrote: > It was my understanding the UNO libraries didn't use DLLPOSTFIX but now > you're making me doubt. They do not :-) > Is there a canonical list of them I could check ? ls ure/lib # in an install ;-) ATB,

Re: [Libreoffice] Debugging UNO references in gdb

2011-05-31 Thread Michael Meeks
On Tue, 2011-05-31 at 07:39 +0200, David Tardon wrote: > FWIW, I have this in ~/.gdbinit : Which reminds me - how is the inclusion of the python debugging goodness going on ? and/or could we use that to help out here ? :-) Thanks, Michael. -- michael.me...@nov

Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters

2011-05-31 Thread Noel Power
On 30/05/11 18:18, Korrawit Pruegsanusak wrote: Hello all, Attached patch is a bit more code cleanup in filters. Please feel free to comment. Anyway, I've found some comments are unreadable, eg. in /hwpfilter/source/hwpreader.cxx line ~4440. Should we also remove them? or are they my encoding fa

Re: [Libreoffice] 8 combinations of Python support: do we really need that?

2011-05-31 Thread Michael Meeks
Hi Tor, On Mon, 2011-05-30 at 14:08 -0600, Tor Lillqvist wrote: > --disable-python. "Disable build of Python 2.x UNO API" > --enable-ext-scripting-python. "Enables support for scripts in Python" > --with-system-python. "Use Python already on system" Of course, there are not eight meaningf

[Libreoffice] [REVIEWED] fix for fdo#37590

2011-05-31 Thread Michael Meeks
Hi Noel, On Mon, 2011-05-30 at 20:40 +0100, Noel Power wrote: > Petr and I chatted briefly on IRC, as he rightly pointed out most > likely the intended change would be > https://bugs.freedesktop.org/attachment.cgi?id=47337 Read around it a bit; seems ok to me :-) any chance you can pus

Re: [Libreoffice] [GSOC] Weekly Report: Wizards....

2011-05-31 Thread Bjoern Michaelsen
Hi Xisco, Hi Norbert, On Mon, 30 May 2011 22:50:12 -0500 Norbert Thiebaud wrote: > It would be best to use a feature branch instead of a whole new set > of repos: > http://wiki.documentfoundation.org/Development#Managing_git_branches I already created a branch named feature/gsoc2011_wizards. Th

Re: [Libreoffice] about the removing of binfilter

2011-05-31 Thread Jean-Baptiste Faure
Le 31/05/2011 10:46, Michael Meeks a écrit : > Hi Jean, > > On Mon, 2011-05-30 at 22:51 +0200, Jean-Baptiste Faure wrote: >> But the removing of the import of old formats is another story. I am >> already hearing end-users complaining against this decision. > > Where, can you give some link

Re: [Libreoffice] [PUSHED[ [REVIEWED] fix for fdo#37590

2011-05-31 Thread Noel Power
On 31/05/11 10:06, Michael Meeks wrote: Hi Noel, On Mon, 2011-05-30 at 20:40 +0100, Noel Power wrote: Petr and I chatted briefly on IRC, as he rightly pointed out most likely the intended change would be https://bugs.freedesktop.org/attachment.cgi?id=47337 as per the ack, pushed to 3.4

Re: [Libreoffice] Warning in basic/source/runtime/runtime.cxx

2011-05-31 Thread Michael Meeks
Hi Julien, Great to have you chasing this joke code: -(pCollection = PTR_CAST(BasicCollection,pVar)) == pCollection ) Digging at what the code is used for it -seems- - that we want to find this collection on the stack (if it is there), to alter the index a 'foreach' i

Re: [Libreoffice] 8 combinations of Python support: do we really need that?

2011-05-31 Thread Caolán McNamara
On Tue, 2011-05-31 at 09:54 +0100, Michael Meeks wrote: > IMHO - that is the thing that most needs fixing; I'd love to slave that > option to enable-python (personally). Then again - the other > --enable-ext-scripting-foo things also need IMHO to be auto-enabled if > the pre-requisites are th

Re: [Libreoffice] 8 combinations of Python support: do we really need that?

2011-05-31 Thread Tor Lillqvist
> Of course, there are not eight meaningful combinations; if you disable > python you get nothing at all. Well, are you sure that is what --disable-python means? I am not sure. But if that is what it means, that no Python will be built or used, then at least the help for that option should say

Re: [Libreoffice] Warning in basic/source/runtime/runtime.cxx

2011-05-31 Thread David Tardon
On Tue, May 31, 2011 at 10:27:19AM +0100, Michael Meeks wrote: > that works. I believe this is just a cut/paste error from dr, and we > want this instead: > > +PTR_CAST(BasicCollection,pVar) == pCollection ) > > I'll commit that, and wait for screams. Moreover, I think th

Re: [Libreoffice] [PUSHED] [PATCH] fdo#32263 - Config file location

2011-05-31 Thread Noel Power
On 31/05/11 09:25, Noel Power wrote: On 31/05/11 01:41, Takeshi Abe wrote: Hi Noel, [...] Well the change against common_brand.scp is surrounded with #ifdef, so will not affect to WNT nor to MACOSX. Or am I misunderstanding something? yes that's what I said ( probably not clearly enough ) e.g

Re: [Libreoffice] Patch to fix compile with Bison 2.5 and Gcc 4.5.3 on LibO 3.4 RC2

2011-05-31 Thread Lubos Lunak
On Monday 30 of May 2011, Kelly Anderson wrote: > Fixes compile with Bison 2.5 and Gcc 4.5.3 for LibO 3.4 RC2. > > libreoffice-libs-core-3.4.0.2 requires patch to compile with Bison 2.5 and > Gcc 4.5.3. Pushed, thanks, but please next time - prefix the mail subject with [PATCH] so that it's easi

[Libreoffice] [PUSHED] fix for fdo#37772: Insert sheets in a protected spreadsheet document

2011-05-31 Thread Michael Meeks
Hi Markus, On Tue, 2011-05-31 at 05:48 +0200, Markus Mohrhard wrote: > this patch fixes bug fdo#37772. Using the plus Icon in the footer > calls different code paths than the normal menus so we need to check > that the document is editable separately. Thanks for that ! :-) > I think this

Re: [Libreoffice] Need help with the Bug 33092 – Autocomplete display double character for this word [CTL / Thai]

2011-05-31 Thread Cedric Bosdonnat
Hello Samphan, On Tue, 2011-05-31 at 12:32 +0700, Samphan Raruenrom wrote: > Any idea about my experimental fix? i.e. remove the auto-style that > switch to the very same locale. It doesn't look bad to me but I could go into deeper investigation as I couldn't type that word using any of the thai

Re: [Libreoffice] about the removing of binfilter

2011-05-31 Thread Cedric Bosdonnat
On Tue, 2011-05-31 at 11:13 +0200, Jean-Baptiste Faure wrote: > Le 31/05/2011 10:46, Michael Meeks a écrit : > > On Mon, 2011-05-30 at 22:51 +0200, Jean-Baptiste Faure wrote: > >> But the removing of the import of old formats is another story. I am > >> already hearing end-users complaining against

Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters

2011-05-31 Thread Korrawit Pruegsanusak
Hello Michael, Noel, * On May 31, 2011 1:11 AM, "Michael Meeks" wrote: >Thanks it looks lovely :-) can you confirm it & all that follow are > MPL/LGPLv3+ licensed ? Maybe I'm late, but I confirm. And may I ask again that: > I've found some comments are unreadable, eg. in > http://opengro

Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters

2011-05-31 Thread Michael Meeks
On Tue, 2011-05-31 at 18:23 +0700, Korrawit Pruegsanusak wrote: > Maybe I'm late, but I confirm. Thanks :-) helps speedup patch inclusion to have that each time, though (as Noel says) I'd pushed it already. > And may I ask again that: > > I've found some comments are unreadable, eg. in >

[Libreoffice] [PATCH] Duplicate code: join ImportFrom and InsertFrom

2011-05-31 Thread Chr. Rossmanith
Hi, more duplicate code cleanup. Class SfxObjectShell has two nearly identical methods: ImportFrom and InsertFrom. The latter has a few lines of code more, so I've removed InsertFrom (which was added to the code base later than ImportFrom), added a boolean parameter to ImportFrom and adjusted

Re: [Libreoffice] [PUSHED-3-4] [REVIEW] more OOo icon to LibO icon changes

2011-05-31 Thread Thorsten Behrens
Andras Timar wrote: > I need one review for 3-4 > http://cgit.freedesktop.org/libreoffice/artwork/commit/?id=3f7ffa8409ba7fc1ce5f70dbae06a44a42c9947f > http://cgit.freedesktop.org/libreoffice/artwork/commit/?id=6fb432551320ea3d6eb1648f78abda6569705795 > Hi Andras, thanks for this - and you have my

Re: [Libreoffice] [PATCH] __cdecl -> SAL_CALL (calc/components/ure/writer)

2011-05-31 Thread Chr. Rossmanith
Hi, more __cdecl->SAL_CALL work for reviewing. I'll push them if the changes are fine. Christina >From d92538be9eba632a9f016878814fcc31e9a4aa9a Mon Sep 17 00:00:00 2001 From: Christina Rossmanith Date: Thu, 26 May 2011 16:34:43 +0200 Subject: [PATCH 1/2] __cdecl -> SAL_CALL --- sc/inc/range

[Libreoffice] merge issues ...

2011-05-31 Thread Bjoern Michaelsen
Hi all, I just noted that commit bootstrap:f6ada6a7bf27fd8e0a50f0096604f541beca06e1 got silently reverted by one of the recent merges. The commit itself is uncritical, but do we have a general problem here? It does not seem as if there was any manual intervention at all for this upon merge. Silen

Re: [Libreoffice] Workflow proposal

2011-05-31 Thread Bjoern Michaelsen
Hi Kendy, On Tue, 31 May 2011 10:43:22 +0200 Jan Holesovsky wrote: > To sum up my proposal: > > - master > - no review, anything can be committed / merged into it > - as long as the author did her / his best to make sure it > builds / does not break the tests) > > - libreoffice-A-X

Re: [Libreoffice] Need help with the Bug 33092 – Autocomplete display double character for this word [CTL / Thai]

2011-05-31 Thread Samphan Raruenrom
On Tue, May 31, 2011 at 5:56 PM, Cedric Bosdonnat < cedric.bosdonnat@free.fr> wrote: > Hello Samphan, > > On Tue, 2011-05-31 at 12:32 +0700, Samphan Raruenrom wrote: > > Any idea about my experimental fix? i.e. remove the auto-style that > > switch to the very same locale. > It doesn't look ba

[Libreoffice] [REVIEW 3.4][REVIEW 3.4.0] use --nologo to prevent oosplash smoketest hangs

2011-05-31 Thread Bjoern Michaelsen
Hi all, please review this commit for 3.4 and 3.4.0. http://cgit.freedesktop.org/libreoffice/testing/commit/?id=c414bb1dc75b3db4fa88874ff5f978e6a0d18d56 rationale: Makes smoketest stable, does not touch code from the delivered product, so should be low risk. Best, Bjoern -- https://launchpad

Re: [Libreoffice] Warning in basic/source/runtime/runtime.cxx

2011-05-31 Thread Michael Meeks
On Tue, 2011-05-31 at 11:58 +0200, David Tardon wrote: > On Tue, May 31, 2011 at 10:27:19AM +0100, Michael Meeks wrote: > > +PTR_CAST(BasicCollection,pVar) == pCollection ) > > > > I'll commit that, and wait for screams. > > Moreover, I think there should be p = p->pNext at the e

Re: [Libreoffice] merge issues ...

2011-05-31 Thread Jan Holesovsky
Hi Bjoern, On 2011-05-31 at 14:30 +0200, Bjoern Michaelsen wrote: > I just noted that commit > bootstrap:f6ada6a7bf27fd8e0a50f0096604f541beca06e1 > got silently reverted by one of the recent merges. The commit > itself is uncritical, but do we have a general problem here? It does > not seem as if

Re: [Libreoffice] Postgresql SDBC source no longer in git repo ?

2011-05-31 Thread Alexander Thurgood
Le 29/05/11 08:41, Alexander Thurgood a écrit : Any news on this ? It appears that the stuff was previously in /connectivity/drivers, at least it was with 3.3.2, but now it is no longer there - a victim of the branch off perhaps ? Alex ___ LibreOffice

Re: [Libreoffice] Workflow proposal

2011-05-31 Thread Jan Holesovsky
Hi Bjoern, On 2011-05-31 at 14:37 +0200, Bjoern Michaelsen wrote: > > To sum up my proposal: > > > > - master > > - no review, anything can be committed / merged into it > > - as long as the author did her / his best to make sure it > > builds / does not break the tests) > > > > - l

Re: [Libreoffice] Platform-specific DLL suffix usefulness

2011-05-31 Thread Bjoern Michaelsen
On Tue, 31 May 2011 08:10:13 +0200 Francois Tigeot wrote: > Hi Bjoern, > > It was my understanding the UNO libraries didn't use DLLPOSTFIX but > now you're making me doubt. > Is there a canonical list of them I could check ? As Michael and Caolan already said, no problem there, go for it! Best,

Re: [Libreoffice] Encrypted password -- change?

2011-05-31 Thread Kohei Yoshida
On Mon, 2011-05-30 at 21:24 +0200, Cor Nouws wrote: > Hi Marc, > > Marc Paré wrote (30-05-11 12:23) > > I am just working on the webpage for the release of 3.4 and on the > > release notes wiki page for LibO 3.4[1] it says: > > > > When the document is encrypted with a password, you can now change

Re: [Libreoffice] merge issues ...

2011-05-31 Thread Bjoern Michaelsen
Hi Kendy, On Tue, 31 May 2011 15:35:07 +0200 Jan Holesovsky wrote: > was pushed to both master and libreoffice-3-4, but the code removing > this line just to master. That correctly conflicted - and the person > doing the merge [me in this case - sorry for that] - picked the > version containing

[Libreoffice] smoke

2011-05-31 Thread Ben Engbers
After a new ./g pull -r I did make dev-install. 2 Hours later, I finally got the same errormsg as yesterday: internal build errors: ERROR: error 65280 occurred while making /home/bengbers/Src/LibreOffice/libo/smoketestoo_native it seems that the error is inside 'smoketestoo_native', please re

Re: [Libreoffice] [PATCH] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

2011-05-31 Thread Kohei Yoshida
Hi Albert, On Tue, 2011-05-31 at 01:38 +0200, Markus Mohrhard wrote: > Hello Albert, > > just two quick comments. > > We are trying to get away from using sal_Int16 for sheet numbers and > use SCTAB instead, so it would be nice if you could change this. > And I think we can't/shouldn't create a

Re: [Libreoffice] smoketest fail, N12_GLOBAL__N_14TestE::test

2011-05-31 Thread Bjoern Michaelsen
On Tue, 31 May 2011 08:22:46 +0200 Julien Nabet wrote: > in smoketestoo_native, I've got this : > > officeconnection.cxx:140:Assertion > Test name: N12_GLOBAL__N_14TestE::test > setUp() failed > - equality assertion failed > - Expected: 2 > - Actual : 0 That assert waits one second with the run

[Libreoffice] [PUSHED] __cdecl -> SAL_CALL (calc/components/ure/writer)

2011-05-31 Thread Michael Meeks
Hi Christina, On Tue, 2011-05-31 at 14:26 +0200, Chr. Rossmanith wrote: > more __cdecl->SAL_CALL work for reviewing. I'll push them if the changes > are fine. They look great to me - nice cleanups (I havn't pushed but added the header to save others time - perhaps REVIEW is better ?).

Re: [Libreoffice] smoke

2011-05-31 Thread Bjoern Michaelsen
On Tue, 31 May 2011 16:49:07 +0200 Ben Engbers wrote: > /home/bengbers/Src/LibreOffice/libo/smoketestoo_native source the *Env.Set.sh in the source root before issuing "build". The script sets up a alias. Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen _

[Libreoffice] libreoffice-3.4.0.2 merged into master

2011-05-31 Thread Jan Holesovsky
Hi all, On 2011-05-27 at 21:24 +0200, Jan Holesovsky wrote: > Next step: merge the current libreoffice-3-4 into master too. Now even this is finished - we can again merge libreoffice-3-4 to master regularly. Regards, Kendy ___ LibreOffice mailing lis

Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters

2011-05-31 Thread Joop Kiefte
Just check if the aren't some unicode characters you can dump into google translate... 2011/5/31 Michael Meeks : > > On Tue, 2011-05-31 at 18:23 +0700, Korrawit Pruegsanusak wrote: >> Maybe I'm late, but I confirm. > >        Thanks :-) helps speedup patch inclusion to have that each time, th

Re: [Libreoffice] merge issues ...

2011-05-31 Thread Jan Holesovsky
Hi Bjoern, On 2011-05-31 at 16:49 +0200, Bjoern Michaelsen wrote: > > was pushed to both master and libreoffice-3-4, but the code removing > > this line just to master. That correctly conflicted - and the person > > doing the merge [me in this case - sorry for that] - picked the > > version cont

Re: [Libreoffice] smoke

2011-05-31 Thread Clio
31.05.2011 10:49, Ben Engbers пишет: After a new ./g pull -r I did make dev-install. 2 Hours later, I finally got the same errormsg as yesterday: internal build errors: ERROR: error 65280 occurred while making /home/bengbers/Src/LibreOffice/libo/smoketestoo_native it se

Re: [Libreoffice] Postgresql SDBC source no longer in git repo ?

2011-05-31 Thread Jan Holesovsky
Hi Alex, On 2011-05-31 at 15:49 +0200, Alexander Thurgood wrote: > Any news on this ? It appears that the stuff was previously in > /connectivity/drivers, at least it was with 3.3.2, but now it is no > longer there - a victim of the branch off perhaps ? It seems it hasn't been ported from the 'b

Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters

2011-05-31 Thread Korrawit Pruegsanusak
Hello Joop, * On Tue, May 31, 2011 at 22:21, Joop Kiefte wrote: > Just check if the aren't some unicode characters you can dump > into google translate... > Thanks for your suggestion, but could you please elaborate on the steps to do this? Best Regards, -- Korrawit Pruegsanusak ___

Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters

2011-05-31 Thread Christian Lohmaier
Hi *, On Tue, May 31, 2011 at 5:21 PM, Joop Kiefte wrote: > Just check if the aren't some unicode characters you can dump > into google translate... They are no more - previously it was something different, but one commit did smash the string to real "?". It very likely was some eastern enc

Re: [Libreoffice] Postgresql SDBC source no longer in git repo ?

2011-05-31 Thread Alexander Thurgood
Le 31/05/11 17:42, Jan Holesovsky a écrit : Hi Kendy, > On 2011-05-31 at 15:49 +0200, Alexander Thurgood wrote: > >> Any news on this ? It appears that the stuff was previously in >> /connectivity/drivers, at least it was with 3.3.2, but now it is no >> longer there - a victim of the branch off

[Libreoffice] [ANNOUNCE] libreoffice-3.3.3.1 tag created (3.3.3-rc1)

2011-05-31 Thread Petr Mladek
Hi, there have been created the libreoffice-3.3.3.1 tag for 3.3.3-rc1 release. The corresponding official builds will be available by the end of the week. See the attached list of changes against 3.3.2-final. You might switch your current 3-3 source tree to it using: ./g fetch --tags ./g checko

Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters

2011-05-31 Thread Joop Kiefte
Ah okay :) so to get to know what it was, one would need to dive into the history. I suppose the best we can do for now is to leave a small note about this in the comments there, and only look it up in case it turns out essential. 2011/5/31 Christian Lohmaier : > Hi *, > > On Tue, May 31, 2011 at

[Libreoffice] [REVIEWED] use --nologo to prevent oosplash smoketest hangs

2011-05-31 Thread Michael Meeks
On Tue, 2011-05-31 at 15:08 +0200, Bjoern Michaelsen wrote: > please review this commit for 3.4 and 3.4.0. Pushed to -3-4, the -3-4-0 boat sailed a while back. Any chance you can review and cherry-pick the attached in return from master to -3-4 :-) Thanks, Michae

Re: [Libreoffice] build problems with cppunit

2011-05-31 Thread Michael Meeks
Hi Regina, On Mon, 2011-05-30 at 09:10 +0200, Regina Henschel wrote: > I have still problems building from tar source. Actual situation: > All modules folders are put into one root folder. That is odd; and/or annoying. If you want the best, most stable, and useful branch to hack on; I wou

Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters

2011-05-31 Thread Christian Lohmaier
Hi Joop, *, On Tue, May 31, 2011 at 6:05 PM, Joop Kiefte wrote: > Ah okay :) so to get to know what it was, As it is hwp filter, i.e. hangul word processor, my first guess is Korean - and indeed google translates the encoded result to something useful. /* 그라데이션이 존재해도, 비트맵파일이 존재하면, 이것이 우선이다. */

[Libreoffice] [REVIEW] fdo#34214: Fixed selection by arrow keys around merged cells

2011-05-31 Thread Kohei Yoshida
I would like to get the following commit http://cgit.freedesktop.org/libreoffice/calc/commit/?id=5d7c7c865913f70f41b6e760e984a48c4e95 cherry-picked to the -3-4 branch. I understand that this is not a small change, but I really don't want to leave the 3.4 branch without fixing fdo#34214. htt

Re: [Libreoffice] Encrypted password -- change?

2011-05-31 Thread Dennis E. Hamilton
I am thinking two (or three) different features are being confused with each other. In LibreOffice 3.4.0rc2 on Windows, there is no change password option on the Security tab. There is a "Change Password" button on the General tab. It doesn't seem to do anything. It is never not gray. See

[Libreoffice] [PUSHED 3-4] libs-core:d847e25271e04196fd99c3e112119cc4f85addcb remove erroneous FIXMEs when re-starting oosplash.bin

2011-05-31 Thread Bjoern Michaelsen
On Tue, 31 May 2011 17:05:21 +0100 Michael Meeks wrote: > Pushed to -3-4, the -3-4-0 boat sailed a while back. Any > chance you can review and cherry-pick the attached in return from > master to -3-4 :-) Done. Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen ___

Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters

2011-05-31 Thread Michael Meeks
On Tue, 2011-05-31 at 18:12 +0200, Christian Lohmaier wrote: > So I can offer to restore the original Korean text - but cannot > provide better translation than google does :-) Nice ! in this case I guess we have to accept automated translation. ATB, Michael. --

[Libreoffice] [PATCH] fix for fdo#37761: Keyboard navigation broken in tools - options

2011-05-31 Thread André Schnabel
Hi, we came across a minor accessability issue at the German discuss list. But the fix is so easy that even I could do it. It's just to remove one line that breaks the keyboard navigation in the options dialog and has no sense at all. Christoph Noack confirmed tha change for UX at bugzilla.

Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters

2011-05-31 Thread Korrawit Pruegsanusak
Hello all, On Tue, May 31, 2011 at 23:41, Michael Meeks wrote: >        Nice ! in this case I guess we have to accept automated translation. Except we have some contributors who know Korean. (not me, of course!) :-) Best Regards, -- Korrawit Pruegsanusak _

Re: [Libreoffice] build problems with cppunit

2011-05-31 Thread Regina Henschel
Hi Michael, Michael Meeks schrieb: Hi Regina, On Mon, 2011-05-30 at 09:10 +0200, Regina Henschel wrote: I have still problems building from tar source. Actual situation: All modules folders are put into one root folder. That is odd; and/or annoying. If you want the best, most stable,

[Libreoffice] [ANNOUNCE] Branch libreoffice-3-3-3 created

2011-05-31 Thread Petr Mladek
Hi all, there have been created the libreoffice-3-3-3 branch. It will be used for fine tuning of the 3.3.3 bugfix release. It is based on the the tag libreoffice-3.3.3.1 for 3.3.3-rc1 release. The following rules apply: + preferably just translation or blocker fixes + only cherry

Re: [Libreoffice] [ANNOUNCE] Branch libreoffice-3-3-3 created

2011-05-31 Thread Friedrich Strohmaier
Hi Petr, *, Petr Mladek schrieb: > there have been created the libreoffice-3-3-3 branch. It will be used [..] > next bugfix release (3.3.4). Please read more at > http://wiki.documentfoundation.org/ReleasePlan apparently something went wrong with 3.3.5 section: http://wiki.documentfound

Re: [Libreoffice] 8 combinations of Python support: do we really need that?

2011-05-31 Thread Tor Lillqvist
> Of course; and if that is what we want, to have just three clear > alternatives, then indeed I will go for it;) Done now and pushed. Just the --enable-python option left, with four potential arguments: no, auto, system, internal. The python scripting is now always enabled unless --enable-pyth

Re: [Libreoffice] Oracle Report Builder corrupting chart objects

2011-05-31 Thread Friedrich Strohmaier
Hi Alex, *, i try to make it as short as possible in order not to waste too much valuable developer time while reading. Superfluous to mention: I'm not a developer ;o)). Alexander Thurgood schrieb: > Le 17/05/11 04:14, Kohei Yoshida a écrit : [.. Oracle Report Builder crashes LibreOffice ..] >>

[Libreoffice] Build Dependencies

2011-05-31 Thread Nigel Hawkins
I've just upgraded my machine (Kubuntu 11.04 64bit) and had to re-get all the build dependencies. One thing I noticed is that doing: sudo apt-get build-dep libreoffice as suggested on the wiki pulls in (amongst other stuff) all of the mono libraries. Does the build really depend on these? Nige

Re: [Libreoffice] [REVIEWED] use --nologo to prevent oosplash smoketest hangs

2011-05-31 Thread Rene Engelhard
Hi, On Tue, May 31, 2011 at 05:05:21PM +0100, Michael Meeks wrote: > On Tue, 2011-05-31 at 15:08 +0200, Bjoern Michaelsen wrote: > > please review this commit for 3.4 and 3.4.0. > > Pushed to -3-4, the -3-4-0 boat sailed a while back. Any chance you can > review and cherry-pick the attached

[Libreoffice] Encrypted password -- NEW ENCRYPTION BUG!

2011-05-31 Thread Dennis E. Hamilton
There is a new problem around encryption (and, consequentially, protection) in LO 3.4.0rc2 on x86 Windows. This may be related to the non-operating "Change Password" feature. The problem is that encryption of documents won't turn off, so there is no way to save a decrypted document as unencryp

Re: [Libreoffice] [PUSHED] __cdecl -> SAL_CALL (calc/components/ure/writer)

2011-05-31 Thread Chr. Rossmanith
Hi, I was ready to push. But after "git pull -r" the build failed (though even "make check" succeeded before). Now I'm building again after "./g pull -r". And then I'll push tomorrow (hopefully). Christina Am 31.05.2011 17:13, schrieb Michael Meeks: Hi Christina, On Tue, 2011-05-31 at 14:2

Re: [Libreoffice] 8 combinations of Python support: do we really need that?

2011-05-31 Thread Michael Meeks
On Tue, 2011-05-31 at 13:11 -0600, Tor Lillqvist wrote: > Done now and pushed. > The python scripting is now always enabled > unless --enable-python=no. Ditto for the Python UNO API. Looks lovely. > Seems to work as intended, but sure, I might have missed some corner case. Thank

[Libreoffice] [GSOC] Some change I made in your feature branch

2011-05-31 Thread Kohei Yoshida
Hi Anurag, So, here is the change I made in the feature/calc-multiline-input branch: http://cgit.freedesktop.org/libreoffice/libs-core/commit/?h=feature/calc-multiline-input&id=844d09c4cf6d08bb58e1b37a5ee7335320880654 http://cgit.freedesktop.org/libreoffice/calc/commit/?h=feature/calc-multiline-i

Re: [Libreoffice] Platform-specific DLL suffix usefulness

2011-05-31 Thread Francois Tigeot
On Tue, May 31, 2011 at 04:05:16PM +0200, Bjoern Michaelsen wrote: > On Tue, 31 May 2011 08:10:13 +0200 > Francois Tigeot wrote: > > > It was my understanding the UNO libraries didn't use DLLPOSTFIX but > > now you're making me doubt. > > Is there a canonical list of them I could check ? > > As

Re: [Libreoffice] [REVIEW][Pushed-3-4] fdo#34214: Fixed selection by arrow keys around merged cells

2011-05-31 Thread Markus Mohrhard
You have my sign-off. Pushed to 3-4. 2011/5/31 Kohei Yoshida > I would like to get the following commit > > > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=5d7c7c865913f70f41b6e760e984a48c4e95 > > cherry-picked to the -3-4 branch. I understand that this is not a small > change, bu

Re: [Libreoffice] [PATCH] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

2011-05-31 Thread Kohei Yoshida
Hi Albert, On Tue, 2011-05-31 at 00:10 +0200, Albert Thuswaldner wrote: > Hi all, > Submitting a patch for Bug 33293 for review. Please let me know if > you want me to improve some parts of it. So, I did test your patch on the master branch. I have some feedback. First off, I'm pretty sure you

[Libreoffice] OneGit migration. Review needed of clean_spaces tool

2011-05-31 Thread Norbert Thiebaud
Taking advantage of the OneGit migration process, we are going to clean-up tabs and spaces in the whole history (hence keeping git-blame useful) In order to do that, the repository are going through a git filter-branch process, typically something like git filter-branch --prune-empty --tag-name-f

Re: [Libreoffice] [PATCH] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

2011-05-31 Thread Kohei Yoshida
On Tue, 2011-05-31 at 22:29 -0400, Kohei Yoshida wrote: > in ScTabViewShell::Construct(), which I find a bit awkward as the doc > options and the app options (presumably for the VBA API) fight each > other in a bit weird way. I would like to have this cleaned up a bit, > but we can do this cleanup

[Libreoffice] Patch for Bug 34786: [EasyHack]Editing: Sentence movement function broken

2011-05-31 Thread jeffrey chang
Hi, I am new to the LibreOffice community. I know that 34786 has been posted for awhile, but no one seems to have claimed the bug and the error was still reproducible in writer so I decided to take up the bug as my first EasyHack. I seemed to have fixed the problem of deleting to the beginning of

Re: [Libreoffice] Patch for Bug 34786: [EasyHack]Editing: Sentence movement function broken

2011-05-31 Thread jeffrey chang
Sorry here is the patch. On Wed, Jun 1, 2011 at 1:18 PM, jeffrey chang wrote: > Hi, > > I am new to the LibreOffice community. I know that 34786 has been posted > for awhile, but no one seems to have claimed the bug and the error was still > reproducible in writer so I decided to take up the bug

[Libreoffice] gdk-pixbuf compile error

2011-05-31 Thread Joseph Powers
I'm guessing that its failing on more then just Mac OS. I found a patch at http://old.nabble.com/build-problems-with-libpng-1.5.1beta01-td30662957.html that seams to work. I'm not sure how to include it in our build system so I'm attaching including it here. It doesn't apply cleanly so I had to

[Libreoffice] [PATCH] Unify DLLPOSTFIX values

2011-05-31 Thread Francois Tigeot
Hi, The attached patch gets rid of many definitions of DLLPOSTFIX. With this change, shared library file names will be the same on all platforms. -- Francois Tigeot >From dd00beebf1abf8f4a1c04169b99dc97adc2aee2d Mon Sep 17 00:00:00 2001 From: Francois Tigeot Date: Wed, 1 Jun 2011 08:40:48 +0200