[Libreoffice] [PATCH] Remove unused code

2012-01-30 Thread Elton Chung
--- sc/inc/scdll.hxx |1 - sc/source/core/inc/ddelink.hxx|1 - sc/source/core/tool/ddelink.cxx | 11 - sc/source/ui/app/scdll.cxx| 10 sc/source/ui/dbgui/fieldwnd.cxx |5 sc/source/ui/inc/areasave.hxx

Re: [Libreoffice] Duplicate branches for if and else in store/source/storlckb.cxx

2012-01-30 Thread Stephan Bergmann
On 01/30/2012 10:35 PM, julien2412 wrote: Cppchecks reports this : core/store/source/storlckb.cxx 74 duplicateBranch style Found duplicate branches for if and else. Here are the lines : 67 OStoreLockBytes::~OStoreLockBytes (void) 68 { 69 if (m_xManager.is()) 70

Re: [Libreoffice] Storage of user's configuration

2012-01-30 Thread Stephan Bergmann
On 01/24/2012 09:38 PM, Stephan Bergmann wrote: One thing that's already there, though, is that if you can indeed go with a single string-list property (lets assume you add it as org.openoffice.Office.Common/Misc/FilePickerBookmarks), you can #include "officecfg/Office/Common.hxx" and read the

Re: [Libreoffice] [REVIEW] [3.5.0] Some simple polish for named ranges dialogue

2012-01-30 Thread Stefan Knorr (Astron)
Hi Petr, > There was still not enough space for German strings in the "Define name" > dialog, see the attached screenshots. So, I have increased it a bit > more, see > http://cgit.freedesktop.org/libreoffice/core/commit/?id=5be59017ca21301e70eca987e8323c92215f0ed4 Oh, sorry. Thanks for fixing thi

Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] [PUSHED] fdo#45285 - Use more revealing error message for not allowed sheet names

2012-01-30 Thread Stefan Knorr (Astron)
Hi Albert, >> Albert, could you please confirm that you submitted your patch under >> LGPL3+/MPL? (If you plan on doing more patches, please consider just >> writing a blanket mail saying that you want to always commit under >> these licenses and then add yourself to [1].) > > Done. Thank you ver

Re: [Libreoffice] [PATCH] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

2012-01-30 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Regina It has been decades since I handled groups, rings, fields, and functions in my french lycée. Now I am confused because it looks like the two terms are swapped between french and english... Regards Olivier In french: http://fr.wikipedia.or

Re: [Libreoffice] R: Fatal error building Windows release - ( Cygwin )

2012-01-30 Thread Jan Holesovsky
Hi Walter, walter píše v Po 30. 01. 2012 v 12:24 +0100: > $ git show > commit 9abb0b6bbe2de65988065f78354ccf5ebde4a7ae > > Error Log (last lines) > pastebin.com/u/walterLO The log looks like your build got terribly confused somehow - missing sal/config.h etc.; I'd do 'make clean', and build fro

[Libreoffice] [REVIEW] partial patch for fdo#44551 libvisio: arrow head shapes not imported properly

2012-01-30 Thread Bruno Girin
Hi all, Please find attached a partial patch to import line marker shapes from Visio files. I would appreciate a review to confirm whether I am on the right path or whether I should do something different. Thanks, Bruno >From cf68600551d3a1d88c7daaa9f2dc8f09afdb7481 Mon Sep 17 00:00:00 2001

[Libreoffice] [PATCH] contour handling for anchored draw objects in writer (fix for bugs 34611 and 45376)

2012-01-30 Thread Andreas Schierl
Hi, I found out that bugs https://bugs.freedesktop.org/show_bug.cgi?id=34611 https://bugs.freedesktop.org/show_bug.cgi?id=45376 are caused by a missing call to ClrContourCache( pObj ); in /sw/source/core/layout/pagechg.cxx: void lcl_MoveAllLowerObjs( SwFrm* pFrm, const Point& rOffset )

Re: [Libreoffice] [PATCH] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

2012-01-30 Thread Regina Henschel
Hi Oliver, Olivier Hallot schrieb: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Please find the patch attached. The term "inverse" is not correct in this context. It should be "reciprocal" instead. Example: The inverse of SIN is ASIN. The reciprocal of SIN is CSC. Kind regards Regin

Re: [Libreoffice] [REVIEW] fdo#43965 fix RTF import of page break symbol

2012-01-30 Thread Miklos Vajna
Hi Michael, On Mon, Jan 30, 2012 at 10:07:50PM +0100, Michael Stahl wrote: > > See > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=2aa3d43a3746c797391afb1a08c024d512976006 > > seems that with this change not only the new LN_PFPageBreakBefore from > \page is reset when a \par occurs,

Re: [Libreoffice] [PATCH] Additional translations of German comments in libs-core/sfx2/source/

2012-01-30 Thread Albert Thuswaldner
Hi Michael, >        Gosh; did this get sorted out in the end ? :-) do you have code that is > not committed to master ? > Sorry for the late reply on this. I have check these patches against the git log. It is all committed to master. Thanks for asking. /Albert

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 45255, which changed state. Bug 45255 Summary: FILEOPEN .doc comments are missing https://bugs.freedesktop.org/show_bug.cgi?id=45255 What|Old Value |New Value

Re: [Libreoffice] [PUSHED] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

2012-01-30 Thread Andras Timar
Hi Olivier, 2012/1/30 Olivier Hallot : > Please find the patch attached. > Thanks for the patch. It builds well and Help displays the text well. Pushed. Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/

[Libreoffice] [PUSHED] Re: [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

2012-01-30 Thread Michael Stahl
On 30/01/12 15:43, Lionel Elie Mamane wrote: > I attach here the "less invasive" variant originally meant for > libreoffice-3-5. > > However, if people are happy with cherry-picking the (more invasive) > master commit, by all means, cherry-pick it. This would have the > advantage of not "forking"

[Libreoffice] [PUSHED^2] Re: [REVIEWED] Fix reading .doc comments (fdo#45255)

2012-01-30 Thread Michael Stahl
On 30/01/12 21:19, Caolán McNamara wrote: > On Mon, 2012-01-30 at 19:52 +, Michael Meeks wrote: >> Looks lovely to me; pushed to -3-5, Caolan are you happy for 3.5.0 ? we >> had busted comment interop with .docx in 3.4 (so people used .doc) :-) > > Yeah, makes sense to me. +1 > > C. doe

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-01-30 Thread Michael Stahl
On 30/01/12 18:16, Cedric Bosdonnat wrote: > Fixed in > http://cgit.freedesktop.org/libreoffice/core/commit/?id=458d56d9b35f2ecb2eea2589737079390b10ee26 looking better... > Would be nice to cherry-pick these two commits to -3-5, -3-4 and 3-5-0 > (if it's not too late). pushed to libreoffice-3-

[Libreoffice] Duplicate branches for if and else in store/source/storlckb.cxx

2012-01-30 Thread julien2412
Hello, Cppchecks reports this : core/store/source/storlckb.cxx 74 duplicateBranch style Found duplicate branches for if and else. Here are the lines : 67 OStoreLockBytes::~OStoreLockBytes (void) 68 { 69 if (m_xManager.is()) 70 { 71 if (m_xNode.is()

[Libreoffice] [REVIEW][3-5] Prevent excessvie references to formula result tokens

2012-01-30 Thread Kohei Yoshida
Hi, I'd like http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2b11f4fd79dce4116badb0ecf6477546ca5d0d4 cherry-picked to the 3-5 branch. It is probably too late for change like this to be in the 3-5-0 branch so I won't even try. To reproduce the problem, open the following file in Calc

Re: [Libreoffice] [REVIEW] fdo#43965 fix RTF import of page break symbol

2012-01-30 Thread Michael Stahl
On 30/01/12 21:44, Miklos Vajna wrote: > Hi, > > See > http://cgit.freedesktop.org/libreoffice/core/commit/?id=2aa3d43a3746c797391afb1a08c024d512976006 > > Could somebody sign-off and push to -3-5, please? (Technically this is a > new feature in the tokenizer but it's a regression from LO-3.4, so

[Libreoffice] [REVIEW] fdo#43965 fix RTF import of page break symbol

2012-01-30 Thread Miklos Vajna
Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=2aa3d43a3746c797391afb1a08c024d512976006 Could somebody sign-off and push to -3-5, please? (Technically this is a new feature in the tokenizer but it's a regression from LO-3.4, so I do not request this to be in -3-5-0.) Thanks, Mi

Re: [Libreoffice] Same expression on both sides of '||' in svtools/source/filter/sgvtext.cxx

2012-01-30 Thread julien2412
Commited and pushed on master (commit 10bfc4df5335c6cd2ae700df7485668d896998b5) Thank you Eike ! Julien. PS : if it could be useful to push this on 3.5, just tell me :-) -- View this message in context: http://nabble.documentfoundation.org/Same-expression-on-both-sides-of-in-svtools-source-filte

[Libreoffice] [#fdo37740. REMARK]

2012-01-30 Thread ape
Hi, I have read a "0001-fdo-37740-remove-duplicate-icons-from-soffice.bin-so.patch". It is technically the correct solution, but it is not optimal solution. A. "soffice.bin" file contains all the icons. Windows Explorer takes it from there. Icons of this file (LibO-3.5.0rc1 and earlier) were used

Re: [Libreoffice] [REVIEWED] Fix reading .doc comments (fdo#45255)

2012-01-30 Thread Caolán McNamara
On Mon, 2012-01-30 at 19:52 +, Michael Meeks wrote: > Looks lovely to me; pushed to -3-5, Caolan are you happy for 3.5.0 ? we > had busted comment interop with .docx in 3.4 (so people used .doc) :-) Yeah, makes sense to me. +1 C. ___ LibreOff

Re: [Libreoffice] [PUSHED] Re: Duplicate expression in vcl/win/source/app/salinst.cxx

2012-01-30 Thread julien2412
Commited and pushed this version : bool WinSalInstance::CheckYieldMutex() { SalData*pSalData = GetSalData(); if ( pSalData->mpFirstInstance ) { SalYieldMutex* pYieldMutex = pSalData->mpFirstInstance->mpSalYieldMutex; return (pYieldMutex->mnThreadId == (GetCurrentThre

Re: [Libreoffice] Same expression on both sides of '||' in svtools/source/filter/sgvtext.cxx

2012-01-30 Thread Eike Rathke
Hi julien2412, On Monday, 2012-01-30 11:24:18 -0800, julien2412 wrote: > 139 #define EscSet'' /* Flag setzen > > */ > > Now why EscSet = EscReset = EscToggl ? > I took a look at the git history and found the commit > 9e5584a82633442467a53cc

[Libreoffice] [REVIEWED] Fix reading .doc comments (fdo#45255)

2012-01-30 Thread Michael Meeks
On Mon, 2012-01-30 at 19:22 +0100, Lubos Lunak wrote: > The regression is caused by commit 8434a6966914547451489db6828b31ae86901186, > which added size checks, but incorrectly - remainingSize() is called before > the seek to the right position is done, which occassionally makes the code > belie

Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] [PUSHED] fdo#45285 - Use more revealing error message for not allowed sheet names

2012-01-30 Thread Markus Mohrhard
Hello Albert, > > Thanks for taking care of this (and yes "may" instead of "can" sounds better). > > Just a thought: should we push this to the 3.5 branch? This is a small > polish of the user experience and it might be > good to have it in a release soon, instead of waiting for 3.6. Also > the bu

Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] [PUSHED] fdo#45285 - Use more revealing error message for not allowed sheet names

2012-01-30 Thread Albert Thuswaldner
Hi, On Mon, Jan 30, 2012 at 10:07, Stefan Knorr (Astron) wrote: > Hi Albert, Korrawit, Ivan, > > the idea sounds good, ... patch is simple, and the details seem to be > correct now. Thus, I've taken the liberty to replace "can" by "may" > and then push to master. > http://cgit.freedesktop.org/lib

Re: [Libreoffice] [PUSHED] Re: Duplicate expression in vcl/win/source/app/salinst.cxx

2012-01-30 Thread Michael Meeks
On Mon, 2012-01-30 at 10:03 -0800, julien2412 wrote: > I wonder if we could more simplify like this : Looks nicer to me :-) whatever is most readable and pleasant with two return paths in the function we could drop the 'bool bRet' as well and gain a vertical line :-) All the best

[Libreoffice] Same expression on both sides of '||' in svtools/source/filter/sgvtext.cxx

2012-01-30 Thread julien2412
Hello, Here is a report of cppcheck : core/svtools/source/filter/sgvtext.cxx 365 duplicateExpression style Same expression on both sides of '||'. Here is the line : if (c==EscSet || c==EscReset || c==EscDeflt || c==EscToggl) FlgVal=c; else {<--- Same expression on both sides

Re: [Libreoffice] [PUSHED 3-5-0 3-5][REVIEW][3-5-0][3-5] Remove debug statement.

2012-01-30 Thread Eike Rathke
Hi, On Monday, 2012-01-30 19:22:38 +0100, Markus Mohrhard wrote: > 2012/1/30 Andras Timar : > > 2012/1/30 Kohei Yoshida : > >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f2bf6d863a25475f27e2b0d37f8c36aec74d6d4 > >> > >> This is simple enough that we can safely put this into 3.5.0. >

[Libreoffice] development summary: year 2012, week 04

2012-01-30 Thread Petr Mladek
Hi, this time a brief summary of what happened during the 4th week in 2012 on LibreOffice repositories and the living branches: + master:LO-3.5 development + libreoffice-3-5: fixes for LO-3.5.1 bug fix release + libreoffice-3-5-0: final stabilization of the L

[Libreoffice] development summary: year 2012, week 03

2012-01-30 Thread Petr Mladek
Hi, this time a brief summary of what happened during the 3rd week in 2012 on LibreOffice repositories and the living branches: + master:LO-3.5 development + libreoffice-3-5: fixes for LO-3.5.0 release + libreoffice-3-4: fixes for potential LO-3.4.6 bug fix

Re: [Libreoffice] Possibility to turn off 'Insert new sheet' tab in LO Calc

2012-01-30 Thread Arnolf Best
Michael Meeks-2 wrote > > Hi Michael, > >> Since this is not a list for reporting feature requests, I assume you >> would like some code pointers to how to implement the setting ? > > No. In my opinion, this ought to be done by the inventor of the 'insert > new sheet' tab. > > I was just

Re: [Libreoffice] [REVIEW][3-5-0][3-5] Remove debug statement.

2012-01-30 Thread Markus Mohrhard
2012/1/30 Andras Timar : > 2012/1/30 Kohei Yoshida : >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f2bf6d863a25475f27e2b0d37f8c36aec74d6d4 >> >> This is simple enough that we can safely put this into 3.5.0. > > +1, pushed to libreoffice-3-5 > Looks good to me. One more needed for 3-5

[Libreoffice] [REVIEW] Fix reading .doc comments (fdo#45255)

2012-01-30 Thread Lubos Lunak
The regression is caused by commit 8434a6966914547451489db6828b31ae86901186, which added size checks, but incorrectly - remainingSize() is called before the seek to the right position is done, which occassionally makes the code believe the file is corrupt. I don't actually know the format en

Re: [Libreoffice] [REVIEW][3-5-0][3-5] Remove debug statement.

2012-01-30 Thread Andras Timar
2012/1/30 Kohei Yoshida : > http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f2bf6d863a25475f27e2b0d37f8c36aec74d6d4 > > This is simple enough that we can safely put this into 3.5.0. +1, pushed to libreoffice-3-5 Andras ___ LibreOffice mailing l

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Honor pre-selected filter type

2012-01-30 Thread Eike Rathke
Hi Kohei, On Friday, 2012-01-27 17:08:14 -0500, Kohei Yoshida wrote: > I'd like to have the attached patch pushed to the 3-5 branch and > preferably to the 3-5-0 branch as well. > > It fixes > > https://bugs.freedesktop.org/show_bug.cgi?id=45084 It seems to fix the symptom and the document is

[Libreoffice] [PUSHED] Re: Duplicate expression in vcl/win/source/app/salinst.cxx

2012-01-30 Thread julien2412
Commited and pushed on master. Now it's : bool WinSalInstance::CheckYieldMutex() { bool bRet = true; SalData*pSalData = GetSalData(); DWORD nCurThreadId = GetCurrentThreadId(); if ( pSalData->mpFirstInstance ) { SalYieldMutex* pYieldMutex = pSalData->mpFirstIn

Re: [Libreoffice] [PATCH] cygwin is $build_os, not $_os & voreppe needs love

2012-01-30 Thread Norbert Thiebaud
On Mon, Jan 30, 2012 at 11:05 AM, Korrawit Pruegsanusak wrote: > Hello Norbert, all, > > As compiling --with-mozilla-build on msvc/cygwin, it also needs msvc > 2005 runtime library in 'instsetoo_native'. > But a check in configure.in might be incorrect, so patch attached & > review appreciated. :-

[Libreoffice] [REVIEW][3-5-0][3-5] Remove debug statement.

2012-01-30 Thread Kohei Yoshida
Hi there, http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f2bf6d863a25475f27e2b0d37f8c36aec74d6d4 This is simple enough that we can safely put this into 3.5.0. Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailin

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-01-30 Thread Cedric Bosdonnat
Hi Michael, On Thu, 2012-01-26 at 19:35 +0100, Michael Stahl wrote: > On 26/01/12 19:30, Michael Stahl wrote: > > On 26/01/12 16:21, Cedric Bosdonnat wrote: > >> Hi all, > >> > >> Could someone review and cherry-pick this commit to -3-5, -3-5-0 and > >> -3-4? > >> http://cgit.freedesktop.org/libre

Re: [Libreoffice] [FIXED] add include directory for ldap.h, fix msvc build

2012-01-30 Thread Korrawit Pruegsanusak
Hello Fridrich, On Mon, Jan 30, 2012 at 20:52, Fridrich Strba wrote: > The patch is good-ish, nevertheless, the place to fix it is actually in the > makefile.mk where one just extends for the purpose of that BUILD_ACTION the > SOLARINC variable adding this directory. > > I fixed it now in master

Re: [Libreoffice] [PUSHED] use SAL_CALL to fix build in msvc

2012-01-30 Thread Korrawit Pruegsanusak
Hello Michael, On Mon, Jan 30, 2012 at 18:42, Michael Meeks wrote: >        Lovely :-) looks obviously correct, pushed it. Thanks :-) >> But the build isn't success yet: still has problem in 'test', which I >> can't figure out. > >        Any more details, is it a failing test or a build issue

Re: [Libreoffice] [PATCH] follow-up of fdo#30788: fix showing of unnecessary empty horizontal scrollbar

2012-01-30 Thread Caolán McNamara
On Sun, 2012-01-29 at 15:01 +0400, Ivan Timofeev wrote: > what is the reason to have this flag? Why only set this flag without > actually showing? And why not change this flag accordingly when actually > showing? (This is what the patch fixes.) Digging into the git history it looks like a collec

[Libreoffice] [PATCH] cygwin is $build_os, not $_os & voreppe needs love

2012-01-30 Thread Korrawit Pruegsanusak
Hello Norbert, all, As compiling --with-mozilla-build on msvc/cygwin, it also needs msvc 2005 runtime library in 'instsetoo_native'. But a check in configure.in might be incorrect, so patch attached & review appreciated. :-) If this patch is pushed, the voreppe tinderbox also needs some love :-)

Re: [Libreoffice] [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

2012-01-30 Thread Lionel Elie Mamane
On Mon, Jan 30, 2012 at 04:55:51PM +0100, Stephan Bergmann wrote: > On 01/30/2012 03:43 PM, Lionel Elie Mamane wrote: >> I attach here the "less invasive" variant originally meant for >> libreoffice-3-5. > My SQL knowledge is actually zero. For example, I have no idea > where to look to verify t

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Honor pre-selected filter type

2012-01-30 Thread Eike Rathke
Hi Caolán, On Monday, 2012-01-30 12:58:29 +, Caolán McNamara wrote: > > https://bugs.freedesktop.org/show_bug.cgi?id=45084 > > With > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=611472edb12ba1d8a38bda1857c952eef0bb3568 > already in place in 3-5-0 to sort the

Re: [Libreoffice] [REVIEW 3-5-0][PUSHED] Updated License document

2012-01-30 Thread Stephan Bergmann
On 01/30/2012 04:32 PM, Petr Mladek wrote: One more approval needed for 3-5-0. Approved and pushed. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

2012-01-30 Thread Stephan Bergmann
On 01/30/2012 03:43 PM, Lionel Elie Mamane wrote: I attach here the "less invasive" variant originally meant for libreoffice-3-5. My SQL knowledge is actually zero. For example, I have no idea where to look to verify that for some SQL_ATTR_CURSOR_TYPE, say, SQLGetStmtAttr expects to find a b

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on||45401 --- Comment #156 from Rainer Bi

Re: [Libreoffice] [REVIEW 3-5-0] Updated License document

2012-01-30 Thread Petr Mladek
Andras Timar píše v Čt 26. 01. 2012 v 13:27 +0100: > Hi, > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2961f3fff10ea1254a082ad6d0a72bff740d66e > I updated LICENSE.odt and generated THIRDPARTYLICENSEREADME.html and > license.txt from it. Unfortunately the diff is not clean, I could n

Re: [Libreoffice] [Libreoffice-qa] [ANN] LibreOffice 3.5.0 RC2 available

2012-01-30 Thread Rainer Bielefeld
Hi, Concerning the Virus Kazy.7720 Problem: Can you all please contact support of your Antivirus Program supplier so that they can check and rework their filters? So we can save much trouble with false alarms normal users would see when they install 3.5.0 before anti virus filters are updated

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Honor pre-selected filter type

2012-01-30 Thread Kohei Yoshida
Hi Caolan, On Mon, 2012-01-30 at 12:58 +, Caolán McNamara wrote: > With > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=611472edb12ba1d8a38bda1857c952eef0bb3568 > already in place in 3-5-0 to sort the writer detection to the end of the > list does it work "out-

Re: [Libreoffice] [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

2012-01-30 Thread Lionel Elie Mamane
On Mon, Jan 30, 2012 at 02:08:54PM +, Michael Meeks wrote: > On Mon, 2012-01-30 at 12:40 +0100, Stephan Bergmann wrote: >> The attached >> 0001-fdo-44025-repair-dbaccess-ORowSetCache-isLast-after-.patch >> appears to be completely unrelated? > True :-) Yes, I used an older email as a

[Libreoffice] [PATCH] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

2012-01-30 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Please find the patch attached. Best regards Olivier Em 30-01-2012 05:56, Jan Holesovsky escreveu: > Hi Olivier, > > Olivier Hallot píše v Pá 27. 01. 2012 v 12:14 -0200: > >> How can I write a help file to fix >> >> https://bugs.freedesktop.o

Re: [Libreoffice] [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

2012-01-30 Thread Michael Meeks
On Mon, 2012-01-30 at 12:40 +0100, Stephan Bergmann wrote: > The attached > 0001-fdo-44025-repair-dbaccess-ORowSetCache-isLast-after-.patch appears > to be completely unrelated? True :-) I suspect the patch intended is attached; the patch it refers to is already merged. This has my ack

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

2012-01-30 Thread Noel Power
On 30/01/12 13:14, Noel Power wrote: Albert On 30/01/12 13:07, Noel Power wrote: Hi I pushed it to master, it's a nice patch incase you look for your patch, well I thought I committed it but only noticed now there is a conflict message, will fix after some food hopefully I didn't screw it up (

[Libreoffice] [REVIEWED][PUSHED][3-*] Writer table border bugs fdo#38542 etc.

2012-01-30 Thread Caolán McNamara
On Mon, 2012-01-30 at 11:58 +, Michael Meeks wrote: > One more required for 3.5.0 I guess ? Pushed to 3-5-0 now. So everything is into was it was requested to go into now I believe. C. ___ LibreOffice mailing list LibreOffice@lists.freedeskto

[Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

2012-01-30 Thread Noel Grandin
Hi Attached patch converts SdCustomShow to use std::vector. Code is contributed under MPL+/LGPL+/GPL+ Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html diff --git a/sd/inc/cusshow.hxx b/sd/inc/cusshow.hxx index 1f981e9..1bd3614 100644 --- a/sd/inc/cusshow.hxx +++ b/sd/

Re: [Libreoffice] [FIXED] add include directory for ldap.h, fix msvc build

2012-01-30 Thread Fridrich Strba
On 30/01/12 13:33, Korrawit Pruegsanusak wrote: So, if I understand correctly, my patch is somehow correct, right? (Sorry if I don't) The patch is good-ish, nevertheless, the place to fix it is actually in the makefile.mk where one just extends for the purpose of that BUILD_ACTION the SOLARIN

Re: [Libreoffice] [REVIEWED][PUSHED][3-5-0] Writer table border bugs fdo#38542 etc.

2012-01-30 Thread Petr Mladek
Noel Power píše v Po 30. 01. 2012 v 11:39 +: > On 27/01/12 23:06, Michael Stahl wrote: > > these commits fix ODF import bugs described in fdo#38542 (regressions > > from LO 3.3) and were already backported to libreoffice-3-5 by Cedric; > > they want to be in libreoffice-3-5-0 and libreoffice-3-

Re: [Libreoffice] PDF converter cross compilation general questions

2012-01-30 Thread Michael Meeks
Hi there, On Mon, 2012-01-30 at 14:56 +0200, andrzej.pacanow...@tieto.com wrote: > > Well - it remains to be seen :-) quite probably our Android work will > > end up giving us a nice backend to render documents incrementally to > > pixels, without having the native UI - at least, as a first cu

Re: [Libreoffice] [REVIEWED][PUSHED][3-5-0] Writer table border bugs fdo#38542 etc.

2012-01-30 Thread Petr Mladek
Michael Meeks píše v Po 30. 01. 2012 v 12:02 +: > On Mon, 2012-01-30 at 11:39 +, Noel Power wrote: > > > the following 2 commits fix problems in the dialog that are regressions > > > from LO 3.3, and want backporting to libreoffice-3-5, libreoffice-3-5-0, > > > and libreoffice-3-4: > > > >

[Libreoffice] [PUSHED][PATCH] Bug 44981 - EasyHack: remove obsolete SWAPLONG macros

2012-01-30 Thread Caolán McNamara
On Mon, 2012-01-30 at 13:43 +0200, Noel Grandin wrote: > Hi > > Bug 44981 - EasyHack: remove obsolete SWAPLONG macros > This patch converts uses of the SWAPSHORT and SWAPLONG macros to > OSL_SWAPWORD and OSL_SWAPDWORD Looks sane to me anyway, pushed now. Thanks for this. C. ___

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

2012-01-30 Thread Noel Power
Albert On 30/01/12 13:07, Noel Power wrote: Hi I pushed it to master, it's a nice patch incase you look for your patch, well I thought I committed it but only noticed now there is a conflict message, will fix after some food ___ LibreOffice mailing li

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 sasha.libreoff...@gmail.com changed: What|Removed |Added Depends on||39903 -- Configure bugmail

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #155 from sasha.libreoff...@gmail.com 2012-01-30 05:11:55 PST --- regression since 3.3.4: Bug 39903 - FORMATTING: Table number format not retained -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You

Re: [Libreoffice] LibreOffice / openIndiana ...

2012-01-30 Thread Stephan Bergmann
On 01/27/2012 05:09 PM, Jonathan Adams wrote: I managed to hack together a "solaris.mk" file (by copying unxgcc.mk and making a few "SUN" changes) and that got me a little further ... Are we talking new build system solenv/gbuild/platform/{solaris,unxgcc}.mk (where a solaris.mk already exists

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

2012-01-30 Thread Noel Power
On 27/01/12 23:50, Albert Thuswaldner wrote: Hi, Shows a number of likely candidates; connecting to the 'ModifyHdl' and running the validator on the name, removing characters if it not valid might work; but of course. git grep SetModifyHdl for some instances of that; p

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Honor pre-selected filter type

2012-01-30 Thread Caolán McNamara
On Fri, 2012-01-27 at 17:08 -0500, Kohei Yoshida wrote: > Hi there, > > I'd like to have the attached patch pushed to the 3-5 branch and > preferably to the 3-5-0 branch as well. > > It fixes > > https://bugs.freedesktop.org/show_bug.cgi?id=45084 With http://cgit.freedesktop.org/libreoffice/co

Re: [Libreoffice] LibreOffice / openIndiana ...

2012-01-30 Thread Michael Meeks
Hi there, On Fri, 2012-01-27 at 16:09 +, Jonathan Adams wrote: > I managed to hack together a "solaris.mk" file (by copying unxgcc.mk > and making a few "SUN" changes) and that got me a little further ... > then on compiling nss Great - if you send a 'git diff' as an attachment we can

Re: [Libreoffice] PDF converter cross compilation general questions

2012-01-30 Thread Andrzej.Pacanowski
Hi, Michael > Well - it remains to be seen :-) quite probably our Android work will > end up giving us a nice backend to render documents incrementally to > pixels, without having the native UI - at least, as a first cut. Is this work available somewhere in repo ? It would be nice to look at

Re: [Libreoffice] Possibility to turn off 'Insert new sheet' tab in LO Calc

2012-01-30 Thread Michael Meeks
Hi Arnolf, On Sat, 2012-01-28 at 09:03 -0800, Arnolf Best wrote: > I am creating an application using the LibreOffice Calc . Users of the > application should select from a couple of sheets. Sounds fun. > Unfortunately, in LibreOffice Calc new sheets can be added unintentionally > very

Re: [Libreoffice] [Libreoffice-qa] [ANN] LibreOffice 3.5.0 RC2 available

2012-01-30 Thread Michael Meeks
On Mon, 2012-01-30 at 09:57 +, LL wrote: > Same problem here Kazy.7720 on windows 7, Avira Antivir Professional We're checking it in some detail; but I strongly suspect this is just yet-another false positive caused by some co-incidence around the icon re-work. Possibly we'll get a sl

[Libreoffice] [REVIEWED: 3-5-0] fix configuration migration on Linux

2012-01-30 Thread Michael Meeks
On Mon, 2012-01-30 at 12:10 +0100, Stephan Bergmann wrote: > Patch looks OK to me for inclusion in -3-5-0. One more review needed. And fine with me; pushed. Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot _

Re: [Libreoffice] PDF converter cross compilation general questions

2012-01-30 Thread Michael Meeks
Hi Andrzej, On Mon, 2012-01-30 at 13:31 +0200, andrzej.pacanow...@tieto.com wrote: > We need to display documents on custom display (no X11) arm linux. > Easiest way is to utilize existing PDF reader and just convert them > with LO. Am I wrong? Well - it remains to be seen :-) quite proba

[Libreoffice] License statement

2012-01-30 Thread Albert Thuswaldner
Hi, All my current and past contributions made to the LibreOffice project are done under MPL1.1+ / GPLv3+ / LGPLv3+. Until further notice, all my future contributions to the LibreOffice project are available under MPL1.1+ / GPLv3+ / LGPLv3+. Best Regards, Albert Thuswaldner _

[Libreoffice] [REVIEWED 3-5-0]

2012-01-30 Thread Michael Meeks
On Mon, 2012-01-30 at 11:44 +, Noel Power wrote: > presuming you know your window ;-) pushed to 3.5, acks still needed fo 3-5-0 And ack'ed by me, and pushed to -3-5-0. We don't want more repeats of the creation of the original bug here, obviously. Thanks ! :-)

Re: [Libreoffice] [PATCH] add include directory for ldap.h, fix msvc build

2012-01-30 Thread Korrawit Pruegsanusak
Hello Tor, Fridrich, On Sun, Jan 29, 2012 at 02:19, Fridrich Strba wrote: > It can use the native Windows API, yes. I ported it to use the mozilla stuff > especially so that the Linux build doesn't need to rely on openldap and I > set it for Windows too not to have many different code paths. Tha

Re: [Libreoffice] [REVIEW][3-5-0] Writer table border bugs fdo#38542 etc.

2012-01-30 Thread Michael Meeks
On Mon, 2012-01-30 at 11:39 +, Noel Power wrote: > > the following 2 commits fix problems in the dialog that are regressions > > from LO 3.3, and want backporting to libreoffice-3-5, libreoffice-3-5-0, > > and libreoffice-3-4: > > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=974

Re: [Libreoffice] [REVIEW:3-5-0][PUSHED] use the correct application icon of Writer/Web under Windows

2012-01-30 Thread Stephan Bergmann
On 01/30/2012 12:04 PM, Michael Stahl wrote: On 30/01/12 12:01, Noel Power wrote: On 27/01/12 18:42, Andras Timar wrote: I made a typo in my soffice.bin/soffice.exe icon reduction patch, so Writer/Web has the wrong application icon under Windows in rc2. The following commit fixes it. http://cgi

Re: [Libreoffice] [REVIEW][3-*] Writer table border bugs fdo#38542 etc.

2012-01-30 Thread Michael Meeks
Hi Michael, On Sat, 2012-01-28 at 00:06 +0100, Michael Stahl wrote: > they want to be in libreoffice-3-5-0 and libreoffice-3-4 as well: So - just poking them from a "will they introduce new crashes" perspective: > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=

Re: [Libreoffice] [PATCH] use SAL_CALL to fix build in msvc

2012-01-30 Thread Noel Power
On 29/01/12 11:35, Korrawit Pruegsanusak wrote: Hello Stephan, all, MSVC complains about error C2695 [1] while building, so I try to fix it with the attached patch, and the noise is now silent. But the build isn't success yet: still has problem in 'test', which I can't figure out. So, this patc

Re: [Libreoffice] [REVIEW 3-5, 3-5-0]

2012-01-30 Thread Michael Stahl
On 28/01/12 13:53, Fridrich Strba wrote: > Hello, a little safe patch that prevents that "compatibility symbol" we > added for backward compatibility with older versions of Duden Korrektor > from landing in the uwinapi.lib import library. This assures that no > accidental linking with it will ha

Re: [Libreoffice] [REVIEW 3-5-0]

2012-01-30 Thread Noel Power
On 28/01/12 12:53, Fridrich Strba wrote: Hello, a little safe patch that prevents that "compatibility symbol" we added for backward compatibility with older versions of Duden Korrektor from landing in the uwinapi.lib import library. This assures that no accidental linking with it will happen in

[Libreoffice] [PUSHED] use SAL_CALL to fix build in msvc

2012-01-30 Thread Michael Meeks
Hi there, On Sun, 2012-01-29 at 18:35 +0700, Korrawit Pruegsanusak wrote: > MSVC complains about error C2695 [1] while building, so I try to fix > it with the attached patch, and the noise is now silent. Lovely :-) looks obviously correct, pushed it. > But the build isn't success yet: st

[Libreoffice] [PATCH] Bug 44981 - EasyHack: remove obsolete SWAPLONG macros

2012-01-30 Thread Noel Grandin
Hi Bug 44981 - EasyHack: remove obsolete SWAPLONG macros This patch converts uses of the SWAPSHORT and SWAPLONG macros to OSL_SWAPWORD and OSL_SWAPDWORD Code is contributed under MPL+/LGPL+/GPL+ Patches passes a full build and make check. Regards, Noel Grandin Disclaimer: http://www.peralex

Re: [Libreoffice] [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

2012-01-30 Thread Stephan Bergmann
On 01/29/2012 09:36 PM, Lionel Elie Mamane wrote: Attached patch fixes fdo#34432, a crash with some ODBC drivers. The bug report is about Firebird SQL. The attached 0001-fdo-44025-repair-dbaccess-ORowSetCache-isLast-after-.patch appears to be completely unrelated? Stephan

Re: [Libreoffice] [REVIEW][3-5-0] Writer table border bugs fdo#38542 etc.

2012-01-30 Thread Noel Power
On 27/01/12 23:06, Michael Stahl wrote: these commits fix ODF import bugs described in fdo#38542 (regressions from LO 3.3) and were already backported to libreoffice-3-5 by Cedric; they want to be in libreoffice-3-5-0 and libreoffice-3-4 as well: http://cgit.freedesktop.org/libreoffice/core/comm

[Libreoffice] [REVIEWED 3-5-0] Fix for formula reference chain breakage during pivot table update

2012-01-30 Thread Michael Meeks
On Sun, 2012-01-29 at 20:27 +0100, Markus Mohrhard wrote: > > I reverted the previous af70bc00c6714eb8695babdf5af07416552f7034 and > > committed the new patch to master, and to 3-5 with my sign-off. > > > > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=08adeedce926bac1a

Re: [Libreoffice] PDF converter cross compilation general questions

2012-01-30 Thread Andrzej.Pacanowski
> Of course, the cross-compilation work is going rather well; we're > managing to get most of the startup phase complete on Android/ARM now, > and even a little (busted) rendering going. I'm interested in why you'd > want to render to PDF on ARM though ... can you tell more ? Thanks for info

[Libreoffice] R: Fatal error building Windows release - ( Cygwin )

2012-01-30 Thread walter
Hi Korrawit, Sorry, but I'm the classic windows desktop programmer, I have to change my mind one more time, sigh ! $ git show commit 9abb0b6bbe2de65988065f78354ccf5ebde4a7ae Error Log (last lines) pastebin.com/u/walterLO Cheers walter ___ LibreOffi

[Libreoffice] REMINDER: Release 3.5.0-rc3 from libreoffice-3-5-0 branch

2012-01-30 Thread Petr Mladek
Hi, please note that the commit deadline for 3.5.0-rc3 is today, January 30, 2012. It will be used as LO-3.5.0 final if no blocker is reported. See also http://wiki.documentfoundation.org/ReleasePlan#3.5_release http://wiki.documentfoundation.org/Release_Criteria http://wiki.documentfoundation.or

Re: [Libreoffice] [REVIEW: 3-5-0] fix configuration migration on Linux

2012-01-30 Thread Stephan Bergmann
On 01/30/2012 11:56 AM, Noel Power wrote: pushed ( or will be when the git gc finishes ) to 3-5. extra reviews etc. needed for 3-5-0 Patch looks OK to me for inclusion in -3-5-0. One more review needed. Stephan ___ LibreOffice mailing list LibreOffi

Re: [Libreoffice] [REVIEW][3.5.0][3-5][3-4] fdo#38595 Calc cell borders lost in ODF import

2012-01-30 Thread Petr Mladek
Petr Mladek píše v Pá 27. 01. 2012 v 14:39 +0100: > Cedric Bosdonnat píše v Pá 27. 01. 2012 v 10:01 +0100: > > The minutes were transformed into a night... but I'm ok with your > > patches and pushed them to 3.5 and master. 2 more reviews to have them > > into 3.5.0. > > What commits are we talkin

Re: [Libreoffice] [REVIEW:3-5-0] use the correct application icon of Writer/Web under Windows

2012-01-30 Thread Michael Stahl
On 30/01/12 12:01, Noel Power wrote: > On 27/01/12 18:42, Andras Timar wrote: >> Hi, >> >> I made a typo in my soffice.bin/soffice.exe icon reduction patch, so >> Writer/Web has the wrong application icon under Windows in rc2. The >> following commit fixes it. >> http://cgit.freedesktop.org/libreof

Re: [Libreoffice] [REVIEW:3-5-0] use the correct application icon of Writer/Web under Windows

2012-01-30 Thread Noel Power
On 27/01/12 18:42, Andras Timar wrote: Hi, I made a typo in my soffice.bin/soffice.exe icon reduction patch, so Writer/Web has the wrong application icon under Windows in rc2. The following commit fixes it. http://cgit.freedesktop.org/libreoffice/core/commit/?id=764674700d35d86890e3538039209f039

Re: [Libreoffice] [REVIEW: 3-5-0] fix configuration migration on Linux

2012-01-30 Thread Noel Power
On 27/01/12 18:10, Petr Mladek wrote: Hi, we moved the used configuration from ~/.libreoffice to ~/.config/libreoffice between LO-3.4 and 3.5 on Linux. Unfortunately, the old configuration is not migrated. I have finally got time to dig into it again. The result is the attached patch. It works w

  1   2   >