[PATCH] Remove unused code (20)

2012-02-24 Thread Elton Chung
Hi, This patch removes 20 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email: el...@layerjet.com -

Re: [PATCH] Moving misplaced Formula options from ScDocOptions to ScAppOptions

2012-02-24 Thread Kohei Yoshida
On Fri, 2012-02-24 at 20:38 -0500, Kohei Yoshida wrote: > Hi Albert, > > On Sat, 2012-02-25 at 01:12 +0100, Albert Thuswaldner wrote: > > > 1.) ScDocument::SetDocOptions requires some rethink. Here, now that > > the format option stuff is moved to appoptions, only > > xPoolHelper->SetFormTableOpt

Real unit testing in sw?

2012-02-24 Thread Markus Mohrhard
Hey guys, thanks to a great script by Daniel we might be able to try to write real unit tests and it would be great if we could try this at a useful class. Since I'm (thankfully) totally clueless about writer I wanted to ask you for the one or two most important classes/methods that would need rea

Re: [PATCH] Moving misplaced Formula options from ScDocOptions to ScAppOptions

2012-02-24 Thread Kohei Yoshida
Hi Albert, On Sat, 2012-02-25 at 01:12 +0100, Albert Thuswaldner wrote: > 1.) ScDocument::SetDocOptions requires some rethink. Here, now that > the format option stuff is moved to appoptions, only > xPoolHelper->SetFormTableOpt(rOpt); uses data from docoptions, the mix > of options makes this met

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-24 Thread julien2412
Hi, I runned gdb during the freeze and found that about 230 were used during this moment. I retrieved 9 bt during this moment (I tried to retrieve it on the whole period). http://nabble.documentfoundation.org/file/n3774132/bt.zip bt.zip Debian testing pc x86-64 (Linux kernel 3.1.0-1-amd64) autog

[REVIEW-3-5, 3-5-1] fdo#46571 add Gurmukhi MT to pa-IN font list

2012-02-24 Thread Andras Timar
Hi, http://cgit.freedesktop.org/libreoffice/core/commit/?id=1e343276ecb7e88482e0dd8b2a1e170dbffbe8ba Thanks, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW 3-5] Fix for fdo#40320

2012-02-24 Thread Kohei Yoshida
On Fri, 2012-02-24 at 14:59 -0500, Kohei Yoshida wrote: > Hi there, > > Please review the following commit > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=67f37b1de7e64e3225844cfe38b9b1adace3fd85 And this commit as well http://cgit.freedesktop.org/libreoffice/core/commit/?id=89e836c

[REVIEW 3-5] Fix for fdo#40320

2012-02-24 Thread Kohei Yoshida
Hi there, Please review the following commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=67f37b1de7e64e3225844cfe38b9b1adace3fd85 for backport to the 3-5 branch. It fixes https://bugs.freedesktop.org/show_bug.cgi?id=40320 Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

[PATCH] Remove unused code (19)

2012-02-24 Thread Elton Chung
Hi, This patch removes 14 unused methods. Best Regards, Elton Remove-unused-code-19.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

development summary: year 2012, week 06

2012-02-24 Thread Petr Mladek
Hi, this time a brief summary of what happened during the 5th week in 2012 on LibreOffice repositories and the living branches: + master:LO-3.5 development + libreoffice-3-5: fixes for LO-3.5.1 bug fix release + libreoffice-3-4: fixes for potential LO-3.4.6

[REVIEW 3-5][REVIEW 3-5-1] Fix for fdo#46074 "FILEOPEN: No Recent Documents..."

2012-02-24 Thread Stephan Bergmann
Please review master commit "Resolves fdo#46074: Fix Partial::contains for paths that go past a leaf node" that fixes "FILEOPEN: No Recent Docu

Re: Java issues ...

2012-02-24 Thread Michael Meeks
Hi there, On Fri, 2012-02-24 at 18:17 +0400, Libreoffice Ge wrote: > java.lang.RuntimeException: java.lang.NoClassDefFoundError: > com/sun/star/comp/beans/OOoBean It's really rather hard to help with this sort of thing without more information, the code you're using etc. Is that publicly

[PUSHED]fdo44516 improved label and business card document creation (final)

2012-02-24 Thread Ivan Timofeev
Marking as [PUSHED]: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a99083d233d0d5c5a09941ec2ee7164bc63c61db Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Android / basic text entry ...

2012-02-24 Thread Michael Meeks
Hi there, I nailed a few more issues, and with some more hideous hackery, it's possible to type 'Hello World' into writer on Android ;-) that only works on the 2nd run - it's necessary to dismiss the initial error dialog and re-'make run' I guess. I'm still poking away at it in id

Re: [PATCH] convert SV_DECL_PTRARR_DEL to boost::ptr_vector in sc/inc/viewuno.hxx

2012-02-24 Thread Ivan Timofeev
Hi Noel, From: Noel Grandin Do you really want to be @ubuntu.(none)? If not, use $ git config --global user.email -for ( sal_uInt16 n=0; nactiveSpreadsheetChanged( aEvent ); +(*it)->activeSpreadsheetChanged( aEvent ); } catch( uno::Exceptio

[ANNOUNCE] Branch libreoffice-3-5-1 created

2012-02-24 Thread Petr Mladek
Hi all, there have been created the libreoffice-3-5-1 branch. It will be used for fine tuning of the 3.5.1 release. It was created before the tag for 3.5.1-rc1 to avoid race condition in the automatically generated bugzilla comments. It was created already on Wednesday evening. I did not announc

Re: [PATCH] fix building dictionaries when PERL_UNICODE environment

2012-02-24 Thread Petr Vorel
I run into troubles while building dictionaries, because I have on my system set PERL_UNICODE=SDL (perl script clone/dictionaries/dictionaries/util/th_check.pl dies as it's forced to use UTF-8, but not all dictionaries are in this encoding). Interesting, I'd never seen this environment variable

[ANNOUNCE] libreoffice-3.5.1.1 tag created (3.5.1-rc1)

2012-02-24 Thread Petr Mladek
Hi, after some fighting, there have been created the libreoffice-3.5.1.1 tag for 3.5.1-rc1 release. The corresponding official builds will be available within next few days. NOTE: The commit deadline for 3.5.1-rc1 is postponed to the following Wedensday/Thursday. We need to give testers some chan

[no subject]

2012-02-24 Thread Libreoffice Ge
Dear Developers, I am trying to run Libreoffice (Openoffice 3.2.1) in applet using this document. I was not able to find same for LibreOffice.org. I have succeeded to run applet from Eclipse, where I am using abso

Re: [PUSHED] fdo#46166: EasyHack: remove obsolete MSFilterTracer

2012-02-24 Thread Stephan Bergmann
On 02/24/2012 02:19 PM, Stephan Bergmann wrote: On 02/24/2012 11:46 AM, Michael Meeks wrote: On Fri, 2012-02-24 at 10:50 +0100, Dézsi Szabolcs wrote: Hi all! Started all over again, this patch removes the MSFilterTracer class, which is no longer used, and removes all references to it (in sc, sd

Re: [PUSHED] fdo#46166: EasyHack: remove obsolete MSFilterTracer

2012-02-24 Thread Stephan Bergmann
On 02/24/2012 11:46 AM, Michael Meeks wrote: On Fri, 2012-02-24 at 10:50 +0100, Dézsi Szabolcs wrote: Hi all! Started all over again, this patch removes the MSFilterTracer class, which is no longer used, and removes all references to it (in sc, sd and sw) The previous patch is obsolete now.

Re: -std=c++0x vs -std=gnu++0x

2012-02-24 Thread Lubos Lunak
On Thursday 23 of February 2012, Stephan Bergmann wrote: > On 02/23/2012 05:08 PM, Lubos Lunak wrote: > > commit 437fe5a11f68d1848c49121394f16f09611b made me notice that we > > actually build with -std=c++0x and not -std=gnu++0x, which I think would > > make more sense and be consistent with

Re: [PUSHED:3-5,3-5-1,3-4] fdo#46165

2012-02-24 Thread Petr Mladek
Noel Power píše v Pá 24. 02. 2012 v 12:36 +: > On 24/02/12 12:26, Petr Mladek wrote: > > I see it in 3-5 branch, so mark as pushed. It will be in 3.5.1-rc1. > > > > I guess that it is still pending review for 3-4. > I took the 3.5 sign-off to be a blessing for 3-4 also so I pushed it > there t

ODF bugzilla keywords (was: Re: minutes of ESC call ...)

2012-02-24 Thread Michael Stahl
On 16/02/12 18:12, Michael Meeks wrote: > * ODF issues (Michael Stahl) > + use the whiteboard for issues related to ODF documented here: > + http://wiki.documentfoundation.org/BugTriage because it is apparently too difficult to add keywords, added "odf" and "odf_validation" to

[REVIEW 3-5] fdo#46568 - VALGRIND corruption

2012-02-24 Thread Noel Power
please review the patch from master here, the detail ( valgrind and gdb traces etc. ) already in the bug so I won't duplicate here http://cgit.freedesktop.org/libreoffice/core/commit/?id=22871f1af3be444e747f7adaad5221b9c8b0bebf Noel ___ LibreOffice mai

Re: [PUSHED:3-5,3-5-1][REVIEW:3-4] fdo#46165

2012-02-24 Thread Noel Power
On 24/02/12 12:26, Petr Mladek wrote: I see it in 3-5 branch, so mark as pushed. It will be in 3.5.1-rc1. I guess that it is still pending review for 3-4. I took the 3.5 sign-off to be a blessing for 3-4 also so I pushed it there too, let me know if you want me to back that out ( it seems sens

Re: [PUSHED:3-5,3-5-1] fdo#46377 BASISINSTALLLOCATION = INSTALLLOCATION

2012-02-24 Thread Petr Mladek
Andras Timar píše v Pá 24. 02. 2012 v 11:52 +0100: > Hi, > > This was fallout from the basis/brand re-merge in LO 3.5. > http://cgit.freedesktop.org/libreoffice/core/commit/?id=06dd0fda38f07a74ba8469542ed4afe93b47ee9c > > Please cherry-pick to libreoffice-3-5 Looks good and safe => pushed into 3

Re: [PUSHED:3-5,3-5-1][REVIEW:3-4] fdo#46165

2012-02-24 Thread Petr Mladek
Michael Meeks píše v Čt 23. 02. 2012 v 14:45 +: > On Thu, 2012-02-23 at 13:03 +, Noel Power wrote: > > don't know if it is too late for libreoffice-3-5-1 or not :-) But... in > > anycase it seems my previous patch > ... > > I have reverted my attempt and ported the patch. I tested the samp

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Noel Power changed: What|Removed |Added Depends on||46568 --- Comment #200 from Noel Power 201

Re: [PUSHED] glib needed only when enable_librsvg, gettext only when enable_librsvg or cross-compile

2012-02-24 Thread Petr Mladek
Marking as pushed. Korrawit Pruegsanusak píše v Čt 23. 02. 2012 v 23:03 +0700: > Hello Michael, > > [re-adding the list in cc, sorry for missing] > > On Tue, Feb 21, 2012 at 22:20, Michael Meeks wrote: > > On Tue, 2012-02-21 at 21:32 +0700, Korrawit Pruegsanusak wrote: > >> >I don't th

[PUSHED] Re: [REVIEW] add test case for old password algorithm, fdo#45171

2012-02-24 Thread Jan Holesovsky
Just marking [PUSHED] :-) Rene Engelhard píše v Út 21. 02. 2012 v 19:57 +0100: > On Tue, Feb 21, 2012 at 03:23:23PM +0100, Markus Mohrhard wrote: > > but fdo#45171 seems to be a distro build problem and I hope that we > > can prevent this problem in the 3-5 branch with this test case. If the > > m

[REVIEW-3-5] fdo#46377 BASISINSTALLLOCATION = INSTALLLOCATION

2012-02-24 Thread Andras Timar
Hi, This was fallout from the basis/brand re-merge in LO 3.5. http://cgit.freedesktop.org/libreoffice/core/commit/?id=06dd0fda38f07a74ba8469542ed4afe93b47ee9c Please cherry-pick to libreoffice-3-5 Thanks, Andras ___ LibreOffice mailing list LibreOffice

[PUSHED] fdo#46166: EasyHack: remove obsolete MSFilterTracer

2012-02-24 Thread Michael Meeks
Hi there, On Fri, 2012-02-24 at 10:50 +0100, Dézsi Szabolcs wrote: > Hi all! Started all over again, this patch removes the MSFilterTracer > class, which is no longer used, and removes all references to it (in > sc, sd and sw) The previous patch is obsolete now. Nice work - I just pushed

Re: [PUSHED] Re: About fdo#46339 Query Wizard fails to open, (post fdo#42543 fix?)

2012-02-24 Thread Jan Holesovsky
Hi Julien, Michael Meeks píše v Pá 24. 02. 2012 v 10:15 +: > > Can I put the tracker to RESOLVED/FIXED or should I wait 3.5.1 to be > > released with the fix to change the status ? > > Sure - I'd resolve it fixed, and put a comment that it should be in > 3.5.1. Actually - changing it

Re: [PUSHED] Re: About fdo#46339 Query Wizard fails to open, (post fdo#42543 fix?)

2012-02-24 Thread Michael Meeks
On Thu, 2012-02-23 at 11:12 -0800, julien2412 wrote: > Can I put the tracker to RESOLVED/FIXED or should I wait 3.5.1 to be > released with the fix to change the status ? Sure - I'd resolve it fixed, and put a comment that it should be in 3.5.1. Thanks ! Michael.

Re: [PUSHED] Fix cppcheck "possible null dereference" in ScMyCellInfo::CreateCell.

2012-02-24 Thread Michael Meeks
On Thu, 2012-02-23 at 22:18 +0100, Catalin Iacob wrote: > I did commit and use format-patch, in fact the "It's safe to remove > the check..." was the part of the commit message :). But then I sent > the mail with git send-email --attach which puts > the second part of the commit message inline an

[PATCH] fdo#46166: EasyHack: remove obsolete MSFilterTracer

2012-02-24 Thread Dézsi Szabolcs
Hi all! Started all over again, this patch removes the MSFilterTracer class, which is no longer used, and removes all references to it (in sc, sd and sw) The previous patch is obsolete now. https://bugs.freedesktop.org/show_bug.cgi?id=46166 Szabolcs Fro

Re: [Libreoffice-commits] .: oox/inc oox/source unusedcode.easy

2012-02-24 Thread Miklos Vajna
On Fri, Feb 24, 2012 at 01:30:06AM +0100, Eike Rathke wrote: > Removing the dump methods broke the dbgutil build, I partly reverted > that, please see > http://cgit.freedesktop.org/libreoffice/core/commit/?id=29b1914fad754ed94e61179f09aac50f1657f2e0 > > I think we should exclude the oox dump meth