[PATCH] Convert SvPtrarr and tools/table.hxx usage in sw module.

2012-03-01 Thread Noel Grandin
Hi License is on file. Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html 0001-Convert-SvPtrarr-usage-to-std-vector-in-GetBookmarks.patch Description: application/mbox ___ LibreOffice mailing list LibreOffice@lists.freedeskt

RE: [PATCH]fdo45671 calc cell background color simplified code for split button action

2012-03-01 Thread Winfried Donkers
Tommy wrote (1 maart 2012 18:10) >is this patch fixing this ancient OOo issue? >https://issues.apache.org/ooo/show_bug.cgi?id=10864 Yes it is/coming patches will be. Bug 45671 is the metabug for a lot of colour buttons that are to be transformed to split buttons or sticky buttons. I already tran

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #211 from Bas Brederode 2012-03-01 22:13:21 PST --- When I hide a row and then copy the remaining rows Calc will also copy the hide rows. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are re

Re: how to change the default settings, like page setting to B5

2012-03-01 Thread huqitu du
I found this http://ask.libreoffice.org/question/433/how-do-i-change-my-default-font-from-times-new but this is not me wanted, I want to change default settings from source file, so I can make a installer, and when I install Office, the changed value is there. 2012/3/1 Michael Meeks > Hi there

[PATCH] Replace String by OUString

2012-03-01 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozil

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-03-01 Thread julien2412
Tommy, I still got a small freeze (1 or 2 seconds) on master (see my comment https://bugs.freedesktop.org/show_bug.cgi?id=46765#c7) but the improvement is huge ! (forgot to tell on the bugtracker comment I had removed my LO profile for the test). Julien. -- View this message in context: http://

[PATCH] instance of SV_DECL_VARARR_SORT -> std::set

2012-03-01 Thread Matúš Kukan
Hi there, This is my first STL C++ patch. ( I also wanted to do some conversion. ) Please review / comment / enjoy. Matus From f84c7a703a2329729b14bd4b99fc16cfcea25a7b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C3=BA=C5=A1=20Kukan?= Date: Thu, 1 Mar 2012 21:59:12 +0100 Subject: [PATCH] replace

Re: Writer Unit tests

2012-03-01 Thread Markus Mohrhard
Hey, great to see someone interested in writer testing. >        Well - writer unit tests are in sw/qa/core/ and I like the > swdoc-test.cxx red-lining regression test - primarily because it doesn't > work - and I didn't have time to dig into it ;-) > >        The idea was to create through rando

Re: Weird code found by clang

2012-03-01 Thread Niko Rönkkö
On 1.3.2012 23.13, Tor Lillqvist wrote: > svtools/source/dialogs/addresstemplate.cxx:195:23: error: > self-comparison always evaluates to false > [-Werror,-Wtautological-compare] > for (;pFields != pFields; ++pFields) >^ > What should this be? Or is what it current

Re: Writer Unit tests

2012-03-01 Thread Michael Meeks
On Fri, 2012-03-02 at 00:55 +0700, Vit wrote: > > Do you have a build already ? if not, I'd recommend using a recent > > Linux distribution (I love openSUSE 12.1) and getting that going, it's > > really a pre-requisite. > > I'm using Arch linux at home but never build or installed daily build

Re: [PATCH] [PUSHED] fdo#46193: Let the user copy error message from error dialog

2012-03-01 Thread Andras Timar
Tor Lillqvist írta (2012. március 1. 19:41): > Thanks, pushed to master. > This patch adds a "Copy to Clipboard" button to every messagebox unconditionally. It solves the original problem, error messages can be copied now. But it also can make confusion. For example when the user tries to close Li

Re: User installation migrated onto itself

2012-03-01 Thread Stephan Bergmann
On 02/27/2012 02:36 PM, Michael Meeks wrote: On Mon, 2012-02-27 at 12:52 +0100, Stephan Bergmann wrote: The migration happens only on the first start of LO 3.5, due to "disable multiple migrations

[PUSHED 3-5-1] fix crash in importSheets

2012-03-01 Thread Michael Meeks
On Thu, 2012-03-01 at 19:37 +0100, Michael Stahl wrote: > >> could you please cherry-pick the attached patch to 3-5 and if still > >> possible 3-5-1. > > looks obvious, +1 Indeed; pushed to -3-5-1 :-) Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engi

Re: minutes of ESC call ...

2012-03-01 Thread Michael Stahl
On 01/03/12 22:25, Michael Meeks wrote: > > On Thu, 2012-03-01 at 20:47 +0100, Stephan Bergmann wrote: >>> AA: + l/strace-alike for UNO (Stephan) >> >> On a more constructive note ;) the above already exists, in the form >> of

[PUSHED 3-5-1] fix crash when deleting db range in formula

2012-03-01 Thread Michael Meeks
On Thu, 2012-03-01 at 19:39 +0100, Michael Stahl wrote: > >> IMHO this patch is extremely safe and it would be great if we could > >> push it to 3-5 and maybe 3-5-1. > > clearly that patch is an improvement :) +1 :-) thanks, pushed to -3-5-1. ATB, Michael. -- m

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-03-01 Thread Tommy
It would be interesting to know if Dezsi personal build with the fix about slow loading replacement table has still the issue I'm describing here... maybe, if we are lucky, that fix could somehow have influence even on the freeze I'm describing. we were lucky!!! Deszi's patch fixed both

Re: minutes of ESC call ...

2012-03-01 Thread Michael Meeks
On Thu, 2012-03-01 at 20:47 +0100, Stephan Bergmann wrote: > > AA: + l/strace-alike for UNO (Stephan) > > On a more constructive note ;) the above already exists, in the form > of . Great - so then, perhaps the

Weird code found by clang

2012-03-01 Thread Tor Lillqvist
svtools/source/dialogs/addresstemplate.cxx:195:23: error: self-comparison always evaluates to false [-Werror,-Wtautological-compare] for (;pFields != pFields; ++pFields) ^ What should this be? Or is what it currently does, exit the loop after one pass through, actually

Re: minutes of ESC call ...

2012-03-01 Thread Michael Meeks
On Thu, 2012-03-01 at 19:38 +0100, Stephan Bergmann wrote: > On 03/01/2012 07:00 PM, Michael Meeks wrote: > > * un-realistic attitude wrt. exceptions and bloat ... (Sberg) > > I do not appreciate that tone. And I never brought this up for > discussion in the ESC. Hah ;-) sorry pardon,

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Tor Lillqvist
> Are there known problems? How can we know without trying? That they say it is supported with any current MSVC version just means that using *their* way of building it is "supported". It doesn't mean that our convoluted build mechanisms for it still work. But I would love to be proved wrong of co

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Lionel Elie Mamane
On Thu, Mar 01, 2012 at 07:50:57PM +0200, Tor Lillqvist wrote: >> According to Wikipedia, MSVC 7.1 is MSVC 2003. We use MSVC2005 or 2008 >> I believe? So it should be OK. > Are you volunteering to do the necessary work then to make a newer > boost then work for us with MSVC2008? Are there known

Re: minutes of ESC call ...

2012-03-01 Thread Stephan Bergmann
On 03/01/2012 07:00 PM, Michael Meeks wrote: * GSOC update (Cedric) + drastic action / brainstorming on ideas required Add these tasks to the wiki AA: + l/strace-alike for UNO (Stephan) On a more constructive note ;) the above already exists, in the form of

Re: minutes of ESC call ...

2012-03-01 Thread Stephan Bergmann
On 03/01/2012 07:00 PM, Michael Meeks wrote: * un-realistic attitude wrt. exceptions and bloat ... (Sberg) I do not appreciate that tone. And I never brought this up for discussion in the ESC. Stephan ___ LibreOffice mailing list LibreOffice@lists

Re: [PATCH] [PUSHED] fdo#46193: Let the user copy error message from error dialog

2012-03-01 Thread Tor Lillqvist
Thanks, pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW] [REVIEWED 3-5] fix crash when deleting db range in formula

2012-03-01 Thread Michael Stahl
On 01/03/12 19:12, Kohei Yoshida wrote: > On Thu, 2012-03-01 at 13:07 +0100, Markus Mohrhard wrote: >> Hey, >> >> [1] fixes a crash if you try to delete a database range in a formula. >> >> IMHO this patch is extremely safe and it would be great if we could >> push it to 3-5 and maybe 3-5-1. >> >>

Re: [REVIEW] [REVIEWED 3-5] fix crash in importSheets

2012-03-01 Thread Michael Stahl
On 01/03/12 19:10, Kohei Yoshida wrote: > On Thu, 2012-03-01 at 12:15 +0100, Markus Mohrhard wrote: >> Hey, >> >> could you please cherry-pick the attached patch to 3-5 and if still >> possible 3-5-1. > > Pushed to the 3-5 branch with my sign-off. I too recommend we push this > to the 3-5-1 branc

[PATCH] fdo#46193: Let the user copy error message from error dialog

2012-03-01 Thread Dézsi Szabolcs
Hi! I already made a patch for this bug, but this is a better solution ( at least i think :) ) I added a 'Copy to Clipboard' button to MessBox, so error messages are now copyable. Here's the bug (there's a screenshot of the patch as well): https://bugs.freedesktop.org/show_bug.cgi?id=46193 Sz

Re: [PATCH] [PUSHED] Remove unused code (21)

2012-03-01 Thread Tor Lillqvist
Thanks, pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW] [REVIEWED 3-5] fix crash when deleting db range in formula

2012-03-01 Thread Kohei Yoshida
On Thu, 2012-03-01 at 13:07 +0100, Markus Mohrhard wrote: > Hey, > > [1] fixes a crash if you try to delete a database range in a formula. > > IMHO this patch is extremely safe and it would be great if we could > push it to 3-5 and maybe 3-5-1. > > Regards, > Markus > > [1] > http://cgit.freed

Re: [REVIEW] [REVIEWED 3-5] fix crash in importSheets

2012-03-01 Thread Kohei Yoshida
On Thu, 2012-03-01 at 12:15 +0100, Markus Mohrhard wrote: > Hey, > > could you please cherry-pick the attached patch to 3-5 and if still > possible 3-5-1. Pushed to the 3-5 branch with my sign-off. I too recommend we push this to the 3-5-1 branch since it's just a simple silly mistake & the fix

minutes of ESC call ...

2012-03-01 Thread Michael Meeks
* Present: + Norbert, Eike, Stephan, David, Bjoern, Caolan, Rainer Andras, Markus, Fridrich, Michael, Thorsten, Cedric, Petr, Michael S, Kohei * Completed Action Items + dig out more Windows 3.5.0 installation bugs (Rainer) + interacting / pendin

[PATCH] Remove unused code (21)

2012-03-01 Thread Elton Chung
Hi, This patch removes 5 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email : el...@layerjet.com -

Re: [REVIEWED][3-5] don't try to update range names twice in ScDocument::TransferTab

2012-03-01 Thread Kohei Yoshida
On Thu, 2012-03-01 at 14:40 +0100, Markus Mohrhard wrote: > Missed the attachment, You can find the commit at > http://cgit.freedesktop.org/libreoffice/core/commit/?id=1b93146d442bb8396126d6106f05a5bb0ee9fffa Pushed to the 3-5 branch with my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker,

Re: Writer Unit tests

2012-03-01 Thread Vit
Hi, Michael! > Do you have a build already ? if not, I'd recommend using a recent > Linux distribution (I love openSUSE 12.1) and getting that going, it's > really a pre-requisite. I'm using Arch linux at home but never build or installed daily builds of LO for now. But, I think, this can

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Tor Lillqvist
> According to Wikipedia, MSVC 7.1 is MSVC 2003. We use MSVC2005 or 2008 > I believe? So it should be OK. Are you volunteering to do the necessary work then to make a newer boost then work for us with MSVC2008? --tml ___ LibreOffice mailing list LibreOf

Re: [REVIEW 3-5, 3-5-1] Make libxslt link the right libxml on mac ppc

2012-03-01 Thread Alexander Thurgood
Le 01/03/12 15:52, Stephan Bergmann a écrit : Hi Stephan, > > No idea why it uses > -I/Developer/SDKs/MacOSX10.4u.sdk/usr/include/libxml2 while building > libxslt for you, then. Anyway, just don't use --without-system-libxml. No idea either, but there must have been some more recent changes to

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Lionel Elie Mamane
On Thu, Mar 01, 2012 at 12:14:28PM +0100, Stephan Bergmann wrote: > On 02/29/2012 06:41 PM, Lionel Elie Mamane wrote: >> On Wed, Feb 29, 2012 at 02:57:09PM +0100, Stephan Bergmann wrote: >>> Note that the stable sal interface historically stays clear of >>> boost, because of differences in the var

Re: [PATCH]fdo45671 calc cell background color simplified code for split button action

2012-03-01 Thread Tommy
On Thu, 01 Mar 2012 13:49:30 +0100, Winfried Donkers wrote: Hello all, Attached patch introduces simpler code to make the 'apply last used color'-part of the split button. This patch is for calc cell background color, the other split buttons are to follow. Becasue of that, some ifs have

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Lionel Elie Mamane
On Thu, Mar 01, 2012 at 01:56:08PM +0200, Tor Lillqvist wrote: >> If 4.4/4.5 are OK, but "only" 4.6.0-4.6.9 are to be blacklisted, I'd >> argue it is not a significant problem. > What about the 4.0.1 used for Mac OS X builds? What was being discussed above was a bug present in GCC 4.6.9, but not

Re: Has the time come to get rid of the "delivering" of public headers?

2012-03-01 Thread Bjoern Michaelsen
On Thu, Feb 23, 2012 at 11:41:20AM +, Michael Meeks wrote: > > :-) Any chance of some more advanced 'easy hacks' on this ? and/or a > Google Summer of Code idea: > > https://wiki.documentfoundation.org/Development/Gsoc/Ideas Done. Best, Bjoern __

MPL/LGPL blanket license

2012-03-01 Thread Sebastian Spaeth
Just in case some code actually ends up in LibO: All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Sebastian Spaeth ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freede

Re: [PATCH] [PUSHED] convert tools/table.hxx to std::vector in editeng module

2012-03-01 Thread Tor Lillqvist
> Convert tools/table.hxx usage in  editeng/source/editdoc.cxx to std::vector Thanks! Pushed to maser. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH][PUSHED] fdo45671 calc cell background color simplified code for split button action

2012-03-01 Thread Tor Lillqvist
> Attached patch introduces simpler code to make the 'apply last used > color'-part of the split button. Thanks! Pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreof

Re: [REVIEW 3-5, 3-5-1] Make libxslt link the right libxml on mac ppc

2012-03-01 Thread Stephan Bergmann
On 03/01/2012 03:22 PM, Alexander Thurgood wrote: Just to add to my previous mail, the config switches I'm using : ./configure CC=ccache gcc-4.0 CXX=ccache g++-4.0 --with-max-jobs=4 --with-num-cpus=2 --with-vendor=The Document Foundation --enable-epm --enable-binfilter --without-system-libxml --

Re: Checking string allocations (was Re: String literals, ASCII vs UTF-8)

2012-03-01 Thread Lubos Lunak
On Wednesday 29 of February 2012, Caolán McNamara wrote: > On Wed, 2012-02-29 at 17:11 +0100, Lubos Lunak wrote: > > Do we actually have code that tries to gracefully handle running out of > > memory? Because if not, and I doubt we realistically do[*] > > Its not O[U]String related, but FWIW vcl/un

Re: how to change the default settings, like page setting to B5

2012-03-01 Thread Michael Meeks
Hi there, On Thu, 2012-03-01 at 22:12 +0800, huqitu du wrote: > I want to change the default settings like page from A4 to B5 or > page layout from left right to top bottom, and I don't know where it > is saving the default settings or which model handle it! This really looks like a

Re: libreoffice + clang == success

2012-03-01 Thread Tor Lillqvist
> FYI, I also decided to start doing the iOS builds using clang. Whoa, compiling with Clang really reveals some interesting thinko-style bugs in the code. Bugs so old that it is hard to say whether it is riskier to fix them and better to let the code be as is (and work as it has worked all the tim

Re: [REVIEW 3-5, 3-5-1] Make libxslt link the right libxml on mac ppc

2012-03-01 Thread Alexander Thurgood
Le 29/02/12 20:13, Alex Thurgood a écrit : > > Sorry, by default setup, I meant the OSX server, not my LO build, I > should've been more precise. I'm not in front of the box at the mo, but > basically am building with virtually all of the extensions, the > binfilters, mysql connector enabled, an

how to change the default settings, like page setting to B5

2012-03-01 Thread huqitu du
Hi, I want to change the default settings like page from A4 to B5 or page layout from left right to top bottom, and I don't know where it is saving the default settings or which model handle it! thank you! best regard. huqitu, inner mongolia

Re: [PUSHED:3-4,3-5][PUSHED:3-5-1] fix crash using edit instance from xforms "Data navigator" dialog

2012-03-01 Thread Stephan Bergmann
On 03/01/2012 02:31 PM, Petr Mladek wrote: Looks fine to me. One more review needed for -3-5-1. pushed Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Small note on static analyzer, includes and build times...

2012-03-01 Thread Stephan Bergmann
On 03/01/2012 12:28 PM, Albert Thuswaldner wrote: On Tue, Feb 28, 2012 at 09:03, Stephan Bergmann wrote: Nice approach. :) One remark re "Looking for .cxx files whose first include is not the header file...": I did not look into the articles you cite to see whether or why they advocate to in

Re: [REVIEW] don't try to update range names twice in ScDocument::TransferTab

2012-03-01 Thread Markus Mohrhard
Missed the attachment, You can find the commit at http://cgit.freedesktop.org/libreoffice/core/commit/?id=1b93146d442bb8396126d6106f05a5bb0ee9fffa 2012/3/1 Markus Mohrhard : > Hey, > > the attached patch prevents double updating of the index for copied range > names. > > The new code updating ran

Re: SVG export

2012-03-01 Thread Thorsten Behrens
Chr. Rossmanith wrote: > I've observed the following strange behaviour when exporting a > drawing to SVG. > Hi Christina, weird, don't see that here (for a -3-5 branch) - the only reason I could think of is that Draw somehow stays in text edit mode. Could you try to narrow down what contributes t

Re: [PUSHED:3-4,3-5][REVIEW:3-5-1] fix crash using edit instance from xforms "Data navigator" dialog

2012-03-01 Thread Petr Mladek
Michael Stahl píše v Čt 01. 03. 2012 v 13:52 +0100: > On 01/03/12 13:20, Noel Power wrote: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b860d4970604f08ebd2e818bfd63891dd940804 > > > > should fix the problem, it seems that commit > > f7f47366ea78a71853fcaca2fa402bef667d9cce introdu

Re: [REVIEW 3-5][REVIEW 3-5-1 ?] fix crash using edit instance from xforms "Data navigator" dialog

2012-03-01 Thread Michael Stahl
On 01/03/12 13:20, Noel Power wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b860d4970604f08ebd2e818bfd63891dd940804 > > should fix the problem, it seems that commit > f7f47366ea78a71853fcaca2fa402bef667d9cce introduced a 'delete(pPage);' ( > it seems from the comment to silen

[PATCH]fdo45671 calc cell background color simplified code for split button action

2012-03-01 Thread Winfried Donkers
Hello all, Attached patch introduces simpler code to make the 'apply last used color'-part of the split button. This patch is for calc cell background color, the other split buttons are to follow. Becasue of that, some ifs have already been converted to switches. Winfried 0001-fdo-45671-cal

[REVIEW 3-5][REVIEW 3-5-1 ?] fix crash using edit instance from xforms "Data navigator" dialog

2012-03-01 Thread Noel Power
http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b860d4970604f08ebd2e818bfd63891dd940804 should fix the problem, it seems that commit f7f47366ea78a71853fcaca2fa402bef667d9cce introduced a 'delete(pPage);' ( it seems from the comment to silence some cppcheck error ) but that delete does

Re: [PUSHED][3-5][3-4] more problems in SwRootFrm dtor

2012-03-01 Thread Miklos Vajna
On Wed, Feb 29, 2012 at 11:00:09PM +0100, Michael Stahl wrote: > so refactor this a little to execute the base class dtors before > SwRootFrm dtor returns: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=ebb74441790a9852b1a1532d6e025c324666f6fc Pushed to -3-5 and -3-4, thanks for th

[REVIEW] fix crash when deleting db range in formula

2012-03-01 Thread Markus Mohrhard
Hey, [1] fixes a crash if you try to delete a database range in a formula. IMHO this patch is extremely safe and it would be great if we could push it to 3-5 and maybe 3-5-1. Regards, Markus [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=f7fbeac4cbb764ccd153f9aea37a07e66e96b809 __

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Tor Lillqvist
> If 4.4/4.5 are OK, but "only" 4.6.0-4.6.9 are to be blacklisted, I'd > argue it is not a significant problem. What about the 4.0.1 used for Mac OS X builds? > I *also* assume that Boost avoids breaking with MSVC :) Any assumptions about MSVC sound quite risky. --tml __

Re: What could be the problem when make gets into a loop in sax, continuously compiling facreg.cxx?

2012-03-01 Thread Tor Lillqvist
I thought the problem would be related to the timestamps of the .o and .d files for the source file in question in some way that shows up when using clang. (With gcc I don't see this problem.) Although I don't understand how. Even if I add a ls -lT to show the full timestamp of the .o and .d files

[REVIEW] don't try to update range names twice in ScDocument::TransferTab

2012-03-01 Thread Markus Mohrhard
Hey, the attached patch prevents double updating of the index for copied range names. The new code updating range names is in cell.cxx adjustRangeName which does the job directly in the formula tokens. The removed code did something similar for global range names but was incomplete and contained

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Michael Stahl
On 01/03/12 12:14, Stephan Bergmann wrote: > On 02/29/2012 06:41 PM, Lionel Elie Mamane wrote: >> On Wed, Feb 29, 2012 at 02:57:09PM +0100, Stephan Bergmann wrote: >>> Note that the stable sal interface historically stays clear of >>> boost, because of differences in the various boost versions >>>

Re: [PUSHED] Reduced duplicate code (simian) / vcl/generic/print/glyphset.cxx

2012-03-01 Thread Chr. Rossmanith
Hi, On Tue, 2012-02-28 at 11:07 +0100, Chr. Rossmanith wrote: here is the patch to reduce code which seems to be copy&pasted (cf. Duplicate code: GlyphSet::DrawGlyphs() and GlyphSet::ImplDrawText() / 27.2.2012) Thanks for that - a beautiful clean, pushed :-) [ how do you find s

License statement

2012-03-01 Thread Chr. Rossmanith
Hi, I declare that all my past and future contributions to LibreOffice are licensed under under MPL/LGPLv3+ . Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

SVG export

2012-03-01 Thread Chr. Rossmanith
Hi, I've observed the following strange behaviour when exporting a drawing to SVG. 1. select text tool and insert a letter 2. export drawing to SVG Expected: a block in the exported svg file Observed: no block and no font block If you export the drawing a second time the text and the font

[PUSHED] Re: [REVIEW -3-5] RTF import of drwaing objects regressions

2012-03-01 Thread Michael Stahl
On 01/03/12 12:06, Miklos Vajna wrote: > On Wed, Feb 29, 2012 at 05:05:01PM +0100, Miklos Vajna > wrote: >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbef8b4 and > > As Michael Stahl pointed out on IRC, a null pointer check was missing in > popState(), fixed with 456a59b in master,

Re: Small note on static analyzer, includes and build times...

2012-03-01 Thread Albert Thuswaldner
Hi Stephan and Michael, On Tue, Feb 28, 2012 at 09:03, Stephan Bergmann wrote: > > Nice approach. :) One remark re "Looking for .cxx files whose first > include is not the header file...": I did not look into the articles you > cite to see whether or why they advocate to include the correspond

Re: A Desugn Suggestion

2012-03-01 Thread Khaled Hosny
On Thu, Mar 01, 2012 at 11:06:41AM +, Arnold Bailson wrote: > I realize that this may not be the right place for this suggestion. If that is > so, my apologies: please pass it on to the correct place. > > I now have macular degeneration in my second eye. I find it convenient when > reading to

Re: [REVIEW-3-5][REVIEW-3-5-1] libxml2 on MacOSX

2012-03-01 Thread Stephan Bergmann
On 02/23/2012 09:48 PM, Stephan Bergmann wrote: shows that only a handful of executables and dynamic libraries use system libxml (/usr/lib/libxml2.2.dylib or /usr/local/lib/libxml2.2.dylib)---all of which are apparently only used during the build (if at all) and not included in the installation s

[REVIEW] fix crash in importSheets

2012-03-01 Thread Markus Mohrhard
Hey, could you please cherry-pick the attached patch to 3-5 and if still possible 3-5-1. Regards, Markus From 70dd1729ed0693ee670af0c27a304b4dbe01c5fe Mon Sep 17 00:00:00 2001 From: Markus Mohrhard Date: Thu, 1 Mar 2012 11:50:13 +0100 Subject: [PATCH] use correct source table --- sc/source/cor

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Stephan Bergmann
On 02/29/2012 06:41 PM, Lionel Elie Mamane wrote: On Wed, Feb 29, 2012 at 02:57:09PM +0100, Stephan Bergmann wrote: Note that the stable sal interface historically stays clear of boost, because of differences in the various boost versions available in the various environments. OK, two prongs:

A Desugn Suggestion

2012-03-01 Thread Arnold Bailson
I realize that this may not be the right place for this suggestion. If that is so, my apologies: please pass it on to the correct place. I now have macular degeneration in my second eye. I find it convenient when reading to use a hand-held lighted magnifier and this has brought very clearly to

Re: [REVIEW -3-5] RTF import of drwaing objects regressions

2012-03-01 Thread Miklos Vajna
On Wed, Feb 29, 2012 at 05:05:01PM +0100, Miklos Vajna wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbef8b4 and As Michael Stahl pointed out on IRC, a null pointer check was missing in popState(), fixed with 456a59b in master, I'm attaching an amended patch, which should be pi

Relicensing

2012-03-01 Thread David Fraser
Hi All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license, including the go-oo code Regards David -- David Fraser St James Software ___ LibreOffice mailing list LibreOffice@lists.freedesktop.

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||46687 --- Comment #210 from Petr Mladek 2

Re: [REVIEW][3-5] i#115684 SfxItemPool performance regression

2012-03-01 Thread Noel Power
On 01/03/12 05:09, Michael Meeks wrote: Looks a bit scary for 3.5.1 after RC1 surely ? or has this been well-tested elsewhere ? I guess if so a further +1 from me, coincidently I made the same change locally > today whilst investigating a large import doc, definitely improved the > import tim

Re: [Pushed] [PATCH] Translate German comments

2012-03-01 Thread Muthu Subramanian K
Pushed. Looked ok to me - I don't know much of the german language, though. Thank you! On 03/01/2012 10:38 AM, Philipp Weissenbacher wrote: > Hi all, > > I'd like to have a second set of eye-ball on these translations. > > Thanks, > Philipp > > > > ___

Re: [REVIEW][3-5-1][3-4] nsplugin broken due to typo

2012-03-01 Thread Stephan Bergmann
On 03/01/2012 06:21 AM, Michael Meeks wrote: Even better would be for a nice, checked, C++, in-line ( with direct shortcuts to the C++ factory method if it is in-process ;-) that could be compiled from the component files in a similar fashion to the configmgr changes - although, that'd be

[PATCH] convert tools/table.hxx to std::vector in editeng module

2012-03-01 Thread Noel Grandin
Hi Convert tools/table.hxx usage in editeng/source/editdoc.cxx to std::vector Contributed under LGPLv3+ / MPL 1.1 or later. (And my license statement is on file in the wiki) Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html 0001-In-removing-tools-table.hxx-usage-rem