https://bugs.freedesktop.org/show_bug.cgi?id=35673
--- Comment #259 from Björn Michaelsen
2012-04-13 01:05:27 PDT ---
... and there was much rejoicing!
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the
Hi Philipp,
On Thu, Apr 12, 2012 at 09:10:06PM +0200, Philipp Weissenbacher
wrote:
> The following patch a locally used macro to a local const variable.
Thanks for this.
> I didn't compile, because my laptop is too slow for that.
>
> I hope it's correct.
It is, but please make sure to test y
On Fri, Apr 13, 2012 at 08:21:35AM +0200, Stephan Bergmann wrote:
> On 04/12/2012 03:59 PM, Lubos Lunak wrote:
> > would somebody see a problem with this?
> >
> >sal/inc/rtl/ustring.hxx :
> >+#ifdef RTL_AUTOMATIC_USING
> >+using ::rtl::OUString;
> >+using ::rtl::OStringToOUString;
> >+using ::rtl:
Hi Santiago,
On Thu, Apr 12, 2012 at 08:04:19PM +0200, Santiago Martinez
wrote:
> This patch removes unused code as listed in unusedcode.easy
Thanks for this.
Given that this code used to be in oox, it still lives in the oox
namespace, though I think it makes more sense to mention the real mod
On Thu, Apr 12, 2012 at 08:02:30PM +0200, Matúš Kukan
wrote:
> We do that in configure.in:11339
> It's just warning, maybe can be overlooked.
Ah, fine. Yes, I overlooked it, but then that's my fault. :)
___
LibreOffice mailing list
LibreOffice@lists.fr
On the other hand, any kind of duplication is always bad, isn't it, as
is inconsistency. So isn't it, from that point of view, bad that some
percentage of the source files contain those "using" statements
(duplication), some a subset of them (inconsistency), others not, some
use ::rtl::foo, others
On 04/13/2012 10:13 AM, Bjoern Michaelsen wrote:
I tend to agree on all points. If something like that is essential, we could
have something like a:
salhelper/inc/rtl/stringhelper.hxx:
#include
using ::rtl::OUString;
using ::rtl::OStringToOUString;
using ::rtl::OUStringToOString;
and allow that
https://bugs.freedesktop.org/show_bug.cgi?id=35673
--- Comment #260 from Michael Meeks 2012-04-13
01:40:16 PDT ---
Thanks Rainer for all that careful work ! :-) and on with the MAB fixing in 3.5
...
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are rece
On 04/13/2012 10:24 AM, Tor Lillqvist wrote:
On the other hand, any kind of duplication is always bad, isn't it, as
is inconsistency. So isn't it, from that point of view, bad that some
percentage of the source files contain those "using" statements
(duplication), some a subset of them (inconsist
Hi,
my patch (that is apparently not pushed yet ;-) breaks the build with
--enable-werror option enabled.
I didn't try it yersterday, sorry for that.
I have two error: in C and in C+ code.
I removed the patch and compiled idlc with old dmake with
--enable-werror enabled.
It worked.
C-code
On 2012-04-12 14:40, Stephan Bergmann wrote:
Insist on people compiling with an unbroken toolchain instead?
It looks like Fedora is also going to do this:
http://fedoraproject.org/wiki/Features/ChangeInImplicitDSOLinking
I'm willing to write a configure test to add the --no-as-needed flag i
On 13/04/12 11:35, Noel Grandin wrote:
>
>
> On 2012-04-12 14:40, Stephan Bergmann wrote:
>> Insist on people compiling with an unbroken toolchain instead?
>>
>>
> It looks like Fedora is also going to do this:
> http://fedoraproject.org/wiki/Features/ChangeInImplicitDSOLinking
this is a differe
On 12 April 2012 13:38, Caolán McNamara wrote:
> On Thu, 2012-04-12 at 12:57 +0200, Michael Stahl wrote:
>> rumor has it that putting the source in Cygwin home has never ever
>> worked, but i have no idea why.
Heh, so I may be the first person in the world who have done that ? :-)
> The conversi
On 11 April 2012 14:24, Noel Grandin wrote:
> Building on Ubuntu 64-bit, "make check" is failing because of a missing
> symbol in libtest_smoketest.so.
> Doing a "make smoketest.clean" doesn't seem to help.
> The library does genuinely seem to be missing the symbol (readelf log
> attached).
>
> An
On 04/13/2012 11:26 AM, David Ostrovsky wrote:
C++ error is about bison generated parser:
idlc/source/parser.y:261:13: Fehler: #pragma system_header außerhalb
include-Datei ignoriert [-Werror]
source/parser.y: In Funktion »int yyparse()«:
source/parser.y:604:65: Fehler: Um Zuweisung, die als Wah
On 04/13/2012 11:35 AM, Noel Grandin wrote:
On 2012-04-12 14:40, Stephan Bergmann wrote:
Insist on people compiling with an unbroken toolchain instead?
It looks like Fedora is also going to do this:
http://fedoraproject.org/wiki/Features/ChangeInImplicitDSOLinking
No, as already detailed by
Hi,
Here is the corrected patch.
I fixed the build error with --enable-werror option enabled.
C problem:
I renamed rand to local_rand in eval.c
C++ problem
As on gbuild parser are not wrapped any more, I adjusted the warning
suppression in parser.y (borrowed from rsc module).
David
On 2012-04-13 12:48, Stephan Bergmann wrote:
Noel, do you happen to be affected because you are on a pre-final
natty release (whatever that is)?
I'm running 11.10 (Oneiric) which is the latest production release.
Disclaimer: http://www.peralex.com/disclaimer.html
__
Hi David
On 12 April 2012 23:45, David Ostrovsky wrote:
>
> thank you for your comments on my patch. I changed it accordingly.
nice patch, thanks
I pushed it with few modifications:
- removed new_style from CustomTarget
- also removed makefile.mk from inc/
- and please, could you be consistent
Sorry, but those patches don't create anything coherent, I think...
You apparently git rm'd the files you renamed but forgot to git add
them under the new name, or something. (Hint: git mv.) Could you
please use git rebase -i to "squish" together all the work into a
single patch, then I guess we co
On 13 April 2012 12:56, David Ostrovsky wrote:
> Hi,
>
> Here is the corrected patch.
> I fixed the build error with --enable-werror option enabled.
Hmm, I would not push it together.
Warning errors are somehow related to gbuild because there are
different settings but I would push that separatel
Hi,
On Fri, Apr 13, 2012 at 12:48:24PM +0200, Stephan Bergmann wrote:
> I would still prefer to simply insist on Ubuntu fixing their tool
> chain.
Well, Ubuntu (and I think Debian too) are defaulting to as-needed for:
- deps (which claims OpenSUSE doing the same)
http://wiki.debian.org/ToolChai
Hi,
I'm running into the same issue:
[ build RGM ]
CustomTarget/jurt/test/com/sun/star/lib/uno/protocols/urp/registry.rdb
terminate called after throwing an instance of
'CppUnit::DynamicLibraryManagerException'
what(): Symbol [cppunitTestPlugIn] not found in dynamic
libary:/home/david/pro
Hej Matúš,
you don't have to be scared, just push it ;-)
here is warning fix as a seperate patch.
David
On 13.04.2012 13:39, Matúš Kukan wrote:
On 13 April 2012 12:56, David Ostrovsky wrote:
Hi,
Here is the corrected patch.
I fixed the build error with --enable-werror option enabled.
Hmm,
I suppose we don't have a current mechanism to get a list a build time
of all the languages that we support in the UI as options for setting
the language ?
i.e. I'd like to be able to e.g. filter the libexttextcat language
fingerprints to only install the ones which are usable by us. I got a
littl
On Thu, 2012-04-12 at 10:14 -0400, Kohei Yoshida wrote:
> On Thu, Apr 12, 2012 at 10:06 AM, Caolán McNamara wrote:
> > *mumable* unotest::testDown has its "dispose" commented out ages ago,
> > putting that back in shows some other problems with various mixes of
> > global singletons that exist for
On 04/13/2012 01:42 PM, Bjoern Michaelsen wrote:
On Fri, Apr 13, 2012 at 12:48:24PM +0200, Stephan Bergmann wrote:
I would still prefer to simply insist on Ubuntu fixing their tool
chain.
Well, Ubuntu (and I think Debian too) are defaulting to as-needed for:
- deps (which claims OpenSUSE doing
On Fri, Apr 13, 2012 at 01:44:23PM +0200, David Ostrovsky wrote:
> Hi,
>
> I'm running into the same issue:
>
>
> [ build RGM ]
> CustomTarget/jurt/test/com/sun/star/lib/uno/protocols/urp/registry.rdb
> terminate called after throwing an instance of
> 'CppUnit::DynamicLibraryManagerException'
>
On 04/13/2012 01:39 PM, Matúš Kukan wrote:
On 13 April 2012 12:56, David Ostrovsky wrote:
Here is the corrected patch.
I fixed the build error with --enable-werror option enabled.
Hmm, I would not push it together.
Warning errors are somehow related to gbuild because there are
different setti
Hi,
please note that the commit deadline for 3.5.3-rc1 is on Monday, April 16,
2012.
The tag and branch libreoffice-3-5-3 is going to be created the day
after. Only commits with 3 reviewers will be allowed for that branch.
See also
http://wiki.documentfoundation.org/ReleasePlan#3.5_release
http:
Hi Stephan,
thanks for fixing this! Yes, I didn't see the rFont arg... All of this
changeset was some kind of dumb. Sorry for this.
Thomas
On 03/13/2012 11:19 AM, Stephan Bergmann wrote:
commit 40c0ff75d2a0f987454b068a663908e6d9b87b9b
Author: Stephan Bergmann
Date: Tue Mar 13 10:33:10 2012
Hi distro packagers,
you might want to subscribe libreoffice-rele...@lists.freedesktop.org
mailing list at
http://lists.freedesktop.org/mailman/listinfo/libreoffice-release
It is a low-traffic mailing list. It is currently used only for announcing newly
created tags for beta and release candidate
Hi,
All of my past and future contributions to the LibreOffice project are
under LGPLv3+/GPLv3+/MPL until further notice.
David Ostrovsky
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libr
Hi there,
I lost your mail with the rather nice re-write you're working on there,
but I attach a simple hack I've been working on instead.
The basic idea is to push the iteration over directories down into the
stoc/ code instead of having it in the cppuhelper code. That lets us
re
On Thu, 2012-04-12 at 14:47 +0200, Andras Timar wrote:
> Hi,
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=25c194163c531648f7ad8cdb1a64a03407f75efc
>
> Shift+F3 shortcut was changed .uno:ChangeCaseRotateCase, but
> originally in LibreOffice 3.3 it was .uno:CopyObjects. I restored th
Hello gentlemen,
Sorry again for delay. I was really busy because of my defeating of
pre-thesis report.
So I've done some initial job that you can estimate. Currently I'm in
process of improving and porting all Ukrainian rules from LT project.
The patch attached. If I'm doing something wron
https://bugs.freedesktop.org/show_bug.cgi?id=37361
--- Comment #267 from dE 2012-04-13 06:55:38 PDT ---
(In reply to comment #265)
> Added Bug 44861 - Calc EDITING: function Find&Replace behaves incorrectly if
> regular expressions used. Related to problem of the character "&" at the
> beginning
Hi Matúš,
this patch should fix the missing key in hash on Macos build [1]:
illegal combination app/SDKBIN/URELIB at
/Volumes/TBRAM/core/solenv/bin/macosx-change-install-names.pl line 70,
line 2.
Unfortunatelly I don't have Mac and can not test it ;-(
Could somebody with Mac try to build L
https://bugs.freedesktop.org/show_bug.cgi?id=37361
--- Comment #268 from dE 2012-04-13 07:01:04 PDT ---
There're a lot of unconfirmed bugs here, and a lot which actually needs not be
here.
This should be a place for really annoying bugs.
--
Configure bugmail: https://bugs.freedesktop.org/userp
On 13 April 2012 15:58, David Ostrovsky wrote:
>
> Hi Matúš,
>
> this patch should fix the missing key in hash on Macos build [1]:
>
> illegal combination app/SDKBIN/URELIB at
> /Volumes/TBRAM/core/solenv/bin/macosx-change-install-names.pl line 70,
> line 2.
Nice catch, I think it will help, p
On Thursday 12 of April 2012, Miklos Vajna wrote:
> Hi,
>
> See
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=f4e0cba
>
> I'm attaching a backport of the fix for 3-5.
Pushed.
--
Lubos Lunak
l.lu...@suse.cz
___
LibreOffice mailing list
Li
On 13 April 2012 16:07, Matúš Kukan wrote:
> On 13 April 2012 15:58, David Ostrovsky wrote:
>> Unfortunatelly I don't have Mac and can not test it ;-(
>
> We'll see.
So, we forgot about dmake using SDK. Sorry, this was wrong:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0c80ad06fd96a4
On Thursday 12 of April 2012, Matúš Kukan wrote:
> Maybe it is better to just let check target depend on build target ?
> In general.
Do you mean making the toplevel targets depend on each other, or also in each
module?
If this is meant to be also for all modules, wouldn't this possibly still
Hi,
"the scripts "download" and "unpack-sources" needed some changes to work
with the newly generated .xz source tarballs, see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=f780859b76263638b9227122e465b0c629c7ca3e
I would be nice to get this into 3-5 branch. It can't make things worse
b
On Thursday 12 of April 2012, Rene Engelhard wrote:
> On Thu, Apr 12, 2012 at 09:13:30PM +0200, Matúš Kukan wrote:
> > Or do people use make check with demand to build only what is
> > necessary for tests and nothing more ?
>
> Well, make check is for after a successful build to check the result, n
Hello,
This makes you eligible for the Google Summer of Code. This is not meant
that you are chosen, but your application is valid and will be
considered in the mentor meeting.
Thanks
Fridrich
On 13/04/12 15:20, Коростіль Данило wrote:
> Hello gentlemen,
>
> Sorry again for delay. I was reall
Thank you!
So shouldn't I send more patches?
LOL: I've made mistake s/defeating/defending/ at my original mail.
On 04/13/2012 04:35 PM, Fridrich Strba wrote:
Hello,
This makes you eligible for the Google Summer of Code. This is not meant
that you are chosen, but your application is valid and
On Thursday 12 of April 2012, Rafael Dominguez wrote:
> More cleanup of related functions.
> I changed IterateBookmarkPages method to be a local function since its used
> only in drawdoc3.cxx
> 0010-Remove-unused-InsertBookmarkAsPage_AddBookmarkedPage.patch
>
> 0011-Refactor-SdDrawDocument-IterateB
On Fri, 2012-04-13 at 12:21 +0200, Matúš Kukan wrote:
> Anyway with this patch I was able to build in /home,
Cool, seems to be working for me too, which is great, as that really
bugged me.
> Could someone, please, try ?
> I think we could remove new warning from
> http://wiki.documentfoundation.
Hi,
I have needed to do some changes to handle the new filelists in LO-3.5,
see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=d04e30c94a0d041ecd3d68b5fcf7e7c9ba1df735
I think that it might be useful for others as well and would make sense
to push it into 3-5 branch. On the other hand, I
Hi,
On Fri, Apr 13, 2012 at 05:14:42PM +0200, Petr Mladek wrote:
> I have needed to do some changes to handle the new filelists in LO-3.5,
> see
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=d04e30c94a0d041ecd3d68b5fcf7e7c9ba1df735
I don't think this is %config.
Or at least *if* it's
Hello Petr,
On Fri, Apr 13, 2012 at 21:34, Petr Mladek wrote:
> "the scripts "download" and "unpack-sources" needed some changes to work
> with the newly generated .xz source tarballs, see
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=f780859b76263638b9227122e465b0c629c7ca3e
I don't
Hello again Petr,
On Fri, Apr 13, 2012 at 21:34, Petr Mladek wrote:
> "the scripts "download" and "unpack-sources" needed some changes to work
> with the newly generated .xz source tarballs [snip]
And I think that ./unpack-sources line 87 should be removed as well.
Because we don't have 'bootstr
On Fri, Apr 13, 2012 at 04:35:27PM +0200, Lubos Lunak wrote:
> On Thursday 12 of April 2012, Rene Engelhard wrote:
> > On Thu, Apr 12, 2012 at 09:13:30PM +0200, Matúš Kukan wrote:
> > > Or do people use make check with demand to build only what is
> > > necessary for tests and nothing more ?
> >
>
Rene Engelhard píše v Pá 13. 04. 2012 v 17:17 +0200:
> Hi,
>
> On Fri, Apr 13, 2012 at 05:14:42PM +0200, Petr Mladek wrote:
> > I have needed to do some changes to handle the new filelists in LO-3.5,
> > see
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=d04e30c94a0d041ecd3d68b5fcf7e7
Korrawit Pruegsanusak píše v Pá 13. 04. 2012 v 22:40 +0700:
> Hello again Petr,
>
> On Fri, Apr 13, 2012 at 21:34, Petr Mladek wrote:
> > "the scripts "download" and "unpack-sources" needed some changes to work
> > with the newly generated .xz source tarballs [snip]
>
> And I think that ./unpack
On Fri, Apr 13, 2012 at 05:51:44PM +0200, Petr Mladek wrote:
> > I don't think this is %config.
> > Or at least *if* it's config it should be in /etc. I have it in /var.
> > But 100% not in /usr :-)
>
> How do you move this file to /var? Is it a hack or a clean solution?
> The LO installation is f
On Thu, 2012-04-12 at 21:40 +0200, Albert Thuswaldner wrote:
> Hi Kohei,
> Here is the other patch of re-factoring the options code, this time is
> the defaults options which I moved from ScDocOptions into a separate
> class.
Hi Albert,
Reviewed and pushed to master. Not much to say really. :-)
On Fri, Apr 13, 2012 at 8:15 AM, Caolán McNamara wrote:
>> Yes. Some of my changes were an attempt to address that
>
> ok, plan b, reorganize matters so that we bootstrap the initial uno
> component context once before all tests, and dispose it once after all
> tests are complete. Rather than se
On 13 April 2012 16:32, Lubos Lunak wrote:
> On Thursday 12 of April 2012, Matúš Kukan wrote:
>> Maybe it is better to just let check target depend on build target ?
>> In general.
>
> Do you mean making the toplevel targets depend on each other, or also in each
> module?
I mean to add into gbui
On Friday 13 of April 2012, Rene Engelhard wrote:
> On Fri, Apr 13, 2012 at 04:35:27PM +0200, Lubos Lunak wrote:
> > On Thursday 12 of April 2012, Rene Engelhard wrote:
> > > On Thu, Apr 12, 2012 at 09:13:30PM +0200, Matúš Kukan wrote:
> > > > Or do people use make check with demand to build only w
Petr Mladek píše v Pá 13. 04. 2012 v 18:00 +0200:
> Korrawit Pruegsanusak píše v Pá 13. 04. 2012 v 22:40 +0700:
> > Hello again Petr,
> >
> > On Fri, Apr 13, 2012 at 21:34, Petr Mladek wrote:
> > > "the scripts "download" and "unpack-sources" needed some changes to work
> > > with the newly gener
On Friday 13 of April 2012, Matúš Kukan wrote:
> On 13 April 2012 16:32, Lubos Lunak wrote:
> > On Thursday 12 of April 2012, Matúš Kukan wrote:
> >> Maybe it is better to just let check target depend on build target ?
> >> In general.
> >
> > Do you mean making the toplevel targets depend on eac
On Thursday 12 of April 2012, Rafael Dominguez wrote:
> This are the hardest ones to port, since the rExchangeList parameter uses
> the last position from InsertBookmarkAsPage in InsertBookmarkAsObject, so
> the best idea i came up with to avoid doing nasty stuffs was erase procesed
> objects in In
On Thursday 12 of April 2012, Rafael Dominguez wrote:
> Last patches, to test the Bookmark related functions, you need to insert
> another presentation or parts of a presentation by going into Insert->File.
>
> Thanks for checking all the patches!!!
I have pushed all the remaining patches in this
Hey Tor
As requested I squashed these patches into a single patch and commit :)
will try and generate larger patches for submission instead of small
commits on the local branch and multiple patches :)
All my contributions past present and future are licensed according to
the licenses used by
On 13 April 2012 18:38, Lubos Lunak wrote:
> On Friday 13 of April 2012, Matúš Kukan wrote:
>> Note that the modules' dependencies (in the sense: first build sal then
>> cppu) are written in /prj/build.lst and build.pl reads them.
>
> Does this mean that if there is a build race condition in chec
On Friday 13 of April 2012, Stephan Bergmann wrote:
> On 04/12/2012 03:59 PM, Lubos Lunak wrote:
> > would somebody see a problem with this?
> >
> > sal/inc/rtl/ustring.hxx :
> > +#ifdef RTL_AUTOMATIC_USING
> > +using ::rtl::OUString;
> > +using ::rtl::OStringToOUString;
> > +using ::rtl::OUStrin
On Friday 13 of April 2012, Bjoern Michaelsen wrote:
> I tend to agree on all points. If something like that is essential, we
> could have something like a:
> salhelper/inc/rtl/stringhelper.hxx:
> #include
> using ::rtl::OUString;
> using ::rtl::OStringToOUString;
> using ::rtl::OUStringToOString;
Hi all,
On 13 April 2012 18:21, Matúš Kukan wrote:
> Bjoern, what do you think about attached patch ?
> I left subsequentcheck untouched for now.
Oh no, it won't work in new gbuild world where we can do:
make -rs -j 4 $(WORKDIR)/Module/check/sw
or anything, from clean.
That's something as Lubos
On Fri, 2012-04-13 at 12:14 -0400, Kohei Yoshida wrote:
> On Fri, Apr 13, 2012 at 8:15 AM, Caolán McNamara wrote:
> > reenabled editeng test again, and await inevitable fallout on some
> > platform or other.
>
> Keeping my fingers crossed. :-)
Inevitable platform fallout on windows happened, now
Remove debug dumping facility from basebmp.
0001-Remove-unused-debug-facilities-from-basebmp.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Remove unused functions from basegfx's polygon tools.
0001-Clean-up-basegfx-s-polygon-tools-code.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Fri, 2012-04-13 at 15:03 +0200, Michael Meeks wrote:
> The basic idea is to push the iteration over directories down into the
> stoc/ code instead of having it in the cppuhelper code. That lets us
> re-use the same representation avoiding the nesting[1]. I guess it is
> the moral equivale
74 matches
Mail list logo
