Question about function SwAttrSet::GetPresentation (sw/source/ui/utlui/attrdesc.cxx)

Hello, By looking in the last fix commits, I sometimes "opengrok" to see if the same kind of initial problem solved by the fix could be found. Then I read this code : 71 // query the attribute descriptions 72 void SwAttrSet::GetPresentation( 73 SfxItemPresentation ePres,

Re: [REVIEW 3-5-5 (2/3)][PUSHED 3-5] fdo#50603: Close fds across a restart of soffice on Mac OS X

On 06/19/2012 04:20 PM, Michael Meeks wrote: On Tue, 2012-06-19 at 15:43 +0200, Stephan Bergmann wrote: On 06/19/2012 02:52 PM, Michael Meeks wrote: It -looks- like you do this on every startup, when in fact we really only want to do it -before- we run 'exec' in this rather rare re-star

Re: [REVIEW 3-5-5 (2/3)][PUSHED 3-5] fdo#50603: Close fds across a restart of soffice on Mac OS X

On 06/20/2012 08:41 AM, Stephan Bergmann wrote: On 06/19/2012 04:20 PM, Michael Meeks wrote: if (!fork()) { // close all sockets exec (...); } Would presumably do what we want (?) :-) No, the whole exercise (with exec from self on Mac OS X) is only there to prevent forking in the first place

Re: Possible change to the "Native Build" page?

On Wed, 2012-06-20 at 08:11 +0800, Phil Hart wrote: > compile: > [javac] > /home/phil/git/libo/tomcat/unxlngx6.pro/misc/build/jakarta-tomcat-5.0.30-src/jakarta-servletapi-5/jsr154/build.xml:67: > > warning: 'includeantruntime' was not set, defaulting to > build.sysclasspath=last; set to fa

Re: Question about function SwAttrSet::GetPresentation (sw/source/ui/utlui/attrdesc.cxx)

Hi, On Wed, Jun 20, 2012 at 8:16 AM, julien2412 wrote: > Hello, > > By looking in the last fix commits, I sometimes "opengrok" to see if the > same kind of initial problem solved by the fix could be found. > > Then I read this code : >     71 // query the attribute descriptions >     72 void SwAt

Re: Question about function SwAttrSet::GetPresentation (sw/source/ui/utlui/attrdesc.cxx)

On Wed, Jun 20, 2012 at 09:17:16AM +0200, Tomaž Vajngerl wrote: > As far as I can see by just looking at this snippet of code this is > needed because rText would be ", ... , ... , ..." instead of "... , > ... , ..." if you omit rText.Len() from the if statement. In other > words.. the rText.Len(

Re: [GSOC] how to fetch document/templates properties

Hi Rafael, On Wed, Jun 20, 2012 at 12:24:51AM -0430, Rafael Dominguez wrote: > Im trying to fetch document properties like author, creation date, > application that created it, etc, from a document or template stored in the > filesystem that arent loaded, to get the templates from the filesystem

test building a gerrit patch using tinbuild2

I have pushed improvement to tinbuild2 to allow to automotate the test building of gerrit patcheset. prereq: + having tinbuild2 (clone contrib/buildbot) + having configured it. (see README.tinbuild2 (*)). I suggest defining a profile 'gerrit' with a ~/.tinbuild/autogen/gerrit.autogen such as the

Re: [GSOC] how to fetch document/templates properties

It is possible to load document properties from a file on disk. You may find this of interest: http://www.oooforum.org/forum/viewtopic.phtml?t=94527 On 06/20/2012 12:54 AM, Rafael Dominguez wrote: Im trying to fetch document properties like author, creation date, application that created it

Re: [PUSHED 3-5][REVIEW-3-5-5] Use after delete in oox

On Tue, Jun 19, 2012 at 10:32:38PM +0200, Eike Rathke wrote: > Two more reviews needed for 3-5-5 Looks reasonable, +1. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED 3-5][REVIEW-3-5-5] Use after delete in oox

+1 from me too, one more person neede. F. On 19/06/12 22:32, Eike Rathke wrote: > Hi Lubos, > > On Tuesday, 2012-06-19 15:20:40 +0200, Lubos Lunak wrote: > >> please review and backport to 3-5 and 3-5-5 the attached patch. > > Looks sensible, pushed to 3-5 > Two more reviews needed for 3-5-5

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - wizards/com

wizards/com/sun/star/wizards/form/StyleApplier.java |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ca28a2430e392d7a7fe6f636da446095e55c3676 Author: Lionel Elie Mamane Date: Thu Nov 24 19:37:46 2011 +0100 fdo#37626: form wizard recognise "#" also at beginning

Re: [PATCH] [PUSHED:3-5] fdo#37626 form wizard does not apply background colour from style

I trust you and pushed it to libreoffice-3-5 f. On 20/06/12 06:44, Lionel Elie Mamane wrote: > My fix for fdo#37626 was reverted by > > commit b35b7080980c0ba43f411db469feb30f8a5c6881 > Author: Michael Meeks > Date: Fri Dec 2 17:15:48 2011 + > > pywizards: resurrect Xisco's code lost

[Libreoffice-commits] .: 2 commits - qadevOOo/runner qadevOOo/tests

qadevOOo/runner/complexlib/Assurance.java |6 +++--- qadevOOo/runner/complexlib/ComplexTestCase.java |2 +- qadevOOo/runner/complexlib/MethodThread.java|9 + qadevOOo/runner/graphical/GlobalLogWriter.java |4 qadevOOo/tests/java/ifc/ucb/_XSim

[PUSHED] fix some java deprecation warnings in qadevOOo module

Pushed it to master. F. On 19/06/12 16:35, Noel Grandin wrote: > Hi > > Since the qadevOOo module seems to require java 1.5, I updated a couple > of places to remove some deprecation warnings. > > Regards, Noel Grandin > > > ___ > LibreOffice mailin

[PUSHED] fix some java deprecation warnings in qadevOOo module

This is a duplicate email of the patches that I just pushed :) F. On 19/06/12 16:34, Noel Grandin wrote: > Hi > > Since the qadevOOo module seems to require java 1.5, I updated a couple > of places to remove some deprecation warnings. > > Regards, Noel Grandin > > Disclaimer: http://www.perale

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on||51247 --- Comment #334 from Rainer Bi

[Libreoffice-commits] Changes to 'feature/gsoc-calc-perf2'

New branch 'feature/gsoc-calc-perf2' available with the following commits: commit 12434dbd5d7e36154f88e1d17d36ce9b953c984f Author: Daniel Bankston Date: Tue Jun 19 16:42:54 2012 -0500 Clean up logic a bit for formula cell ODS import Made Markus's recommended changes for logic clean

[Libreoffice-commits] .: Branch 'features/base-preview' - sw/source

sw/source/ui/docvw/FrameControlsManager.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit a2c9059f4137b208842786d37903722c60df202e Author: Lionel Elie Mamane Date: Wed Jun 20 10:49:14 2012 +0200 fdo#51243 infinite loop in SwFrameControlsManager::SetReadonlyControls

[Libreoffice-commits] .: i18npool/inc i18npool/source svtools/source

i18npool/inc/i18npool/lang.h|2 ++ i18npool/source/isolang/isolang.cxx |2 ++ svtools/source/misc/langtab.src |2 ++ 3 files changed, 6 insertions(+) New commits: commit bb6fec1bd39be9f6d660623abd2b25400a34b9ac Author: Eike Rathke Date: Wed Jun 20 10:40:43 2012 +0200

Re: Difficulties with Flat XML under source control

On Tue, Jun 19, 2012 at 07:56:08PM +0200, Johannes Sixt wrote: > > The code to poke at is in: > > > > xmloff/ > > and > > sw/source/filter/xml/ > > Been there, done that. But it's way over my head (and time budget). See > > http://thread.gmane.org/gmane.comp.documentfoundation.libre

Re: [PUSHED 3-5][PUSHED-3-5-5] Use after delete in oox

On Wed, Jun 20, 2012 at 10:03:58AM +0200, Miklos Vajna wrote: > On Tue, Jun 19, 2012 at 10:32:38PM +0200, Eike Rathke > wrote: > > Two more reviews needed for 3-5-5 > > Looks reasonable, +1. Forgot to set subject. ___ LibreOffice mailing list LibreOf

[Libreoffice-commits] .: Branch 'libreoffice-3-5-5' - oox/inc oox/source

oox/inc/oox/vml/vmlshapecontainer.hxx|2 +- oox/source/shape/ShapeContextHandler.cxx |2 +- oox/source/vml/vmlshapecontainer.cxx |6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 2d914ff7c6e7c628db22a1e1984c65fc75082289 Author: Luboš Luňák Dat

Re: Cleaning bug list

Hi Joel, Joel Madero píše v Út 19. 06. 2012 v 13:36 -0700: > I moved this to a new thread because the subject here didn't really > accurately portray the direction of the conversation The mail includes many good questions and proposals that might move us forward. I'll try to answer it later this

Re: [ANN] Please use Gerrit from now on for Patch Review

On Mon, Jun 18, 2012 at 12:09:49PM +0200, Bjoern Michaelsen wrote: > http://sweetshark.livejournal.com/13298.html > gerrit is documented and ready to go. It refuses to take patches (commits) whose author field is not an email address registered in my account. How do I submit for review a patch

[PATCH] [REVIEW:3-5] fdo#51243 freeze regression in 3.5.5 wrt to 3.5.4 infinite loope

fdo#51243 caused by error in fix to fdo#48932, which introduced infinite loop, and thus from the user's POV a freeze of the whole LibO process. Not visible in the patch, here's the code affected: void SwFrameControlsManager::SetReadonlyControls( bool bReadonly ) { map< FrameControlType, SwFra

[REVIEW:3-5] fdo#50087 fix RTF import of Title, Subject, Comments document properties

Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=629001d Regression from 3.4; backported patch attached. (Also on gerrit: https://gerrit.libreoffice.org/228) Thanks, Miklos >From 3b7c3ede59b0cdd7ff739c94c17382002f41b687 Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Fri, 15 J

Re: [ANN] Please use Gerrit from now on for Patch Review

On Wed, Jun 20, 2012 at 4:21 AM, Lionel Elie Mamane wrote: > On Mon, Jun 18, 2012 at 12:09:49PM +0200, Bjoern Michaelsen wrote: > >>  http://sweetshark.livejournal.com/13298.html > >> gerrit is documented and ready to go. > > It refuses to take patches (commits) whose author field is not an > emai

Re: [PATCH] [REVIEW:3-5] fdo#51243 freeze regression in 3.5.5 wrt to 3.5.4 infinite loope

On Wed, Jun 20, 2012 at 11:27:25AM +0200, Lionel Elie Mamane wrote: > fdo#51243 caused by error in fix to fdo#48932, which introduced > infinite loop, and thus from the user's POV a freeze of the whole LibO > process. Interestingly, the error is in the backport to libreoffice-3-5; the original com

Re: Possible change to the "Native Build" page?

On 20/06/2012 2:57 PM, Caolán McNamara wrote: On Wed, 2012-06-20 at 08:11 +0800, Phil Hart wrote: compile: [javac] /home/phil/git/libo/tomcat/unxlngx6.pro/misc/build/jakarta-tomcat-5.0.30-src/jakarta-servletapi-5/jsr154/build.xml:67: warning: 'includeantruntime' was not set, defaulting to

Using system libsqlite3.dylib on Mac OS X? (fdo#50682)

Hi all, "On MacOS X 10.7, 'import uno' crashes in the LibreOffice-provided Python" discusses a problem that is due to our "official" LO Mac OS X builds (based on 10.4 SDK) bringing along their own copy of libsqlite3.dylib instead of using t

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on||51253 --- Comment #335 from Rainer Bi

Re: Possible change to the "Native Build" page?

It's look like you're using GCJ instead of a regular java VM, which is probably the cause of your problems. On 2012-06-20 09:37, Phil Hart wrote: export JAVALIB=-L/usr/lib64/jvm/java-1.5.0-gcj/lib64 export JAVA_HOME=/usr/lib64/jvm/java-1.5.0-gcj Disclaimer: http://www.peralex.com/disclaimer

[Libreoffice-commits] .: android/experimental

android/experimental/DocumentLoader/src/org/libreoffice/android/examples/DocumentLoader.java | 78 +++--- 1 file changed, 31 insertions(+), 47 deletions(-) New commits: commit f3748935be05ae0508bcd3d0ddb8553b58d09166 Author: Tor Lillqvist Date: Wed Jun 20 12:35:07 2012 +0300 Furth

[Libreoffice-commits] .: i18npool/Library_localedata_others.mk i18npool/source

i18npool/Library_localedata_others.mk |1 i18npool/source/localedata/data/pap_CW.xml | 358 + i18npool/source/localedata/localedata.cxx |3 3 files changed, 361 insertions(+), 1 deletion(-) New commits: commit d8db97f8b03e7e3d29f9d9a6bfa5f36de50aeb36 A

Re: Possible change to the "Native Build" page?

On 20/06/2012 5:47 PM, Noel Grandin wrote: It's look like you're using GCJ instead of a regular java VM, which is probably the cause of your problems. On 2012-06-20 09:37, Phil Hart wrote: export JAVALIB=-L/usr/lib64/jvm/java-1.5.0-gcj/lib64 export JAVA_HOME=/usr/lib64/jvm/java-1.5.0-gcj D

[Libreoffice-commits] .: sc/qa

sc/qa/unit/subsequent_filters-test.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 029c367d06d5af3fe26bebfe02eadac295331fc2 Author: Markus Mohrhard Date: Wed Jun 20 12:16:34 2012 +0200 disable this test for now, fails on windows due to row height problem

Re: [ANN] Please use Gerrit from now on for Patch Review

On Wed, Jun 20, 2012 at 04:31:21AM -0500, Norbert Thiebaud wrote: > On Wed, Jun 20, 2012 at 4:21 AM, Lionel Elie Mamane wrote: >> On Mon, Jun 18, 2012 at 12:09:49PM +0200, Bjoern Michaelsen wrote: >>> gerrit is documented and ready to go. >> It refuses to take patches (commits) whose author fiel

Re: Possible change to the "Native Build" page?

On Wed, Jun 20, 2012 at 05:57:45PM +0800, Phil Hart wrote: > Does that mean that it might be useful to other newbies (I am one!) > to advise them that openSUSE 12.1 has this issue, and to use the > work-around as per the start of this thread? http://wiki.documentfoundation.org/Development/Linux_

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 3 commits - connectivity/Library_dbtools.mk connectivity/source

connectivity/Library_dbtools.mk |2 ++ connectivity/source/parse/sqlbison.y |8 +++- 2 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 7986c0368cdbb642d91c0293647d16a7c218c867 Author: Christian Lohmaier Date: Fri Jun 15 01:31:46 2012 +0200 ancient bison

[Libreoffice-commits] .: writerfilter/source

writerfilter/source/dmapper/OLEHandler.cxx | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) New commits: commit 9390507bfcd21063f549166f302536f5c372a477 Author: Miklos Vajna Date: Wed Jun 20 12:46:45 2012 +0200 n#758883 dmapper: set wrap mode even if determining the

[Libreoffice-commits] .: 2 commits - sw/source

sw/source/core/text/frmform.cxx | 24 ++--- sw/source/core/text/frmpaint.cxx | 66 +++- sw/source/core/text/inftxt.cxx | 74 -- sw/source/core/text/inftxt.hxx | 158 +++ 4 files changed, 155 insertions(+), 167 deletions(-)

[Libreoffice-commits] .: 2 commits - extensions/source filter/source sc/source sd/source sw/source unusedcode.easy vcl/generic vcl/inc vcl/source

extensions/source/propctrlr/standardcontrol.cxx |3 filter/source/msfilter/msdffimp.cxx | 10 - filter/source/msfilter/svdfppt.cxx | 13 - sc/source/ui/docshell/impex.cxx |4 sd/source/filter/ppt/propread.cxx |6 sw/source/c

[Libreoffice-commits] .: sw/source

sw/source/core/tox/tox.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 29d53d239066f967155e61aebc9cc3984756eb16 Author: Philipp Weissenbacher Date: Wed Jun 20 13:12:02 2012 +0200 Fix some sloppiness Change-Id: Ie91b4fb5c3b1916701199f3f787b11

[Libreoffice-commits] .: sw/source

sw/source/core/doc/docfly.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 017a82c50c338a4304ca0b945ed04c7d2d62f1d5 Author: Miklos Vajna Date: Wed Jun 20 13:24:17 2012 +0200 SwDoc::SetFlyFrmAnchor: fix crash when SwTxtNode has no hints Change-Id:

Re: How to integrate an image into the source tree

On Mon, 2012-06-18 at 21:08 +0200, Cedric Bosdonnat wrote: > Could you show a snippet of your code trying to load the image? It won't > be easy to help you otherwise ;) Rafael solved it - but replied saying so only to me :-) There is some level of run-time issue, whereby it's nec

[Libreoffice-commits] .: cui/source

cui/source/options/certpath.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e41a630bc8aa93a104d56820862e28386805197a Author: Caolán McNamara Date: Wed Jun 20 12:42:52 2012 +0100 make space for radiobuttons in cert dialog a bit bigger Change-Id: I

Re: [ANN] Please use Gerrit from now on for Patch Review

On Wed, Jun 20, 2012 at 12:26:23PM +0200, Lionel Elie Mamane wrote: > Ah, I understand. When the gerrit repos are the "true one source" and > gerrit will do the "push" automatically once someone validates the > patch in the web interface, what will "Committer" be? The one that > uploaded the patch

Re: [Libreoffice-commits] .: sw/source

On Wednesday 20 of June 2012, Miklos Vajna wrote: > sw/source/core/doc/docfly.cxx |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > New commits: > commit 017a82c50c338a4304ca0b945ed04c7d2d62f1d5 > Author: Miklos Vajna > Date: Wed Jun 20 13:24:17 2012 +0200 > > SwDoc::SetFlyFr

Re: How to integrate an image into the source tree

On Wed, 2012-06-20 at 12:36 +0100, Michael Meeks wrote: > On Mon, 2012-06-18 at 21:08 +0200, Cedric Bosdonnat wrote: > > Could you show a snippet of your code trying to load the image? It won't > > be easy to help you otherwise ;) > > Rafael solved it - but replied saying so only to me :-) >

Re: [Libreoffice-commits] .: sw/source

On Wed, Jun 20, 2012 at 01:45:32PM +0200, Lubos Lunak wrote: > > -const_cast(pHnt->GetFlyCnt()).SetFlyFmt(); > > +if (pHnt) > > +const_cast(pHnt->GetFlyCnt()).SetFlyFmt(); > > I think this is a sign of internal inconsistency. I had a similar problem > leading to 5de6

Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review

On 06/19/2012 09:32 PM, David Ostrovsky wrote: On 19.06.2012 19:24, Petr Mladek wrote: Sounds good but how many people would know about the comments? How hard would be to find them? https://gerrit.libreoffice.org/#/c/179/4/ (may be you need to login into gerrit with your openId) You can see it

[Libreoffice-commits] .: Branch 'feature/pdf-signing' - vcl/source

vcl/source/gdi/pdfwriter_impl.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 4ef8a04b6a11bed9f83685242672492c6d723d9d Author: Gökçen Eraslan Date: Wed Jun 20 15:10:48 2012 +0300 Add a fake appearance dictionary to Sig object. Change-Id: Ibd8f6232b0121de6951e

Re: Possible change to the "Native Build" page?

On Wed, 2012-06-20 at 15:37 +0800, Phil Hart wrote: > Answers: > > phil@linux-012k:~/Downloads/libreoffice-core-3.5.99.1> grep JAVA > config_host.mk > export JAVALIB=-L/usr/lib64/jvm/java-1.5.0-gcj/lib64 > export JAVA_HOME=/usr/lib64/jvm/java-1.5.0-gcj > export JAVA_SOURCE_VER=1.6 > export JAVA_T

[Libreoffice-commits] .: 3 commits - android/experimental odk/examples

android/experimental/DocumentLoader/src/org/libreoffice/android/examples/DocumentLoader.java | 81 ++ odk/examples/java/DocumentHandling/test/test1.odt |binary 2 files changed, 50 insertions(+), 31 deletions(-) New commits: commit 785221e74

[Libreoffice-commits] .: 4 commits - vcl/source vcl/win

vcl/source/window/menu.cxx | 11 - vcl/win/source/gdi/salnativewidgets-luna.cxx | 273 +++ 2 files changed, 210 insertions(+), 74 deletions(-) New commits: commit ff367eb669686c80cd5f0931cf0adf81d02f49e0 Author: Jan Holesovsky Date: Wed Jun 20 14:17

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 4 commits - vcl/source vcl/win

vcl/source/window/menu.cxx | 11 - vcl/win/source/gdi/salnativewidgets-luna.cxx | 273 +++ 2 files changed, 210 insertions(+), 74 deletions(-) New commits: commit 6bc7cc692977431d1873dea0dd4c2636a6735eaa Author: Jan Holesovsky Date: Wed Jun 20 14:17

Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review

On Wed, Jun 20, 2012 at 02:11:31PM +0200, Stephan Bergmann wrote: > Still, this removes the comments from many people's (potential) > sight. The IMO big advantage of the "everything on a single mailing > list" approach is that everybody is forced ;) to see everything > (modulo information overload)

[GSOC] Weekly report

This week i ported the drawing code from the vcl API to use the drawinglayer one, refactored the ThumbnailView class into a more general purpose one, making it possible to customize it if needed by a subclass, after that i created two subclasses, one for displaying the templates folders and another

Re: How to integrate an image into the source tree

I guess i hitted the wrong button, but thanks again all for the help ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] use dash parameters from svg file

Fridrich Strba wrote: > > As far as I can see now the emulated style id in the internal-style-ref > > attribute isn't used anywhere (id following after '$'). Keep it or > > remove it? > > No idea. Thorsten? > Didn't try it, but: that style should be referenced by the shape later, otherwise, what'

[Libreoffice-commits] .: 13 commits - desktop/source vcl/inc vcl/source vcl/unx vcl/win

desktop/source/app/officeipcthread.cxx |9 +- desktop/source/app/officeipcthread.hxx |2 vcl/inc/aqua/saldata.hxx |1 vcl/inc/ios/saldata.hxx|1 vcl/inc/salsession.hxx |8 +- vcl/inc/svdata.hxx | 13 vc

[Libreoffice-commits] .: Branch 'feature/pdf-signing' - vcl/source

vcl/source/gdi/pdfwriter_impl.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 9ad3203bc1585085c70b026465de1fdc27d1a3a2 Author: Gökçen Eraslan Date: Wed Jun 20 15:46:13 2012 +0300 Fix the calculation of ByteRange values. Change-Id: I1d386f3

Re: [PATCH] Fixed out of bounds memory access

On 06/18/2012 05:50 PM, Caolán McNamara wrote: I bet this is one if the false-positive occasions where valgrind isn't aware of one of the strlen performance hacks IIRC where glibc knows that it can get away with traversing that strdup's memory block in 4byte chunks in its strlen e.g. someone with

Re: Difficulties with Flat XML under source control

Johannes Sixt wrote: > >> - Measurements change. E.g. (just to pick one case), in > >> the draw:visible-area-width changes from > >> 6.088cm to 6.089cm. Is there a remedy to avoid changes of this kind? > > > > Ah; nasty, some rounding problem / internal representation issue - > > possibly aga

[Libreoffice-commits] .: unotools/source

unotools/source/i18n/localedatawrapper.cxx | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) New commits: commit 209f1cdc933e42d097c03b35cbf8a6f7d52314b4 Author: Eike Rathke Date: Wed Jun 20 14:49:56 2012 +0200 adapt callers of getCurrFormatsImpl() to changes

Re: [ANN] Please use Gerrit from now on for Patch Review

On Tuesday 19 of June 2012, Bjoern Michaelsen wrote: > On Tue, Jun 19, 2012 at 05:04:58PM +0200, Lubos Lunak wrote: > > Which is the problem. Besides asking just to do that it should have also > > said why one should do that. I'm one of the people who haven't done that, > > because 'Do it because.

Re: Using system libsqlite3.dylib on Mac OS X? (fdo#50682)

Stephan Bergmann wrote: > Can anyone with access to a baseline Mac OS X 10.4 system check > whether adapting this fix to always build against system > libsqlite3.dylib on Mac OS X would work? > Sorry, I don't have access to a 10.4 system anymore. Cheers, -- Thorsten pgpzJ8ngDk6Fh.pgp Descriptio

[PUSHED:3-5] fdo#51243 freeze regression in 3.5.5 wrt to 3.5.4 infinite loope

Pushed to 3-5 F. On 20/06/12 11:35, Lionel Elie Mamane wrote: > On Wed, Jun 20, 2012 at 11:27:25AM +0200, Lionel Elie Mamane wrote: >> fdo#51243 caused by error in fix to fdo#48932, which introduced >> infinite loop, and thus from the user's POV a freeze of the whole LibO >> process. > > Interes

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sw/source

sw/source/ui/docvw/FrameControlsManager.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit fa84c91b85b6934b21b02b07de1409be38425229 Author: Lionel Elie Mamane Date: Wed Jun 20 10:49:14 2012 +0200 fdo#51243 infinite loop in SwFrameControlsManager::SetReadonlyControls

Re: Help in fixing gradient bug

Aakriti Gupta wrote: > Which files do I look into for exporting of embedded documents in pdfs, > e.g. charts inserted in a presentation to be exported to pdf? This bug > seems to be higher on our priority list. > Hi there, it's the same backend code that I referenced in my earlier email - it all

Re: [ANN] Please use Gerrit from now on for Patch Review

On Wed, Jun 20, 2012 at 02:55:53PM +0200, Lubos Lunak wrote: > If you don't want people to miss important information, you need to announce > it properly and not as some offhand remark. A mail with "ACTION REQUIRED" in the subject is not an offhand remark. Having called it out with vigor in the

Re: Precompiled headers?

On Tuesday 19 of June 2012, Bjoern Michaelsen wrote: > On Tue, Jun 19, 2012 at 02:32:23PM +0200, Lubos Lunak wrote: > > does somebody know why support for precompiled headers has been removed > > from LibreOffice? > > So back in the days: > - lack of an insanely fast windows tinderbox > - most peo

Re: [REVIEW 3-5-5 (2/3)][PUSHED 3-5] fdo#50603: Close fds across a restart of soffice on Mac OS X

On Wed, 2012-06-20 at 08:45 +0200, Stephan Bergmann wrote: > What would work, btw, is to rather exec some helper app that closes all > fds and then in turn execs soffice. But I ditched that in favor of the > simpler solution. Yep - or pass some parameter: 'close-fds' ;-) but I think we

Re: Using system libsqlite3.dylib on Mac OS X? (fdo#50682)

On 06/20/2012 11:37 AM, Stephan Bergmann wrote: Can anyone with access to a baseline Mac OS X 10.4 system check whether adapting this fix to always build against system libsqlite3.dylib on Mac OS X would work? (And does anybody know what LO functionality would need to be checked for regressions?)

Re: [ANN] Please use Gerrit from now on for Patch Review

On Wed, Jun 20, 2012 at 5:26 AM, Lionel Elie Mamane wrote: > Ah, I understand. When the gerrit repos are the "true one source" and > gerrit will do the "push" automatically once someone validates the > patch in the web interface, what will "Committer" be? The one that > uploaded the patch or the

Re: Precompiled headers?

On Wed, Jun 20, 2012 at 03:19:53PM +0200, Lubos Lunak wrote: > I know that PCH builds can break non-PCH (because of missing required > #includes), but how can it break the other way around, given that PCH is some > kind of extra? The only thing I'm aware of is MSVC requiring explicit > #include

fdo 50950 make (ISO)WEEKNUM comply with ODFF1.2, advise asked

Hi Eike, I just uploaded a diff file and test document to bug50950. The ODFF1.2-compliant functions work and I would like some help from you with importing old-style formulas from documents saved with previous LibO versions. Your plan from June 7 (see below) seems clear to me, but I don't know wh

[patch] proposal of a patch to solve a crasher when saving a spreadsheet with track-change

Hello, At Lanedo, we have been working on a bug described here: https://bugs.freedesktop.org/show_bug.cgi?id=51249 We have been investigating this and our conclusion is that, when track-change is enabled, you can have a discrepancy between the "Styles" and the "Content" parts of your tables. My

Re: Difficulties with Flat XML under source control

Dennis E. Hamilton wrote: > For out-in (which this is, presumably), you want to record a > decimal expression of the internal value that will convert back to > the exact internal value on re-input. (The in-out case is that > the input conversion provide whatever internal representation that > will

[Libreoffice-commits] .: vcl/source

vcl/source/fontsubset/sft.cxx |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) New commits: commit c4a3adc99cf7dc6598c3851588d58d2701210277 Author: Christophe Christophe Marion Date: Mon Jun 18 22:10:27 2012 +0200 Remove some useless memset(0) diff --git a/vcl/source/fon

[PUSHED] - avoid some memset

On Mon, 2012-06-18 at 22:40 +0200, Marion & Christophe JAILLET wrote: > this patch removes some useless memset(..., 0, ...) of memory that has > been calloc'ated Thanks ! :-) looks nice, pushed. Regards, Michael. -- michael.me...@suse.com <><, Pseudo Engineer

[Libreoffice-commits] .: oox/source

oox/source/vml/vmlshape.cxx | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) New commits: commit f3ed8b8b152a16e8a6a8f11587ebd74c6dadad60 Author: Miklos Vajna Date: Wed Jun 20 15:41:57 2012 +0200 oox: mso-wrap-style is about wrapping mode fo

Re: Precompiled headers?

On Tue, Jun 19, 2012 at 7:32 AM, Lubos Lunak wrote: > >  Hello, > >  does somebody know why support for precompiled headers has been removed from > LibreOffice? > >  I couldn't find anything conclusive, repo log messages just say that it's > being done but not why, in list archives From memory, t

Re: [ANN] Please use Gerrit from now on for Patch Review

On Wednesday 20 of June 2012, Bjoern Michaelsen wrote: > On Wed, Jun 20, 2012 at 02:55:53PM +0200, Lubos Lunak wrote: > > If you don't want people to miss important information, you need to > > announce it properly and not as some offhand remark. > > A mail with "ACTION REQUIRED" in the subject is

[Libreoffice-commits] .: sw/source

sw/source/core/text/itradj.cxx | 143 ++--- 1 file changed, 66 insertions(+), 77 deletions(-) New commits: commit ccfc7bd12dd89f2ec4fd4e9339710ccb4c6532da Author: Philipp Weissenbacher Date: Wed Jun 20 16:07:56 2012 +0200 Translate German comments, fix

Re: Precompiled headers?

On Wednesday 20 of June 2012, Norbert Thiebaud wrote: > On Tue, Jun 19, 2012 at 7:32 AM, Lubos Lunak wrote: > >[...] PCH with > > MSVC avoid the performance hit of using many -I options (adding -I for > > each /inc adds 25% time for whatever reason, but only without > > PCH) > > ahh, so that is _n

Re: [ANN] Please use Gerrit from now on for Patch Review

On Wed, Jun 20, 2012 at 8:52 AM, Lubos Lunak wrote: > >  Besides, is every committer required to study ESC minutes? That is the _one_ message a week that, yes, every committer should read, or loose the right to complain about not being informed. Norbert _

[REVIEW 3-5-5] Re: [PUSHED:3-5] fdo#51243 freeze regression in 3.5.5 wrt to 3.5.4 infinite loope

On 20/06/12 15:11, Fridrich Strba wrote: > Pushed to 3-5 > > F. > > On 20/06/12 11:35, Lionel Elie Mamane wrote: >> On Wed, Jun 20, 2012 at 11:27:25AM +0200, Lionel Elie Mamane wrote: >>> fdo#51243 caused by error in fix to fdo#48932, which introduced >>> infinite loop, and thus from the user's P

Re: What is bibisect? And what is it doing in my office?

Jan Holesovsky wrote > > Hi, > On 2012-06-16 at 02:22 -0700, bfo wrote: > Not at all - it is even possible to generate a zipped installation, that > would be just unpacked, and checked into git; ie. nothing really hard to > do. But nobody has done that yet - are you interested? > If yes: The bes

Re: gerrit for release branches (bots ftw?)

Hi Bjoern, On 18.06.2012 17:27, Bjoern Michaelsen wrote: we might alternatively have either a email or an IRC bot, which you send a message like: releasereview 213d5355d78a0a690e366645d6416f4a8fe5e666 libroffice-3-5 and it will do all of the above on its own. Opinions on that? Is it better t

[PUSHED] Convert SV_DECL_PTRARR_DEL of Sw*Fmts to std vector

Pushed to master Thanks F. On 20/06/12 16:41, Noel Grandin wrote: > Hi > > This patch converts the various Sw*Fmts classes from using > SV_DECL_PTRARR macros to the STL collection classes. > > They all pass a full make check (and I compile with --enable-dbgutil) > > This patch is pretty big b

Re: [ANN] Please use Gerrit from now on for Patch Review

On Wed, Jun 20, 2012 at 03:52:11PM +0200, Lubos Lunak wrote: > Besides, is every committer required to study ESC minutes? Good question. IMHO not in general. But this is one of the rare occations, where I think making a difference between volunteers and full-time paid developers is sensible. I pe

[Libreoffice-commits] .: reportdesign/source

reportdesign/source/ui/inc/InsertFunctions.hxx | 46 - reportdesign/source/ui/report/ReportController.cxx |1 2 files changed, 47 deletions(-) New commits: commit bf729a27bdc4c5b9a3643862695d676f1324b20a Author: Takeshi Abe Date: Thu Jun 21 00:03:49 2012 +0900

Re: Cleaning bug list

Thanks for the advice. I thought I had included the qa list, my mistake. As for the length, I agree and I almost didn't include it but that was an email in response to mine so I felt a bit obligated to respond despite the length. I had another side question, the response to the thread was made her

Re: Cleaning bug list

Joel Madero píše v St 20. 06. 2012 v 08:08 -0700: > Thanks for the advice. I thought I had included the qa list, my > mistake. As for the length, I agree and I almost didn't include it but > that was an email in response to mine so I felt a bit obligated to > respond despite the length. If only I

[Libreoffice-commits] .: 2 commits - desktop/source sal/osl

desktop/source/app/app.cxx | 30 -- sal/osl/unx/signal.c |3 +-- 2 files changed, 9 insertions(+), 24 deletions(-) New commits: commit 104567a5340db731f08ee6eef03f0deef9e5118d Author: Stephan Bergmann Date: Wed Jun 20 17:57:02 2012 +0200 Show backin

[Bug 44446] LibreOffice 3.6 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=6 fabien.mic...@hespul.org changed: What|Removed |Added Depends on||40907 --- Comment #20 from fab

[Libreoffice-commits] .: sw/source

sw/source/core/doc/dbgoutsw.cxx | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) New commits: commit b64c730520204a6aa81e705532bb191450510519 Author: Stephan Bergmann Date: Wed Jun 20 18:18:43 2012 +0200 Adapt DBG_UTIL code to 1015cd4ff73ee25e55b4da8c8bc55a41e652d

Re: gerrit for release branches (bots ftw?)

Bjoern Michaelsen píše v Út 19. 06. 2012 v 21:27 +0200: > On Tue, Jun 19, 2012 at 07:57:30PM +0200, Petr Mladek wrote: > > One more idea. This is not easy to compare. I wonder if you could create > > a table when you will compare the basic operations side by side. I mean > > something like https://

  1   2   >