Re: Options included in CC/CXX vs. in gb_CFLAGS/gb_CXXFLAGS

2012-09-20 Thread Stephan Bergmann
On 09/20/2012 08:48 AM, Tor Lillqvist wrote: I think there is some fuzziness about what compiler options should be part of the CC/CXX variables and what should be in gb_CFLAGS/gb_CXXFLAGS. In some cases, like my Mac build tree that uses the 10.4 SDK, from Xcode 3 installed in /Xcode3, gb_CXXFLAG

[Libreoffice-commits] .: 2 commits - configure.in liborcus/ExternalProject_liborcus.mk liborcus/liborcus_0.1.0-warnings.patch liborcus/UnpackedTarball_orcus.mk solenv/gbuild solenv/inc

2012-09-20 Thread Libreoffice Gerrit user
configure.in | 12 liborcus/ExternalProject_liborcus.mk |2 - liborcus/UnpackedTarball_orcus.mk |2 - liborcus/liborcus_0.1.0-warnings.patch | 45 - solenv/gbuild/platform/macosx.mk |2 - solenv/inc/unx

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - pyuno/source

2012-09-20 Thread Libreoffice Gerrit user
pyuno/source/module/pyuno_runtime.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit ed39debbc379628ce74b096f7b7b179ab826551b Author: Stephan Bergmann Date: Fri Jul 20 10:32:47 2012 +0200 warning C4702: unreachable code (cherry picked from commit 618376bcb55906913

Re: [PUSHED 3-6] acclerate large OLE2 file reading ...

2012-09-20 Thread Miklos Vajna
Marking as pushed. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

preventing gerrit changes from being merged

2012-09-20 Thread d . ostrovsky
Hi, recently some gerrit changes were accidentally merged into master through gerrit UI. While there are ways to prevent it, like voting -2 for a change or prefixing the commit message with "work in progress, please don't merge" or something like that, I want to share with you the gerrit w

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - solenv/inc

2012-09-20 Thread Libreoffice Gerrit user
solenv/inc/wntmsc.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6779927cfcfbd386c8d9129ac49385cd54af6739 Author: Michael Stahl Date: Fri Jul 13 16:10:02 2012 +0200 wntmsc.mk: disable warnings-as-errors for binfilter Change-Id: If5ac0aa620d514ca4a

Re: Dialogs - Why so Inconsistent

2012-09-20 Thread Miklos Vajna
On Wed, Sep 19, 2012 at 10:10:04AM -0700, Joel Madero wrote: > Even simple things like position are handled different, some define columns > as COL and then use those in the src file while others directly put in > positions (X,Y). > > My questions are: > > 1. Is this okay? > 2. Is this efficien

Re: [PATCH] i18npool Add locale data for ebo_CG and tyx_CG

2012-09-20 Thread Miklos Vajna
Hi Jeremy, On Wed, Sep 19, 2012 at 10:30:52PM +0100, Jeremy Brown wrote: > This is my first patch submission to LibreOffice or anywhere else so > let me know if there's something I haven't done right or should do > differently. Thanks. All you need is to submit a license mail what we can link

[Libreoffice-commits] .: avmedia/source

2012-09-20 Thread Libreoffice Gerrit user
avmedia/source/quicktime/manager.hxx |8 avmedia/source/quicktime/manager.mm |2 +- avmedia/source/quicktime/player.hxx | 10 +- avmedia/source/quicktime/player.mm |2 +- avmedia/source/quicktime/quicktimeuno.mm |2 +- 5 files changed, 12 inse

Re: [PATCH] i18npool Add locale data for ebo_CG and tyx_CG

2012-09-20 Thread Andras Timar
2012/9/20 Miklos Vajna : > Hi Jeremy, > > On Wed, Sep 19, 2012 at 10:30:52PM +0100, Jeremy Brown <> wrote: >> This is my first patch submission to LibreOffice or anywhere else so >> let me know if there's something I haven't done right or should do >> differently. Thanks. > > All you need is to su

[PUSHED] Some OUString cleanup and ::rtl::OUString to OUString in avm...

2012-09-20 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/645 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/645 To unsubscribe, visi

[Libreoffice-commits] .: 2 commits - sd/source

2012-09-20 Thread Libreoffice Gerrit user
sd/source/ui/remotecontrol/BluetoothServer.cxx | 63 ++--- 1 file changed, 47 insertions(+), 16 deletions(-) New commits: commit cf480d6c37e8c58972ee8a3e3ce04747f3ae0b5e Author: Andrzej J.R. Hunt Date: Thu Sep 20 09:54:29 2012 +0200 Move the DBusGObjectPath typedef a

Re: Options included in CC/CXX vs. in gb_CFLAGS/gb_CXXFLAGS

2012-09-20 Thread Tor Lillqvist
> Should the -isysroot flag actually be part ot CC/CXX, not gb_CXXFLAGS? > Should configure.in and macosx.mk be modified thusly? That's what I did, and reverted my other attempts from this morning to get liborcus to build, and it seems that it was a good move, the tinderboxes are getting greener n

[Libreoffice-commits] .: offapi/com offapi/UnoApi_offapi.mk sax/source unusedcode.easy

2012-09-20 Thread Libreoffice Gerrit user
offapi/UnoApi_offapi.mk |1 offapi/com/sun/star/xml/sax/XFastSerializer.idl | 165 sax/source/tools/fastserializer.cxx | 97 -- sax/source/tools/fastserializer.hxx | 93 - unusedcode.easy

[PUSHED] unusedcode: FastSaxSerializer is not used through UNO

2012-09-20 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/651 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/651 To unsubscribe, visi

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2012-09-20 Thread Libreoffice Gerrit user
sw/source/core/crsr/crsrsh.cxx | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) New commits: commit 6bcbf68b29b609cf06dbea0e192533e11eb523c3 Author: Michael Stahl Date: Wed Sep 19 20:47:48 2012 +0200 rhbz#689053: fix crash following delete at last table cell:

[PUSHED] Change in core[libreoffice-3-6]: rhbz#689053: fix crash following delete at last table cell:

2012-09-20 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/652 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/652 To unsubscribe, visi

Re: sal/config.g sal/types.h and sal/osl/rtl includes in general

2012-09-20 Thread Lubos Lunak
On Wednesday 19 of September 2012, Norbert Thiebaud wrote: > So there is no automatic way to verify that an include set is > 'minimal', but there isn't even a way to do that with eyeballing... Actually, there possibly is an automatic way to do that: http://code.google.com/p/include-what-you-use/

[ANN] LibreOffice 3.5.7 RC1 available

2012-09-20 Thread Thorsten Behrens
Dear Community, The Document Foundation is happy to announce the first release candidate of LibreOffice 3.5.7. The upcoming 3.5.7 will be the seventh in a series of frequent bugfix releases for our 3.5 code line. Please be aware that LibreOffice 3.5.7 RC1 is not yet ready for production use, you s

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sal/inc

2012-09-20 Thread Libreoffice Gerrit user
sal/inc/rtl/string.hxx |7 ++- sal/inc/rtl/ustring.hxx |7 ++- 2 files changed, 4 insertions(+), 10 deletions(-) New commits: commit ab76bfc0366d72d80698e4145130a072aed64d31 Author: Stephan Bergmann Date: Mon Jul 23 12:09:12 2012 +0200 Make rtl::O[U]String::isEmpty return

[PUSHED] Change in core[libreoffice-3-6]: Make rtl::O[U]String::isEmpty return true bool

2012-09-20 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/650 Approvals: Miklos Vajna: Verified; Looks good to me, approved Luboš Luňák: Looks good to me, but someone else must approve -- To view

[Libreoffice-commits] .: config_host.mk.in configure.in filter/Module_filter.mk sc/CppunitTest_sc_filters_test.mk sc/qa sd/CppunitTest_sd_filters_test.mk sd/qa svtools/Module_svtools.mk sw/Module_sw.m

2012-09-20 Thread Libreoffice Gerrit user
config_host.mk.in |1 + configure.in | 17 + filter/Module_filter.mk |2 ++ sc/CppunitTest_sc_filters_test.mk |6 ++ sc/qa/unit/filters-test.cxx |2 ++ sd/CppunitTest_sd_filters_test.mk |6 ++ sd/qa/

[PUSHED] introduce new option --disable-cve-tests

2012-09-20 Thread Michael Meeks (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/653 Approvals: Michael Meeks: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/653 To unsubscribe, vis

[Libreoffice-commits] .: offapi/com offapi/UnoApi_offapi.mk officecfg/Configuration_officecfg.mk officecfg/registry

2012-09-20 Thread Libreoffice Gerrit user
offapi/UnoApi_offapi.mk|1 offapi/com/sun/star/setup/ProductRegistration.idl | 82 - officecfg/Configuration_officecfg.mk |1 officecfg/registry/data/org/openoffice/Office/Jobs.xcu | 39 4 files changed,

[Libreoffice-commits] .: bridges/source cppu/inc cppu/source

2012-09-20 Thread Libreoffice Gerrit user
bridges/source/jni_uno/jni_bridge.cxx |9 + cppu/inc/uno/environment.h|7 ++- cppu/source/uno/lbenv.cxx |4 3 files changed, 19 insertions(+), 1 deletion(-) New commits: commit 69765868e30494eb39a2b4b7566f161ef1f3db04 Author: Tor Lillqvist Dat

[Libreoffice-commits] .: postprocess/packregistry

2012-09-20 Thread Libreoffice Gerrit user
postprocess/packregistry/makefile.mk |1 - 1 file changed, 1 deletion(-) New commits: commit b590d87b380389371eca94ffb0e6f47f86d1c917 Author: Matúš Kukan Date: Thu Sep 20 11:57:41 2012 +0200 forgot to remove this one Change-Id: Idd33388f61461a55021b93498e2c992d7ae560d0 dif

[Libreoffice-commits] .: sd/source

2012-09-20 Thread Libreoffice Gerrit user
sd/source/ui/remotecontrol/Server.cxx | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) New commits: commit e2e701b5747982d037f76021ed64ab15a49cb573 Author: Andrzej J.R. Hunt Date: Thu Sep 20 12:02:05 2012 +0200 Add SAL_WARN/INFO to network server + remove static

[PUSHED:3-6-2] [PATCH] fdo#37529 clear DataColumns read-only information when we cl...

2012-09-20 Thread Michael Meeks
On Thu, 2012-09-13 at 17:28 +0200, Miklos Vajna wrote: > On Thu, Sep 13, 2012 at 04:38:34PM +0200, Lionel Elie Mamane > wrote: > > It is (yet another) Base crash. 't would be nice to have it in > > libreoffice-3-6-2, too. > > Looks OK to me, one more needed. Pushed to -3-6-2 :-)

[Libreoffice-commits] .: Branch 'libreoffice-3-6-2' - dbaccess/source

2012-09-20 Thread Libreoffice Gerrit user
dbaccess/source/core/api/RowSet.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 2fca05d5e4dee32feb6f9c9ba5f2c3792b72d5d1 Author: Lionel Elie Mamane Date: Thu Sep 13 16:24:38 2012 +0200 fdo#37529 clear DataColumns read-only information when we clear DataColumns

Re: sal/config.g sal/types.h and sal/osl/rtl includes in general

2012-09-20 Thread Norbert Thiebaud
On Thu, Sep 20, 2012 at 4:00 AM, Lubos Lunak wrote: > On Wednesday 19 of September 2012, Norbert Thiebaud wrote: >> So there is no automatic way to verify that an include set is >> 'minimal', but there isn't even a way to do that with eyeballing... > > Actually, there possibly is an automatic way

Re: LO build can not find external dependencies

2012-09-20 Thread Michael Meeks
Hi there, On Wed, 2012-09-19 at 10:35 +0200, Henrik /KaarPoSoft wrote: > I am trying to build version 3.6.2.1 from source on a Linux box. Sounds great. > I want to use headers already on system and system installed versions of > libraries as much as possible, so I pass --with-system-hea

Re: LO build can not find external dependencies

2012-09-20 Thread Michael Stahl
On 19/09/12 10:35, Henrik /KaarPoSoft wrote: > Dear all, > > I am trying to build version 3.6.2.1 from source on a Linux box. > > I want to use headers already on system and system installed versions of > libraries as much as possible, so I pass --with-system-headers > --with-system-libs to ./c

Re: sal/config.g sal/types.h and sal/osl/rtl includes in general

2012-09-20 Thread Michael Meeks
On Thu, 2012-09-20 at 11:00 +0200, Lubos Lunak wrote: > On Wednesday 19 of September 2012, Norbert Thiebaud wrote: > > So there is no automatic way to verify that an include set is > > 'minimal', but there isn't even a way to do that with eyeballing... > > Actually, there possibly is an automati

[PATCH] Change in core[libreoffice-3-6]: Don't access broken service mgr during bootstrap failure

2012-09-20 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/654 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/654/1 Don't access broken service mgr during bootstrap failure ...so that displaying a (non-translated) error box upon B

Re: [PUSHED 3-6][REVIEW 3-6-2 2/3] fdo#55059, use correct cell for broadcasting

2012-09-20 Thread Miklos Vajna
On Wed, Sep 19, 2012 at 01:22:54PM -0400, Kohei Yoshida wrote: > Looks good to me. Pushed to 3-6 with my sign off. > > Two more needed for 3-6-2. Looks reasonable to me. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.free

Is there easy way to find unused .idl files ?

2012-09-20 Thread Matúš Kukan
Hi, recently I've touched .idl files in http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7c41f1d1fcabc8f4abc670d5a18546a117b540a http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f77f1ac177521698ee7c978f218127cb5840046 And I wonder if there is an easy way how to tell, they can be r

[Libreoffice-commits] .: oox/source

2012-09-20 Thread Libreoffice Gerrit user
oox/source/export/chartexport.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit f3b2fc9be23739cec600b349e6b28b71be9acc3d Author: Radek Doulik Date: Thu Sep 20 12:46:15 2012 +0200 write only non NaN chart series values (fixes part of n#760997 Chang

[Libreoffice-commits] .: sot/source

2012-09-20 Thread Libreoffice Gerrit user
sot/source/sdstor/stgcache.cxx | 67 + sot/source/sdstor/stgcache.hxx | 19 ++- 2 files changed, 52 insertions(+), 34 deletions(-) New commits: commit 540ab389f2adb021a95b5ac52c55c97fc5db5c17 Author: Michael Meeks Date: Thu Sep 20 11:52:49 20

[Libreoffice-commits] .: sw/source

2012-09-20 Thread Libreoffice Gerrit user
sw/source/core/unocore/unodraw.cxx | 18 -- 1 file changed, 18 deletions(-) New commits: commit 21359dc87000c65665e49652d1c255e679817787 Author: Miklos Vajna Date: Thu Sep 20 13:01:04 2012 +0200 sw: drop unused includes in unodraw Change-Id: I2cae970f532c3441a7e

[Libreoffice-commits] .: offapi/com offapi/UnoApi_offapi.mk officecfg/Configuration_officecfg.mk officecfg/registry postprocess/packregistry

2012-09-20 Thread Libreoffice Gerrit user
offapi/UnoApi_offapi.mk|1 offapi/com/sun/star/setup/ProductRegistration.idl | 82 + officecfg/Configuration_officecfg.mk |1 officecfg/registry/data/org/openoffice/Office/Jobs.xcu | 39 postprocess/packr

Re: sal/config.g sal/types.h and sal/osl/rtl includes in general

2012-09-20 Thread Jack Leigh
On 20/09/12 11:12, Norbert Thiebaud wrote: On Thu, Sep 20, 2012 at 4:00 AM, Lubos Lunak wrote: On Wednesday 19 of September 2012, Norbert Thiebaud wrote: So there is no automatic way to verify that an include set is 'minimal', but there isn't even a way to do that with eyeballing... Actual

[Libreoffice-commits] .: vcl/inc vcl/unx

2012-09-20 Thread Libreoffice Gerrit user
vcl/inc/cupsmgr.hxx |2 +- vcl/unx/generic/printer/cupsmgr.cxx |3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) New commits: commit 8e1e27ae6d0751097d276eb3394b57af123e09f3 Author: Michael Meeks Date: Thu Sep 20 12:00:11 2012 +0100 cups: initialize thread r

Re: Is there easy way to find unused .idl files ?

2012-09-20 Thread Michael Stahl
On 20/09/12 12:36, Matúš Kukan wrote: > Hi, > > recently I've touched .idl files in > http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7c41f1d1fcabc8f4abc670d5a18546a117b540a > http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f77f1ac177521698ee7c978f218127cb5840046 > > And I wonde

[REVIEW-3-6] trivial cups thread init issue ...

2012-09-20 Thread Michael Meeks
As attached, I've noticed a number of these straying in. Did we disable a warning on un-initialized members for some reason ? I could swear the compiler used to complain helpfully about this. Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itin

Re: LO build can not find external dependencies

2012-09-20 Thread Henrik /KaarPoSoft
On 09/20/12 12:15, Michael Stahl wrote: On 19/09/12 10:35, Henrik /KaarPoSoft wrote: Dear all, I am trying to build version 3.6.2.1 from source on a Linux box. I want to use headers already on system and system installed versions of libraries as much as possible, so I pass --with-system-header

Re: LO build can not find external dependencies

2012-09-20 Thread Henrik /KaarPoSoft
On 09/20/12 12:13, Michael Meeks wrote: On Wed, 2012-09-19 at 10:35 +0200, Henrik /KaarPoSoft wrote: /home/kaarpux/KX_OO/kaarpux/linux/build/opt/libreoffice-core-3.6.2.1/solver/unxlngi6.pro/bin/cppunit/cppunittester: error while loading shared libraries: libcppunit-1.12.so.1: cannot open shared

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - desktop/inc desktop/source vcl/aqua vcl/generic vcl/inc vcl/ios vcl/source vcl/win

2012-09-20 Thread Libreoffice Gerrit user
desktop/inc/app.hxx| 19 ++--- desktop/source/app/app.cxx | 139 + desktop/source/app/desktop.hrc |1 desktop/source/app/desktop.src |5 - desktop/source/app/sofficemain.cxx | 21 - vcl/aqua/source/app/salsys.cxx

[PUSHED] Change in core[libreoffice-3-6]: Don't access broken service mgr during bootstrap failure

2012-09-20 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/654 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/654 To unsubscribe, vis

[Libreoffice-commits] .: 4 commits - sc/source stoc/source sw/source xmloff/source

2012-09-20 Thread Libreoffice Gerrit user
sc/source/ui/unoobj/dispuno.cxx |4 ++-- stoc/source/corereflection/crefl.cxx |5 + sw/source/core/text/porlay.cxx|6 +++--- sw/source/ui/lingu/olmenu.cxx |2 +- sw/source/ui/uno/unodispatch.cxx

Re: LO build can not find external dependencies

2012-09-20 Thread Michael Stahl
On 20/09/12 13:12, Henrik /KaarPoSoft wrote: > On 09/20/12 12:15, Michael Stahl wrote: >> On 19/09/12 10:35, Henrik /KaarPoSoft wrote: >>> I also have >>> export LD_LIBRARY_PATH="/opt/lib" >> apparently the new build system overwrites this always, guess nobody >> ever needed to set this from the ou

[Libreoffice-commits] .: javaunohelper/com javaunohelper/Library_juh.mk javaunohelper/Module_javaunohelper.mk

2012-09-20 Thread Libreoffice Gerrit user
javaunohelper/Library_juh.mk | 11 ++ javaunohelper/Module_javaunohelper.mk |9 - javaunohelper/com/sun/star/comp/helper/Bootstrap.java | 32 +- 3 files changed, 50 insertions(+), 2 deletions(-) New commits: commit 4b326ea35

[Libreoffice-commits] .: idl/source

2012-09-20 Thread Libreoffice Gerrit user
idl/source/objects/types.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit b869b73947659c45c1edc5f9cff80bfbe61e52ac Author: Tor Lillqvist Date: Thu Sep 20 14:18:22 2012 +0300 Avoid duplicate symbols when DISABLE_DYNLOADING for Android Change-Id: Iecd0ed802f6cc71

[Libreoffice-commits] .: editeng/source

2012-09-20 Thread Libreoffice Gerrit user
editeng/source/editeng/editview.cxx |2 +- editeng/source/editeng/impedit2.cxx |2 +- editeng/source/editeng/impedit3.cxx |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 45bae63f0f56060e2a609ebb2610502a3722dfee Author: Tor Lillqvist Date: Thu Sep 20 14

Re: Options included in CC/CXX vs. in gb_CFLAGS/gb_CXXFLAGS

2012-09-20 Thread Michael Stahl
On 20/09/12 09:08, Stephan Bergmann wrote: > On 09/20/2012 08:48 AM, Tor Lillqvist wrote: >> I think there is some fuzziness about what compiler options should be >> part of the CC/CXX variables and what should be in >> gb_CFLAGS/gb_CXXFLAGS. >> >> In some cases, like my Mac build tree that uses th

Re: Options included in CC/CXX vs. in gb_CFLAGS/gb_CXXFLAGS

2012-09-20 Thread Tor Lillqvist
> btw, why doesn't macosx.mk use --sysroot, which is much better than > -isysroot because it mangles the library search path as well? is the > gcc too old for it? man gcc: -isysroot dir This option is like the --sysroot option, but applies only to header files, except for Apple

[PATCH] docx export: export default table cell margins and borders

2012-09-20 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/656 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/656/1 docx export: export default table cell margins and borders Export table cell margins/borders in w:tblPr. First cel

[PATCH] docx import: position table using tblInd OR tblCellMar

2012-09-20 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/655 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/655/1 docx import: position table using tblInd OR tblCellMar Previously cell-margin was unconditionnaly used to compute

[PATCH] docx export: if table has no width use w:tblW 'auto' type

2012-09-20 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/657 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/657/1 docx export: if table has no width use w:tblW 'auto' type Change-Id: I085febf04205181e7c4488bc948f346f92070fe2 ---

Re: Failed to compile accessibility module due to gb_Deliver_deliver file is missing.

2012-09-20 Thread LOH KOK HOE
Hi noel, When I issue the command make rsc > I got this error: make -r -f /home/kokhoe/workspace/LibreOffice/core/Makefile.top rsc make[1]: Entering directory `/home/kokhoe/workspace/LibreOffice/core' cd rsc && make -j 2 -rs gb_PARTIALBUILD=T make[2]: Entering directory `/home/kokhoe/workspace/L

Re: Options included in CC/CXX vs. in gb_CFLAGS/gb_CXXFLAGS

2012-09-20 Thread Christian Lohmaier
Hi Tor, *, It is pointless to write to the mailinglist for feedback, if you don't even wait two ours before taking the action you ask to be OK or not. If you want to do it, just do it, but such "alibi" posts don't really make much sense then. On Thu, Sep 20, 2012 at 10:29 AM, Tor Lillqvist wrote

Re: Options included in CC/CXX vs. in gb_CFLAGS/gb_CXXFLAGS

2012-09-20 Thread Tor Lillqvist
> And now the build will break for those who use CC="/path/to/ccache > gcc", won't it? Probably, yes. But that might well have happened earlier, too. Living on the master branch requires some manual adaption now and then. The alternative would be to make no progress. --tml ___

Re: Failed to compile accessibility module due to gb_Deliver_deliver file is missing.

2012-09-20 Thread Noel Grandin
It looks like you're trying to build individual pieces without doing a complete build first. Before you try hacking on individual modules, you have to first have a complete build i.e. ./autogen.sh make and let it run to completion. May take several hours. On 2012-09-20 14:54, LOH KOK HOE wr

Re: Failed to compile accessibility module due to gb_Deliver_deliver file is missing.

2012-09-20 Thread LOH KOK HOE
Hi matus, When issuing *make accessibility.all* command, it actually building the whole source code. Right now I come to build 46 of 62, module ridljar, and the build was stop on this build. From the stack trace I see this *javac: invalid source release: 1.7* I am currently using JAVA version 1.7

Re: [PATCH] i18npool Add locale data for ebo_CG and tyx_CG

2012-09-20 Thread Jeremy Brown
I hereby declare that: All my contributions, past and future, to LibreOffice are licensed under the terms of the MPL / LGPLv3+. Jeremy Brown ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/lib

Re: Failed to compile accessibility module due to gb_Deliver_deliver file is missing.

2012-09-20 Thread LOH KOK HOE
Sorry noel, I just want to know the options available for ./autogen.sh, and I had accidentally type ./autogen.sh help. Thus the next time I issuing the command ./autogen.sh I have following error. Is there a way to clean it? *console output* running ./configure with 'help' configure: WARNING: you

[Libreoffice-commits] .: 2 commits - liblangtag/liblangtag-0.2-xmlCleanupParser.patch liblangtag/makefile.mk

2012-09-20 Thread Libreoffice Gerrit user
liblangtag/liblangtag-0.2-xmlCleanupParser.patch | 20 liblangtag/makefile.mk |9 + 2 files changed, 29 insertions(+) New commits: commit 5e6c595e9d698caf23ae68d38b9cab30ff9c9b94 Author: Stephan Bergmann Date: Thu Sep 20 15:40:30 201

[PATCH] neon: convert to gbuild

2012-09-20 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/659 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/659/1 neon: convert to gbuild Change-Id: I1cca0e3be7e148c835af26d2c001878b849e8432 --- M Makefile.top M Module_tail_buil

[PATCH] allow Library to disable hidden visibility

2012-09-20 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/658 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/658/1 allow Library to disable hidden visibility Change-Id: I1f676b7536183f68795595f216ae23610cadb1eb --- M solenv/gbuil

Re: Failed to compile accessibility module due to gb_Deliver_deliver file is missing.

2012-09-20 Thread Noel Grandin
Maybe you should try reading the documentation? http://wiki.documentfoundation.org/Development/Native_Build On 2012-09-20 15:46, LOH KOK HOE wrote: Sorry noel, I just want to know the options available for ./autogen.sh, and I had accidentally type ./autogen.sh help. Thus the next time I issu

Re: How to use internal neon ?

2012-09-20 Thread Matúš Kukan
On 10 September 2012 21:53, Caolán McNamara wrote: > On Mon, 2012-09-10 at 18:55 +0200, Matúš Kukan wrote: >> Hi, >> >> I am pondering gbuildizing neon. >> It's built by dmake as dynamic library currently. >> Could it be used as static library ? > > It used to be a static library but got converted

[Libreoffice-commits] .: solenv/gbuild

2012-09-20 Thread Libreoffice Gerrit user
solenv/gbuild/platform/unxgcc.mk |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 4ba760078019fba15f9d0d33a6094960026b9dfb Author: Stephan Bergmann Date: Thu Sep 20 15:54:23 2012 +0200 Make "make debugrun" less fancy but more useful For one, --tui ha

Re: Failed to compile accessibility module due to gb_Deliver_deliver file is missing.

2012-09-20 Thread LOH KOK HOE
I have already figure it out how to resolve my problem by re-issuing the ./autogen.sh command with new options. BTW, I have read that document before I start compiling, just that my typing skills is very bad. :p Anyway, thank you so much on your help. THanks @! On Thu, Sep 20, 2012 at 9:58 PM,

Build error in offapi module

2012-09-20 Thread LOH KOK HOE
I was trying to make a clean build using this command ./autogen.sh and have encountering a build error in offapi module. I am running out of clue on how this problem could be solve. Below are the details of the stack trace, hope you guys can give some pointer. *Trace extract from build_error.log*

[Libreoffice-commits] .: oox/source

2012-09-20 Thread Libreoffice Gerrit user
oox/source/vml/vmlshape.cxx |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) New commits: commit b5a1db961372b3fa66724ee580726c67e7683dbc Author: Miklos Vajna Date: Thu Sep 20 16:13:51 2012 +0200 n#779834 fix VML import of absolutely positioned image with no left margin

[PATCH] fdo#39468: Translated German comments in sw/source/core/text

2012-09-20 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/660 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/660/1 fdo#39468: Translated German comments in sw/source/core/text Change-Id: I53a415e1ec573d342e06d0cf10bad6f8cb95b478

[Libreoffice-commits] .: sc/inc sc/source

2012-09-20 Thread Libreoffice Gerrit user
sc/inc/rangenam.hxx |3 +- sc/source/core/tool/rangenam.cxx| 36 +--- sc/source/filter/oox/defnamesbuffer.cxx | 13 +-- 3 files changed, 37 insertions(+), 15 deletions(-) New commits: commit 7539a695b801b92d10ff30463a8c08672a

Re: Build error in offapi module

2012-09-20 Thread Stephan Bergmann
On 09/20/2012 04:18 PM, LOH KOK HOE wrote: I was trying to make a clean build Did you actually do "make clean"? offapi/com/sun/star/auth/SSOExceptions.idl was removed quite a while ago on master, so it looks to me like you still have some remains from on old build around. Stephan _

Re: How to use internal neon ?

2012-09-20 Thread Stephan Bergmann
On 09/20/2012 04:00 PM, Matúš Kukan wrote: I see, so it will be a little complicated with exporting symbols. Currently, there is even .map file used. (probably, I don't know how dmake works) I've removed .map files, allowed to turn of -fvisibility=hidden in https://gerrit.libreoffice.org/#/c/658/

[Libreoffice-commits] .: helpcontent2/source

2012-09-20 Thread Libreoffice Gerrit user
helpcontent2/source/auxiliary/sbasic.tree | 22 +++--- helpcontent2/source/auxiliary/scalc.tree| 12 ++-- helpcontent2/source/auxiliary/shared.tree | 22 +++--- helpcontent2/source/auxiliary/simpress.tree |2 +- helpcontent2/source/auxiliar

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - oox/source

2012-09-20 Thread Libreoffice Gerrit user
oox/source/docprop/ooxmldocpropimport.cxx | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) New commits: commit 3ad52a6453ff612409123db29dc74a9071789aab Author: Muthu Subramanian Date: Tue Sep 11 12:44:44 2012 +0530 fdo#54609, fdo#45366: Exception while impor

[REVIEW 3-6-2 1/3] Crasher fix for xlsx import

2012-09-20 Thread Kohei Yoshida
I've cherry-picked https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=3ad52a6453ff612409123db29dc74a9071789aab Just a minute ago to fix https://bugs.freedesktop.org/show_bug.cgi?id=48366 https://bugs.freedesktop.org/show_bug.cgi?id=54609 the latter of which is a hard-hack. The ch

[PATCH] Change in core[libreoffice-3-6]: Add RPATH to liblangtag

2012-09-20 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/661 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/661/1 Add RPATH to liblangtag ...so that it consistenly uses the LO versions of libxml2/glibc libs at runtime. Change-I

[PATCH] Change in core[libreoffice-3-6]: Do not call xmlCleanupParser from liblangtag

2012-09-20 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/662 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/662/1 Do not call xmlCleanupParser from liblangtag Despite its name, it is a cleanup function for libxml2 that must only

Re: [Libreoffice-qa] minutes of ESC call ...

2012-09-20 Thread Bjoern Michaelsen
On Thu, Sep 20, 2012 at 04:24:09PM +0100, Michael Meeks wrote: > + gerrit - patch abandonment can only be done by owner or gerrit admin > (Bjoern) please drop, nothing actionable there ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice-qa] minutes of ESC call ...

2012-09-20 Thread Bjoern Michaelsen
On Thu, Sep 20, 2012 at 04:24:09PM +0100, Michael Meeks wrote: > * Present: > + propose new Difficulty: DifficultyHard Eek, multiple questions on that: - What would be the difference to "DifficultyInteresting" in hard and objective terms? - How do we make sure we would all judge the EasyHa

[Libreoffice-commits] .: 4 commits - oox/inc oox/source sw/source writerfilter/inc writerfilter/source

2012-09-20 Thread Libreoffice Gerrit user
oox/inc/oox/vml/vmlshape.hxx |1 oox/source/token/properties.txt |1 oox/source/vml/vmlshape.cxx | 19 +++ oox/source/vml/vmlshapecontext.cxx |3 + sw/source/core/text/po

[PUSHED] docx import: position table using tblInd OR tblCellMar

2012-09-20 Thread Bosdonnat Cedric (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/655 -- To view, visit https://gerrit.libreoffice.org/655 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: me

Re: How to use internal neon ?

2012-09-20 Thread Matúš Kukan
On 20 September 2012 17:09, Stephan Bergmann wrote: > On 09/20/2012 04:00 PM, Matúš Kukan wrote: >> >> I see, so it will be a little complicated with exporting symbols. >> Currently, there is even .map file used. (probably, I don't know how >> dmake works) >> I've removed .map files, allowed to tu

Re: [REVIEW 3-6-2 1/3] Crasher fix for xlsx import

2012-09-20 Thread Markus Mohrhard
Hey, 2012/9/20 Kohei Yoshida : > I've cherry-picked > > https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=3ad52a6453ff612409123db29dc74a9071789aab > > Just a minute ago to fix > > https://bugs.freedesktop.org/show_bug.cgi?id=48366 > https://bugs.freedesktop.org/show_bug.cgi?id=54609

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - liblangtag/makefile.mk

2012-09-20 Thread Libreoffice Gerrit user
liblangtag/makefile.mk |8 1 file changed, 8 insertions(+) New commits: commit c5f049680130a9af6c97856ea18869738811822b Author: Stephan Bergmann Date: Thu Sep 20 15:00:50 2012 +0200 Add RPATH to liblangtag ...so that it consistenly uses the LO versions of libxml2/gli

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - liblangtag/liblangtag-0.2-xmlCleanupParser.patch liblangtag/makefile.mk

2012-09-20 Thread Libreoffice Gerrit user
liblangtag/liblangtag-0.2-xmlCleanupParser.patch | 20 liblangtag/makefile.mk |1 + 2 files changed, 21 insertions(+) New commits: commit c63f4962caefc22cbf0fa9cde87f3a49d79f0b85 Author: Stephan Bergmann Date: Thu Sep 20 15:40:30 2012 +0200

[PUSHED] Change in core[libreoffice-3-6]: Do not call xmlCleanupParser from liblangtag

2012-09-20 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/662 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/662 To unsubscribe, vis

[PUSHED] Change in core[libreoffice-3-6]: Add RPATH to liblangtag

2012-09-20 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/661 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/661 To unsubscribe, vis

‘auto_ptr’ is deprecated in sc/source/core/tool/rangenam.cxx

2012-09-20 Thread julien2412
Hello, WAE is enabled in my autogen.lastrun for master sources. I just updated and had this during compilation: /home/julien/compile-libreoffice/libo/sc/source/core/tool/rangenam.cxx: In member function ‘void ScRangeData::SetCode(ScTokenArray&)’: /home/julien/compile-libreoffice/libo/sc/source/cor

getting started

2012-09-20 Thread Jorge Luis Roque Alvarez
Hi iam just learning how to develop; my first step is to understand the examples i already install the sdk from the repository aim currently using ubuntu 12.04.1 but when i run make to the bookmarkInsertation(example in java) it do not find any library i'm i missing something could anybody help

Re: ‘auto_ptr’ is deprecated in sc/source/core/tool/rangenam.cxx

2012-09-20 Thread Michael Stahl
On 20/09/12 19:23, julien2412 wrote: > Hello, > > WAE is enabled in my autogen.lastrun for master sources. I just updated and > had this during compilation: > /home/julien/compile-libreoffice/libo/sc/source/core/tool/rangenam.cxx: In > member function ‘void ScRangeData::SetCode(ScTokenArray&)’: >

Re: ‘auto_ptr’ is deprecated in sc/source/core/tool/rangenam.cxx

2012-09-20 Thread julien2412
Michael Stahl-2 wrote > usually can be replaced with boost::scoped_ptr. > > but in this case i wonder, what purpose does pOldCode serve? > why isn't pCode some kind of smart pointer? Thank you Michael for your feedback. I followed your piece of advice and it's compiling right now. For the rest,

Re: Is there easy way to find unused .idl files ?

2012-09-20 Thread Matúš Kukan
On 20 September 2012 13:01, Michael Stahl wrote: >> And I wonder if there is an easy way how to tell, they can be removed. >> For files added with gb_UnoApi_add_idlfile_noheader, one probably have >> to grep in the code. > > technically all of those are "unused" because they are mere > documentati

[Libreoffice-commits] .: 2 commits - sw/source

2012-09-20 Thread Libreoffice Gerrit user
sw/source/core/text/txttab.cxx | 48 ++-- sw/source/core/text/widorp.cxx | 152 +++-- 2 files changed, 97 insertions(+), 103 deletions(-) New commits: commit 606b57c625aebabd004a4f3e3a2552f3a03551a0 Author: Michael Stahl Date: Thu Sep 20 20:28:00

[Libreoffice-commits] .: Branch 'libreoffice-3-6-2' - oox/source

2012-09-20 Thread Libreoffice Gerrit user
oox/source/docprop/ooxmldocpropimport.cxx | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) New commits: commit 9b1ba36bce25cf5abd41835d5d4c156893e8eca6 Author: Muthu Subramanian Date: Tue Sep 11 12:44:44 2012 +0530 fdo#54609, fdo#45366: Exception while impor

  1   2   >