Re: [Libreoffice] [PUSHED] Re: [PATCH] Accelerate perl installer: optimize installer::scriptitems::optimize_list().

2010-12-02 Thread Alex Hudson
Hey Jordan, On Thu, 2010-12-02 at 13:29 -0600, Jordan Ayers wrote: > I'm not a perl expert, just have had to learn it on the job over > the last few years. Since I'm also not very familiar with all the > details the installer is handling, I've been focusing on incremental > cleanup items. (A

Re: [Libreoffice] [PATCH] Accelerate perl installer: optimize installer::scriptitems::optimize_list().

2010-12-02 Thread Alex Hudson
(and now I apologise for following up my own mail ;) On Thu, 2010-12-02 at 11:32 +, Alex Hudson wrote: > I haven't looked at a huge amount of the installer, but it might be that > internally using strings less and data structures more could be used to > speed it up a fair bit:

Re: [Libreoffice] [PATCH] Accelerate perl installer: optimize installer::scriptitems::optimize_list().

2010-12-02 Thread Alex Hudson
(apologies for breaking the thread; I only just subscribed) I offered an opinion on this excellent little patch to Caolán on IRC, basically that I thought the last foreach()/chop combo would be better written as a join. A minor nit, but probably not with much speed benefit. The more perlish versi