Hi,
I have attached a patch for fdo#63311 with this mail.
Basically, the patch makes sure there is no NULL text, but instead uses
empty_text.
[empty_text seems to be the initialization text for the shape while NULL
seems to be applied when the user removes the text]
I am not sure if this i
Hi Vishv,
On 04/01/2013 04:15 PM, Vishv Brahmbhatt wrote:
Hi,
I need help for Bug 47302.
https://bugs.freedesktop.org/show_bug.cgi?id=47302
For *impress* : I have to get slide name in the text-field through
option *Insert->Fields->Slide Name*. Similar to the Page Number option
in the Insert->F
Hi,
Thank you for your patch! It has been merged to LibreOffice.
If you are interested in details, please visit
https://gerrit.libreoffice.org/2125
Approvals:
Muthu Subramanian K: Verified; Looks good to me, approved
--
To view, visit https://gerrit.libreoffice.org/2125
To
Hi,
Thank you for your patch! It has been merged to LibreOffice.
If you are interested in details, please visit
https://gerrit.libreoffice.org/2046
Approvals:
Muthu Subramanian K: Verified; Looks good to me, approved
Tor Lillqvist: Looks good to me, but someone else must approve
Hi,
Thank you for your patch! It has been merged to LibreOffice.
If you are interested in details, please visit
https://gerrit.libreoffice.org/2554
Approvals:
Muthu Subramanian K: Verified; Looks good to me, approved
--
To view, visit https://gerrit.libreoffice.org/2554
To
Hi,
Thank you for your patch! It has been merged to LibreOffice.
If you are interested in details, please visit
https://gerrit.libreoffice.org/2451
Approvals:
Muthu Subramanian K: Verified; Looks good to me, approved
Miklos Vajna: Looks good to me, but someone else must approve
Eike
Hi,
Thank you for your patch! It has been merged to LibreOffice.
If you are interested in details, please visit
https://gerrit.libreoffice.org/2494
Approvals:
Muthu Subramanian K: Verified; Looks good to me, approved
Norbert Thiebaud: Looks good to me, but someone else must approve
Hi,
Thank you for your patch! It has been merged to LibreOffice.
If you are interested in details, please visit
https://gerrit.libreoffice.org/2453
Approvals:
Muthu Subramanian K: Verified; Looks good to me, approved
--
To view, visit https://gerrit.libreoffice.org/2453
To
Hi,
Thank you for your patch! It has been merged to LibreOffice.
If you are interested in details, please visit
https://gerrit.libreoffice.org/2534
Approvals:
Muthu Subramanian K: Verified; Looks good to me, approved
--
To view, visit https://gerrit.libreoffice.org/2534
To
Hi,
I was trying to fix a problem which occurs while the user tries to open
a pptx file which has a .ppt extension. LibreOffice seems to throw a
'broken file' dialog and providing options to the user to repair it.
I was trying to fix it by avoiding that annoying dialog and opening the
pptx c
Hi,
I had recently committed these to the master branch. It would be nice if
we could have it on the 4.0 branch as well.
PPT Export fix - Autofit of background images
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e481740cc894ea21c8e7a49100d56ca572a21a76
PPTX Import - Flip gradients
Hi,
Thank you for your patch! It has been merged to LibreOffice.
If you are interested in details, please visit
https://gerrit.libreoffice.org/1485
Approvals:
Muthu Subramanian K: Verified; Looks good to me, approved
--
To view, visit https://gerrit.libreoffice.org/1485
To unsubscribe
: merged
Gerrit-Change-Id: I905e85ce9d754047ad287c9dd3caa92427b25b0d
Gerrit-PatchSet: 5
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania
Gerrit-Reviewer: Muthu Subramanian K
Gerrit-Reviewer: Ricardo Montania
___
LibreOffice
: merged
Gerrit-Change-Id: I594b24341eb38c05523f578c1dc2e43d90544f30
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky
Gerrit-Reviewer: Muthu Subramanian K
___
LibreOffice mailing list
LibreOffice
: merged
Gerrit-Change-Id: If6a53fd69f8a99bafc7fc324911132dd51e67266
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania
Gerrit-Reviewer: Muthu Subramanian K
Gerrit-Reviewer: Ricardo Montania
___
LibreOffice
: merged
Gerrit-Change-Id: I27709f12ef6e3448ed457bd0e9f2056979ba0291
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania
Gerrit-Reviewer: Muthu Subramanian K
Gerrit-Reviewer: Ricardo Montania
___
LibreOffice
: merged
Gerrit-Change-Id: Ie27a55e933462c644f315d0123978082054d79af
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania
Gerrit-Reviewer: Muthu Subramanian K
Gerrit-Reviewer: Olivier Hallot
Gerrit-Reviewer: Ricardo Montania
: merged
Gerrit-Change-Id: Iaa56c5f8a15032c3102ad58011c80e3c86fe287c
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania
Gerrit-Reviewer: Muthu Subramanian K
Gerrit-Reviewer: Ricardo Montania
___
LibreOffice
: merged
Gerrit-Change-Id: I01c3224bc21a7f8a03a8562191fbc161032f2a1d
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot
Gerrit-Reviewer: Muthu Subramanian K
Gerrit-Reviewer: Olivier Hallot
___
LibreOffice mailing
: merged
Gerrit-Change-Id: I4543a3a6d6a6971d2c31b8dc36bd2ec95bd892d4
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot
Gerrit-Reviewer: Michael Meeks
Gerrit-Reviewer: Muthu Subramanian K
Gerrit-Reviewer: Olivier Hallot
: merged
Gerrit-Change-Id: If930f77179dbf24d43f10a344b68edcf968f7304
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot
Gerrit-Reviewer: Muthu Subramanian K
Gerrit-Reviewer: Olivier Hallot
___
LibreOffice mailing
: merged
Gerrit-Change-Id: I3de75446e53618862e50c69382a7ddaf0d482fa7
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot
Gerrit-Reviewer: Muthu Subramanian K
Gerrit-Reviewer: Olivier Hallot
___
LibreOffice mailing
: merged
Gerrit-Change-Id: Ic933f6da44c788cba48bb2fe6fa29658985310b6
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Korrawit Pruegsanusak
Gerrit-Reviewer: Korrawit Pruegsanusak
Gerrit-Reviewer: Muthu Subramanian K
: merged
Gerrit-Change-Id: I2878d2db002411783e814b0ecf02e2a030d2d6d4
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christophe JAILLET
Gerrit-Reviewer: Christophe JAILLET
Gerrit-Reviewer: Muthu Subramanian K
___
LibreOffice
: merged
Gerrit-Change-Id: I3dfa6566758d30bd76bed478089a0937ade24f89
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christophe JAILLET
Gerrit-Reviewer: Christophe JAILLET
Gerrit-Reviewer: Muthu Subramanian K
___
LibreOffice
Hi Niklas,
We may have to do something like:
http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/drtxtob1.cxx#254
Maybe header/footer views aren't invalidated when we click 'OK'? I am
just guessing.
PS: I am not too familiar with this part of the code, unfortunately :(
Thanks & Regard
On 09/12/2012 04:51 AM, Markus Mohrhard wrote:
Hey Muthu,
Two more points from me just as a notice.
You might run into two problems with the rendering code that are also
affecting the conditional format code.
oh...yes...I forgot about this one...Let me test it out. I assume it
should behave th
On 09/12/2012 11:49 AM, Stefan Knorr wrote:
Hello all,
so, here's an attempt at a UX view at the feature:
* most of the UI looks the same as comparable UI for drawing objects –
which is excellent, because that makes the UIs consistent, and because
it already uses time-tested UI (which of course
Hi Kohei,
On 09/10/2012 11:03 PM, Kohei Yoshida wrote:
On 09/10/2012 03:56 AM, Jan Holesovsky wrote:
Hi Muthu,
Muthu Subramanian K píše v Po 03. 09. 2012 v 13:04 +0530:
I have attached a first cut patch for the gradient fill for cells.
I initially tried using only the 'Gradient'
Hi,
Sorry, but I didn't understand your question properly :(
Detailed steps would be helpful, please?
It would be also nice to track this problem by creating an entry on
http://bugs.freedesktop.org and assign it to yourself. - Just my opinion.
Btw, this is a developer mailing list, assuming y
On 08/20/2012 05:00 PM, Michael Meeks wrote:
> One issue is powering up bluetooth on Android: documentation insists
> that you ask the user to switch on bluetooth: one option is to add an
> item "Search for Bluetooth" devices on the selection screen which does
> this, or alternatively to just
Hi,
It would be nice if somebody could review and cherry pick the patch
http://cgit.freedesktop.org/libreoffice/core/commit/?id=36233b158b5de6c474f06c8c8772f0012b191baa
to the 3.6 branch, please?
Thank you!
Muthu Subramanian
___
LibreOffice mailing li
Hi,
It would be nice to have the fix for fdo#45260 on 3.6, if possible, please?
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e647cc9d895005c5bed2fec98c73ca28ccd925ae
Thanks!
Muthu Subramanian
___
LibreOffice mailing list
LibreOffice@lists.f
I tested the problem refrenced to in i#112978 and it still seemed
broken. So, I have partially reverted the fix as:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e647cc9d895005c5bed2fec98c73ca28ccd925ae
On 07/11/2012 04:15 PM, Muthu Subramanian K wrote:
Related commits:
http
Related commits:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=d999ae10
So, is this safe to revert, please?
On 07/11/2012 04:00 PM, Muthu Subramanian K wrote:
Hi,
I was debugging the problem mentioned in fdo#45260 and found a strange
problem.
Copy uses BoundRect()
http
Hi,
I was debugging the problem mentioned in fdo#45260 and found a strange
problem.
Copy uses BoundRect()
http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/sdview2.cxx#133
while Paste uses SnapRect()
http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/sdview3.cxx#631
And unfor
+1. Looks fine to me.
The patch path (2fb377c19f8ae38e7ec649af1343bbd64b70a16b) has long been
disabled (because of related issues like these). The idea was to import
quick and compile the formula only when necessary, but there's quite
some pending work there...
On 07/03/2012 02:52 PM, Eike R
Other functions where CharAttribList::ResortAttribs() is called seem to
not guarantee that. So your fix would only help where the entire array
is already sorted, not where only partial sorting is to be retained.
Would be good to know if ContentNode::ExpandAttribs() and
ContentNode::CollapsAttribs
be some corner cases). Though insert takes care
of keeping the array sorted (and the order of the attribs as well).
Thanks & Regards,
Muthu SUbramanian
On 06/18/2012 05:36 PM, Eike Rathke wrote:
Hi Muthu,
On Thursday, 2012-06-14 20:02:38 +0530, Muthu Subramanian K wrote:
qsort seems t
Hi,
I was trying to debug a problem where the email-field doesn't show the
correct color when imported (pptx).
I have attached a sample debug file.
qsort seems to change the order of the elements even if the elements are
sorted. (Technically though it is correct), our way of applying color
a
Oops...seems like Korrawit already proposed this in a different mail
thread...sorry for the troubles.
On 06/12/2012 04:44 PM, Muthu Subramanian K wrote:
Hi,
Can somebody review and cherry-pick this one please?
http://cgit.freedesktop.org/libreoffice/core/commit/?id
Hi,
Can somebody review and cherry-pick this one please?
http://cgit.freedesktop.org/libreoffice/core/commit/?id=25dd603fe2044f35341fe0c6d0b632c9295a824e
Thanks!
Muthu Subramanian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://li
Hi all,
Some broken documents seem to contain negative values for margins, which
messes the output. One of the sample documents is available as
attachment in n757419.
I have attached a patch for review with this mail.
I didn't want to touch editeng for fixing this better (e.g. in
SvxLRSpaceIt
Oops..sorry for the troubles, missed that some how :( Thank you so much!
On 05/07/2012 06:02 PM, Michael Stahl wrote:
On 07/05/12 08:23, Muthu Subramanian K wrote:
Hi,
It will be great if someone can cherry-pick this fix for n#717947, please?
http://cgit.freedesktop.org/libreoffice/core
Hi,
It will be great if someone can cherry-pick this fix for n#746996, please?
http://cgit.freedesktop.org/libreoffice/core/commit/?id=1a2a2a02bd03829d2d50fb5f1a2178280ed2e997
Summary: Text color is imported wrong when there are none specified. We
should use default color settings (in pptx - i.
Hi,
It will be great if someone can cherry-pick this fix for n#717947, please?
http://cgit.freedesktop.org/libreoffice/core/commit/?id=03a651507e34ee423674d2a537f2bb4b509af6d6
Summary: when exporting to PDF, images (in notes view) aren't exported
completely (they were optimized exported - i.e. s
Hi,
It will be great if someone can cherry-pick this fix, please?
http://cgit.freedesktop.org/libreoffice/core/commit/?id=11713989b1580799635fff997b920d9bd4bf619f
Its a crasher - I guess, it happens with certain type of (broken?) pptx
files.
Thanks & Regards,
Muthu Subramanian
___
Pushed. Thank you.
On 04/25/2012 12:12 AM, Christina Roßmanith wrote:
Hi,
an easyhack, to get a feeling of success while trying to understand
import of SVGs.
Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freed
Marking this pushed.
These are already pushed (I guess you sent this again by mistake?)
Btw, I had sent you a private email (to your other address at uco.edu)
---snip---
Assuming you would like to contribute more, it would be great if you
could send across a license statement and add yourself he
Pushed. Thank you!
Looking for more ;)
On 04/22/2012 09:42 PM, Javier Silva Sanahuja wrote:
Hi:
I send you a patch in order to erase the unused code:
formula::FormulaTokenArray::AddBad(unsigned short const*).
Best Regards
Javier
___
LibreOffice ma
Pushed. Thank you!
Looking for more ;)
On 04/22/2012 09:42 PM, Javier Silva Sanahuja wrote:
Hi:
I send you a patch in order to erase the unused code:
formula::FormulaTokenArray::AddBad(unsigned short const*).
Best Regards
Javier
___
LibreOffice ma
Pushed. Thank you!
On 04/23/2012 12:44 AM, Ferran Vidal i Marginet wrote:
Hello,
These is the patch that I've created.
Licence: made available under the MPL/LGPLv3+
Ferran Vidal
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://
Thank you!
On 04/23/2012 02:06 AM, Santiago Martinez wrote:
This patch removes unused code as listed in unusedcode.easy
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
Thank you for the patch! I believe this is your first patch?
Can you confirm that this (and possibly your future contributions) is
licensed under the MPL/LGPLv3+ dual license, please?
Thank you so much again!
Muthu Subramanian
On 04/23/2012 05:48 AM, Mònica Ramírez Arceda wrote:
Hi,
This pat
Pushed. Thank you.
On 04/20/2012 04:21 AM, Dézsi Szabolcs wrote:
Crash while opening odt file
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
I guess the unusedcode.easy is created by script(s) (?)
On 04/20/2012 03:35 AM, Xavi Escriche Galindo wrote:
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
_
Hi,
I was trying to implement the wrapping feature for fields (specifically
the hyperlinks) in impress. Currently, the text box containing
hyperlinks can overflow the width of the box. This can be a problem when
the content is on the border of the slide (or otherwise).
What this patch does/d
Hi,
http://cgit.freedesktop.org/libreoffice/core/commit/?id=03a651507e34ee423674d2a537f2bb4b509af6d6
fixes the issue https://bugzilla.novell.com/show_bug.cgi?id=717947
It will be great if someone can review this and cherry-pick it, please?
In brief: When Impress slides with image and notes ar
Pushed. Thank you!
On 04/05/2012 12:10 AM, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinf
Marking pushed.
On 04/05/2012 01:11 PM, Winfried Donkers wrote:
> No fix this time, but cleanup of unused code I found whilst working on
> fdo45671.
>
>
>
>
>
>
>
> Winfried
>
>
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.f
+1
[There were some duplicate code, which I attempted to remove - if there
are no mistakes there, pushing that is better? Or probably merging via
master is better?]
On 03/27/2012 06:38 AM, Thorsten Behrens wrote:
> Hi there,
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=06c16e1e26
These links help too:
https://wiki.documentfoundation.org/Development/GSoc#How_to_apply
http://www.google-melange.com/gsoc/org/google/gsoc2012/libreoffice
On 03/26/2012 08:11 PM, Коростіль Данило wrote:
> On 03/26/2012 05:23 PM, Abhishek Jindal wrote:
>> I am highly interested in working with Libr
Hi Waqas,
Sorry for the delay...I was away (festival weekend here).
Well,I did reply to your mail earlier today. Do let me know if you need
any other info too (or in case the mail didn't reach you)...
Regards,
Muthu Subramanian
On 03/25/2012 02:22 PM, Waqas Iftikhar wrote:
> The IRC channel is d
Pushed.
On 03/08/2012 02:07 AM, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffi
Pushed.
On 03/08/2012 02:19 AM, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffi
Pushed.
On 03/08/2012 01:05 AM, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.easy
>
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreo
Pushed.
On 03/08/2012 01:27 AM, Santiago Martinez wrote:
> This patch removes unused code as listed in unusedcode.eas
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffic
Pushed. Looked ok to me - I don't know much of the german language, though.
Thank you!
On 03/01/2012 10:38 AM, Philipp Weissenbacher wrote:
> Hi all,
>
> I'd like to have a second set of eye-ball on these translations.
>
> Thanks,
> Philipp
>
>
>
> ___
Pushed. Thank you :)
On 02/21/2012 04:54 AM, Albert Thuswaldner wrote:
> Hi,
> This is just a small clean-up patch of files that I'm currently working on.
>
> Regarding the translation effort I hope Christina is not working on
> these particular files:
>
> http://wiki.documentfoundation.org/Deve
@all: Was wondering: Should we be removing the todo code, please?
On 02/26/2012 12:29 AM, Bartolomé Sánchez Salado wrote:
> Hello.
>
> I've removed some unused virtual methods inside backends as Michael
> Meeks requested me:
>
> http://www.mail-archive.com/libreoffice@lists.freedesktop.org/msg23
[For improved clarity and better license handling:]
All of my past & future contributions to LibreOffice may be licensed
under the MPL/LGPLv3+ dual license, including the go-oo (and where
applicable, OpenOffice.org) code contributions
___
LibreOffice mai
@Ivan: Thanks! I missed that one.
On 02/27/2012 06:45 PM, Ivan Timofeev wrote:
> On 27.02.2012 16:59, Ivan Timofeev wrote:
>> Hi Christina,
>>
>> On 27.02.2012 12:22, Chr. Rossmanith wrote:
>>> some more getLength() -> isEmpty() replacements. Would be nice if
>>> someone could review the patch.
>>
Pushed. Thank you!
On 02/26/2012 05:47 AM, Petr Vorel wrote:
> Another patch removing some unused methods.
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
_
Pushed. Thank you!
On 02/27/2012 01:52 PM, Chr. Rossmanith wrote:
> Hi,
>
> some more getLength() -> isEmpty() replacements. Would be nice if
> someone could review the patch.
>
> Christina
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.
+1
should we also push it to 3.5.x branches as well?
On 02/16/2012 03:16 PM, Thorsten Behrens wrote:
> Hi there,
>
> could someone please review
>
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=905df1bae9cab296ee7dd07e88813c667788ed8a
>
> and cherry-pick to -3-5? A very obvious g
+1 Looks ok to me.
PS: How many sign-off's would we need in these cases (script changes)?
On 02/08/2012 10:06 PM, Jan Holesovsky wrote:
> Hi,
>
> I'm about to upload the new version of the 3.4 wikihelp. These are the
> patches I am using to generate that, would be great to get them in the
> rep
Hello,
It would be nice to have
http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd33c0b1cf23020b27db25895eeb380653d734b6
on 3.5.x (at least on 3.5.1 ?) branch.
The problem is because we set the master slide name with already
existing one (which is not allowed in lo)
Thank you so much for
+1 from me too...
On 02/01/2012 03:58 PM, Noel Power wrote:
> On 31/01/12 22:14, Lionel Elie Mamane wrote:
>> Attached patch fixes fdo#45453, which breaks datasheet display of all
>> queries/tables (with more than twice the number of rows than fit on
>> screen), if the database system does not pro
Hello Kendy,
>
> I am very much afraid this is lost in the history of the CWS merges :-(
> It might be properly affiliated only if you had commit access to
> ooo-build at that time (and committed your stuff there), the history of
> that counts.
Yes, I had commit access to ooo-build as well (during
While at it: My commits from around the year 2005 seem to have been
missed causing my joining date to be listed as 2010. It would be great
if it could be fixed as well. Thanks!
On 01/26/2012 11:59 PM, Andras Timar wrote:
> Hi,
>
> readlicense_oo/odt/CREDITS.odt is rather outdated. I would like to
Marking this as pushed. I pushed it as two different patches - one for
the translations and the other the easyhack. Thank you for the patches
(I really liked the new behavior of the button). And sorry for the delay.
Some nitpicking:
- It would be great if you could use expand tabs (i.e. spaces inst
> So - -really- I'm less convinced of that. As I said - this busts our
> history.
Yes, I very well agree with this - I have faced problems with the
history before. But, I was actually referring to specifically the git
hooks - which might be helpful in catching typos?
>
> So - as I sai
2012 10:19 AM, Muthu Subramanian K wrote:
> Hello Alexander,
>
> Its nice to see those patches. But, it will be nice to see/use the
> tools/scripts directly? Especially if they can be hooked to git (like
> the current white space/tabs removal ones)?
>
> @lubos: Alexander is good with
Hello Alexander,
Its nice to see those patches. But, it will be nice to see/use the
tools/scripts directly? Especially if they can be hooked to git (like
the current white space/tabs removal ones)?
@lubos: Alexander is good with scripts, so as a starter he wanted to do
something like
"http://cgit
Pushed. Thank you for the patch!
Looking for more... :)
On 01/25/2012 03:02 AM, Christina Roßmanith wrote:
> Reduced duplicate code detected by simian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/li
Hello,
I did some initial review of the patch. It works really nicely.
It would be great if somebody more knowledgeable in this area confirm
and push - thanks a lot!
Some nitpicking: isEmpty() seems to be accidentally replaced with
getLength().
@Winfried: Thanks a lot for the patch. Its really c
Marking the two unused code removal patches in basegfx as pushed.
Thank you for the contributions :)
And Of course, looking forward for more!
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libr
Hi,
Thank you for the cool patch(s).
Pushed - except for the code in svx/source/svdraw/svdoole2.cxx - I felt
there were some commented code which acts like pointers for the TODOs -
would you like to relook at this, please?
Thanks a lot! ( and of course, looking for more...:) )
Muthu Subramanian
Hi,
I am somehow not yet convinced. I would want to wait for a second opinion.
Thanks!
Muthu Subramanian
On 01/23/2012 03:38 PM, Marcel Metz wrote:
> Hello Muthu,
>
> On 23.01.2012 09:19, Muthu Subramanian K wrote:
>> Before pushing, it would be great to understand th
Pushed. Thank you for your patch.
Looking for more! :)
http://cgit.freedesktop.org/libreoffice/core/commit/?id=7735b09b5e10e366ffb3a156790316ea0ccfa0a0
On 01/22/2012 05:21 PM, Thomas Collerton wrote:
> Hello, this patch addresses the EasyHack described
> at https://bugs.freedesktop.org/show_bug.c
Thanks for the patch!
On 01/22/2012 06:01 PM, Mariusz Dykierek wrote:
> Attached patch removes
> NfCurrencyEntry::ApplyVariableInformation(NfCurrencyEntry const&) as
> listed in unusedcode.easy.
>
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice
Pushed! Thank you for the patch!
Looking for more :)
On 01/22/2012 05:44 PM, Mariusz Dykierek wrote:
> Hi,
>
> Attached patch removes:
> - LineListBox::GetEntryLine1
> - LineListBox::GetEntryLine2
> - LineListBox::GetEntryDistance
> - LineListBox::GetSelectEntryLine1
> - LineListBox::GetSele
Hello Marcel,
Thank you for the nice patch.
Before pushing, it would be great to understand the reason behind
replacing the macro with regular code. I believe the macro would help in
improving code readability (and of course the code size) - in my
understanding. Any particular reason, please?
Tha
Pushed it with slight modifications. Thank you so much for the patch!
Looking forward for more... :)
http://cgit.freedesktop.org/libreoffice/core/commit/?id=9042c4d0740c5b222b27d189e526b74fbd740b6f
On 01/23/2012 03:32 AM, Mariusz Dykierek wrote:
> Subject explains almost everything.
>
>
>
>
>
Marking this pushed:
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=b9977b7a23ba4d9fc739133b6aa199f5d6cdec35
Thank you all.
On 01/05/2012 12:37 PM, Muthu Subramanian K wrote:
> Thank you so much!
> So, I assume we have 3 reviews for this.
> I will pus
Thank you so much!
So, I assume we have 3 reviews for this.
I will push this to 3.5 today, if there are no objections by then.
Thanks again for the reviews!
Muthu Subramanian
On 01/05/2012 02:29 AM, Miklos Vajna wrote:
> On Wed, Jan 04, 2012 at 04:24:22PM +0100, Jan Holesovsky
> wrote:
>>>
Approved from me too.
On 12/30/2011 04:36 PM, Jan Holesovsky wrote:
> Hi Andras,
>
> On 2011-12-26 at 22:44 +0100, Andras Timar wrote:
>
>> https://bugs.freedesktop.org/show_bug.cgi?id=38435
>> Missing icons in index designer - it is a regression and fix is trivial.
>> http://cgit.freedesktop.or
Hi,
I had written this patch quite some time back:
https://issues.apache.org/ooo/attachment.cgi?id=68593&action=diff
Related to
https://bugs.freedesktop.org/show_bug.cgi?id=33602
I assumed this was in go-oo.org and also made it to libreoffice, but I
guess I was wrong.
If the code is fine, shall I
Ah...that didn't strike me...because I assumed it is
again converted back to 8bit by shifting back...which is the case as
well in some functions e.g. GetColor()...but then it doesn't seem to
matter so much as much as for up-sampling.
Thank you for the clarifications.
Yes, 65535/255 or 0x/0xFF m
Hi,
During the code digging for one of the bugs, I came across GetXPixel()
function in vcl. Which seems to be implemented wrong - not sure why it
is multiplied by 257 - the idea, I believe, is to convert 8bit to 16bit
values for X11, but I may be wrong. I have attached the patch with this
mail for
1 - 100 of 126 matches
Mail list logo
