Re: 'master' 'make check' lcov code coverage report

2014-11-08 Thread Maarten Hoes
On Fri, Nov 7, 2014 at 8:55 PM, Norbert Thiebaud nthieb...@gmail.com wrote: This is not really part of the product we package... os just put an appropriate open-source license statement at the to of the script. and prolly the best is to find a place for it in 'buildbot.git' (accessble via

Re: 'master' 'make check' lcov code coverage report

2014-11-08 Thread Maarten Hoes
On Sat, Nov 8, 2014 at 9:50 AM, Maarten Hoes hoes.maar...@gmail.com wrote: On Fri, Nov 7, 2014 at 8:55 PM, Norbert Thiebaud nthieb...@gmail.com wrote: This is not really part of the product we package... os just put an appropriate open-source license statement at the to of the script.

Re: 'master' 'make check' lcov code coverage report

2014-11-08 Thread Norbert Thiebaud
On Sat, Nov 8, 2014 at 3:03 AM, Maarten Hoes hoes.maar...@gmail.com wrote: On Sat, Nov 8, 2014 at 9:50 AM, Maarten Hoes hoes.maar...@gmail.com wrote: nevermind, I guess this is it: https://wiki.documentfoundation.org/Development/gerrit yep :-) one more question: is it possible to change

Re: 'master' 'make check' lcov code coverage report

2014-11-07 Thread Maarten Hoes
On Mon, Nov 3, 2014 at 8:12 PM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Maybe not weekly but bi-weekly or monthly. Otherwise it will only be done from time to time without a plan. Hrm. Good point.

Re: 'master' 'make check' lcov code coverage report

2014-11-07 Thread Norbert Thiebaud
On Fri, Nov 7, 2014 at 10:38 AM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:12 PM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Maybe not weekly but bi-weekly or monthly. Otherwise

Re: 'master' 'make check' lcov code coverage report

2014-11-07 Thread Maarten Hoes
On Fri, Nov 7, 2014 at 7:29 PM, Norbert Thiebaud nthieb...@gmail.com wrote: On Fri, Nov 7, 2014 at 10:38 AM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:12 PM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard

Re: 'master' 'make check' lcov code coverage report

2014-11-07 Thread Norbert Thiebaud
On Fri, Nov 7, 2014 at 1:28 PM, Maarten Hoes hoes.maar...@gmail.com wrote: all these 3 point could be solved by putting that job under jenkins control.. I'll have a look at doing that. Alright, so no complex error handling code then. But I guess you still will want the script to exit with a

Re: 'master' 'make check' lcov code coverage report

2014-11-06 Thread Stephan Bergmann
On 11/04/2014 11:45 AM, Michael Stahl wrote: On 04.11.2014 10:49, Maarten Hoes wrote: Hrm. Looks like I may have made a silly (and wrong) assumption. Is all non-libreoffice code located in these two directory's in the source tree ? : src/libreoffice/workdir/ExternalProject/libfoo

Re: 'master' 'make check' lcov code coverage report

2014-11-06 Thread Michael Stahl
On 06.11.2014 12:03, Stephan Bergmann wrote: On 11/04/2014 11:45 AM, Michael Stahl wrote: On 04.11.2014 10:49, Maarten Hoes wrote: Hrm. Looks like I may have made a silly (and wrong) assumption. Is all non-libreoffice code located in these two directory's in the source tree ? :

Re: 'master' 'make check' lcov code coverage report

2014-11-06 Thread Caolán McNamara
On Wed, 2014-11-05 at 16:21 +0100, Maarten Hoes wrote: On Wed, Nov 5, 2014 at 4:07 PM, Caolán McNamara caol...@redhat.com wrote: On Tue, 2014-11-04 at 12:15 +0100, Maarten Hoes wrote: I can easily export some pictures to the psd format for you. Just

Re: 'master' 'make check' lcov code coverage report

2014-11-06 Thread Maarten Hoes
On Mon, Nov 3, 2014 at 12:44 PM, Maarten Hoes hoes.maar...@gmail.com wrote: Hi, I ran an gcov/lcov report of 'make check' on master ('sccomp_lpsolver.test' and 'sw_tox.test' failed for some reason with a core dump, and therefore are excluded from the results), which I could (if interested)

Re: 'master' 'make check' lcov code coverage report

2014-11-05 Thread Caolán McNamara
On Tue, 2014-11-04 at 12:15 +0100, Maarten Hoes wrote: I can easily export some pictures to the psd format for you. Just point me to the location of the source files you want converted Oh anything at all, even a blank square in the .psd format is a good start, and you can just mail it to me

Re: 'master' 'make check' lcov code coverage report

2014-11-05 Thread Maarten Hoes
On Wed, Nov 5, 2014 at 4:07 PM, Caolán McNamara caol...@redhat.com wrote: On Tue, 2014-11-04 at 12:15 +0100, Maarten Hoes wrote: I can easily export some pictures to the psd format for you. Just point me to the location of the source files you want converted Oh anything at all, even a

Re: 'master' 'make check' lcov code coverage report

2014-11-04 Thread Maarten Hoes
Hrm. Looks like I may have made a silly (and wrong) assumption. Is all non-libreoffice code located in these two directory's in the source tree ? : src/libreoffice/workdir/ExternalProject/libfoo src/libreoffice/external/libfoo In that case, it may simply be the case of excluding these two top

Re: 'master' 'make check' lcov code coverage report

2014-11-04 Thread Michael Stahl
On 04.11.2014 10:49, Maarten Hoes wrote: Hrm. Looks like I may have made a silly (and wrong) assumption. Is all non-libreoffice code located in these two directory's in the source tree ? : src/libreoffice/workdir/ExternalProject/libfoo src/libreoffice/external/libfoo easily 98% of it

Re: 'master' 'make check' lcov code coverage report

2014-11-04 Thread Maarten Hoes
On Mon, Nov 3, 2014 at 5:59 PM, Caolán McNamara caol...@redhat.com wrote: The catch apparently is that we don't have a single image/x-photo-cd pcd attachment in any of the Red Hat, Freedesktop, legacy OpenOffice.org, etc bugzillas to use as a test now that I look into my local horde from

Re: 'master' 'make check' lcov code coverage report

2014-11-04 Thread Maarten Hoes
On Tue, Nov 4, 2014 at 11:45 AM, Michael Stahl mst...@redhat.com wrote: On 04.11.2014 10:49, Maarten Hoes wrote: Hrm. Looks like I may have made a silly (and wrong) assumption. Is all non-libreoffice code located in these two directory's in the source tree ? :

'master' 'make check' lcov code coverage report

2014-11-03 Thread Maarten Hoes
Hi, I ran an gcov/lcov report of 'make check' on master ('sccomp_lpsolver.test' and 'sw_tox.test' failed for some reason with a core dump, and therefore are excluded from the results), which I could (if interested) upload (if given access) to dev-builds.libreoffice.org/lcov_reports/ for

Re: 'master' 'make check' lcov code coverage report

2014-11-03 Thread Caolán McNamara
On Mon, 2014-11-03 at 12:44 +0100, Maarten Hoes wrote: Hi, I ran an gcov/lcov report of 'make check' on master ('sccomp_lpsolver.test' and 'sw_tox.test' failed for some reason with a core dump, and therefore are excluded from the results), which I could (if interested) upload (if given

Re: 'master' 'make check' lcov code coverage report

2014-11-03 Thread Caolán McNamara
On Mon, 2014-11-03 at 16:57 +0100, Maarten Hoes wrote: On Mon, Nov 3, 2014 at 4:10 PM, Caolán McNamara caol...@redhat.com wrote: I'd be interested especially interested in which dirs in filter/source/graphicfilter have 0 coverage and are import filters. Does this list handle

Re: 'master' 'make check' lcov code coverage report

2014-11-03 Thread Markus Mohrhard
Hey Maarten, On Mon, Nov 3, 2014 at 4:10 PM, Caolán McNamara caol...@redhat.com wrote: On Mon, 2014-11-03 at 12:44 +0100, Maarten Hoes wrote: Hi, I ran an gcov/lcov report of 'make check' on master ('sccomp_lpsolver.test' and 'sw_tox.test' failed for some reason with a core dump, and

Re: 'master' 'make check' lcov code coverage report

2014-11-03 Thread Maarten Hoes
On Mon, Nov 3, 2014 at 6:09 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Hey Maarten, On Mon, Nov 3, 2014 at 4:10 PM, Caolán McNamara caol...@redhat.com wrote: On Mon, 2014-11-03 at 12:44 +0100, Maarten Hoes wrote: Hi, I ran an gcov/lcov report of 'make check' on master

Re: 'master' 'make check' lcov code coverage report

2014-11-03 Thread Markus Mohrhard
Hey, On Mon, Nov 3, 2014 at 7:38 PM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 6:09 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Hey Maarten, On Mon, Nov 3, 2014 at 4:10 PM, Caolán McNamara caol...@redhat.com wrote: On Mon, 2014-11-03 at 12:44 +0100,

Re: 'master' 'make check' lcov code coverage report

2014-11-03 Thread Norbert Thiebaud
On Mon, Nov 3, 2014 at 12:38 PM, Maarten Hoes hoes.maar...@gmail.com wrote: Looking briefly at the differences (or lack thereof) in the reports of both 11-Apr-2014 and today, I cannot help but wonder if running the report as often as weekly would be beneficial at this point. Doing it manually

Re: 'master' 'make check' lcov code coverage report

2014-11-03 Thread Maarten Hoes
On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Maybe not weekly but bi-weekly or monthly. Otherwise it will only be done from time to time without a plan. Hrm. Good point. Even weekly would not hurt as we have neither a problem with disk space or

Re: 'master' 'make check' lcov code coverage report

2014-11-03 Thread Christian Lohmaier
Hi Maarten, *, On Mon, Nov 3, 2014 at 8:12 PM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Alright, I guess that means Ill have a go at it, then. So who do I need to mail my pub ssh key and what is the

Re: 'master' 'make check' lcov code coverage report

2014-11-03 Thread Maarten Hoes
On Mon, Nov 3, 2014 at 8:25 PM, Christian Lohmaier cl...@documentfoundation.org wrote: Hi Maarten, *, On Mon, Nov 3, 2014 at 8:12 PM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Alright, I guess that