Re: [Libreoffice] [PATCH] Introduce HideDisabledMenuItems style setting

2011-04-28 Thread Lubos Lunak
On Wednesday 27 of April 2011, Christian Lohmaier wrote: > Hi Christian, *, > > On Thu, Apr 21, 2011 at 3:44 PM, Christian Dywan wrote: > > I'm introducing a setting that decides if disabled menu items should be > > hidden. Currently the code is broken in the sense that items are hidden > > if di

Re: [Libreoffice] [PATCH] Introduce HideDisabledMenuItems style setting

2011-04-28 Thread Lubos Lunak
On Wednesday 27 of April 2011, Christian Dywan wrote: > Am 27.04.2011 13:01:36 schrieb Christoph Noack: > > Just a small question ... do I get it right that the disabled menu items > > get hidden instead of being "grayed out"? Real interest: could you > > please explain what the rationale for the c

Re: [Libreoffice] [PATCH] Introduce HideDisabledMenuItems style setting

2011-04-27 Thread Christoph Noack
Hi Christian! Sorry, it seems that I'm still a bit confused about that issue ... Am Mittwoch, den 27.04.2011, 11:13 + schrieb Christian Dywan: > Am 27.04.2011 13:01:36 schrieb Christoph Noack: > > Just a small question ... do I get it right that the disabled menu items > > get hidden instead

Re: [Libreoffice] [PATCH] Introduce HideDisabledMenuItems style setting

2011-04-27 Thread Christian Lohmaier
Hi Christian, *, On Thu, Apr 21, 2011 at 3:44 PM, Christian Dywan wrote: > I'm introducing a setting that decides if disabled menu items should be > hidden. Currently the code is broken in the sense that items are hidden if > disabled on all platforms and UpdateApplicationSettings which theorti

Re: [Libreoffice] [PATCH] Introduce HideDisabledMenuItems style setting

2011-04-27 Thread Christian Dywan
Am 27.04.2011 13:01:36 schrieb Christoph Noack: > Just a small question ... do I get it right that the disabled menu items > get hidden instead of being "grayed out"? Real interest: could you > please explain what the rationale for the change is? As far as I know, > there is currently no platfor

Re: [Libreoffice] [PATCH] Introduce HideDisabledMenuItems style setting

2011-04-21 Thread Christoph Noack
Hi Christian, all! Just a small question ... do I get it right that the disabled menu items get hidden instead of being "grayed out"? Real interest: could you please explain what the rationale for the change is? As far as I know, there is currently no platform guideline that requires that (or even

[Libreoffice] [PATCH] Introduce HideDisabledMenuItems style setting

2011-04-21 Thread Christian Dywan
I'm introducing a setting that decides if disabled menu items should be hidden. Currently the code is broken in the sense that items are hidden if disabled on all platforms and UpdateApplicationSettings which theortically does that is a) counter-intuitive and b) not set by platforms. The patch s