On 24/03/12 01:26, Albert Thuswaldner wrote:
> Hi Markus,
> Thanks for your review.
>
> On Thu, Mar 22, 2012 at 01:14, Markus Mohrhard
> wrote:
>>
>> Ok. So as promised I reviewed the patch now. Sadly there are some more
>> problems than I thought after my first quick look:
also, this thing cras
Hey Michael,
thanks for looking into this.
>
> my fix actually tried to do this for one of them, but i've noticed that
> in table3.cxx there is code that hard-codes sorting related arrays to
> size 3, which crashes when you add back the code that i've commented
> out; at that point i thought this
Hi Markus and Michael,
On Thu, Apr 5, 2012 at 11:57, Markus Mohrhard
wrote:
> Hey Michael,
>
> thanks for looking into this.
>
>>
>> my fix actually tried to do this for one of them, but i've noticed that
>> in table3.cxx there is code that hard-codes sorting related arrays to
>> size 3, which cr
Hello Albert,
2012/3/15 Albert Thuswaldner :
> Hi Markus,
> So I have hacked on this a bit, progress has been slow, detours and so
> on. Anyhow, I think have now completed the step 1, i.e changed the
> underlying code removing the static limit. I've have tried to keep
> much of the old structure f
Hey Albert,
2012/3/20 Albert Thuswaldner :
> Hi Markus,
>
> On Thu, Mar 15, 2012 at 04:27, Markus Mohrhard
> wrote:
>> Hello Albert,
>>
>> I have a simple idea that shouldn't be too complex to implement. I
>> think we can agree that only the sort entries are the difficult part.
>> I would create
Hey Albert,
> I will check this patch tomorrow. A quick look through the patch did
> not show any serious problems only some small nit-picks that I will
> change while reviewing.
>
Ok. So as promised I reviewed the patch now. Sadly there are some more
problems than I thought after my first quick
Hello Albert,
sorry that it took me some time but I had a long fight with our chart
interpolation algorithm and was not able to update my tree for more
than a week.
>> - ScSortDescriptor::FillSortParam looks like there might happen some
>> index out of bounds access
>
> So I have updated the patc
Hello Albert,
>
> sorry that it took me some time but I had a long fight with our chart
> interpolation algorithm and was not able to update my tree for more
> than a week.
>
>>> - ScSortDescriptor::FillSortParam looks like there might happen some
>>> index out of bounds access
>>
>> So I have upd
Hi Markus,
On Sat, Mar 31, 2012 at 18:36, Markus Mohrhard
wrote:
> And had to revert it immediately. We can use initializer lists because
> older gcc versions don't know this feature. I got spammed by nearly
> every of our tinderbox. I tried to fix them but the whole patch is
> build around that
Hi Markus,
So I have hacked a bit on the UI for the new sort dialog in calc. I'm
posting my work-in-progress patch hoping to get confirmation that I'm
on the right track and also help with the specific issues below.
As you suggested I've used the same concept for as in namedlg, where I
created ScS
Hey Albert,
> So I have hacked a bit on the UI for the new sort dialog in calc. I'm
> posting my work-in-progress patch hoping to get confirmation that I'm
> on the right track and also help with the specific issues below.
>
> As you suggested I've used the same concept for as in namedlg, where
Servus Markus,
Just an update on what I've been doing on this.
On Sun, Apr 29, 2012 at 4:37 PM, Markus Mohrhard
wrote:
>> So far so good I think, then comes the ugly bits:
>>
>> 1.) Obviously I'm using the wrong widget class for ScSortKeyDlg since
>> each dialog opens in a separate window and ar
Hi Marcus,
Here is an updated patch which I hope you have time to review. I'm
sure that there are things that can be done differently, but basically
the patch works.
I have found two problems myself that I need help resolving:
1.) Compile time waring about resources ids. There is probably a
simpl
Hi Markus,
Forgot to CC the list in my previous mail, sorry for the noise.
The patch in the last mail was also wrong.
On Fri, May 18, 2012 at 12:10 PM, Markus Mohrhard
wrote:
> Hello Albert,
>
> Sorry that it took me a bit to review your patch but my master trees
> are totally screwed for my own
Hi Albert,
2012/5/18 Markus Mohrhard :
>
> This one is quite simple. we need to move the identifiers out of the 0
> to 255 range.
>
> Andras, do you have an idea what range is useable in sc for this? I
> think most of the 256 to 999 range is already used but I have no idea
> where to check this.
Hi Andras,
Thanks for taking your time to reply.
On Tue, May 22, 2012 at 5:50 PM, Andras Timar wrote:
> Hi Albert,
>
> 2012/5/18 Markus Mohrhard :
>>
>> This one is quite simple. we need to move the identifiers out of the 0
>> to 255 range.
>>
>> Andras, do you have an idea what range is useable
Hey Albert,
2012/5/24 Albert Thuswaldner :
> Hi Andras,
> Thanks for taking your time to reply.
>
> On Tue, May 22, 2012 at 5:50 PM, Andras Timar wrote:
>> Hi Albert,
>>
>> 2012/5/18 Markus Mohrhard :
>>>
>>> This one is quite simple. we need to move the identifiers out of the 0
>>> to 255 range.
Hey Albert,
>
> I already had a quick look at the closing problem and it seems it is
> not a crash. It looks more like a missing close handler which results
> in the parent window being closed which is in this case the LibO
> window but I need to spend some more time on it. I will spend next
> wee
HI Marcus,
Sorry for not replying until now. Forgot to CC the list again...
On Tue, Jun 5, 2012 at 3:13 AM, Markus Mohrhard
wrote:
> Hey Albert,
>
>>
>> I already had a quick look at the closing problem and it seems it is
>> not a crash. It looks more like a missing close handler which results
>>
Hey Albert,
>
>> Thanks a lot for this amazing work. I added it to the 3.6 release notes page.
>
> I added a reference to the bug and a screenshot to the release notes.
Great. The screenshot looks really good.
> I have a few things lined up which I want to do next. For instance, do
> you mind if
20 matches
Mail list logo
