Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-06-06 Thread Albert Thuswaldner
HI Marcus, Sorry for not replying until now. Forgot to CC the list again... On Tue, Jun 5, 2012 at 3:13 AM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Hey Albert, I already had a quick look at the closing problem and it seems it is not a crash. It looks more like a missing close

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-06-06 Thread Markus Mohrhard
Hey Albert, Thanks a lot for this amazing work. I added it to the 3.6 release notes page. I added a reference to the bug and a screenshot to the release notes. Great. The screenshot looks really good. I have a few things lined up which I want to do next. For instance, do you mind if I

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-06-04 Thread Markus Mohrhard
Hey Albert, I already had a quick look at the closing problem and it seems it is not a crash. It looks more like a missing close handler which results in the parent window being closed which is in this case the LibO window but I need to spend some more time on it. I will spend next week on

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-05-25 Thread Markus Mohrhard
Hey Albert, 2012/5/24 Albert Thuswaldner albert.thuswald...@gmail.com: Hi Andras, Thanks for taking your time to reply. On Tue, May 22, 2012 at 5:50 PM, Andras Timar tima...@gmail.com wrote: Hi Albert, 2012/5/18 Markus Mohrhard markus.mohrh...@googlemail.com: This one is quite simple. we

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-05-23 Thread Albert Thuswaldner
Hi Andras, Thanks for taking your time to reply. On Tue, May 22, 2012 at 5:50 PM, Andras Timar tima...@gmail.com wrote: Hi Albert, 2012/5/18 Markus Mohrhard markus.mohrh...@googlemail.com: This one is quite simple. we need to move the identifiers out of the 0 to 255 range. Andras, do you

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-05-22 Thread Andras Timar
Hi Albert, 2012/5/18 Markus Mohrhard markus.mohrh...@googlemail.com: This one is quite simple. we need to move the identifiers out of the 0 to 255 range. Andras, do you have an idea what range is useable in sc for this? I think most of the 256 to 999 range is already used but I have no idea

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-05-21 Thread Albert Thuswaldner
Hi Markus, Forgot to CC the list in my previous mail, sorry for the noise. The patch in the last mail was also wrong. On Fri, May 18, 2012 at 12:10 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Hello Albert, Sorry that it took me a bit to review your patch but my master trees are

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-05-14 Thread Albert Thuswaldner
Hi Marcus, Here is an updated patch which I hope you have time to review. I'm sure that there are things that can be done differently, but basically the patch works. I have found two problems myself that I need help resolving: 1.) Compile time waring about resources ids. There is probably a

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-05-08 Thread Albert Thuswaldner
Servus Markus, Just an update on what I've been doing on this. On Sun, Apr 29, 2012 at 4:37 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: So far so good I think, then comes the ugly bits: 1.) Obviously I'm using the wrong widget class for ScSortKeyDlg since each dialog opens in a

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-04-29 Thread Markus Mohrhard
Hey Albert, So I have hacked a bit on the UI for the new sort dialog in calc. I'm posting my work-in-progress patch hoping to get confirmation that I'm on the right track and also help with the specific issues below. As you suggested I've used the same concept for as in namedlg, where I

[PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-04-26 Thread Albert Thuswaldner
Hi Markus, So I have hacked a bit on the UI for the new sort dialog in calc. I'm posting my work-in-progress patch hoping to get confirmation that I'm on the right track and also help with the specific issues below. As you suggested I've used the same concept for as in namedlg, where I created