Re: [PATCH] sal_bool and String conversions

2012-10-02 Thread Stephan Bergmann
On 10/02/2012 04:22 PM, Noel Grandin wrote: Part of my motivation for adding this, besides making String->OUString conversion easier, was that OUString already has the operator+= methods. Yes, but OUStringBuffer only has append() until now, and---as Michael already pointed out---some append()

Re: [PATCH] sal_bool and String conversions

2012-10-02 Thread Noel Grandin
On 2012-10-02 16:00, Stephan Bergmann wrote: am unsure about this: +OUStringBuffer & operator+=( const OUString &str ) +{ +return append( str.getStr(), str.getLength() ); +} + +/** +Appends the string representation of the char array +argument to thi

Re: [PATCH] sal_bool and String conversions

2012-10-02 Thread Stephan Bergmann
On 10/02/2012 03:01 PM, Michael Stahl wrote: On 02/10/12 08:33, Noel Grandin wrote: Patch 7 and 11 need careful checking because they add methods to OUStringBuffer and OUString. diff --git a/sal/inc/rtl/ustring.h b/sal/inc/rtl/ustring.h index 5b4982e..1595c0f 100644 --- a/sal/inc/rtl/ustring

Re: [PATCH] sal_bool and String conversions

2012-10-02 Thread Michael Stahl
On 02/10/12 08:33, Noel Grandin wrote: > Hi > > The first 4 patches perform sal_Bool->bool conversions in the SVL module. > > The next 8 patches perform UniString->OUString conversions. pushed about 8 of those. > Patch 7 and 11 need careful checking because they add methods to > OUStringBuffer