[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-16 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#21). Change subject: WIP: date/time IDL datatypes incompatible change

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-16 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#20). Change subject: WIP: date/time IDL datatypes incompatible change

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-15 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#16). Change subject: WIP: date/time IDL datatypes incompatible change

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-15 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#17). Change subject: WIP: date/time IDL datatypes incompatible change

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-15 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#18). Change subject: WIP: date/time IDL datatypes incompatible change

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-15 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#19). Change subject: WIP: date/time IDL datatypes incompatible change

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#12). Change subject: WIP: date/time IDL datatypes incompatible change

Re: [PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane
On Sun, Apr 14, 2013 at 02:22:54PM +0200, Thomas Arnhold wrote: are those OUString(buf.getStr()) necessary? I think it's working as it was before :) See sax/qa/cppunit/test_converter.cxx (afaik it's only in this file): -SAL_INFO(sax.cppunit, buf.getStr()); +SAL_INFO(sax.cppunit,

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#13). Change subject: WIP: date/time IDL datatypes incompatible change

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#14). Change subject: WIP: date/time IDL datatypes incompatible change

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#15). Change subject: WIP: date/time IDL datatypes incompatible change

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-13 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#11). Change subject: WIP: date/time IDL datatypes incompatible change

Re: [PUSHED][PATCH] WIP: Convert scalc delete contents dialog to .ui

2013-04-10 Thread Caolán McNamara
On Tue, 2013-04-09 at 22:40 +0200, Albert Thuswaldner wrote: On Tue, Apr 9, 2013 at 5:30 PM, Caolán McNamara caol...@redhat.com wrote: On Mon, 2013-04-08 at 17:52 +0200, Albert Thuswaldner wrote: I almost completed the conversion of the Delete Contents

Re: [PATCH] WIP: Convert scalc delete contents dialog to .ui

2013-04-09 Thread Caolán McNamara
On Mon, 2013-04-08 at 17:52 +0200, Albert Thuswaldner wrote: I almost completed the conversion of the Delete Contents dialog in Calc (see patch #1) What's missing from your patch is the .ui file itself, do a git add /path/to/that/file.ui and git commit --amend What I didn't manage to do was

Re: [PATCH] WIP: Convert scalc delete contents dialog to .ui

2013-04-09 Thread Albert Thuswaldner
On Tue, Apr 9, 2013 at 5:30 PM, Caolán McNamara caol...@redhat.com wrote: On Mon, 2013-04-08 at 17:52 +0200, Albert Thuswaldner wrote: I almost completed the conversion of the Delete Contents dialog in Calc (see patch #1) What's missing from your patch is the .ui file itself, do a git

[PATCH] WIP: Convert scalc delete contents dialog to .ui

2013-04-08 Thread Albert Thuswaldner
Hi Caolán, Thanks for your excellent tutorial on WidgetLayout conversion: https://wiki.documentfoundation.org/Development/WidgetLayout#HOWTO:_Step_by_step_dialog_conversion With the help of this I almost completed the conversion of the Delete Contents dialog in Calc (see patch #1) What I didn't

Re: [PATCH] WIP: Convert scalc delete contents dialog to .ui

2013-04-08 Thread Albert Thuswaldner
Correction, the second reference is: http://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh1.cxx#362 /Albert On Mon, Apr 8, 2013 at 5:52 PM, Albert Thuswaldner albert.thuswald...@gmail.com wrote: Hi Caolán, Thanks for your excellent tutorial on WidgetLayout conversion:

[PATCH] wip

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2944 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/2944/1 wip Change-Id: I23427e1e3bfb583ef10123577ebec76af617f917 --- M vcl/inc/vcl/bitmap.hxx M

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-03-23 Thread Lionel Elie Mamane (via Code Review)
Hello LibreOffice gerrit bot, Eike Rathke, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2783 to look at the new patch set (#10). Change subject: WIP: date/time IDL datatypes incompatible change

[PATCH] WiP: Remove the need to manually register libs in scp2

2013-02-14 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2144 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/2144/1 WiP: Remove the need to manually register libs in scp2 - we have all the needed information in gbuild - reduce

[PATCH] WIP fdo#56124 add IFERROR and IFNA to calc

2012-12-14 Thread Winfried Donkers (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1343 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/1343/1 WIP fdo#56124 add IFERROR and IFNA to calc Change-Id: If0145363ed7495a6633d80dabbbfac30af9a0301 --- M

[PATCH] WIP: move base check for bibliography to sfx2

2012-11-30 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1207 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/1207/1 WIP: move base check for bibliography to sfx2 - in the libbiblio component the frame is already created, and a

[PATCH] WIP: template pack installer

2012-11-14 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1071 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/1071/1 WIP: template pack installer - so this adds a button to the templates dialog to install

[PATCH] WIP: first stab at converting the insert-row dialog

2012-10-20 Thread Philipp Kaluza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/893 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/93/893/1 WIP: first stab at converting the insert-row dialog to UI format Change-Id:

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-06-06 Thread Albert Thuswaldner
HI Marcus, Sorry for not replying until now. Forgot to CC the list again... On Tue, Jun 5, 2012 at 3:13 AM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Hey Albert, I already had a quick look at the closing problem and it seems it is not a crash. It looks more like a missing close

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-06-06 Thread Markus Mohrhard
Hey Albert, Thanks a lot for this amazing work. I added it to the 3.6 release notes page. I added a reference to the bug and a screenshot to the release notes. Great. The screenshot looks really good. I have a few things lined up which I want to do next. For instance, do you mind if I

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-06-04 Thread Markus Mohrhard
Hey Albert, I already had a quick look at the closing problem and it seems it is not a crash. It looks more like a missing close handler which results in the parent window being closed which is in this case the LibO window but I need to spend some more time on it. I will spend next week on

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-05-25 Thread Markus Mohrhard
Hey Albert, 2012/5/24 Albert Thuswaldner albert.thuswald...@gmail.com: Hi Andras, Thanks for taking your time to reply. On Tue, May 22, 2012 at 5:50 PM, Andras Timar tima...@gmail.com wrote: Hi Albert, 2012/5/18 Markus Mohrhard markus.mohrh...@googlemail.com: This one is quite simple. we

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-05-23 Thread Albert Thuswaldner
Hi Andras, Thanks for taking your time to reply. On Tue, May 22, 2012 at 5:50 PM, Andras Timar tima...@gmail.com wrote: Hi Albert, 2012/5/18 Markus Mohrhard markus.mohrh...@googlemail.com: This one is quite simple. we need to move the identifiers out of the 0 to 255 range. Andras, do you

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-05-22 Thread Andras Timar
Hi Albert, 2012/5/18 Markus Mohrhard markus.mohrh...@googlemail.com: This one is quite simple. we need to move the identifiers out of the 0 to 255 range. Andras, do you have an idea what range is useable in sc for this? I think most of the 256 to 999 range is already used but I have no idea

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-05-21 Thread Albert Thuswaldner
Hi Markus, Forgot to CC the list in my previous mail, sorry for the noise. The patch in the last mail was also wrong. On Fri, May 18, 2012 at 12:10 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Hello Albert, Sorry that it took me a bit to review your patch but my master trees are

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-05-14 Thread Albert Thuswaldner
Hi Marcus, Here is an updated patch which I hope you have time to review. I'm sure that there are things that can be done differently, but basically the patch works. I have found two problems myself that I need help resolving: 1.) Compile time waring about resources ids. There is probably a

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-05-08 Thread Albert Thuswaldner
Servus Markus, Just an update on what I've been doing on this. On Sun, Apr 29, 2012 at 4:37 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: So far so good I think, then comes the ugly bits: 1.) Obviously I'm using the wrong widget class for ScSortKeyDlg since each dialog opens in a

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-04-29 Thread Markus Mohrhard
Hey Albert, So I have hacked a bit on the UI for the new sort dialog in calc. I'm posting my work-in-progress patch hoping to get confirmation that I'm on the right track and also help with the specific issues below. As you suggested I've used the same concept for as in namedlg, where I

[PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-04-26 Thread Albert Thuswaldner
Hi Markus, So I have hacked a bit on the UI for the new sort dialog in calc. I'm posting my work-in-progress patch hoping to get confirmation that I'm on the right track and also help with the specific issues below. As you suggested I've used the same concept for as in namedlg, where I created

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc

2012-04-05 Thread Markus Mohrhard
Hey Michael, thanks for looking into this. my fix actually tried to do this for one of them, but i've noticed that in table3.cxx there is code that hard-codes sorting related arrays to size 3, which crashes when you add back the code that i've commented out; at that point i thought this

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc

2012-04-04 Thread Michael Stahl
On 24/03/12 01:26, Albert Thuswaldner wrote: Hi Markus, Thanks for your review. On Thu, Mar 22, 2012 at 01:14, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Ok. So as promised I reviewed the patch now. Sadly there are some more problems than I thought after my first quick look:

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc

2012-04-02 Thread Albert Thuswaldner
Hi Markus, On Sat, Mar 31, 2012 at 18:36, Markus Mohrhard markus.mohrh...@googlemail.com wrote: And had to revert it immediately. We can use initializer lists because older gcc versions don't know this feature. I got spammed by nearly every of our tinderbox. I tried to fix them but the whole

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc

2012-03-31 Thread Markus Mohrhard
Hello Albert, sorry that it took me some time but I had a long fight with our chart interpolation algorithm and was not able to update my tree for more than a week. - ScSortDescriptor::FillSortParam looks like there might happen some index out of bounds access So I have updated the patch

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc

2012-03-21 Thread Markus Mohrhard
Hey Albert, I will check this patch tomorrow. A quick look through the patch did not show any serious problems only some small nit-picks that I will change while reviewing. Ok. So as promised I reviewed the patch now. Sadly there are some more problems than I thought after my first quick

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc

2012-03-20 Thread Markus Mohrhard
Hey Albert, 2012/3/20 Albert Thuswaldner albert.thuswald...@gmail.com: Hi Markus, On Thu, Mar 15, 2012 at 04:27, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Hello Albert, I have a simple idea that shouldn't be too complex to implement. I think we can agree that only the sort

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc

2012-03-14 Thread Markus Mohrhard
Hello Albert, 2012/3/15 Albert Thuswaldner albert.thuswald...@gmail.com: Hi Markus, So I have hacked on this a bit, progress has been slow, detours and so on. Anyhow, I think have now completed the step 1, i.e changed the underlying code removing the static limit. I've have tried to keep

Re: [Libreoffice] [PATCH] [WIP] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

2011-05-29 Thread Rob Snelders
Hi Albert, Then you are a lot further then I am. I'll leave you to it. Please state in the ticket when you are working on it. That way nobody will work on the ticket when you are busy with it. Greetings, Rob Snelders On 28-05-11 21:46, Albert Thuswaldner wrote: Hi Rob, On Sat, May 28,

Re: [Libreoffice] [PATCH] [WIP] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

2011-05-28 Thread Albert Thuswaldner
Hi Rob, On Sat, May 28, 2011 at 01:01, Rob Snelders programm...@ertai.nl wrote: Hi Albert, I have worked on this bug before I heard that you had already worked on it. Did you work any further on it? Maybe we can callaborate on it? Oh, how far did you come? I think I basically have done most

Re: [Libreoffice] [PATCH] [WIP] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

2011-05-27 Thread Rob Snelders
Hi Albert, I have worked on this bug before I heard that you had already worked on it. Did you work any further on it? Maybe we can callaborate on it? I have found the place where the number of sheets is set. This is in

Re: [Libreoffice] [PATCH] [WIP] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

2011-05-18 Thread Albert Thuswaldner
Hi Kohei, Thanks for your help. On Mon, May 9, 2011 at 21:19, Kohei Yoshida kyosh...@novell.com wrote: On Sun, 2011-05-08 at 17:09 +0200, Albert Thuswaldner wrote: Dear List, As a first attempt to contribute some code to LO, I've started hacking on his:

Re: [Libreoffice] [PATCH] [WIP] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

2011-05-09 Thread Albert Thuswaldner
Hi again, In case my original email got stuck in peoples spam filter (I accidentally managed to send it as a HTML mail) here it is again. If it still went through, sorry for spamming the list. Regards, /Albert On Sun, May 8, 2011 at 17:09, Albert Thuswaldner albert.thuswald...@gmail.com wrote:

Re: [Libreoffice] [PATCH] [WIP] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

2011-05-09 Thread Kohei Yoshida
On Sun, 2011-05-08 at 17:09 +0200, Albert Thuswaldner wrote: Dear List, As a first attempt to contribute some code to LO, I've started hacking on his: https://bugs.freedesktop.org/show_bug.cgi?id=33293 I think I have come quite far with implementing the changes to the configuration

[Libreoffice] [PATCH] [WIP] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

2011-05-08 Thread Albert Thuswaldner
Dear List, As a first attempt to contribute some code to LO, I've started hacking on his: https://bugs.freedesktop.org/show_bug.cgi?id=33293 I think I have come quite far with implementing the changes to the configuration dialog (see the patch). Here there is still some things to do, like

Re: [Libreoffice] [PATCH] [WIP] Remove most of dead code in libs-core

2011-04-05 Thread Christina Roßmanith
shell part pushed. Christina Am 20.03.2011 00:52, schrieb Xisco Faulí: Here we go with the first round of patches. Whitespaces are not deleted anymore and all the bogus have been deleted. Everything builds allright. Part 1 --

Re: [Libreoffice] [PATCH] [WIP] Remove most of dead code in libs-core

2011-04-04 Thread Christina Roßmanith
Pushed the linguistic part. Christina Am 20.03.2011 00:52, schrieb Xisco Faulí: Here we go with the first round of patches. Whitespaces are not deleted anymore and all the bogus have been deleted. Everything builds allright. Part 1 --

Re: [Libreoffice] [PATCH] [WIP] Remove most of dead code in libs-core

2011-03-29 Thread Christina Roßmanith
Hi, pushed the framework part. Again a lot of files changed their place so it was quite a lot of work to apply the patch. Additionally I removed lots of dates, comments above removed commented methods, {} not needed anymore after the if () has gone and changed if ( bState = sal_True) to if

Re: [Libreoffice] [PATCH] [WIP] Remove most of dead code in libs-core

2011-03-28 Thread Christina Roßmanith
Hi, formula and sfx2 pushed. The files WriterHelper.java and DocumentMetadataAccess.java changed their place in the code tree but DocumentMetaData.java seems to have been removed. Christina Am 20.03.2011 00:52, schrieb Xisco Faulí: Here we go with the first round of patches. Whitespaces

Re: [Libreoffice] [PATCH] [WIP] Remove most of dead code in libs-core

2011-03-19 Thread Xisco Faulí
Here we go with the first round of patches. Whitespaces are not deleted anymore and all the bogus have been deleted. Everything builds allright. Part 1 -- http://dl.dropbox.com/u/1274885/removed-commented-code-part1.tar.gz I'll post the second part soon Greetings 2011/3/18 Christina Roßmanith

[Libreoffice] [PATCH][WIP] fdo#31251 - Improve default page layout

2011-02-27 Thread Sébastien Le Ray
Hi list, Attached is a patch that improves Writer page as described in fdo#31251[1]. After a quick poll on various LibreOffice user it appears that a halo on the four borders is confusing so we have a smooth shadow on two borders. There are still some little glitches and book mode is not fully