Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-24 Thread Eike Rathke
Hi Kohei, On Monday, 2012-07-23 22:15:57 -0400, Kohei Yoshida wrote: > Anyway, in case we change our mind and backport this to 3.6, commits > 4e8552993aed7caaa247bb1baf6168ddcfba159a through > 01ee7955fe6d0e25c325717fe7d5dbd56e28983c add an extra configuration > option to toggle this behavior. G

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-23 Thread Kohei Yoshida
On 07/23/2012 11:51 AM, Petr Mladek wrote: Eike Rathke píše v Po 23. 07. 2012 v 17:36 +0200: Hi Kohei, On Friday, 2012-07-20 10:10:48 -0400, Kohei Yoshida wrote: I'll add this configuration option during 3.7 cycle if this can wait until 3.7. If you guys need it earlier than that I could work

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-23 Thread khagaroth
>From a translators point of view, it would be no problem. The translations are continually updated anyway. I guess it could be a little bit annoying for people that do not use pootle, but who cares about one untranslated string if it fixes a problem that breaks compatibility, not to mention there

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-23 Thread Petr Mladek
Eike Rathke píše v Po 23. 07. 2012 v 17:36 +0200: > Hi Kohei, > > On Friday, 2012-07-20 10:10:48 -0400, Kohei Yoshida wrote: > > > I'll add this configuration option during 3.7 cycle if this can wait > > until 3.7. If you guys need it earlier than that I could work on it > > and push it as a lat

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-23 Thread Kohei Yoshida
On 07/23/2012 11:36 AM, Eike Rathke wrote: Hi Kohei, On Friday, 2012-07-20 10:10:48 -0400, Kohei Yoshida wrote: I'll add this configuration option during 3.7 cycle if this can wait until 3.7. If you guys need it earlier than that I could work on it and push it as a late feature if it's desper

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-23 Thread Eike Rathke
Hi Kohei, On Friday, 2012-07-20 10:10:48 -0400, Kohei Yoshida wrote: > I'll add this configuration option during 3.7 cycle if this can wait > until 3.7. If you guys need it earlier than that I could work on it > and push it as a late feature if it's desperately needed for 3.6. I'd appreciate if

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-20 Thread Kohei Yoshida
On 07/20/2012 10:04 AM, Caolán McNamara wrote: On Thu, 2012-07-19 at 17:58 +0200, Markus Mohrhard wrote: Hey Eike, Kohei, 2012/7/19 Kohei Yoshida : I'm also not fully convinced of this patch. This behavior has been in Libreoffice since the start so IMHO it is more important to keep the behavior

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-20 Thread Caolán McNamara
On Thu, 2012-07-19 at 17:58 +0200, Markus Mohrhard wrote: > Hey Eike, Kohei, > 2012/7/19 Kohei Yoshida : > I'm also not fully convinced of this patch. This behavior has been in > Libreoffice since the start so IMHO it is more important to keep the > behavior for all the LibO users than to change it

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-19 Thread Andrew Douglas Pitonyak
On 07/19/2012 11:58 AM, Markus Mohrhard wrote: Hey Eike, Kohei, 2012/7/19 Kohei Yoshida : On 07/19/2012 10:29 AM, Eike Rathke wrote: Hi, Please review and cherry-pick to 3-6 and 3-6-0 http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a that resol

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-19 Thread Markus Mohrhard
Hey Eike, Kohei, 2012/7/19 Kohei Yoshida : > On 07/19/2012 10:29 AM, Eike Rathke wrote: >> >> Hi, >> >> Please review and cherry-pick to 3-6 and 3-6-0 >> >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a >> that resolves https://bugs.freedesktop.or

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-19 Thread Kohei Yoshida
On 07/19/2012 10:29 AM, Eike Rathke wrote: Hi, Please review and cherry-pick to 3-6 and 3-6-0 http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a that resolves https://bugs.freedesktop.org/show_bug.cgi?id=50345 to accept empty string and strings conta

[REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-19 Thread Eike Rathke
Hi, Please review and cherry-pick to 3-6 and 3-6-0 http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a that resolves https://bugs.freedesktop.org/show_bug.cgi?id=50345 to accept empty string and strings containing only blanks as an argument converted to