Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On 14/03/18 16:03, Christian Lohmaier wrote: On Wed, Mar 14, 2018 at 3:29 PM, Stephan Bergmann wrote: (And I think David already nailed the reason down in another mail in this thread.) To be honest hard to find the info in all that ranting/user permissions re setting

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On Wed, Mar 14, 2018 at 3:29 PM, Stephan Bergmann wrote: > On 14/03/18 14:38, Christian Lohmaier wrote: >> >> Then it is worse - your mailserver then silently deletes mail. Here's >> one that was sent to both you and me and that still was in my >> inbox...: > > > Why do you

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On 14/03/18 14:38, Christian Lohmaier wrote: Then it is worse - your mailserver then silently deletes mail. Here's one that was sent to both you and me and that still was in my inbox...: Why do you assume that I did not get that mail? It was apparently a mail triggered by a Jenkins comment

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

Hi Stephan, *, On Fri, Mar 9, 2018 at 3:38 PM, Stephan Bergmann wrote: > On 06.03.2018 10:09, Stephan Bergmann wrote: >> >> There's no such mails blocked in my spam folder. Then it is worse - your mailserver then silently deletes mail. Here's one that was sent to both you

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On 11/03/18 09:59, David Ostrovsky wrote: On Fri Mar 9 19:14:33 UTC 2018, Eike Rathke wrote: On Tuesday, 2018-03-06 10:09:22 +0100, Stephan Bergmann wrote: for a Gerrit change on which I'm listed as reviewer, I do get mails for mine and all other people's comments, just not for comments from

Let failed Jenkins builds set Verified: -1 in Gerrit?

On Fri Mar 9 19:14:33 UTC 2018, Eike Rathke wrote: >> On Tuesday, 2018-03-06 10:09:22 +0100, Stephan Bergmann wrote: >> for a Gerrit change on which I'm listed as reviewer, I do get mails for mine >> and all other people's comments, just not for comments from Jenkins. > >Same here. I also don't

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

Hi, On Tuesday, 2018-03-06 10:09:22 +0100, Stephan Bergmann wrote: > On 05.03.2018 21:41, Christian Lohmaier wrote: > > On Wed, Feb 28, 2018 at 9:24 AM, Stephan Bergmann > > wrote: > > > On 23.02.2018 18:57, Christian Lohmaier wrote: > > > > Done - now jenkins' message

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On 06.03.2018 10:09, Stephan Bergmann wrote: On 05.03.2018 21:41, Christian Lohmaier wrote: On Wed, Feb 28, 2018 at 9:24 AM, Stephan Bergmann wrote: On 23.02.2018 18:57, Christian Lohmaier wrote: Done - now jenkins' message should be sent to ALL (owner, reviewer and

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On 05.03.2018 21:41, Christian Lohmaier wrote: On Wed, Feb 28, 2018 at 9:24 AM, Stephan Bergmann wrote: On 23.02.2018 18:57, Christian Lohmaier wrote: Done - now jenkins' message should be sent to ALL (owner, reviewer and "interested" users (those who starred the change

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

Hi Stephan, On Wed, Feb 28, 2018 at 9:24 AM, Stephan Bergmann wrote: > On 23.02.2018 18:57, Christian Lohmaier wrote: >> >> Done - now jenkins' message should be sent to ALL (owner, reviewer and >> "interested" users (those who starred the change or watch another user >> on

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On 23.02.2018 18:57, Christian Lohmaier wrote: Done - now jenkins' message should be sent to ALL (owner, reviewer and "interested" users (those who starred the change or watch another user on the changeset) Doesn't seem to work. For example, I didn't get any mails for any of

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

Hi *, On Fri, Feb 23, 2018 at 4:22 PM, Miklos Vajna wrote: > Hi, > > On Fri, Feb 23, 2018 at 04:08:24PM +0100, Stephan Bergmann > wrote: >> > I think this was a decision from Norbert, probably because he was worried >> > about false negatives. A

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

he dashboard? Note that there was follow-on discussion back then, but unfortunately detached from the original mail thread due to missing In-Reply-To headers on two of David's replies, <https://lists.freedesktop.org/archives/libreoffice/2017-November/078991.html> "Let failed Jenkins bu

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On 2/23/2018 6:22 PM, Miklos Vajna wrote: > Hi, > > On Fri, Feb 23, 2018 at 04:08:24PM +0100, Stephan Bergmann > wrote: >>> I think this was a decision from Norbert, probably because he was worried >>> about false negatives. A workaround is to watch your inbox (which gets a

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

Hi, On Fri, Feb 23, 2018 at 04:08:24PM +0100, Stephan Bergmann wrote: > > I think this was a decision from Norbert, probably because he was worried > > about false negatives. A workaround is to watch your inbox (which gets a > > mail, whatever is the outcome), rather than

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On 30.11.2017 09:00, Miklos Vajna wrote: On Wed, Nov 29, 2017 at 12:16:24PM +0100, Stephan Bergmann wrote: Is there any good reason why a failed Gerrit/Jenkins build does not set the corresponding Gerrit change's Verified flag to -1 (similar to how a successful such build

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On 12/07/2017 09:07 PM, Michael Stahl wrote: mainly the benefit would be that you could see on the search page which changes have finished build logs that need investigating, those would be the "verified: -1" ones. Exactly. That's what I stated as motivation in this thread's original post.

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On 01.12.2017 18:27, Norbert Thiebaud wrote: > On Fri, Dec 1, 2017 at 1:32 AM, David Ostrovsky wrote: >> On Thu Nov 30 08:25:40 UTC 2017, Stephan Bergmann wrote: >> >>> Does "(with a help of maintainers)" imply that there are change >>> owners who could not override a VRFY-1

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

Hi, On Friday, 2017-12-01 11:27:02 -0600, Norbert Thiebaud wrote: > On Fri, Dec 1, 2017 at 1:32 AM, David Ostrovsky wrote: > > On Thu Nov 30 08:25:40 UTC 2017, Stephan Bergmann wrote: > >>Does "(with a help of maintainers)" imply that there are change > >>owners who could

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On Tue, Dec 5, 2017 at 1:16 AM, David Ostrovsky wrote: > > RTFM: [1]? Quoting: > > " > *Remove Reviewer* > > This category permits users to remove other users from the list of > reviewers on a change. > [...] > Project owners and site administrators can always remove any

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On Fri, 2017-12-01 at 11:27 -0600, Norbert Thiebaud wrote: > On Fri, Dec 1, 2017 at 1:32 AM, David Ostrovsky > wrote: > > On Thu Nov 30 08:25:40 UTC 2017, Stephan Bergmann wrote: > > > > > Does "(with a help of maintainers)" imply that there are change > > > owners who could

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On Fri, Dec 1, 2017 at 1:32 AM, David Ostrovsky wrote: > On Thu Nov 30 08:25:40 UTC 2017, Stephan Bergmann wrote: > >>Does "(with a help of maintainers)" imply that there are change >>owners who could not override a VRFY-1 from Jenkins themselves? > > Yes. I believe that

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

On Thu, Nov 30, 2017 at 2:00 AM, Miklos Vajna wrote: > > I think this was a decision from Norbert, probably because he was worried > about false negatives. A workaround is to watch your inbox (which gets a > mail, whatever is the outcome), rather than the above URL. > >

Let failed Jenkins builds set Verified: -1 in Gerrit?

On Thu Nov 30 08:25:40 UTC 2017, Stephan Bergmann wrote: >Does "(with a help of maintainers)" imply that there are change >owners who could not override a VRFY-1 from Jenkins themselves? Yes. I believe that "registered users" group members will not be able to remove VRFY-1 vote.

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

Hi Stephan, On Wed, Nov 29, 2017 at 12:16:24PM +0100, Stephan Bergmann wrote: > Is there any good reason why a failed Gerrit/Jenkins build does not set the > corresponding Gerrit change's Verified flag to -1 (similar to how a > successful such build sets the flag to +1)? >

Let failed Jenkins builds set Verified: -1 in Gerrit?

Is there any good reason why a failed Gerrit/Jenkins build does not set the corresponding Gerrit change's Verified flag to -1 (similar to how a successful such build sets the flag to +1)? Especially with the poor Jenkins turnaround times, it is hard to tell on a page like