Re: [Libreoffice] final and override

2011-11-28 Thread Stephan Bergmann
On 11/28/2011 08:10 PM, Pierre-André Jacquod wrote: but since it seems that MSCV (according the same wiki) supports it / will support it, why not just wait a bit and then use it directly, setting a minimal compiler version ? This would allow a "cleaner" code, not having to take into account "befo

Re: [Libreoffice] final and override

2011-11-28 Thread Pierre-André Jacquod
Hello, However, given that override and final will only make it into GCC 4.7 (according to ), it according to gcc.gnu.org too.. but since it seems that MSCV (according the same wiki) supports it / will support it, why not just wait a bit an

Re: [Libreoffice] final and override

2011-11-28 Thread Stephan Bergmann
On 11/28/2011 01:27 PM, Michael Meeks wrote: Sure - which is why we'd do that for old compiler versions only ...where it would still result in undefined behaviour, technically (note the "nitpick," was meant somewhat tongue-in-cheek). finalbool methodFoo(); virtua

Re: [Libreoffice] final and override

2011-11-28 Thread Michael Meeks
On Mon, 2011-11-28 at 11:42 +0100, Stephan Bergmann wrote: > On 11/28/2011 11:25 AM, Michael Meeks wrote: > > On the other hand; I'd (personally) prefer to use some defines to > > create the 'override' and 'final' keywords (as they will be in future). > > Defining them to 'virtual' or even emp

Re: [Libreoffice] final and override

2011-11-28 Thread Stephan Bergmann
On 11/28/2011 11:25 AM, Michael Meeks wrote: On the other hand; I'd (personally) prefer to use some defines to create the 'override' and 'final' keywords (as they will be in future). Defining them to 'virtual' or even empty would do, if they are not present in the compiler. cf. glib's pro

Re: [Libreoffice] final and override

2011-11-28 Thread Michael Meeks
On Mon, 2011-11-28 at 09:03 +0100, Stephan Bergmann wrote: > VOS_NAMESPACE etc. stuff, e.g.), we will likely need macros for new > features that can be enabled for compilers that already understand them, > without breaking the code for legacy compilers. I believe the Mozilla guys augmen

Re: [Libreoffice] final and override

2011-11-28 Thread Stephan Bergmann
On 11/27/2011 08:58 PM, Noel Grandin wrote: I see the Mozilla project is adding MOZ_FINAL and MOZ_OVERRIDE macros to help control method overriding in their codebase http://whereswalden.com/2011/11/16/introducing-moz_override-to-annotate-virtual-functions-which-override-base-class-virtual-functi