string / size bits ... #2 ...

2012-04-02 Thread Michael Meeks
On Fri, 2012-03-30 at 15:21 +0100, Michael Meeks wrote: > I up-loaded the output of my string debug for a writer start: And discovered there was a bazillion problems with it, in particular the handling of OUStrings, having nailed that - it now has some considerable error due to 'Str

Re: string / size bits ... #2 ...

2012-04-02 Thread Noel Grandin
To make it easier to find culprits, perhaps you could add a feature to your script? Use some kind of variable to select a specific string, and then store the callstack every time that string gets allocated, using backtrace() Then dump the top 100 call-stacks using backtrace_symbols() Brute forc

Re: string / size bits ... #2 ...

2012-04-02 Thread Michael Meeks
On Mon, 2012-04-02 at 16:52 +0200, Noel Grandin wrote: > To make it easier to find culprits, perhaps you could add a feature to > your script ? Checkout sal/rtl/source/strimp.hxx and instrument the _NEW piece to your heart's content. Potentially it'd be good to out-line that into a concre

Re: string / size bits ... #2 ...

2012-04-02 Thread Eike Rathke
Hi Michael, On Monday, 2012-04-02 15:25:58 +0100, Michael Meeks wrote: > How we get 81k allocations of a string containing '/' is somewhat > curious ;-) My first shoot would be configuration paths ... Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer

Re: string / size bits ... #2 ...

2012-04-02 Thread Lubos Lunak
On Monday 02 of April 2012, Michael Meeks wrote: > On Fri, 2012-03-30 at 15:21 +0100, Michael Meeks wrote: > > I up-loaded the output of my string debug for a writer start: > > And discovered there was a bazillion problems with it, in particular > the handling of OUStrings, having nailed

Re: string / size bits ... #2 ...

2012-04-02 Thread Enrico Weigelt
Hi, > I don't want to spoil the fun much for you :) , but I expect the > number of > string allocations to go down when RTL_CONSTASCII_* stops being used > in favor > of string literals, and further down after whenever I get to > implementing the > efficient operator+. So you may be profiling a

Re: string / size bits ... #2 ...

2012-04-03 Thread Lubos Lunak
On Tuesday 03 of April 2012, Enrico Weigelt wrote: > Hi, > > > I don't want to spoil the fun much for you :) , but I expect the > > number of > > string allocations to go down when RTL_CONSTASCII_* stops being used > > in favor > > of string literals, and further down after whenever I get to > >

Re: string / size bits ... #2 ...

2012-04-03 Thread Enrico Weigelt
> > Just curious: what's the big difference between rtl::OUString and > > std::string ? > > http://lists.freedesktop.org/archives/libreoffice/2012-March/028485.html > (and > click the next message link a couple of times). Okay. Do situations where std::string doesnt suffice happen that often,

Re: string / size bits ... #2 ...

2012-04-03 Thread Tor Lillqvist
> Okay. Do situations where std::string doesnt suffice happen that often, > that we need to OUString virtually everywhere ? You aren't telling us anything we don't know already. Sure, stopping using UTF-16 strings in situations where it is just ASCII anyway that is handled is one thing we want to

Re: string / size bits ... #2 ...

2012-04-04 Thread Bjoern Michaelsen
On Tue, Apr 03, 2012 at 06:00:27AM +0200, Enrico Weigelt wrote: > Just curious: what's the big difference between rtl::OUString and std::string > ? The most important is that rtl::OUString is part of the public API. Best, Bjoern ___ LibreOffice mailin