Re: New tool for better understanding the codebase, to complement the wiki.

On 02/14/2012 02:33 PM, Michael Meeks wrote: On Tue, 2012-02-14 at 23:07 +1030, Josh Heidenreich wrote: What is the markup format to be used in the READMEs? It's a loose copy of the wikimedia syntax used in the wiki, so: - Paragraphs are separated by a blank line. - Headings are in the form "=

Re: [ANN] Referencing bugs in commits

hello, The bug reference has to have fdo#ABCDE form (where ABCDE is the bug number), and has to be at the first line of the commit (it does not matter where on that line). Sorry, one point is for me not clear: by the first line, do you mean "title line" or would it works also as first line o

input for fdo#45779 from a basegfx knowledgeable person needed

hello, I have quickly investigated the crash in fdo#45779 when saving an impress document. The reason of the crash is in basegfx/inc/basegfx/point/b2dpoint.hxx (line 82) where this is called: 2DPoint::B2DPoint (this=0xbfffc850, rPoint=...) : B2DTuple(rPoint) (from back-trace) It tur

Re: one-big library approach of mozilla ...

On 2/14/2012 4:24 AM, Michael Meeks wrote: Hi Taras, We're running into some fun performance& development iteration problems with LibreOffice as we plan to merge more libraries together; and I was wondering - how does Mozilla deal with that ? How long does it take your develope

Re: [Libreoffice-commits] "Remove unused VolumeDevice functions and related code"

On Tue, Feb 14, 2012 at 06:18:52PM +0100, Stephan Bergmann wrote: > On 02/05/2012 09:52 PM, François Tigeot wrote: > > > > Remove unused VolumeDevice functions and related code > > > [...] > >diff --git a/sal/util/sal.map b/sal/util/sal.map > >index 472ea8f..338854d 100644 > >--- a/sal/util/sal

Re: poor little bug

On Tue, 2012-02-14 at 20:06 +0100, Luc Castermans wrote: > I'm this poor little bug left alone in the corner. When will I be solved ? Feel free to have a look at the code! You seem to forget that I already spent days for a first fix that improves the situation. That's not the way I was told to say

Re: No page and Columns boundaries in 3.5

That was a design choice that was started long ago in the OpenOffice.org times, discussed at least lively with Christoph Noack (and most probably on the ux-advise list) a few months ago... I don't really like being asked to get some different feature back right after the release when people have p

Re: New tool for better understanding the codebase, to complement the wiki.

Stephan Bergmann wrote: > I wonder whether there's not some package to translate one of those > newfangled lightweight markups into HTML which could be reused here? > Sure - e.g. http://search.cpan.org/~rwstauner/Pod-Markdown-1.20/lib/Pod/Markdown.pm or http://pypi.python.org/pypi/Markdown

Re: [Libreoffice-commits] "Remove unused VolumeDevice functions and related code"

On Wed, 2012-02-15 at 09:05 +0100, Francois Tigeot wrote: > I may have been a bit too enthusiastic with sal.map; feel free to add > the entries back if you think they are needed. Heh - so, we should of course leave the functions there so linking continues to work, but have dummy implement

Re: New tool for better understanding the codebase, to complement the wiki.

On Tue, 2012-02-14 at 23:01 +0100, Stephan Bergmann wrote: > On 02/14/2012 10:39 PM, Josh Heidenreich wrote: > > Do we need licence blocks in a README? Can we just write the licence in > > on all pages generated by the script? > > My (naive?) take on it is that, technically, all the files committ

Re: .: bin/get-bugzilla-attachments-by-mimetype

On 21/11/11 11:18, Caolán McNamara wrote: > On Mon, 2011-11-21 at 02:04 +0100, Miklos Vajna wrote: >> On Mon, Nov 14, 2011 at 02:37:07AM -0800, Caolán McNamara >> wrote: >>> add script to download documents from various bugzillas i've pimped it a bit and it can now download ~all document typ

Re: input for fdo#45779 from a basegfx knowledgeable person needed

Pierre-André Jacquod wrote: > B2DTuple(const B2DTuple& rTup) > ... > Here you dereference the null pointer, which crash. > > Ok, the basic attitude would be to let B2DTuple be Null-pointer > consistent: (checking that rTup is not NULL), but is it really a > good idea? > Hi Pierre-André, no, wha

Re: [EasyHack] #44681 port to CLucene from java/Lucene

On Tue, 2012-02-14 at 12:01 +, Caolán McNamara wrote: > On Tue, 2012-02-14 at 09:45 +0100, G.H.M.Valkenhoef, van wrote: > > > > > Yes, I found that java code (the HelpIndexer I refer to). I'll work on > > a patch to replace the XInvocations of the Java code with calls to my > > code. > > I ca

Re: .: bin/get-bugzilla-attachments-by-mimetype

On Wed, 2012-02-15 at 11:06 +0100, Michael Stahl wrote: > that's the only thing that's still missing... should i file an easy > hack? :) Indeed, that probably makes sense. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.

Re: [PUSHED-3-5] fdo#45995 & fdo#45992

On 14/02/12 19:17, Petr Mladek wrote: It did not work because the test document used linked picture. It works well with the updated test document. The changes look reasonable. They work well => I have pushed them into the 3-5 branch, see http://cgit.freedesktop.org/libreoffice/core/commit/?h=l

Re: input for fdo#45779 from a basegfx knowledgeable person needed

> > Or should I look higher in the hierarchy, saying that a NULL point > > in a B2DPolygon has nothing to do and disallow it ? > > > Yes, the calling code somehow accesses invalid elements. Let me have > a look. > Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you like, would be co

[REVIEW-3-5] Fix for fdo#45779

Hi there, could someone please review & cherry-pick http://cgit.freedesktop.org/libreoffice/core/commit/?id=d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 for -3-5? TIA, -- Thorsten pgpMmILR9mq7a.pgp Description: PGP signature ___ LibreOffice mailing list

Re: No page and Columns boundaries in 3.5

On Tue, 14 Feb 2012 19:16:56 +0100, Fernand Vanrie wrote: On the user lists the first complaints about "no" page and column boundaries for LO Writer 3.5 are comming in. For some documents the "new corner layout" can be helpfull but without visible page and column boundaries it becomes very dif

Re: linking performance

On 14/02/12 13:30, Mark Wielaard wrote: > Hi, > > Added Tom to the CC, see thread here: > http://thread.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/24055/focus=24096 > (Although it seems posts from non-subscribers, aka me, are not allowed, > so you won't see my earlier reply there.

Re: README.cross patch [REJECTED]

Ther autogen.lastrun samples in README.cross are *examples*. If should be obvious that: --with-android-ndk=/home/tml/android-ndk-r7 is an example and not to be used literally. Replacing it with --with-android-ndk= Location of ndk download doesn't really help much. Especially as "ndk download" c

[PUSHED] Re: [REVIEW-3-5] Fix for fdo#45779

On 15/02/12 11:32, Thorsten Behrens wrote: > Hi there, > > could someone please review & cherry-pick > http://cgit.freedesktop.org/libreoffice/core/commit/?id=d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 > for -3-5? hmm.. dividing by 0 considered harmful indeed http://cgit.freedesktop.org/libreoffic

[REVIEW] fdo#45553 fix RTF import of space-before/after tokens

Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=c32b9cd2139249f0c680f664a0ceac3702dd0e73 Could someone review and cherry-pick to -3-5, please? Thanks, Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.f

RE: [PUSHED] Re: [PATCH]bug 44516 improved label and business card document creation

Hi Winfried, Winfried Donkers píše v St 15. 02. 2012 v 07:27 +0100: > >Pushed that, thank you a lot for that! > >http://cgit.freedesktop.org/libreoffice/core/commit/?id=80a72c4cc7edc6b4c0b88d841500617cd733cbf7 > >Kendy > > To my horror the behaviour of the pushed patch is not identical to the pa

[PUSHED] Turn on strictures for some installer Perl modules

Hi Tim ! On Tue, 2012-02-14 at 23:02 +, Tim Retout wrote: > I'd like to try to clean up some of the code in the solenv Perl > modules Cool ! it is long overdue. > - as a first task, I want to turn on 'use strict', which I'd > consider a bare minimum for maintainable Perl. Longer-te

RE: [PUSHED] Re: [PATCH]bug 44516 improved label and business card document creation

Kendy wrote (15-02-2012 12.34) >I only changed some (leading) tabs to spaces, it should not affect >anything. But to be sure, just take the patch from git and diff it with >your patch that works for you, and look at the differences. I thought so, but you never know. Thanks for checking. > should

[REVIEW][3-5] Re: Bug 45530 - Accessibility does not work

On 15/02/12 04:10, Masataka Shinke wrote: > Patch of Bug 45530 - Accessibility does not work > https://bugs.freedesktop.org/show_bug.cgi?id=45530 hello Masataka, yes, the Java accessibility bridge was effectively not installed; thanks a lot for finding this problem and for the fix. could you ple

Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?

On 14 February 2012 19:23, Tor Lillqvist wrote: > I also merged sal and sal_textenc (in the --enable-mergelibs case). Hmm, I experimented with this but apparently didn't commit and then did a git reset and lost the changes, or something. Will have a look again if I still have the stuff in Emacs

Re: [EasyHack] #44681 port to CLucene from java/Lucene

Great, thanks. That looks like it fills in most of the missing pieces from my patch. On 15-02-12, Caolán McNamara wrote: > On Tue, 2012-02-14 at 12:01 +, Caolán McNamara wrote: > > On Tue, 2012-02-14 at 09:45 +0100, G.H.M.Valkenhoef, van wrote: > > > > > > > Yes, I found that java code (th

RE: [PUSHED] Re: [PATCH]bug 44516 improved label and business card document creation

Hi Winfried, Winfried Donkers píše v St 15. 02. 2012 v 13:15 +0100: > > should I revert the patch in the meantime? > I understood from Markus Mohrhard that Tor had fixed the git/qa problem. > I intend to look into it later this afternoon (UTC); I don't think reverting > the patch > is necessary,

connectivity::ORowSetValue cleanup and behaviour

Hi, The connectivity contains a ORowSetValue class, to hold a database value, along with its type. "Obviously" this class is used all over the place in our database-related code. I'm itching to change it in non-trivial ways, and I've hit some "WTFs", so I thought I'd check if someone knows a good

Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?

On 15 February 2012 13:35, Tor Lillqvist wrote: > On 14 February 2012 19:23, Tor Lillqvist wrote: > >> I also merged sal and sal_textenc (in the --enable-mergelibs case). > > Hmm, I experimented with this but apparently didn't commit and then > did a git reset and lost the changes, or something.

Re: [EasyHack] #44681 port to CLucene from java/Lucene

On Tue, 2012-02-14 at 22:27 +0100, Gert van Valkenhoef wrote: > 1. how to convert the rtl::UOString to the TCHAR* that CLucene needs. > 2. In xmlhelp/source/cxxhelp/provider/makefile.mk, I've hacked the > include path to include l10ntools/source/help Attached patch hopefully basically takes car

[PUSHED 3-5] Re: [REVIEW][3-5] Re: Bug 45530 - Accessibility does not work

Hi Michael, Michael Stahl píše v St 15. 02. 2012 v 13:35 +0100: > please somebody review and backport the following to libreoffice-3-5: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=fbe60c962259ae0449acd65e74fd790530045e93 > > http://cgit.freedesktop.org/libreoffice/core/commit/?

Re: [PUSHED][PATCH] unusedcode.easy: Removed unused code

On Fri, 2012-02-10 at 17:39 +0100, Alexander Bergmann wrote: > --- > editeng/source/editeng/editdoc.cxx |8 > editeng/source/editeng/editdoc.hxx |1 - pushed this now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.

Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?

> It was something more than this: ? Umm, no, that was it. Now I am confused, why don't I see that in my master checkout after merging the branch to master? Git is a mystery. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://li

Re: [PATCH] Translate German comments - final patch

On Wed, Feb 15, 2012 at 01:46:55PM +0100, Philipp Weissenbacher wrote: > So, any developer wishes on what to translate next? In general, dbaccess/ and connectivity/ are the two modules of particular interest to me. I get the impression I'll have to dig into forms/ in the next months, just today,

Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?

On 02/14/2012 06:23 PM, Tor Lillqvist wrote: I also merged sal and sal_textenc (in the --enable-mergelibs case). I'm not sure this is not counter-productive. For Android and iOS it might be vital to get sal_textenc merged, to reduce the overall number of dynamic libraries. But for other pla

Re: [PUSHED] Remove unused methods from PDFI

On Mon, 2012-02-13 at 19:48 +, Kate Goss wrote: > I'm also contemplating tackling bugs in bugzilla assistant, if that > would be helpful. Oh ! cool :-) yes very much so, Rainer has a number of tweaks and issues in there queued up for fixing if I remember correctly, it'd be just lovely

Re: [PATCH] [PUSHED] Translate German comments - final patch

Hi, pushed this with minor modifications. Thanks a lot for your work, Philipp! I hope you weren't already on this, Lionel... if yes, sorry. Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listi

[PUSHED] Re: [PATCH] Help - minor updates

Hi Stanislav, Radek Doulik píše v Út 14. 02. 2012 v 17:53 +0100: > Makes sense, thanks for clarification. Pushed. (master and 3-5 branches) Marking the thread as [PUSHED] :-) BTW - it is great that you are working on the help! Do you want to continue? I think some of the new 3.5 features migh

Re: [DONE][PUSHED][3-4][3-5] fdo#45995 & fdo#45992

Noel Power píše v St 15. 02. 2012 v 10:31 +: > On 14/02/12 19:17, Petr Mladek wrote: > > It did not work because the test document used linked picture. It > > works well with the updated test document. The changes look > > reasonable. They work well => I have pushed them into the 3-5 branch,

Re: changes in profile path in release notes for 3.5

Stephan Bergmann wrote (13-02-12 10:06) Introduced with "fdo#32263"; should affect all Linux desktops. Thanks for the info, Stephan, -- - Cor - http://nl.libreoffice.org _

Re: [PATCH] Translate German comments - final patch

On Wed, 2012-02-15 at 13:46 +0100, Philipp Weissenbacher wrote: > Find attached the patch that finalises my efforts to get rid of the > German comments in sw/source/core/doc. Wonderful ! :-) > Thanks Michael BTW for the mention in your Easy Hacks talk at FOSDEM. > Much appreciated!

Re: connectivity::ORowSetValue cleanup and behaviour

On Wed, Feb 15, 2012 at 01:55:34PM +0100, Lionel Elie Mamane wrote: > 2) Signed integers and unsigned integers never compare equal. But an >unsigned integer compares equal to the corresponding float... >Errr... They obviously should? I misread the code... Need coffee. integers never comp

[REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

As per "Importing uno bindings in python causes crash" the master commit "Reintroduce pyuno.so wrapper around libpyuno.so" should please be

Re: [PUSHED] Code removal, first contribution

Hi Catalin Catalin Iacob píše v Po 13. 02. 2012 v 22:09 +0100: > >So it sounds like you did an excellent job; what's next ? an easy > > hack > > perhaps ? or more unused code ? :-) > > It would be cool to try an easy hack If you haven't chosen yet, the Easy Hack landing page is here:

Re: [PATCH] Translate German comments - final patch

On 15 February 2012 14:56, Michael Meeks wrote: >> So, any developer wishes on what to translate next? > >        Cedric was giving a personal plea for sw/source/core/layout/ which he > wrestles with daily, is non-obvious code, and packed with impenetrable > German ;-) ~2700 detected lines in ther

Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?

> I'm not sure this is not counter-productive.  For Android and iOS it might > be vital to get sal_textenc merged, Well, --enable-mergelibs is probably actually intended for Android only, I think? But sure, I can change the condition to check $(OS) instead. We desperately need to reduce the number

Re: [PATCH] Translate German comments - final patch

2012/2/15 Philipp Weissenbacher : > On 15 February 2012 14:56, Michael Meeks wrote: >>> So, any developer wishes on what to translate next? >> >>        Cedric was giving a personal plea for sw/source/core/layout/ which he >> wrestles with daily, is non-obvious code, and packed with impenetrable >

Re: [PATCH] Translate German comments - final patch

Hi On Wed, 2012-02-15 at 13:56 +, Michael Meeks wrote: [...] > > So, any developer wishes on what to translate next? > > Cedric was giving a personal plea for sw/source/core/layout/ which he > wrestles with daily, is non-obvious code, and packed with impenetrable > German ;-) ~2700 dete

Re: [PATCH] Translate German comments - final patch

Hi On Wed, 2012-02-15 at 13:56 +, Michael Meeks wrote: [...] > > So, any developer wishes on what to translate next? > > Cedric was giving a personal plea for sw/source/core/layout/ which he > wrestles with daily, is non-obvious code, and packed with impenetrable > German ;-) ~2700 dete

Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?

On 02/15/2012 03:11 PM, Tor Lillqvist wrote: I'm not sure this is not counter-productive. For Android and iOS it might be vital to get sal_textenc merged, Well, --enable-mergelibs is probably actually intended for Android only, I think? I wasn't sure about the status of --enable-mergelibs, w

Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?

> I wasn't sure about the status of --enable-mergelibs, whether it is only > something Android-specific or whether it is also used to enable that general > merge/LTO endeavor. I don't know either, really. But anyway, I will make the sal_textenc+sal merge Android-specific and not mergelibs-specific

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 39026, which changed state. Bug 39026 Summary: Recent Documents list does not work https://bugs.freedesktop.org/show_bug.cgi?id=39026 What|Old Value |New Value ---

[PATCH] Translate German comments

Hi all, Lionel, Here are the files you mentioned earlier. Hope quality didn't suffer with this quick job. You might want to take a look at line num 2185 in DatabaseForm.cxx. Looks like commented out code. If you still find any German strings, please contact me and I'll help you. Cheers, Phil

[PUSHED] Re: [PATCH] Remove unused code

Just adding [PUSHED] :-) Radek Doulik píše v Út 14. 02. 2012 v 19:03 +0100: > Hi Santiago, > > thanks for you patch, pushed. > > Cheers > Radek > > On Mon, 2012-02-13 at 21:55 +0100, Santiago Martinez wrote: > > This patch removes unused code as listed in unusedcode.easy > > > > > > _

Re: [PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

Hi Updated patch implementing Ivan's suggestion. Passes make and make check. Convert tools/table.hxx usage in editeng/inc/editeng/forbiddencharacterstable.hxx to std::map Contributed under LGPLv3+ / MPL 1.1 or later. (And my license statement is on file in the wiki) Regards, Noel. On 2012

JRE warning on startup ...

Hi guys, There have been a number of complaints about JRE's being required during install, with the infamous and horribly unpleasant: "LibreOffice requires a Java runtime environment (JRE) to perform this task. Please install a JRE and restart LibreOffice"

Re: [PATCH] Translate German comments - final patch

>>       Cedric was giving a personal plea for sw/source/core/layout/ which he >> wrestles with daily, is non-obvious code, and packed with impenetrable >> German ;-) ~2700 detected lines in there .. > > I'm already working on this and will provide patches in a few days :) So I think we'll wait fo

Re: [PATCH] SwDocStub now prints out parameters

Hey, thanks a lot for your great work here. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Translate German comments - final patch

2012/2/15 Philipp Weissenbacher : >>>       Cedric was giving a personal plea for sw/source/core/layout/ which he >>> wrestles with daily, is non-obvious code, and packed with impenetrable >>> German ;-) ~2700 detected lines in there .. >> >> I'm already working on this and will provide patches in

Re: JRE warning on startup ...

On Wed, 2012-02-15 at 15:13 +, Michael Meeks wrote: > Since we switched ~everything to passive registration, I believe this > comes from the bundled extension help indexing on very-first-start. So, if its the case that its from extension help indexing, then this would probably be from xm

javadep.c & Java 7

Hi, I found soltools/javadep/javadep.c that contains a very simple parser for java class files. The problem is that it is old, at least it does not handle the class files generated by Java 7: as far as I remember, java guys added the new types of constant pool entries, but... javadep.c:520:

RE: qa-build errros on clean code

>Tor already fixed it and after a pull you should be able to build. >(http://cgit.freedesktop.org/libreoffice/core/commit/?id=49a4b4c32bda86b97ef48d1d2ce9bf8f02d3e2e3) >Hope that your next build succeeds. >Markus No such luck :( After git pull -r, the first clean build went ok, but the next buil

more (caligra) test files ...

On Wed, 2012-02-15 at 10:15 +, Caolán McNamara wrote: > On Wed, 2012-02-15 at 11:06 +0100, Michael Stahl wrote: > > that's the only thing that's still missing... should i file an easy > > hack? :) > > Indeed, that probably makes sense. If we're doing this systematically, we should pr

Re: poor little bug

On Tue, 2012-02-14 at 20:06 +0100, Luc Castermans wrote: > I'm this poor little bug left alone in the corner. When will I be solved ? This is in pretty poor taste, and doesn't belong on the developers list - which is for discussion of constructive development: hacking on fixes, code point

Re: [PATCH] Translate German comments - final patch

Hi Nicolas, On Wed, 2012-02-15 at 15:01 +0100, Nicolas Christener wrote: > I'm already working on this and will provide patches in a few days :) Great to have you working on this ! :-) From a working together perspective, it's almost always not a good idea to put people off worki

Re: qa-build errros on clean code

Hi Winfried, Il 15/02/2012 16:30, Winfried Donkers ha scritto: Value: 8 33formel: =A1+B1 3 ucalc.cxx:2924:Assertion Test name: N12_GLOBAL__N_14TestE::testPostIts assertion failed - Expression: m_pDoc->GetNote(rAddr) == NULL - note hasn't moved Any suggestions? I have this very same failure pl

RE: qa-build errros on clean code

Riccardo Magliocchetti wrote (15 februari 2012) >> ucalc.cxx:2924:Assertion >I have this very same failure plus another connectivity related, >building with this patch applied to at least finish the build: >http://paste.ubuntu.com/843064/ Yes, I'll also disable the tests that produce assertions

Re: [REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

On Wed, 2012-02-15 at 15:07 +0100, Stephan Bergmann wrote: > As per > "Importing uno bindings in python causes crash" the master commit > >

Re: [PATCH] Remove unused code from gtkframe

Hi Kate, On Tue, 2012-02-14 at 21:33 +, Kate Goss wrote: > Please find attached a patch to remove a couple of methods listed in > unusedcode.easy, from gtkframe. Sadly they are used - but only for the gtk3 mode that caolan is not compiling. Perhaps instead if you could move up the #i

[REVIEW-3-5] Fix for fdo#45177 - crash in Impress outline view

Hi, couldl someone please review http://cgit.freedesktop.org/libreoffice/core/commit/?id=57e6f04066cfddfa79eb2b79cf5c45653c79eff3 and cherry-pick to -3-5? It's not a final solution, since we're loosing some convenience in outline view undo, but better than a crash I think. Cheers, -- Thorste

Re: javadep.c & Java 7

On 02/15/2012 04:31 PM, Ivan Timofeev wrote: I found soltools/javadep/javadep.c that contains a very simple parser for java class files. The problem is that it is old, at least it does not handle the class files generated by Java 7: as far as I remember, java guys added the new types of constant

Re: .: 2 commits - configure.in sw/source

On 13/02/12 09:39, Tor Lillqvist wrote: > commit b7980663f0866629e7c54a085f31dba3d9c26b26 > Author: Tor Lillqvist > Date: Mon Feb 13 09:42:39 2012 +0200 > > WaE: type name first seen using 'class' now seen using 'struct' IMHO this is an utterly pointless warning, because the only differen

[RFC] x11 / cairo-less build try #3

Hello, this is another update on building libreoffice without need to link against X11 or toolkits in general. The aim is to ease the deploy server side where less dependencies needed the better. As you can see the vcl/headless/headlessinst.cxx has been shamelessly copied from Android, you can se

Re: javadep.c & Java 7

On 15.02.2012 20:41, Stephan Bergmann wrote: Apparently only remaining use is in the old build system (see solenv/inc/rules.mk, where it is called STARDEP). So I would not bother to invest any time in it -- as long as its shortcomings do not actually cause problems (which I don't quite get from y

Re: .: 2 commits - configure.in sw/source

On 02/15/2012 05:48 PM, Michael Stahl wrote: WaE: type name first seen using 'class' now seen using 'struct' IMHO this is an utterly pointless warning, because the only difference between "class" and "struct" is the default visibility of the members, and a forward declaration doesn't decla

Re: [PUSHED][PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

Hi Noel, On 15.02.2012 19:01, Noel Grandin wrote: Updated patch implementing Ivan's suggestion. Passes make and make check. Convert tools/table.hxx usage in editeng/inc/editeng/forbiddencharacterstable.hxx to std::map Looks good to me, pushed (without GetCharInfo - it was unused): http://cgit

Re: qa-build errros on clean code

Hey, 2012/2/15 Riccardo Magliocchetti : > Hi Winfried, > > Il 15/02/2012 16:30, Winfried Donkers ha scritto: >> >> Value: 8 >> 33formel: =A1+B1 >> >> 3 >> ucalc.cxx:2924:Assertion >> Test name: N12_GLOBAL__N_14TestE::testPostIts >> assertion failed >> - Expression: m_pDoc->GetNote(rAddr) == NULL >

Re: qa-build errros on clean code

Hi Markus, Il 15/02/2012 19:05, Markus Mohrhard ha scritto: Hey, 2012/2/15 Riccardo Magliocchetti: Hi Winfried, Il 15/02/2012 16:30, Winfried Donkers ha scritto: Value: 8 33formel: =A1+B1 3 ucalc.cxx:2924:Assertion Test name: N12_GLOBAL__N_14TestE::testPostIts assertion failed - Expression

Re: .: 2 commits - configure.in sw/source

> I completely > fail to see what actual problem could be caused by this. And how is that relevant? By the same logic, you could write code that just "knows" that ints are always 32 bits and whatnot. MSVC mangles struct and class differently (just one char difference, see http://en.wikipedia.org

Re: .: 2 commits - configure.in sw/source

On 15/02/12 19:28, Tor Lillqvist wrote: >> I completely >> fail to see what actual problem could be caused by this. > > And how is that relevant? By the same logic, you could write code that > just "knows" that ints are always 32 bits and whatnot. but no applicable standard requires ints to be 32

dbaccess_macros_test: no orderly shutdown

Hi all, Just experienced a spurious crash of cppunittester when executing Cppunit_dbaccess_macros_test, see backtraces below: * Thread 5 is the main thread, already in exit(3). * Thread 1 is executing a FastLoader thread (dbaccess/source/filter/xml/xmlfilter.cxx), and that code indeed has no

Re: [PATCH] Remove unused code from gtkframe

Hi Michael, Caolan, How accurate/ up to date is unusedcode.easy? Is there a way to make sure the methods I'm removing are genuinely unused? Am I just doing it wrong and removing the wrong things? : ) Kate On 15 February 2012 16:01, Michael Meeks wrote: > Hi Kate, > > On Tue, 2012-02-14 at 21:

[PATCH] Remove unused (hopefully!) methods from l10ntools Export

Hi, Another patch to remove methods listed as unused in unusedcode.easy Kate From e1934638ebc6f8456921c3b371997e878b414b28 Mon Sep 17 00:00:00 2001 From: Kate Goss Date: Wed, 15 Feb 2012 20:19:18 + Subject: [PATCH] Remove unused code from l10ntools Export Remove getCurrentDir( std::string&

Re: Hosting LibreOffice online

On Mon, 2012-02-13 at 12:24 +, Michael Meeks wrote: > On Mon, 2012-02-13 at 11:43 +0100, Andor E wrote: > > https://wiki.documentfoundation.org/Using_LibreOffice_in_a_Web_Browser > > > > As promised I have created a first version of the Wiki page. I hope it > > is not too awful. > > Tha

Re: [PATCH] Remove unused code from gtkframe

On 15/02/12 21:31, Kate Goss wrote: > Hi Michael, Caolan, > > How accurate/ up to date is unusedcode.easy? Is there a way to make sure > the methods I'm removing are genuinely unused? the problem is that unusedcode.easy is generated from a single configuration of LO. because there is a huge numb

Refactor installer::sorter

Hi! Here are a few patches related to installer::sorter. I've tried to keep them low-risk, because much of the code is called during Windows builds, which I'm not yet testing. I think the sort algorithm used currently in installer::sorter must be equivalent to bubble sort; in any case, I removed

License of my contributions

Hi, I confirm that all my past, present and future contributions to the LibreOffice project are licensed under the MPL / LGPLv3+. Regards, Stanislav Horacek ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/m

[PATCH] [core/fpicker/source/win32/filepicker/asynceventnotifier.cxx:243]: (performance) Possible inefficient checking for 'm_EventList' emptiness.

-- Pozdrawiam, Mariusz Dykerek diff --git a/fpicker/source/win32/filepicker/asynceventnotifier.cxx b/fpicker/source/win32/filepicker/asynceventnotifier.cxx index a155f8b..748e5ac 100644 --- a/fpicker/source/win32/filepicker/asynceventnotifier.cxx +++ b/fpicker/source/win32/filepicker/asynceventn

[PATCH] [core/dtrans/source/win32/dtobj/FetcList.cxx:123]: (performance) Possible inefficient checking for 'm_FormatMap' emptiness.

-- Pozdrawiam, Mariusz Dykerek diff --git a/dtrans/source/win32/dtobj/FetcList.cxx b/dtrans/source/win32/dtobj/FetcList.cxx index 3bb3beb..3599da8 100644 --- a/dtrans/source/win32/dtobj/FetcList.cxx +++ b/dtrans/source/win32/dtobj/FetcList.cxx @@ -120,7 +120,7 @@ sal_Bool CFormatEtcContainer::ha

Re: [PUSHED] Re: [PATCH] Help - minor updates

Dne 15.2.2012 14:45, Jan Holesovsky napsal(a): BTW - it is great that you are working on the help! Do you want to continue? I think some of the new 3.5 features might need an update in the help too - would that be interesting for you? Hi Kendy, you know that I would make no contribution with

[PATCH] [core/dtrans/source/win32/dtobj/FmtFilter.cxx:485]: (performance) Possible inefficient checking for 'fileList' emptiness.

-- Regards, Mariusz Dykerek diff --git a/dtrans/source/win32/dtobj/FmtFilter.cxx b/dtrans/source/win32/dtobj/FmtFilter.cxx index c012115..4093e92 100644 --- a/dtrans/source/win32/dtobj/FmtFilter.cxx +++ b/dtrans/source/win32/dtobj/FmtFilter.cxx @@ -482,7 +482,7 @@ typedef Sequence ByteSequence_t

[REVIEW-3-5] Fix some apparent misuses of RTL_CONSTASCII_USTRINGPARAM

The attached core-0001-Fix-some-apparent-misuses-of-RTL_CONSTASCII_USTRINGP.patch and binfilter-0001-Fix-some-apparent-misuses-of-RTL_CONSTASCII_USTRINGP.patch extract those parts of the master commits 9ab0b38e95133dab720408cc2c80093b8a201c10 and 715ac8c1b402e33930317a69bbdd61ad88133740 (core)

[PATCH] [core/linguistic/source/dlistimp.*:*]: (performance) Possible inefficient checking for 'aDicList' emptiness.

-- Pozdrawiam, Mariusz Dykerek diff --git a/linguistic/source/dlistimp.cxx b/linguistic/source/dlistimp.cxx index e824888..316d86d 100644 --- a/linguistic/source/dlistimp.cxx +++ b/linguistic/source/dlistimp.cxx @@ -608,7 +608,7 @@ void SAL_CALL pDicEvtLstnrHelper->DisposeAndClear(

Re: Master fails to compile with cclan in moz module

Hi, I'm still trying to compile with llvm/cclang. I disabled mozilla compilation and it compiled until cairo. I attached all the raw logs I had until now there : https://bugs.freedesktop.org/attachment.cgi?id=57120 If someone has an idea about this cairo problem Hope these raw logs help a little.

[PATCH] [core/vcl/source/window/splitwin.cxx:2047] -> [core/vcl/source/window/splitwin.cxx:2045]: (style) Found duplicate branches for if and else.

+ some simplification -- Regards, Mariusz Dykerek diff --git a/vcl/source/window/splitwin.cxx b/vcl/source/window/splitwin.cxx index f5da206..09ad468 100644 --- a/vcl/source/window/splitwin.cxx +++ b/vcl/source/window/splitwin.cxx @@ -2035,17 +2035,9 @@ void SplitWindow::ImplDrawFadeIn( sal_Bool

[PATCH] cppcheck's (portability) Extra qualification '::' unnecessary and considered an error by many compilers.

-- Regards, Mariusz Dykerek diff --git a/cli_ure/source/uno_bridge/cli_bridge.h b/cli_ure/source/uno_bridge/cli_bridge.h index 0306e4d..b9297d0 100644 --- a/cli_ure/source/uno_bridge/cli_bridge.h +++ b/cli_ure/source/uno_bridge/cli_bridge.h @@ -96,7 +96,7 @@ struct Bridge System::Object*

[PATCH] [core/editeng/source/items/borderline.cxx:514] -> [core/editeng/source/items/borderline.cxx:509]: (style) Found duplicate branches for if and else.

-- Regards, Mariusz Dykerek diff --git a/editeng/source/items/borderline.cxx b/editeng/source/items/borderline.cxx index b617ff4..1677141 100644 --- a/editeng/source/items/borderline.cxx +++ b/editeng/source/items/borderline.cxx @@ -492,29 +492,20 @@ bool SvxBorderLine::HasPriority( const SvxBor

Re: feature/gbuild_java is finished

On 14 February 2012 06:55, David Tardon wrote: > On Mon, Dec 26, 2011 at 01:33:57PM +0100, David Tardon wrote: >> I have converted 6 modules to gbuild on branch feature/gbuild_java: >> javaunohelper, jurt, jvmaccess, jvmfwk, ridljar and unoil. It builds >> fine here and smoketest finishes with sta

  1   2   >