date:20140314

 sc/source/filter/excel/excdoc.cxx   |3 ++-
 sc/source/filter/excel/excrecds.cxx |   24 
 sc/source/filter/inc/excrecds.hxx   |   25 ++---
 3 files changed, 36 insertions(+), 16 deletions(-)

New commits:
commit 00b7d4c8043a0c6b9e267f0fd5d7389128628ca0
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Thu Mar 13 21:49:04 2014 -0400

fdo#58307: Export sheet tab colors to xlsx.

And let's not re-use Biff's XclExpWsbool record class to export SheetPr
elements.  That was a bit hacky...

(cherry picked from commit 5063f31c248fd3c16115582a1e3aef182257a225)

Conflicts:
sc/source/filter/excel/excrecds.cxx
sc/source/filter/inc/excrecds.hxx

Change-Id: Ia585f53d547af3d6840fce1b1244b60bb5076b07
Reviewed-on: https://gerrit.libreoffice.org/8583
Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com

diff --git a/sc/source/filter/excel/excdoc.cxx 
b/sc/source/filter/excel/excdoc.cxx
index 9cf433d..87b17aa 100644
--- a/sc/source/filter/excel/excdoc.cxx
+++ b/sc/source/filter/excel/excdoc.cxx
@@ -550,7 +550,8 @@ void ExcTable::FillAsXmlTable( SCTAB nCodeNameIdx )
 
 Add( new ExcBof8 );
 
-Add( new XclExpWsbool( bFitToPages, mnScTab, GetFilterManager() ) );
+Color aTabColor = GetRoot().GetDoc().GetTabBgColor(mnScTab);
+Add(new XclExpXmlSheetPr(bFitToPages, mnScTab, aTabColor, 
GetFilterManager()));
 
 // GUTS (count  size of outline icons)
 aRecList.AppendRecord( mxCellTable-CreateRecord( EXC_ID_GUTS ) );
diff --git a/sc/source/filter/excel/excrecds.cxx 
b/sc/source/filter/excel/excrecds.cxx
index 9be9bfe..614a70a 100644
--- a/sc/source/filter/excel/excrecds.cxx
+++ b/sc/source/filter/excel/excrecds.cxx
@@ -442,16 +442,17 @@ void XclExpCountry::WriteBody( XclExpStream rStrm )
 
 // XclExpWsbool ===
 
-XclExpWsbool::XclExpWsbool( bool bFitToPages, SCTAB nScTab, 
XclExpFilterManager* pManager )
+XclExpWsbool::XclExpWsbool( bool bFitToPages )
 : XclExpUInt16Record( EXC_ID_WSBOOL, EXC_WSBOOL_DEFAULTFLAGS )
-, mnScTab( nScTab )
-, mpManager( pManager )
 {
 if( bFitToPages )
 SetValue( GetValue() | EXC_WSBOOL_FITTOPAGE );
 }
 
-void XclExpWsbool::SaveXml( XclExpXmlStream rStrm )
+XclExpXmlSheetPr::XclExpXmlSheetPr( bool bFitToPages, SCTAB nScTab, const 
Color rTabColor, XclExpFilterManager* pManager ) :
+mnScTab(nScTab), mpManager(pManager), mbFitToPage(bFitToPages), 
maTabColor(rTabColor) {}
+
+void XclExpXmlSheetPr::SaveXml( XclExpXmlStream rStrm )
 {
 sax_fastparser::FSHelperPtr rWorksheet = rStrm.GetCurrentStream();
 rWorksheet-startElement( XML_sheetPr,
@@ -465,11 +466,18 @@ void XclExpWsbool::SaveXml( XclExpXmlStream rStrm )
 XML_filterMode, mpManager ? XclXmlUtils::ToPsz( 
mpManager-HasFilterMode( mnScTab ) ) : NULL,
 // OOXTODO: XML_enableFormatConditionsCalculation,
 FSEND );
-// OOXTODO: elements XML_tabColor, XML_outlinePr
-rWorksheet-singleElement( XML_pageSetUpPr,
+
+// Note : the order of child elements is significant. Don't change the 
order.
+
+// OOXTODO: XML_outlinePr
+
+rWorksheet-singleElement(
+XML_tabColor, XML_rgb, XclXmlUtils::ToOString(maTabColor).getStr(), 
FSEND);
+
+rWorksheet-singleElement(XML_pageSetUpPr,
 // OOXTODO: XML_autoPageBreaks,
-XML_fitToPage,  XclXmlUtils::ToPsz( GetValue()  
EXC_WSBOOL_FITTOPAGE ),
-FSEND );
+XML_fitToPage,  XclXmlUtils::ToPsz(mbFitToPage), FSEND);
+
 rWorksheet-endElement( XML_sheetPr );
 }
 
diff --git a/sc/source/filter/inc/excrecds.hxx 
b/sc/source/filter/inc/excrecds.hxx
index 0a6b7be..b4a3ba9 100644
--- a/sc/source/filter/inc/excrecds.hxx
+++ b/sc/source/filter/inc/excrecds.hxx
@@ -24,6 +24,7 @@
 #include rtl/ustring.hxx
 #include svl/zforlist.hxx
 #include tools/solar.h
+#include tools/color.hxx
 #include vcl/vclenum.hxx
 
 
@@ -325,16 +326,26 @@ private:
 class XclExpWsbool : public XclExpUInt16Record
 {
 public:
-explicitXclExpWsbool( bool bFitToPages, SCTAB nScTab = 
-1, XclExpFilterManager* pManager = NULL );
-
-virtual voidSaveXml( XclExpXmlStream rStrm );
-private:
-SCTAB   mnScTab;
-XclExpFilterManager*mpManager;
+explicit XclExpWsbool( bool bFitToPages );
 };
 
+/**
+ * Save sheetPr element and its children for xlsx export.
+ */
+class XclExpXmlSheetPr : public XclExpRecordBase
+{
+public:
+explicit XclExpXmlSheetPr(
+bool bFitToPages, SCTAB nScTab, const Color rTabColor, 
XclExpFilterManager* pManager );
+
+virtual void SaveXml( XclExpXmlStream rStrm );
 
-// 
+private:
+SCTAB mnScTab;
+XclExpFilterManager* mpManager;
+bool mbFitToPage;
+Color

Document Freedom Day 2014 @Taiwan

2014-03-14 Thread imacat

Dear all,

We are holding the Document Freedom Day 2014 at Taiwan, on
2014/3/26(Wed).  There will be two DFD 2014 meetings in Taiwan:

* Taipei: 2014/3/23(Wed) 18:30 at WaWa Book 2nd Floor
  http://imacat.kktix.cc/events/dfd2014
  2F., No.3, Sec. 2, Bade Rd., Da’an Dist., Taipei City, Taiwan
  imacat will be sharing from doc, docx to odt and GoogleDocs.  We'll
also share the latest development of LibreOffice 4.2.1 and OpenOffice 4.1.

* Hualien: 2014/3/23(Wed) 19:30 at Yuri Suangan Caf'e
  https://www.facebook.com/events/597139773708958/
  No.6, Ln. 58, Minquan St., Yuli Township, Hualien County, Taiwan

   Please come to join us if you are at Taiwan at that time.

-- 
Best regards,
imacat ^_*' ima...@mail.imacat.idv.tw
PGP Key http://www.imacat.idv.tw/me/pgpkey.asc

Woman's Voice News: http://www.wov.idv.tw/
Tavern IMACAT's http://www.imacat.idv.tw/
Woman in FOSS in Taiwan http://wofoss.blogspot.com/
OpenOffice http://www.openoffice.org/
EducOO/OOo4Kids Taiwan http://www.educoo.tw/
Greenfoot Taiwan http://greenfoot.westart.tw/



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: is com.sun.star.comp.framework.License dead ?


On 03/13/2014 10:05 PM, Caolán McNamara wrote:

Is com.sun.star.comp.framework.License something dead that can be
removed ? I don't seem to see any use of it anywhere in our code and I
don't see it documented anywhere for use by extensions or anything.

(it has a old-school .src dialog in it that I want to get rid of)


As dead as it gets, I'd say---apparently for 10 years now.  (The 
Extension Mgr has its own 
desktop/source/deployment/gui/license_dialog.hxx for displaying any 
extension licenses.)


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/qa

2014-03-14 Thread Tomaž Vajngerl

 sw/qa/extras/ooxmlexport/data/TextEffects_InStyle.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlw14export.cxx|  242 -
 2 files changed, 239 insertions(+), 3 deletions(-)

New commits:
commit 5eee8861efdebe08265a994132989f676312066b
Author: TomaÅ¾ Vajngerl tomaz.vajng...@collabora.com
Date:   Thu Mar 13 11:00:59 2014 +0100

ooxml: round-trip test of w14 elements contained in styles.xml

Change-Id: I57a9f04240b75710a99b33818711e45816361a9f

diff --git a/sw/qa/extras/ooxmlexport/data/TextEffects_InStyle.docx 
b/sw/qa/extras/ooxmlexport/data/TextEffects_InStyle.docx
new file mode 100644
index 000..5be6d9c
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/TextEffects_InStyle.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlw14export.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlw14export.cxx
index 4e8ee1b..1c7761c 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlw14export.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlw14export.cxx
@@ -273,11 +273,17 @@ 
DECLARE_OOXMLEXPORT_TEST(Test_TextEffects_StylisticSets_CntxtAlts, TextEffects_
 
 DECLARE_OOXMLEXPORT_TEST(Test_McIgnorable, 
TextEffects_StylisticSets_CntxtAlts.docx)
 {
-xmlDocPtr pXmlDoc = parseExport(word/document.xml);
-if (!pXmlDoc)
+xmlDocPtr pXmlDocument = parseExport(word/document.xml);
+if (!pXmlDocument)
+return;
+
+ assertXPath(pXmlDocument, /w:document, Ignorable, w14 wp14);
+
+xmlDocPtr pXmlStyles = parseExport(word/styles.xml);
+if (!pXmlStyles)
 return;
 
- assertXPath(pXmlDoc, /w:document, Ignorable, w14 wp14);
+ assertXPath(pXmlStyles, /w:styles, Ignorable, w14);
 }
 
 DECLARE_OOXMLEXPORT_TEST(Test_CompatSettingsForW14, 
TextEffects_StylisticSets_CntxtAlts.docx)
@@ -424,6 +430,236 @@ DECLARE_OOXMLEXPORT_TEST(Test_TextEffects_Groupshapes, 
TextEffects_Groupshapes.
 assertXPath(pXmlDoc, (sPathStylisticSets+/w14:styleSet).c_str(), id, 
1);
 }
 
+DECLARE_OOXMLEXPORT_TEST(Test_TextEffects_InStyleXml, 
TextEffects_InStyle.docx)
+{
+xmlDocPtr pXmlDoc = parseExport(word/styles.xml);
+if (!pXmlDoc)
+return;
+
+std::string sPathToCharacterStyle = /w:styles/w:style[3];
+
+assertXPath(pXmlDoc, (sPathToCharacterStyle).c_str(), type, character);
+assertXPath(pXmlDoc, (sPathToCharacterStyle).c_str(), styleId, 
TextEffectsStyleChar);
+assertXPath(pXmlDoc, (sPathToCharacterStyle).c_str(), customStyle, 1);
+
+{
+std::string sPathToRun = sPathToCharacterStyle + /w:rPr;
+
+// Glow
+std::string sPathGlow = sPathToRun + /w14:glow;
+assertXPath(pXmlDoc, (sPathGlow).c_str(), rad, 63500);
+assertXPath(pXmlDoc, (sPathGlow+/w14:schemeClr).c_str(), val, 
accent2);
+assertXPath(pXmlDoc, (sPathGlow+/w14:schemeClr/w14:alpha).c_str(), 
val, 6);
+assertXPath(pXmlDoc, (sPathGlow+/w14:schemeClr/w14:satMod).c_str(), 
val, 175000);
+
+// Shadow
+std::string sPathShadow = sPathToRun + /w14:shadow;
+assertXPath(pXmlDoc, (sPathShadow).c_str(), blurRad, 50800);
+assertXPath(pXmlDoc, (sPathShadow).c_str(), dist, 38100);
+assertXPath(pXmlDoc, (sPathShadow).c_str(), dir, 1620);
+assertXPath(pXmlDoc, (sPathShadow).c_str(), sx, 10);
+assertXPath(pXmlDoc, (sPathShadow).c_str(), sy, 10);
+assertXPath(pXmlDoc, (sPathShadow).c_str(), kx, 0);
+assertXPath(pXmlDoc, (sPathShadow).c_str(), ky, 0);
+assertXPath(pXmlDoc, (sPathShadow).c_str(), algn, b);
+assertXPath(pXmlDoc, (sPathShadow+/w14:srgbClr).c_str(), val, 
00);
+assertXPath(pXmlDoc, (sPathShadow+/w14:srgbClr/w14:alpha).c_str(), 
val, 6);
+
+// Reflection
+std::string sPathReflection = sPathToRun + /w14:reflection;
+assertXPath(pXmlDoc, (sPathReflection).c_str(), blurRad, 6350);
+assertXPath(pXmlDoc, (sPathReflection).c_str(), stA, 5);
+assertXPath(pXmlDoc, (sPathReflection).c_str(), stPos, 0);
+assertXPath(pXmlDoc, (sPathReflection).c_str(), endA, 300);
+assertXPath(pXmlDoc, (sPathReflection).c_str(), endPos, 5);
+assertXPath(pXmlDoc, (sPathReflection).c_str(), dist, 29997);
+assertXPath(pXmlDoc, (sPathReflection).c_str(), dir, 540);
+assertXPath(pXmlDoc, (sPathReflection).c_str(), fadeDir, 540);
+assertXPath(pXmlDoc, (sPathReflection).c_str(), sx, 10);
+assertXPath(pXmlDoc, (sPathReflection).c_str(), sy, -10);
+assertXPath(pXmlDoc, (sPathReflection).c_str(), kx, 0);
+assertXPath(pXmlDoc, (sPathReflection).c_str(), ky, 0);
+assertXPath(pXmlDoc, (sPathReflection).c_str(), algn, bl);
+
+// TextOutline
+std::string sPathTextOutline = sPathToRun + /w14:textOutline;
+assertXPath(pXmlDoc, (sPathTextOutline).c_str(), w, 25400);
+assertXPath(pXmlDoc, (sPathTextOutline).c_str(), cap, rnd);
+assertXPath(pXmlDoc, (sPathTextOutline).c_str(), cmpd, sng);
+

[Libreoffice-commits] core.git: 4 commits - configure.ac idl/inc idl/source Library_merged.mk

2014-03-14 Thread Matúš Kukan

 Library_merged.mk|2 +-
 configure.ac |9 ++---
 idl/inc/database.hxx |2 ++
 idl/source/objects/types.cxx |   25 +++--
 idl/source/prj/database.cxx  |1 +
 5 files changed, 29 insertions(+), 10 deletions(-)

New commits:
commit fc27a685d466dc380a8b68cd48f47db632ed3693
Author: MatÃºÅ¡ Kukan matus.ku...@collabora.com
Date:   Thu Mar 13 11:03:04 2014 +0100

Avoid duplicate symbols in libmerged for Windows too.

Export these symbols from sfx library.
For cases when we link together more libraries, there are more symbols,
so I've kept __attribute__((__weak__)) hack there.

Change-Id: I8b7f6fc9bea479dca5062344c04b74c1f3eb36b2

diff --git a/configure.ac b/configure.ac
index 92ca7dd..7c5d277 100644
--- a/configure.ac
+++ b/configure.ac
@@ -12424,11 +12424,11 @@ if test -n $enable_mergelibs -a $enable_mergelibs 
!= no; then
 if test $enable_mergelibs = all; then
 MERGELIBS=ALL
 URELIBS=TRUE
+AC_DEFINE(STATIC_LINKING)
 else
 MERGELIBS=CORE
 fi
 AC_MSG_RESULT([yes])
-AC_DEFINE(STATIC_LINKING)
 else
 AC_MSG_RESULT([no])
 fi
diff --git a/idl/inc/database.hxx b/idl/inc/database.hxx
index 15e87f2..f9abfd2 100644
--- a/idl/inc/database.hxx
+++ b/idl/inc/database.hxx
@@ -81,6 +81,8 @@ protected:
 aIFaceName = OString();
 }
 public:
+OUString sSlotMapFile;
+
 explicit SvIdlDataBase( const SvCommand rCmd );
 ~SvIdlDataBase();
 static sal_Bool IsBinaryFormat( SvStream  rInStm );
diff --git a/idl/source/objects/types.cxx b/idl/source/objects/types.cxx
index 1797fa2..6dc8216 100644
--- a/idl/source/objects/types.cxx
+++ b/idl/source/objects/types.cxx
@@ -1398,7 +1398,7 @@ sal_uLong SvMetaType::MakeSfx( OStringBuffer rAttrArray )
 }
 
 void SvMetaType::WriteSfxItem(
-const OString rItemName, SvIdlDataBase , SvStream  rOutStm )
+const OString rItemName, SvIdlDataBase rBase, SvStream rOutStm )
 {
 WriteStars( rOutStm );
 OStringBuffer aVarName( a);
@@ -1411,14 +1411,35 @@ void SvMetaType::WriteSfxItem(
 OString::number(nAttrCount));
 aTypeName.append(aAttrCount);
 
-rOutStm.WriteCharPtr( extern  ).WriteCharPtr( aTypeName.getStr() )
+bool bExport = false, bReturn = false;
+// these are exported from sfx library
+if (rItemName == SfxBoolItem ||
+rItemName == SfxStringItem ||
+rItemName == SfxUInt16Item ||
+rItemName == SfxUInt32Item ||
+rItemName == SfxVoidItem)
+{
+if (rBase.sSlotMapFile.endsWith(sfxslots.hxx))
+bExport = true;
+else
+bReturn = true;
+}
+
+rOutStm.WriteCharPtr( extern  );
+if (bExport)
+rOutStm.WriteCharPtr( SFX2_DLLPUBLIC  );
+rOutStm.WriteCharPtr( aTypeName.getStr() )
.WriteCharPtr( aVarName.getStr() ).WriteChar( ';' )  endl;
+if (bReturn)
+return;
 
 // write the implementation part
 rOutStm.WriteCharPtr( #ifdef SFX_TYPEMAP )  endl;
 rOutStm.WriteCharPtr( #if !defined(_WIN32)  
((defined(DISABLE_DYNLOADING)  (defined(ANDROID) || defined(IOS))) || 
STATIC_LINKING) )  endl;
 rOutStm.WriteCharPtr( __attribute__((__weak__)) )  endl;
 rOutStm.WriteCharPtr( #endif )  endl;
+if (bExport)
+rOutStm.WriteCharPtr( SFX2_DLLPUBLIC  );
 rOutStm.WriteCharPtr( aTypeName.getStr() ).WriteCharPtr( aVarName.getStr() 
)
.WriteCharPtr(  =  )  endl;
 rOutStm.WriteChar( '{' )  endl;
diff --git a/idl/source/prj/database.cxx b/idl/source/prj/database.cxx
index 3ac165d..04f351c 100644
--- a/idl/source/prj/database.cxx
+++ b/idl/source/prj/database.cxx
@@ -34,6 +34,7 @@ SvIdlDataBase::SvIdlDataBase( const SvCommand rCmd )
 , aPersStream( *IDLAPP-pClassMgr, NULL )
 , pIdTable( NULL )
 {
+sSlotMapFile = rCmd.aSlotMapFile;
 }
 
 SvIdlDataBase::~SvIdlDataBase()
commit bee9ea584cb5c1e6bee802c45214010d072846db
Author: MatÃºÅ¡ Kukan matus.ku...@collabora.com
Date:   Fri Mar 14 09:23:47 2014 +0100

add shlwapi

Change-Id: Icb7b7d9954a6954b2a34358a49988a10c3ab384a

diff --git a/Library_merged.mk b/Library_merged.mk
index cd45fd3..61075ab 100644
--- a/Library_merged.mk
+++ b/Library_merged.mk
@@ -106,6 +106,7 @@ $(eval $(call gb_Library_use_system_win32_libs,merged,\
ole32 \
oleaut32 \
shell32 \
+   shlwapi \
user32 \
usp10 \
uuid \
commit 0737d4f6f9d5db5197ce4f35214a785250b8e848
Author: MatÃºÅ¡ Kukan matus.ku...@collabora.com
Date:   Thu Mar 13 10:55:54 2014 +0100

Remove --disable-lpsolve configure option.

Use --with-lpsolver=coinmp or --with-lpsolver=no.

Change-Id: Ibc806b85fb6c03e1cf6f23d860246a6fb2f273c1

diff --git a/configure.ac b/configure.ac
index 6c453e2..92ca7dd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -781,11 +781,6 @@ AC_ARG_ENABLE(ext-wiki-publisher,
 [Enable the Wiki Publisher extension.])
 )

[Libreoffice-commits] core.git: rsc/inc rsc/source unusedcode.easy

 rsc/inc/rscdb.hxx |1 -
 rsc/source/parser/rscicpx.cxx |   13 -
 unusedcode.easy   |6 ++
 3 files changed, 6 insertions(+), 14 deletions(-)

New commits:
commit f9903a57dcb478c3b0e3c184ab6a020a94d6
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 08:48:55 2014 +

callcatcher: update unused code

Change-Id: If4615e5bcb012321c554f75cd936dbf9b0dbf8ab

diff --git a/rsc/inc/rscdb.hxx b/rsc/inc/rscdb.hxx
index e36e296..7708d98 100644
--- a/rsc/inc/rscdb.hxx
+++ b/rsc/inc/rscdb.hxx
@@ -209,7 +209,6 @@ class RscTypCont
 RscTop *InitClassNumericFormatter( RscTop * pSuper );
 RscTop *InitClassMetricFormatter( RscTop * pSuper,
   RscEnum * pFieldUnits );
-RscTop *InitClassCurrencyFormatter( RscTop * pSuper );
 RscTop *InitClassDateFormatter( RscTop * pSuper, RscTop * pClassDate );
 RscTop *InitClassTimeFormatter( RscTop * pSuper, RscTop * pClassTime,
 RscEnum * pTimeFieldFormat );
diff --git a/rsc/source/parser/rscicpx.cxx b/rsc/source/parser/rscicpx.cxx
index 432cc80..45139c3 100644
--- a/rsc/source/parser/rscicpx.cxx
+++ b/rsc/source/parser/rscicpx.cxx
@@ -1292,19 +1292,6 @@ RscTop * RscTypCont::InitClassMetricFormatter( RscTop * 
pSuper,
 return pClassMetric;
 }
 
-RscTop * RscTypCont::InitClassCurrencyFormatter(RscTop * pSuper)
-{
-AtomnId;
-RscTop *pClassCurrency;
-
-// Klasse anlegen
-nId = pHS-getID( CurrencyFormatter );
-pClassCurrency = new RscClass( nId, RSC_NOTYPE, pSuper );
-pClassCurrency-SetCallPar( *pStdPar1, *pStdPar2, *pStdParType );
-
-return pClassCurrency;
-}
-
 RscTop * RscTypCont::InitClassDateFormatter( RscTop * pSuper,
 RscTop * pClassDate )
 {
diff --git a/unusedcode.easy b/unusedcode.easy
index d7b52c4..0a0fa5d 100644
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -55,6 +55,12 @@ SwExtraRedlineTbl::GetPos(SwExtraRedline const*) const
 SwExtraRedlineTbl::Remove(unsigned short)
 TextDoc::IsValidPaM(TextPaM const)
 
UnoApiTest::closeDocument(com::sun::star::uno::Referencecom::sun::star::lang::XComponent)
+VCLXGraphics::getFillColor()
+VCLXGraphics::getFont()
+VCLXGraphics::getLineColor()
+VCLXGraphics::getRasterOp()
+VCLXGraphics::getTextColor()
+VCLXGraphics::getTextFillColor()
 apitest::CellProperties::testRotateReference()
 apitest::CellProperties::testVertJustify()
 apitest::DataPilotField::testAutoShowInfo()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - be/899f92bafeac8dbb02732de5249c7fa7a1f08d

 be/899f92bafeac8dbb02732de5249c7fa7a1f08d |1 +
 1 file changed, 1 insertion(+)

New commits:
commit c7fbbb4bca2dae632aa58ce71b1fed31e67f21ae
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 08:57:54 2014 +

Notes added by 'git notes add'

diff --git a/be/899f92bafeac8dbb02732de5249c7fa7a1f08d 
b/be/899f92bafeac8dbb02732de5249c7fa7a1f08d
new file mode 100644
index 000..ab2df80
--- /dev/null
+++ b/be/899f92bafeac8dbb02732de5249c7fa7a1f08d
@@ -0,0 +1 @@
+merged as: eb4fb12fdbe14b929cf8fe5d5785fcfae8d96fa4
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 95/81d8a5a9de55f5fe6736ab1c9cea481bfcf2bc

 95/81d8a5a9de55f5fe6736ab1c9cea481bfcf2bc |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 6f34fbabd31b81fafcb6be670631e497701bd0e0
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 08:57:21 2014 +

Notes added by 'git notes add'

diff --git a/95/81d8a5a9de55f5fe6736ab1c9cea481bfcf2bc 
b/95/81d8a5a9de55f5fe6736ab1c9cea481bfcf2bc
new file mode 100644
index 000..ab2df80
--- /dev/null
+++ b/95/81d8a5a9de55f5fe6736ab1c9cea481bfcf2bc
@@ -0,0 +1 @@
+merged as: eb4fb12fdbe14b929cf8fe5d5785fcfae8d96fa4
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: configure.ac idl/inc idl/source

2014-03-14 Thread Matúš Kukan

 configure.ac |2 +-
 idl/inc/database.hxx |2 --
 idl/source/objects/types.cxx |   25 ++---
 idl/source/prj/database.cxx  |1 -
 4 files changed, 3 insertions(+), 27 deletions(-)

New commits:
commit 50c5a4ce9cb7c908e798158edac8001246f6e888
Author: MatÃºÅ¡ Kukan matus.ku...@collabora.com
Date:   Fri Mar 14 10:09:19 2014 +0100

Revert Avoid duplicate symbols in libmerged for Windows too.

Forgot to test properly on Windows :-(.

This reverts commit fc27a685d466dc380a8b68cd48f47db632ed3693.

diff --git a/configure.ac b/configure.ac
index 7c5d277..92ca7dd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -12424,11 +12424,11 @@ if test -n $enable_mergelibs -a $enable_mergelibs 
!= no; then
 if test $enable_mergelibs = all; then
 MERGELIBS=ALL
 URELIBS=TRUE
-AC_DEFINE(STATIC_LINKING)
 else
 MERGELIBS=CORE
 fi
 AC_MSG_RESULT([yes])
+AC_DEFINE(STATIC_LINKING)
 else
 AC_MSG_RESULT([no])
 fi
diff --git a/idl/inc/database.hxx b/idl/inc/database.hxx
index f9abfd2..15e87f2 100644
--- a/idl/inc/database.hxx
+++ b/idl/inc/database.hxx
@@ -81,8 +81,6 @@ protected:
 aIFaceName = OString();
 }
 public:
-OUString sSlotMapFile;
-
 explicit SvIdlDataBase( const SvCommand rCmd );
 ~SvIdlDataBase();
 static sal_Bool IsBinaryFormat( SvStream  rInStm );
diff --git a/idl/source/objects/types.cxx b/idl/source/objects/types.cxx
index 6dc8216..1797fa2 100644
--- a/idl/source/objects/types.cxx
+++ b/idl/source/objects/types.cxx
@@ -1398,7 +1398,7 @@ sal_uLong SvMetaType::MakeSfx( OStringBuffer rAttrArray )
 }
 
 void SvMetaType::WriteSfxItem(
-const OString rItemName, SvIdlDataBase rBase, SvStream rOutStm )
+const OString rItemName, SvIdlDataBase , SvStream  rOutStm )
 {
 WriteStars( rOutStm );
 OStringBuffer aVarName( a);
@@ -1411,35 +1411,14 @@ void SvMetaType::WriteSfxItem(
 OString::number(nAttrCount));
 aTypeName.append(aAttrCount);
 
-bool bExport = false, bReturn = false;
-// these are exported from sfx library
-if (rItemName == SfxBoolItem ||
-rItemName == SfxStringItem ||
-rItemName == SfxUInt16Item ||
-rItemName == SfxUInt32Item ||
-rItemName == SfxVoidItem)
-{
-if (rBase.sSlotMapFile.endsWith(sfxslots.hxx))
-bExport = true;
-else
-bReturn = true;
-}
-
-rOutStm.WriteCharPtr( extern  );
-if (bExport)
-rOutStm.WriteCharPtr( SFX2_DLLPUBLIC  );
-rOutStm.WriteCharPtr( aTypeName.getStr() )
+rOutStm.WriteCharPtr( extern  ).WriteCharPtr( aTypeName.getStr() )
.WriteCharPtr( aVarName.getStr() ).WriteChar( ';' )  endl;
-if (bReturn)
-return;
 
 // write the implementation part
 rOutStm.WriteCharPtr( #ifdef SFX_TYPEMAP )  endl;
 rOutStm.WriteCharPtr( #if !defined(_WIN32)  
((defined(DISABLE_DYNLOADING)  (defined(ANDROID) || defined(IOS))) || 
STATIC_LINKING) )  endl;
 rOutStm.WriteCharPtr( __attribute__((__weak__)) )  endl;
 rOutStm.WriteCharPtr( #endif )  endl;
-if (bExport)
-rOutStm.WriteCharPtr( SFX2_DLLPUBLIC  );
 rOutStm.WriteCharPtr( aTypeName.getStr() ).WriteCharPtr( aVarName.getStr() 
)
.WriteCharPtr(  =  )  endl;
 rOutStm.WriteChar( '{' )  endl;
diff --git a/idl/source/prj/database.cxx b/idl/source/prj/database.cxx
index 04f351c..3ac165d 100644
--- a/idl/source/prj/database.cxx
+++ b/idl/source/prj/database.cxx
@@ -34,7 +34,6 @@ SvIdlDataBase::SvIdlDataBase( const SvCommand rCmd )
 , aPersStream( *IDLAPP-pClassMgr, NULL )
 , pIdTable( NULL )
 {
-sSlotMapFile = rCmd.aSlotMapFile;
 }
 
 SvIdlDataBase::~SvIdlDataBase()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: OfficeMenuBar no longer takes private menu's in StartModule


On 03/13/2014 10:07 PM, Fernand Vanrie wrote:

With  4.2 (Windows)

Private Extensions menu's are no longer visible in the StartModule
Private Toolbars are still visible in the StartModule

node oor:name=OfficeMenuBar
 node oor:name=MyPrivateMenu.OfficeMenuBar oor:op=replace
 prop oor:name=Context oor:type=xs:string
valuecom.sun.star.frame.StartModule,com.sun.star.text.TextDocument,com.sun.star.sdb.TextReportDesign,com.sun.star.text.WebDocument,com.sun.star.xforms.XMLFormDocument,com.sun.star.text.GlobalDocument,com.sun.star.sdb.FormDesign,com.sun.star.sheet.SpreadsheetDocument,com.sun.star.drawing.DrawingDocument,com.sun.star.presentation.PresentationDocument,com.sun.star.sdb.OfficeDatabaseDocument/value

 /prop

this menu shows in the different modules but
com.sun.star.frame.StartModule is sillently ignored

[...]

is it forbidden to show private Menu's in the start Module ?


I would rather assume this is an unintended regression with the new 
start center code.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7545a9054cd8fbca0073b4603b833080b4810a94
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 09:31:01 2014 +

Updated core
Project: help  fcc6cf6417cc21d817e0fa921d66ecbe2bf2b9fe

diff --git a/helpcontent2 b/helpcontent2
index 52c7f5e..fcc6cf6 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 52c7f5e3a3bf92ccddb93d3a565eb6f073435793
+Subproject commit fcc6cf6417cc21d817e0fa921d66ecbe2bf2b9fe
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: helpers/help_hid.lst

 helpers/help_hid.lst |5 -
 1 file changed, 5 deletions(-)

New commits:
commit fcc6cf6417cc21d817e0fa921d66ecbe2bf2b9fe
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 09:31:01 2014 +

remove help ids that point nowhere

Change-Id: I0d3316c58528c428a622f52f6659a0c655f4d48d

diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst
index e96d663..9dcec72 100644
--- a/helpers/help_hid.lst
+++ b/helpers/help_hid.lst
@@ -2187,7 +2187,6 @@ HID_LETTER_PAGE6,53274,
 HID_LETTER_PAGE7,53275,
 HID_LETTER_PAGE8,53276,
 HID_LETTER_PAGE9,53277,
-HID_LICENSEDIALOG,40369,
 HID_LINGU_ADD_WORD,53430,
 HID_LINGU_AUTOCORR,53433,
 HID_LINGU_IGNORE_WORD,53431,
@@ -5678,10 +5677,6 @@ 
fpicker_ListBox_DLG_SVT_EXPLORERFILE_LB_EXPLORERFILE_SHARED_LISTBOX,1334644257,
 fpicker_MenuButton_DLG_SVT_EXPLORERFILE_BTN_EXPLORERFILE_STANDARD,1334652943,
 fpicker_MenuButton_DLG_SVT_EXPLORERFILE_BTN_EXPLORERFILE_UP,1334652942,
 fpicker_PushButton_DLG_SVT_EXPLORERFILE_BTN_EXPLORERFILE_OPEN,1334645264,
-framework_MultiLineEdit_DLG_LICENSE_ML_LICENSE,1077938699,
-framework_PushButton_DLG_LICENSE_PB_ACCEPT,1077940759,
-framework_PushButton_DLG_LICENSE_PB_DECLINE,1077940758,
-framework_PushButton_DLG_LICENSE_PB_PAGEDOWN,1077940754,
 reportdesign_ListBox_RID_GROUPS_SORTING_LST_FOOTERLST,2114719236,
 reportdesign_ListBox_RID_GROUPS_SORTING_LST_GROUPONLST,2114719238,
 reportdesign_ListBox_RID_GROUPS_SORTING_LST_HEADERLST,2114719234,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source writerfilter/source

2014-03-14 Thread Rohit Deshmukh

 sw/inc/authfld.hxx|3 
 sw/inc/fldbas.hxx |4 -
 sw/inc/poolfmt.hrc|1 
 sw/inc/shellres.hxx   |1 
 sw/inc/tox.hxx|   15 
 sw/inc/toxe.hxx   |3 
 sw/qa/extras/ooxmlexport/data/FDO74775.docx   |binary
 sw/qa/extras/ooxmlexport/ooxmlexport.cxx  |   10 ++
 sw/source/core/doc/docnew.cxx |2 
 sw/source/core/doc/doctxm.cxx |4 -
 sw/source/core/fields/authfld.cxx |7 +
 sw/source/core/fields/fldbas.cxx  |   11 ++-
 sw/source/core/tox/tox.cxx|2 
 sw/source/core/uibase/index/toxmgr.cxx|1 
 sw/source/core/uibase/utlui/initui.cxx|1 
 sw/source/core/uibase/utlui/initui.hrc|1 
 sw/source/core/uibase/utlui/initui.src|6 +
 sw/source/core/unocore/unoidx.cxx |   19 +
 sw/source/filter/ww8/docxattributeoutput.cxx  |   11 ++-
 sw/source/filter/ww8/fields.cxx   |3 
 sw/source/filter/ww8/fields.hxx   |3 
 sw/source/filter/ww8/ww8atr.cxx   |8 ++
 sw/source/ui/index/cnttab.cxx |3 
 sw/source/ui/utlui/poolfmt.src|4 +
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |   80 ++
 writerfilter/source/dmapper/DomainMapper_Impl.hxx |1 
 writerfilter/source/dmapper/FieldTypes.hxx|7 +
 27 files changed, 198 insertions(+), 13 deletions(-)

New commits:
commit 06f7d1a96eef5aa69d4872ff6d96eb5085296d09
Author: Rohit Deshmukh rohit.deshm...@synerzip.com
Date:   Wed Mar 12 15:07:38 2014 +0530

fdo#74775: Preseved Citation after round trip.

Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
https://gerrit.libreoffice.org/8473

Change-Id: Ie1b0ac3cb4d4b9bf305323599d5e4b63f913fb1b

diff --git a/sw/inc/authfld.hxx b/sw/inc/authfld.hxx
index 55ed5b7..a26cc6d 100644
--- a/sw/inc/authfld.hxx
+++ b/sw/inc/authfld.hxx
@@ -150,6 +150,9 @@ class SwAuthorityField : public SwField
 virtual SwField*Copy() const;
 
 public:
+/// For internal use only, in general continue using ExpandField() instead.
+OUString ConditionalExpand(ToxAuthorityField eField) const;
+
 SwAuthorityField(SwAuthorityFieldType* pType, const OUString 
rFieldContents);
 SwAuthorityField(SwAuthorityFieldType* pType, sal_IntPtr nHandle);
 ~SwAuthorityField();
diff --git a/sw/inc/fldbas.hxx b/sw/inc/fldbas.hxx
index 26df00f..90cd505 100644
--- a/sw/inc/fldbas.hxx
+++ b/sw/inc/fldbas.hxx
@@ -26,7 +26,7 @@
 #include com/sun/star/uno/Any.hxx
 #include cppuhelper/weakref.hxx
 #include vector
-
+#include toxe.hxx
 class SwDoc;
 class SvNumberFormatter;
 
@@ -317,7 +317,7 @@ public:
 SwTxtFormatter::NewFldPortion() sets things up properly.
 @return the generated text (suitable for display)
   */
-OUStringExpandField(bool const bCached) const;
+OUStringExpandField(bool const bCached, ToxAuthorityField 
eField = AUTH_FIELD_IDENTIFIER) const;
 
 /// @return name or content.
 virtual OUStringGetFieldName() const;
diff --git a/sw/inc/poolfmt.hrc b/sw/inc/poolfmt.hrc
index c9c87c6..423fad5 100644
--- a/sw/inc/poolfmt.hrc
+++ b/sw/inc/poolfmt.hrc
@@ -221,6 +221,7 @@
 #define STR_POOLCOLL_TOX_USER9  (RC_POOLCOLL_REGISTER_BEGIN+ 34)
 #define STR_POOLCOLL_TOX_USER10 (RC_POOLCOLL_REGISTER_BEGIN+ 35)
 
+#define STR_POOLCOLL_TOX_CITATION   (RC_POOLCOLL_REGISTER_BEGIN+ 36)
 
 // Category Chapter/Document
 #define STR_POOLCOLL_DOC_TITEL  (RC_POOLCOLL_DOC_BEGIN+ 0)
diff --git a/sw/inc/shellres.hxx b/sw/inc/shellres.hxx
index df10cbd..60ab4a1 100644
--- a/sw/inc/shellres.hxx
+++ b/sw/inc/shellres.hxx
@@ -63,6 +63,7 @@ struct SW_DLLPUBLIC ShellResource : public Resource
 OUStringaTOXObjectsName;
 OUStringaTOXTablesName;
 OUStringaTOXAuthoritiesName;
+OUStringaTOXCitationName;
 
 OUStringaLinkCtrlClick;
 OUStringaLinkClick;
diff --git a/sw/inc/tox.hxx b/sw/inc/tox.hxx
index ee3b6c6..f6c578f 100644
--- a/sw/inc/tox.hxx
+++ b/sw/inc/tox.hxx
@@ -56,6 +56,7 @@ class SW_DLLPUBLIC SwTOXMark
 OUString aAltText;// Text of caption is different.
 OUString aPrimaryKey;
 OUString aSecondaryKey;
+OUString aCitationKeyReading;
 
 // three more strings for phonetic sorting
 OUString aTextReading;
@@ -113,12 +114,14 @@ public:
 inline void SetTextReading(const OUString rStr);
 inline void SetPrimaryKeyReading(const OUString rStr );
 inline void SetSecondaryKeyReading(const OUString rStr);
+inline void

[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sw/qa sw/source

 sw/qa/extras/uiwriter/data/fdo75898.odt |binary
 sw/qa/extras/uiwriter/uiwriter.cxx  |   17 +
 sw/source/core/frmedt/fetab.cxx |8 
 sw/source/ui/shells/tabsh.cxx   |3 ++-
 4 files changed, 27 insertions(+), 1 deletion(-)

New commits:
commit 9b0cffd68316e6ecb6f11f77504bca64ff34ba72
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Thu Mar 13 15:03:33 2014 +0100

fdo#75898 SwFEShell::InsertRow: fix this in case bSelectAll == true

Change-Id: Iaf59db6a55c3f81d11d0196d5d3e52056e31c4b1
(cherry picked from commit f1f9b5b1b73218274ee69cf4e518c2ba926458af)
Reviewed-on: https://gerrit.libreoffice.org/8574
Reviewed-by: BjÃ¶rn Michaelsen bjoern.michael...@canonical.com
Tested-by: BjÃ¶rn Michaelsen bjoern.michael...@canonical.com

diff --git a/sw/qa/extras/uiwriter/data/fdo75898.odt 
b/sw/qa/extras/uiwriter/data/fdo75898.odt
new file mode 100644
index 000..81a5062
Binary files /dev/null and b/sw/qa/extras/uiwriter/data/fdo75898.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index a86d2ca..e30db24 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -24,12 +24,14 @@ public:
 void testReplaceBackward();
 void testFdo69893();
 void testFdo75110();
+void testFdo75898();
 
 CPPUNIT_TEST_SUITE(SwUiWriterTest);
 CPPUNIT_TEST(testReplaceForward);
 CPPUNIT_TEST(testReplaceBackward);
 CPPUNIT_TEST(testFdo69893);
 CPPUNIT_TEST(testFdo75110);
+CPPUNIT_TEST(testFdo75898);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -93,6 +95,21 @@ void SwUiWriterTest::testFdo75110()
 rUndoManager.Undo();
 }
 
+void SwUiWriterTest::testFdo75898()
+{
+SwDoc* pDoc = createDoc(fdo75898.odt);
+SwWrtShell* pWrtShell = pDoc-GetDocShell()-GetWrtShell();
+pWrtShell-SelAll();
+pWrtShell-InsertRow(1, true);
+pWrtShell-InsertRow(1, true);
+
+// Now check if the table has 3 lines.
+SwShellCrsr* pShellCrsr = pWrtShell-getShellCrsr(false);
+SwTableNode* pTableNode = 
pShellCrsr-Start()-nNode.GetNode().FindTableNode();
+// This was 1, when doing the same using the UI, Writer even crashed.
+CPPUNIT_ASSERT_EQUAL(static_castsize_t(3), 
pTableNode-GetTable().GetTabLines().size());
+}
+
 void SwUiWriterTest::testReplaceBackward()
 {
 SwDoc* pDoc = createDoc();
diff --git a/sw/source/core/frmedt/fetab.cxx b/sw/source/core/frmedt/fetab.cxx
index b2589d0..f3e9491 100644
--- a/sw/source/core/frmedt/fetab.cxx
+++ b/sw/source/core/frmedt/fetab.cxx
@@ -207,6 +207,14 @@ bool SwFEShell::InsertRow( sal_uInt16 nCnt, bool bBehind )
 
 // search boxes via the layout
 SwSelBoxes aBoxes;
+bool bSelectAll = StartsWithTable()  
ExtendedSelectedAll(/*bFootnotes=*/false);
+if (bSelectAll)
+{
+SwPaM* pPaM = getShellCrsr(false);
+SwNode* pNode = 
pPaM-Start()-nNode.GetNode().FindTableNode()-EndOfSectionNode();
+pPaM-End()-nNode = pNode-GetIndex() - 2;
+
pPaM-End()-nContent.Assign(pPaM-End()-nNode.GetNode().GetCntntNode(), 0);
+}
 GetTblSel( *this, aBoxes, nsSwTblSearchType::TBLSEARCH_ROW );
 
 TblWait( nCnt, pFrm, *GetDoc()-GetDocShell(), aBoxes.size() );
diff --git a/sw/source/ui/shells/tabsh.cxx b/sw/source/ui/shells/tabsh.cxx
index 44ddfca..10a11a0 100644
--- a/sw/source/ui/shells/tabsh.cxx
+++ b/sw/source/ui/shells/tabsh.cxx
@@ -165,7 +165,8 @@ static SwTableRep*  lcl_TableParamToItemSet( SfxItemSet 
rSet, SwWrtShell rSh )
 if(rSh.GetBoxDirection( aBoxDirection ))
 rSet.Put(aBoxDirection, FN_TABLE_BOX_TEXTORIENTATION);
 
-sal_Bool bTableSel = rSh.IsTableMode();
+bool bSelectAll = rSh.StartsWithTable()  
rSh.ExtendedSelectedAll(/*bFootnotes=*/false);
+sal_Bool bTableSel = rSh.IsTableMode() || bSelectAll;
 if(!bTableSel)
 {
 rSh.StartAllAction();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa writerfilter/source

 sw/qa/extras/rtfimport/data/fdo69289.rtf   |6 ++
 sw/qa/extras/rtfimport/rtfimport.cxx   |   10 ++
 writerfilter/source/rtftok/rtfdocumentimpl.cxx |3 +++
 3 files changed, 19 insertions(+)

New commits:
commit 3e2cda224e4119b31d85263ff16a383e693dcbbd
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Fri Mar 14 10:50:25 2014 +0100

fdo#69289 RTF import: handle cells with zero width

Change-Id: I31b12a5afa5d501d57b56f515ee1d2fd46a09b32

diff --git a/sw/qa/extras/rtfimport/data/fdo69289.rtf 
b/sw/qa/extras/rtfimport/data/fdo69289.rtf
new file mode 100644
index 000..96054a9
--- /dev/null
+++ b/sw/qa/extras/rtfimport/data/fdo69289.rtf
@@ -0,0 +1,6 @@
+{\rtf\ansi
+{
+\trowd\trgaph30\trleft-30\trrh256\clvertalb\cellx1280\clvertalb\cellx1280\clvertalb\cellx2560\pard\plain\intbl
+\ql a\cell\ql b\cell\ql c\cell\row
+}
+}
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx 
b/sw/qa/extras/rtfimport/rtfimport.cxx
index 6010c7c..5965aae 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -1518,6 +1518,16 @@ DECLARE_RTFIMPORT_TEST(testCharColor, char-color.rtf)
 CPPUNIT_ASSERT_EQUAL(sal_Int32(0x365F91), 
getPropertysal_Int32(getParagraph(1), CharColor));
 }
 
+DECLARE_RTFIMPORT_TEST(testFdo69289, fdo69289.rtf)
+{
+uno::Referencetext::XTextTablesSupplier xTextTablesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Referencecontainer::XIndexAccess 
xTables(xTextTablesSupplier-getTextTables(), uno::UNO_QUERY);
+uno::Referencetext::XTextTable xTable(xTables-getByIndex(0), 
uno::UNO_QUERY);
+uno::Referencetable::XTableRows xTableRows(xTable-getRows(), 
uno::UNO_QUERY);
+// There were only 2 cells (1 separators) in the table, should be 3 (2 
separators).
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), getProperty 
uno::Sequencetext::TableColumnSeparator (xTableRows-getByIndex(0), 
TableColumnSeparators).getLength());
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index cdb77b5..1f9306e 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -3510,6 +3510,9 @@ int RTFDocumentImpl::dispatchValue(RTFKeyword nKeyword, 
int nParam)
 ? m_nNestedCurrentCellX
 : m_nTopLevelCurrentCellX);
 int nCellX = nParam - rCurrentCellX;
+const int COL_DFLT_WIDTH = 41; // 
sw/source/filter/inc/wrtswtbl.hxx, minimal possible width of cells.
+if (!nCellX)
+nCellX = COL_DFLT_WIDTH;
 
 // If there is a negative left margin, then the first cellx is 
relative to that.
 RTFValue::Pointer_t pTblInd = 
m_aStates.top().aTableRowSprms.find(NS_ooxml::LN_CT_TblPrBase_tblInd);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

2014-03-14 Thread Takeshi Abe

 vcl/source/gdi/bitmap.cxx  |   53 ++
 vcl/source/gdi/bitmap3.cxx |   78 -
 2 files changed, 46 insertions(+), 85 deletions(-)

New commits:
commit 61f9aa6176629c2f8774f4f1ea44ca8c4d8b3c09
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Thu Mar 13 23:59:50 2014 +0900

Avoid possible resource leaks by boost::scoped_array

Change-Id: If9b4a70895ae22ef40d9d1fa83ecbf9131c836af

diff --git a/vcl/source/gdi/bitmap.cxx b/vcl/source/gdi/bitmap.cxx
index af11af2..2bd739e2 100644
--- a/vcl/source/gdi/bitmap.cxx
+++ b/vcl/source/gdi/bitmap.cxx
@@ -32,6 +32,7 @@
 
 #include impbmp.hxx
 #include salbmp.hxx
+#include boost/scoped_array.hpp
 
 Bitmap::Bitmap() :
 mpImpBmp( NULL )
@@ -584,19 +585,18 @@ bool Bitmap::Mirror( sal_uLong nMirrorFlags )
 if( pAcc )
 {
 const long  nScanSize = pAcc-GetScanlineSize();
-sal_uInt8*  pBuffer = new sal_uInt8[ nScanSize ];
+boost::scoped_arraysal_uInt8 pBuffer(new sal_uInt8[ nScanSize ]);
 const long  nHeight = pAcc-Height();
 const long  nHeight1 = nHeight - 1L;
 const long  nHeight_2 = nHeight  1L;
 
 for( long nY = 0L, nOther = nHeight1; nY  nHeight_2; nY++, 
nOther-- )
 {
-memcpy( pBuffer, pAcc-GetScanline( nY ), nScanSize );
+memcpy( pBuffer.get(), pAcc-GetScanline( nY ), nScanSize );
 memcpy( pAcc-GetScanline( nY ), pAcc-GetScanline( nOther ), 
nScanSize );
-memcpy( pAcc-GetScanline( nOther ), pBuffer, nScanSize );
+memcpy( pAcc-GetScanline( nOther ), pBuffer.get(), nScanSize 
);
 }
 
-delete[] pBuffer;
 ReleaseAccess( pAcc );
 bRet = true;
 }
@@ -726,10 +726,10 @@ bool Bitmap::Rotate( long nAngle10, const Color 
rFillColor )
 longnRotY;
 longnSinY;
 longnCosY;
-long*   pCosX = new long[ nNewWidth ];
-long*   pSinX = new long[ nNewWidth ];
-long*   pCosY = new long[ nNewHeight ];
-long*   pSinY = new long[ nNewHeight ];
+boost::scoped_arraylong pCosX(new long[ nNewWidth ]);
+boost::scoped_arraylong pSinX(new long[ nNewWidth ]);
+boost::scoped_arraylong pCosY(new long[ nNewHeight ]);
+boost::scoped_arraylong pSinY(new long[ nNewHeight ]);
 
 for ( nX = 0; nX  nNewWidth; nX++ )
 {
@@ -764,11 +764,6 @@ bool Bitmap::Rotate( long nAngle10, const Color 
rFillColor )
 }
 }
 
-delete[] pSinX;
-delete[] pCosX;
-delete[] pSinY;
-delete[] pCosY;
-
 aNewBmp.ReleaseAccess( pWriteAcc );
 }
 
@@ -925,7 +920,7 @@ bool Bitmap::CopyPixel( const Rectangle rRectDst,
 if( pReadAcc-HasPalette()  pWriteAcc-HasPalette() )
 {
 const sal_uInt16nCount = 
pReadAcc-GetPaletteEntryCount();
-sal_uInt8*  pMap = new sal_uInt8[ nCount ];
+boost::scoped_arraysal_uInt8 pMap(new sal_uInt8[ 
nCount ]);
 
 // Create index map for the color table, as the 
bitmap should be copied
 // retaining it's color information relatively well
@@ -935,8 +930,6 @@ bool Bitmap::CopyPixel( const Rectangle rRectDst,
 for( long nSrcY = aRectSrc.Top(); nSrcY  
nSrcEndY; nSrcY++, nDstY++ )
 for( long nSrcX = aRectSrc.Left(), nDstX = 
aRectDst.Left(); nSrcX  nSrcEndX; nSrcX++, nDstX++ )
 pWriteAcc-SetPixelIndex( nDstY, nDstX, 
pMap[ pReadAcc-GetPixelIndex( nSrcY, nSrcX ) ] );
-
-delete[] pMap;
 }
 else if( pReadAcc-HasPalette() )
 {
@@ -1403,10 +1396,10 @@ bool Bitmap::Replace( const Bitmap rMask, const Color 
rReplaceColor )
 }
 else
 {
-bool* pFlags = new bool[ nMaxColors ];
+boost::scoped_arraybool pFlags(new bool[ nMaxColors ]);
 
 // Set all entries to false
-std::fill( pFlags, pFlags+nMaxColors, false );
+std::fill( pFlags.get(), pFlags.get()+nMaxColors, false );
 
 for( long nY = 0L; nY  nHeight; nY++ )
 for( long nX = 0L; nX  nWidth; nX++ )
@@ -1421,8 +1414,6 @@ bool Bitmap::Replace( const Bitmap rMask, const Color

[Libreoffice-commits] buildbot.git: 2 commits - bin/push_nightlies.sh tb/tb_internals.sh

2014-03-14 Thread Jan Holesovsky

 bin/push_nightlies.sh |4 ++--
 tb/tb_internals.sh|2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit d62a9feb43b83c50d19b20d2c006e377b2ccf684
Author: Jan Holesovsky ke...@collabora.com
Date:   Tue Mar 4 16:23:38 2014 +0100

Symbols upload: Attempt to reduce the upload time in the tb script too.

diff --git a/tb/tb_internals.sh b/tb/tb_internals.sh
index 716b5c9..5114824 100644
--- a/tb/tb_internals.sh
+++ b/tb/tb_internals.sh
@@ -540,7 +540,7 @@ push_symbols()
 done
 popd /dev/null
 
-rsync --bwlimit=${TB_BANDWIDTH_LIMIT} --delete -avzP -e ssh 
${TB_SYMBOLS_DIR}/ 
upl...@gimli.documentfoundation.org:/srv/www/dev-builds.libreoffice.org/daily/${TB_BRANCH?}/${TB_NAME?}/symbols/
 || exit 1
+rsync --bwlimit=${TB_BANDWIDTH_LIMIT} --fuzzy --delete-after -avzP -e ssh 
${TB_SYMBOLS_DIR}/ 
upl...@gimli.documentfoundation.org:/srv/www/dev-builds.libreoffice.org/daily/${TB_BRANCH?}/${TB_NAME?}/symbols/
 || return 1
 }
 
 push_nightly()
commit 041050b3dc190c379f8ac925ea339518d79bac78
Author: Jan Holesovsky ke...@collabora.com
Date:   Tue Mar 4 16:14:40 2014 +0100

Symbols upload: Attempt to reduce the upload time.

diff --git a/bin/push_nightlies.sh b/bin/push_nightlies.sh
index 0ae1f91..a737f2b 100755
--- a/bin/push_nightlies.sh
+++ b/bin/push_nightlies.sh
@@ -160,7 +160,7 @@ if [ $ASYNC = 1 ] ; then
 fi
 rm -fr ${stage}/${tag}_*
 if [ -n $SYMBOLS_DIR ] ; then
-rsync --bwlimit=${BANDWIDTH} --delete -ave ssh ${SYMBOLS_DIR}/ 
upl...@gimli.documentfoundation.org:/srv/www/dev-builds.libreoffice.org/daily/${BRANCH}/${BUILDER_NAME}/symbols/
 || exit 1
+rsync --bwlimit=${BANDWIDTH} --fuzzy --delete-after -ave ssh 
${SYMBOLS_DIR}/ 
upl...@gimli.documentfoundation.org:/srv/www/dev-builds.libreoffice.org/daily/${BRANCH}/${BUILDER_NAME}/symbols/
 || exit 1
 fi
 )# 200${lock_file?}
 ) 
@@ -170,6 +170,6 @@ else
ssh upl...@gimli.documentfoundation.org cd 
\/srv/www/dev-builds.libreoffice.org/daily/${BRANCH}/${BUILDER_NAME}/\  { 
rm current; ln -s \${PULL_TIME}\ current ; }
 fi
 if [ -n $SYMBOLS_DIR ] ; then
-rsync --bwlimit=${BANDWIDTH} --delete -ave ssh ${SYMBOLS_DIR}/ 
upl...@gimli.documentfoundation.org:/srv/www/dev-builds.libreoffice.org/daily/${BRANCH}/${BUILDER_NAME}/symbols/
 || exit 1
+rsync --bwlimit=${BANDWIDTH} --fuzzy --delete-after -ave ssh 
${SYMBOLS_DIR}/ 
upl...@gimli.documentfoundation.org:/srv/www/dev-builds.libreoffice.org/daily/${BRANCH}/${BUILDER_NAME}/symbols/
 || exit 1
 fi
 fi
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dev-tools.git: 3 commits - ciabot/run-libreoffice-ciabot.pl scripts/gerrit-filter-domain

 ciabot/run-libreoffice-ciabot.pl |   39 +--
 scripts/gerrit-filter-domain |2 +-
 2 files changed, 38 insertions(+), 3 deletions(-)

New commits:
commit 75d8d6db694575272f63894ab5b8e973f3147a20
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Wed Mar 5 09:50:30 2014 +0100

gerrit-filter-domain: print URL for skipped changes as well

Change-Id: Ia4a6609791ababe8ae9edfd87139728c5053ec14

diff --git a/scripts/gerrit-filter-domain b/scripts/gerrit-filter-domain
index 9f353c3..69eca4c 100755
--- a/scripts/gerrit-filter-domain
+++ b/scripts/gerrit-filter-domain
@@ -74,7 +74,7 @@ def main(argv):
 print()
 print(Skipped %s changes: % len(skippedChanges))
 for i in skippedChanges:
-print(%s: %s % (i[0]['number'], i[1]))
+print(http://gerrit.libreoffice.org/%s: %s % (i[0]['number'], i[1]))
 
 if __name__ == __main__:
 try:
commit 475eb0d0590854520a5d801a471f12824e92cea1
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Tue Mar 4 16:32:03 2014 +0100

fix the ciabot script after latest changes

diff --git a/ciabot/run-libreoffice-ciabot.pl b/ciabot/run-libreoffice-ciabot.pl
index 8fa65c9..2ca4b9f 100755
--- a/ciabot/run-libreoffice-ciabot.pl
+++ b/ciabot/run-libreoffice-ciabot.pl
@@ -118,13 +118,15 @@ sub report($$$) {
 {
 qx(perl -I $cwd $cwd/sigui-bugzilla.pl 
$repo $_ $branch_name);
 } else {
-next if ( ! is_valid_bugzilla_commit( 
$repo, $branch_name ) );
-qx($ciabot $repo $_ $branch_name 
$ciaproxy);
+if ( is_valid_bugzilla_commit( $repo, 
$branch_name ) ) {
+qx($ciabot $repo $_ $branch_name 
$ciaproxy);
+}
 qx(perl -I $cwd 
$cwd/libreoffice-bugzilla.pl $repo $_ $branch_name);
 }
 } else {
-next if ( ! is_valid_bugzilla_commit( $repo, 
$branch_name ) );
-print $ciabot '$repo' '$_' '$branch_name' 
$ciaproxy\n;
+if ( is_valid_bugzilla_commit( $repo, 
$branch_name ) ) {
+print $ciabot '$repo' '$_' '$branch_name' 
$ciaproxy\n;
+}
 print perl -I $cwd 
$cwd/libreoffice-bugzilla.pl '$repo' '$_' '$branch_name'\n;
 }
 }
commit 3f17397d609e846d4a3b7c859378fa8c1a0de070
Author: Jan-Marek Glogowski glo...@fbihome.de
Date:   Mon Mar 3 14:20:28 2014 +

Filter branches for automatic bugzilla reports.

Introduces a much stricter branch filter for the 'core' repository.
Now it just reports changes for libreoffice-[^/]* and master.

diff --git a/ciabot/run-libreoffice-ciabot.pl b/ciabot/run-libreoffice-ciabot.pl
index 689cb36..8fa65c9 100755
--- a/ciabot/run-libreoffice-ciabot.pl
+++ b/ciabot/run-libreoffice-ciabot.pl
@@ -24,6 +24,13 @@ sub error($) {
 print STDERR $message\n;
 }
 
+#
+# Get a list of filtered branch HEADs
+#
+# Gets all branches, except HEAD.
+#
+# @returns \%{ branch name = git branch head hashval }
+#
 sub get_branches() {
 my %branches;
 if ( open REFS, git show-ref | ) {
@@ -44,10 +51,34 @@ sub get_branches() {
 return \%branches;
 }
 
+#
+# Should we generate Bugzilla comments?
+#
+# Report all commits for all repositories except 'core'. For 'core'
+# just report libreoffice-* and master branches to Bugzilla.
+#
+# @returns true, if this commit should be reported to Bugzilla.
+#
+sub is_valid_bugzilla_commit($$) {
+   my ( $repo, $branch ) = @_;
+   return 1 if ( $repo ne 'core' );
+   return ( $branch =~ /^(libreoffice-[^\/]*|master)$/ );
+}
+
 sub timestamp() {
 return strftime([%Y-%m-%d %H:%M:%S], localtime);
 }
 
+#
+# Report all branch changes to IRC and bugzilla.
+#
+# We just report changes filtered by is_valid_bugzilla_report to Bugzilla
+# but inform IRC off all changes.
+#
+# $1 = repository name
+# $2 = hashref of old branch heads (@see get_branches).
+# $3 = hashref of new branch heads (@see get_branches).
+#
 sub report($$$) {
 my ( $repo, $old_ref, $new_ref ) = @_;
 my %old = %{$old_ref};
@@ -87,10 +118,12 @@ sub report($$$) {
 {
 qx(perl -I $cwd $cwd/sigui-bugzilla.pl 
$repo $_ $branch_name);
 } else {
+next if ( ! is_valid_bugzilla_commit( 
$repo, $branch_name ) );
 qx($ciabot $repo $_ $branch_name 
$ciaproxy);
 qx(perl -I $cwd 
$cwd/libreoffice-bugzilla.pl $repo $_ $branch_name);
 }

[Libreoffice-commits] dev-tools.git: Branch 'private/jmux/filter-bugzilla-branches' - ciabot/run-libreoffice-ciabot.pl

2014-03-14 Thread Jan-Marek Glogowski

Rebased ref, commits from common ancestor:
commit ea5d93ba9a99f50c4771844ca3e58c3ce372c4d2
Author: Jan-Marek Glogowski glo...@fbihome.de
Date:   Mon Mar 3 14:20:28 2014 +

Filter branches for automatic bugzilla reports.

Introduces a much stricter branch filter for the 'core' repository.
Now it just reports changes for libreoffice-[^/]* and master.

diff --git a/ciabot/run-libreoffice-ciabot.pl b/ciabot/run-libreoffice-ciabot.pl
index 689cb36..4cb1bdb 100755
--- a/ciabot/run-libreoffice-ciabot.pl
+++ b/ciabot/run-libreoffice-ciabot.pl
@@ -24,6 +24,13 @@ sub error($) {
 print STDERR $message\n;
 }
 
+#
+# Get a list of filtered branch HEADs
+#
+# Gets all branches, except HEAD.
+#
+# @returns \%{ branch name = git branch head hashval }
+#
 sub get_branches() {
 my %branches;
 if ( open REFS, git show-ref | ) {
@@ -44,10 +51,34 @@ sub get_branches() {
 return \%branches;
 }
 
+#
+# Should we generate Bugzilla comments?
+#
+# Report all commits for all repositories except 'core'. For 'core'
+# just report libreoffice-* and master branches to Bugzilla.
+#
+# @returns true, if this commit should be reported to Bugzilla.
+#
+sub is_valid_bugzilla_commit($$) {
+   my ( $repo, $branch ) = @_;
+   return 1 if ( $repo ne 'core' );
+   return ( $branch =~ /^(libreoffice-[^\/]*|master)$/ );
+}
+
 sub timestamp() {
 return strftime([%Y-%m-%d %H:%M:%S], localtime);
 }
 
+#
+# Report all branch changes to IRC and bugzilla.
+#
+# We just report changes filtered by is_valid_bugzilla_report to Bugzilla
+# but inform IRC off all changes.
+#
+# $1 = repository name
+# $2 = hashref of old branch heads (@see get_branches).
+# $3 = hashref of new branch heads (@see get_branches).
+#
 sub report($$$) {
 my ( $repo, $old_ref, $new_ref ) = @_;
 my %old = %{$old_ref};
@@ -88,10 +119,12 @@ sub report($$$) {
 qx(perl -I $cwd $cwd/sigui-bugzilla.pl 
$repo $_ $branch_name);
 } else {
 qx($ciabot $repo $_ $branch_name 
$ciaproxy);
+next if ( ! is_valid_bugzilla_commit( 
$repo, $branch_name ) );
 qx(perl -I $cwd 
$cwd/libreoffice-bugzilla.pl $repo $_ $branch_name);
 }
 } else {
 print $ciabot '$repo' '$_' '$branch_name' 
$ciaproxy\n;
+next if ( ! is_valid_bugzilla_commit( $repo, 
$branch_name ) );
 print perl -I $cwd 
$cwd/libreoffice-bugzilla.pl '$repo' '$_' '$branch_name'\n;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Bad empty file at http://updateexte.libreoffice.org/ExtensionUpdateService/check.Update

Quoting https://bugs.freedesktop.org/show_bug.cgi?id=65795#c7 on 
Syntax error in Extension Manager when trying to update:


The reason [for the syntax error] is that 
http://updateexte.libreoffice.org/ExtensionUpdateService/check.Update 
references a completely empty file.  That URL is the value of the 
ExtensionUpdateURL property in the version ini file.  It is used by 
getDefaultUpdateInfos (desktop/source/deployment/misc/dp_update.cxx) to 
try and obtain 'backup' update information from one central place for 
all those extensions that fail to provide their own update information. 
 The current 
http://updateexte.libreoffice.org/ExtensionUpdateService/check.Update 
URL is used since 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=52456c0acaaebe1c85d07c90a94a82c9efa4850f 
'Switch all urls from TDF to LibreOffice.'  The prior, OOo-specific URL 
http://updateexte.services.openoffice.org/ExtensionUpdateService/check.Update 
still delivers a file starting with



?xml version=1.0 encoding=utf-8?
feed xmlns=http://www.w3.org/2005/Atom; xml:lang=en-US
  titleExtension Update Feed/title
  link rel=alternate type=text/html 
href=http://extensions.openoffice.org/
  updated2013-03-18T12:03:22+00:00/updated


I have no idea who is responsible for the empty file at 
http://updateexte.libreoffice.org/ExtensionUpdateService/check.Update.


I see three options to fix this:

1  Fix the file at 
http://updateexte.libreoffice.org/ExtensionUpdateService/check.Update 
to conform to the expected syntax (even if it would not contain any true 
payload yet, but could do so in the future).  That would fix this issue 
even for already released versions of LO.


2  Give the ExtensionUpdateURL property in the version ini file an 
empty value.  That would not fix this issue for already released 
versions of LO, and for future versions of LO would disable the 
(currently unused) feature of providing such central 'backup' extension 
update information (until we change the value back in a later release).


3  Remove the (currently unused) feature of providing such central 
'backup' extension update information completely from the code.  That 
would not fix this issue for already released versions of LO.


I favour option 1 and will see to get hold of somebody to fix the file 
at http://updateexte.libreoffice.org/ExtensionUpdateService/check.Update.


So, who can fix that file (or propose a better fix)?

Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

spadmin, fax machines, etc. is this still useful ?

On (non-MacOSX) unix we have spadmin the printer administration tool. 

Over the years the amount of stuff it does has been reduced, e.g. it no
longer admins fonts, that's done through fontconfig now. It now no
longer provides a font-substitution tab page as that's redundant
functionality now. It now no longer provides a route to migrate your
archaic StarOffice printer configuration to the current one.

So what's left:
a) you can connect a fax device
b) you can connect a PDF converter
c) you can add a printer
d) you can disable cups support

I would like to simplify the situation to we use cups and remove
spadmin and all its many associated dialogs and tabpages in favor of the
system printer management software. So the question is if any part of
spadmin is still useful? Is there anyone still configuring fax machines
or using the other options there, and if so for what purpose ?

The last time I tried to get rid of spadmin (in 2004) in Fedora there
was push back because there were still people using fax machines. 10
years later, is this still the case ? If this is still a relevant use
case then I can invest a little time in examining the fax-cups options
out there and figure out how to correctly send the destination phone
number to them and recommend that as the new fax support mechanism.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/source

2014-03-14 Thread Chris Sherlock

 vcl/source/gdi/print.cxx |   17 +
 vcl/source/gdi/virdev.cxx|   11 ++-
 vcl/source/window/window.cxx |   10 --
 3 files changed, 19 insertions(+), 19 deletions(-)

New commits:
commit 0d88e15a8a3fa7fba6471c832d7df3cfd61da962
Author: Chris Sherlock chris.sherloc...@gmail.com
Date:   Fri Mar 14 11:27:09 2014 +1100

fdo#74702 Return true if graphics is set, cleanup unused variables

If mpGraphics is set, then return true as initialization of graphics
device has already been done. I've also removed unnecessary variables
which were a left over from the function splits.

Change-Id: I25c25b93b9db2c112c9a1aea278b1ec3e0590303
Reviewed-on: https://gerrit.libreoffice.org/8581
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com

diff --git a/vcl/source/gdi/print.cxx b/vcl/source/gdi/print.cxx
index 7eca283..92a7d3d 100644
--- a/vcl/source/gdi/print.cxx
+++ b/vcl/source/gdi/print.cxx
@@ -458,6 +458,9 @@ bool Printer::ImplInitGraphics() const
 {
 DBG_TESTSOLARMUTEX();
 
+if ( mpGraphics )
+return true;
+
 mbInitLineColor = true;
 mbInitFillColor = true;
 mbInitFont  = true;
@@ -466,13 +469,11 @@ bool Printer::ImplInitGraphics() const
 
 ImplSVData* pSVData = ImplGetSVData();
 
-const Printer* pPrinter = (const Printer*)this;
-
-if ( pPrinter-mpJobGraphics )
-mpGraphics = pPrinter-mpJobGraphics;
-else if ( pPrinter-mpDisplayDev )
+if ( mpJobGraphics )
+mpGraphics = mpJobGraphics;
+else if ( mpDisplayDev )
 {
-const VirtualDevice* pVirDev = pPrinter-mpDisplayDev;
+const VirtualDevice* pVirDev = mpDisplayDev;
 mpGraphics = pVirDev-mpVirDev-AcquireGraphics();
 // if needed retry after releasing least recently used virtual device 
graphics
 while ( !mpGraphics )
@@ -495,14 +496,14 @@ bool Printer::ImplInitGraphics() const
 }
 else
 {
-mpGraphics = pPrinter-mpInfoPrinter-AcquireGraphics();
+mpGraphics = mpInfoPrinter-AcquireGraphics();
 // if needed retry after releasing least recently used printer graphics
 while ( !mpGraphics )
 {
 if ( !pSVData-maGDIData.mpLastPrnGraphics )
 break;
 pSVData-maGDIData.mpLastPrnGraphics-ImplReleaseGraphics();
-mpGraphics = pPrinter-mpInfoPrinter-AcquireGraphics();
+mpGraphics = mpInfoPrinter-AcquireGraphics();
 }
 // update global LRU list of printer graphics
 if ( mpGraphics )
diff --git a/vcl/source/gdi/virdev.cxx b/vcl/source/gdi/virdev.cxx
index bb9d37f..3e962fd 100644
--- a/vcl/source/gdi/virdev.cxx
+++ b/vcl/source/gdi/virdev.cxx
@@ -38,6 +38,9 @@ bool VirtualDevice::ImplInitGraphics() const
 {
 DBG_TESTSOLARMUTEX();
 
+if ( mpGraphics )
+return true;
+
 mbInitLineColor = true;
 mbInitFillColor = true;
 mbInitFont  = true;
@@ -46,18 +49,16 @@ bool VirtualDevice::ImplInitGraphics() const
 
 ImplSVData* pSVData = ImplGetSVData();
 
-const VirtualDevice* pVirDev = (const VirtualDevice*)this;
-
-if ( pVirDev-mpVirDev )
+if ( mpVirDev )
 {
-mpGraphics = pVirDev-mpVirDev-AcquireGraphics();
+mpGraphics = mpVirDev-AcquireGraphics();
 // if needed retry after releasing least recently used virtual device 
graphics
 while ( !mpGraphics )
 {
 if ( !pSVData-maGDIData.mpLastVirGraphics )
 break;
 pSVData-maGDIData.mpLastVirGraphics-ImplReleaseGraphics();
-mpGraphics = pVirDev-mpVirDev-AcquireGraphics();
+mpGraphics = mpVirDev-AcquireGraphics();
 }
 // update global LRU list of virtual device graphics
 if ( mpGraphics )
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index d4a0087..f57e384 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -357,7 +357,7 @@ bool Window::ImplInitGraphics() const
 DBG_TESTSOLARMUTEX();
 
 if ( mpGraphics )
-return mpGraphics;
+return true;
 
 mbInitLineColor = true;
 mbInitFillColor = true;
@@ -367,9 +367,7 @@ bool Window::ImplInitGraphics() const
 
 ImplSVData* pSVData = ImplGetSVData();
 
-Window* pWindow = (Window*)this;
-
-mpGraphics = pWindow-mpWindowImpl-mpFrame-AcquireGraphics();
+mpGraphics = mpWindowImpl-mpFrame-AcquireGraphics();
 // try harder if no wingraphics was available directly
 if ( !mpGraphics )
 {
@@ -377,7 +375,7 @@ bool Window::ImplInitGraphics() const
 OutputDevice* pReleaseOutDev = pSVData-maGDIData.mpLastWinGraphics;
 while ( pReleaseOutDev )
 {
-if ( ((Window*)pReleaseOutDev)-mpWindowImpl-mpFrame == 
pWindow-mpWindowImpl-mpFrame )
+if ( ((Window*)pReleaseOutDev)-mpWindowImpl-mpFrame ==

Re: spadmin, fax machines, etc. is this still useful ?

Le 14/03/2014 11:45, Caolán McNamara a écrit :

Hi Caolan,

Judging from the posts I have seen on the user list since LO came into
existence, there are still some use cases where CUPS does not provide
the required support and people need to be able to fall back to spadmin
for printing.

The fact that spadmin could be used to add Type1 PS fonts, which are no
longer supported, if I understand correctly, has also been, and
continues to be, an issue that crops up on the user list (and possibly
also in BZ) for some people.

The problem as I see it is that there are so many printers out there
being used by LO users, some of them quite old now (yet tried and
trusted, especially in business), for which CUPS support has been
dropped or curbed over time, and it is handy to be able to pop in one's
own PPD to just get the job done.

From my own experience, the switch to CUPS ONLY by default caused the
loss of being able to print from two different trays in one document
over the network, i.e. have page 1 print out on header paper in a first
or manual tray, and then subsequent pages from the follow-on paper tray.
This could previously be set up in a PPD and included via spadmin,
including on Mac OSX. I have not yet found a way to this with CUPS,
having been reduced to separate printing steps for each set of pages.

I have no idea whether such use cases are still representative of the
mainstream usage of LO, but it is certainly around in businesses with
legacy printers that are still functioning. I have used HP LJs (4050n,
2500dtn, Apple LaserWriter) in business scenarii in the past with OOo
and the ability to fiddle with the PPD to get things working right was
the saving grace on many occasion.

Alex




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 7 commits - external/libxml2 RepositoryExternal.mk Repository.mk scp2/source sfx2/README

2014-03-14 Thread Michael Stahl

 Repository.mk  |4 
 RepositoryExternal.mk  |   26 
 external/libxml2/ExternalPackage_xml2.mk   |4 
 external/libxml2/ExternalPackage_xml2_win32.mk |   26 
 external/libxml2/Module_libxml2.mk |1 
 scp2/source/ooo/common_brand.scp   |   19 ---
 scp2/source/ooo/file_library_ooo.scp   |  141 -
 scp2/source/ooo/module_hidden_ooo.scp  |   25 
 scp2/source/ooo/ure.scp|   20 ---
 sfx2/README|3 
 10 files changed, 61 insertions(+), 208 deletions(-)

New commits:
commit 64ea9944cfc441504915da37f6b2dff7a394d797
Author: Michael Stahl mst...@redhat.com
Date:   Fri Mar 14 11:48:24 2014 +0100

scp2: move libxml2 to AutoInstall

Change-Id: I62f2f654ac661ebf266b7b5cf70728a616c9b50f

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 4553be3..39bed26 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -868,6 +868,14 @@ gb_ExternalProject__use_libxml2:=
 
 else # !SYSTEM_LIBXML
 
+$(eval $(call gb_Helper_register_packages_for_install,ure,\
+   xml2 \
+))
+
+$(eval $(call gb_Helper_register_packages_for_install,ooo,\
+   xml2_win32 \
+))
+
 define gb_LinkTarget__use_libxml2
 $(call gb_LinkTarget_use_package,$(1),xml2)
 $(call gb_LinkTarget_set_include,$(1),\
diff --git a/external/libxml2/ExternalPackage_xml2.mk 
b/external/libxml2/ExternalPackage_xml2.mk
index e25a7f8..a0bf5eb 100644
--- a/external/libxml2/ExternalPackage_xml2.mk
+++ b/external/libxml2/ExternalPackage_xml2.mk
@@ -17,12 +17,8 @@ $(eval $(call 
gb_ExternalPackage_add_file,xml2,$(LIBO_URE_LIB_FOLDER)/libxml2.2.
 else ifeq ($(OS),WNT)
 ifeq ($(COM),GCC)
 $(eval $(call 
gb_ExternalPackage_add_file,xml2,$(LIBO_URE_LIB_FOLDER)/libxml2.dll,.libs/libxml2.dll))
-$(eval $(call 
gb_ExternalPackage_add_file,xml2,$(LIBO_LIB_FOLDER)/libxml2.dll,.libs/libxml2.dll))
 else # COM=MSC
 $(eval $(call 
gb_ExternalPackage_add_file,xml2,$(LIBO_URE_LIB_FOLDER)/libxml2.dll,win32/bin.msvc/libxml2.dll))
-# duplicate copy next to executables due to idiotic Win32 DLL search order
-# see 5a5dab5167d136c315e81448ea8eca59e60067da
-$(eval $(call 
gb_ExternalPackage_add_file,xml2,$(LIBO_LIB_FOLDER)/libxml2.dll,win32/bin.msvc/libxml2.dll))
 endif
 else # OS!=WNT
 $(eval $(call 
gb_ExternalPackage_add_file,xml2,$(LIBO_URE_LIB_FOLDER)/libxml2.so.2,.libs/libxml2.so.2.9.1))
diff --git a/external/libxml2/ExternalPackage_xml2_win32.mk 
b/external/libxml2/ExternalPackage_xml2_win32.mk
new file mode 100644
index 000..c97fd89
--- /dev/null
+++ b/external/libxml2/ExternalPackage_xml2_win32.mk
@@ -0,0 +1,26 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_ExternalPackage_ExternalPackage,xml2_win32,xml2))
+
+$(eval $(call gb_ExternalPackage_use_external_project,xml2_win32,xml2))
+
+# duplicate copy next to executables due to stupid Win32 DLL search order
+# where a libxml2.dll in C:\Windows is loaded before one in URE lib dir
+# see 5a5dab5167d136c315e81448ea8eca59e60067da
+
+ifeq ($(OS),WNT)
+ifeq ($(COM),GCC)
+$(eval $(call 
gb_ExternalPackage_add_file,xml2_win32,$(LIBO_LIB_FOLDER)/libxml2.dll,.libs/libxml2.dll))
+else # COM=MSC
+$(eval $(call 
gb_ExternalPackage_add_file,xml2_win32,$(LIBO_LIB_FOLDER)/libxml2.dll,win32/bin.msvc/libxml2.dll))
+endif
+endif # OS=WNT
+
+# vim: set noet sw=4 ts=4:
diff --git a/external/libxml2/Module_libxml2.mk 
b/external/libxml2/Module_libxml2.mk
index f6bca3f..9efb17c 100644
--- a/external/libxml2/Module_libxml2.mk
+++ b/external/libxml2/Module_libxml2.mk
@@ -11,6 +11,7 @@ $(eval $(call gb_Module_Module,libxml2))
 
 $(eval $(call gb_Module_add_targets,libxml2,\
ExternalPackage_xml2 \
+   ExternalPackage_xml2_win32 \
ExternalProject_xml2 \
UnpackedTarball_xml2 \
 ))
diff --git a/scp2/source/ooo/common_brand.scp b/scp2/source/ooo/common_brand.scp
index 2498822..e731d8f 100644
--- a/scp2/source/ooo/common_brand.scp
+++ b/scp2/source/ooo/common_brand.scp
@@ -61,7 +61,6 @@ Module gid_Module_Root_Brand
  gid_Brand_File_Bin_Unopkgcom,
  gid_Brand_File_Bin_Unopkgexe,
  gid_Brand_File_Bin_Unopkg,
- gid_Brand_File_Bin_Libxml2,
  gid_Brand_File_Bmp_IntroAboutShell,
  gid_Brand_File_Bmp_IntroAboutShell_custom,
 gid_Brand_File_Desktophelper_Txt,
@@ -616,24 +615,6 @@ File gid_Brand_File_Bin_Unopkg
 Name = unopkg.bin;
 End
 
-// Due to Windows DLL search order, OOo executables might pick up a libxml2 DLL
-// from a Windows system directory instead of the one from the URE; to avoid
-// problems, as a HACK, for now a

[Libreoffice-commits] core.git: sc/inc sc/source

 sc/inc/clipparam.hxx  |1 -
 sc/source/core/data/clipparam.cxx |9 -
 2 files changed, 10 deletions(-)

New commits:
commit 0b2765d4e8bb460d63876d756f006cf0343e5cdd
Author: Stephan Bergmann sberg...@redhat.com
Date:   Fri Mar 14 12:38:49 2014 +0100

Help poor old Mac compiler by making ScClipParam copy ctor non-explicit

(and defaulted)

Change-Id: I0cccef5710fad801e5541ce581ac976f645a7fdb

diff --git a/sc/inc/clipparam.hxx b/sc/inc/clipparam.hxx
index 3b3747f..f0f1c3b 100644
--- a/sc/inc/clipparam.hxx
+++ b/sc/inc/clipparam.hxx
@@ -42,7 +42,6 @@ struct ScClipParam
 
 ScClipParam();
 ScClipParam(const ScRange rRange, bool bCutMode);
-explicit ScClipParam(const ScClipParam r);
 
 bool isMultiRange() const;
 
diff --git a/sc/source/core/data/clipparam.cxx 
b/sc/source/core/data/clipparam.cxx
index 3935141..4a7370e 100644
--- a/sc/source/core/data/clipparam.cxx
+++ b/sc/source/core/data/clipparam.cxx
@@ -36,15 +36,6 @@ ScClipParam::ScClipParam(const ScRange rRange, bool 
bCutMode) :
 maRanges.Append(rRange);
 }
 
-ScClipParam::ScClipParam(const ScClipParam r) :
-maRanges(r.maRanges),
-meDirection(r.meDirection),
-mbCutMode(r.mbCutMode),
-mnSourceDocID(r.mnSourceDocID),
-maProtectedChartRangesVector(r.maProtectedChartRangesVector)
-{
-}
-
 bool ScClipParam::isMultiRange() const
 {
 return maRanges.size()  1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: helpers/help_hid.lst

 helpers/help_hid.lst |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 4a7afcf2c94a9267ddab51c9a3b58ff13102ea0b
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 11:45:54 2014 +

drop help id that points nowhere

Change-Id: I2cdc07b1a2a2646e284550adbbd05d1df1455c39

diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst
index 9dcec72..6ceb867 100644
--- a/helpers/help_hid.lst
+++ b/helpers/help_hid.lst
@@ -5645,7 +5645,6 @@ 
filter_CheckBox_DLG_OPTIONS_BOOL_EXPORT_OLE_AS_JPEG,1090520070,
 filter_CheckBox_DLG_OPTIONS_BOOL_EXPORT_SLIDE_CONTENTS,1090520068,
 filter_CheckBox_DLG_OPTIONS_BOOL_EXPORT_SOUND,1090520069,
 filter_ModalDialog_DLG_OPTIONS,1090519040,
-filter_ModalDialog_RID_PDF_ERROR_DLG,1404878848,
 filter_NumericField_DLG_OPTIONS_NUM_FLD_QUALITY,1090525185,
 formula_CheckBox_RID_FORMULADLG_FORMULA_BTN_MATRIX,2655437835,
 formula_CheckBox_RID_FORMULADLG_FORMULA_MODAL_BTN_MATRIX,1581728779,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bfb9fc91fb718e79a895cf027c0d8b5ac44ffb19
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 11:45:54 2014 +

Updated core
Project: help  4a7afcf2c94a9267ddab51c9a3b58ff13102ea0b

diff --git a/helpcontent2 b/helpcontent2
index fcc6cf6..4a7afcf 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit fcc6cf6417cc21d817e0fa921d66ecbe2bf2b9fe
+Subproject commit 4a7afcf2c94a9267ddab51c9a3b58ff13102ea0b
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - filter/source filter/uiconfig filter/UIConfig_xsltdlg.mk framework/inc framework/Library_fwl.mk framework/source framework/util vcl/source

 filter/UIConfig_xsltdlg.mk |1 
 filter/source/pdf/impdialog.cxx|   81 +---
 filter/source/pdf/impdialog.hrc|   39 --
 filter/source/pdf/impdialog.hxx|   10 
 filter/source/pdf/impdialog.src|  104 ++---
 filter/uiconfig/ui/warnpdfdialog.ui|   89 
 framework/Library_fwl.mk   |1 
 framework/inc/classes/resource.hrc |   16 
 framework/inc/services.h   |2 
 framework/inc/services/license.hxx |   83 
 framework/inc/services/licensedlg.hxx  |   97 -
 framework/source/classes/resource.src  |  149 
 framework/source/register/registertemp.cxx |2 
 framework/source/services/license.cxx  |  529 -
 framework/util/fwl.component   |3 
 vcl/source/window/layout.cxx   |1 
 16 files changed, 185 insertions(+), 1022 deletions(-)

New commits:
commit f35b1958e3519887355f74e1ffdc60dca9de8de5
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 09:14:41 2014 +

convert pdf warn dialog to .ui

Change-Id: I379c7f06ae87bee5571c1f2ef5053b3b863d6e61

diff --git a/filter/UIConfig_xsltdlg.mk b/filter/UIConfig_xsltdlg.mk
index abef4d3..3442112 100644
--- a/filter/UIConfig_xsltdlg.mk
+++ b/filter/UIConfig_xsltdlg.mk
@@ -19,6 +19,7 @@ $(eval $(call gb_UIConfig_add_uifiles,filter,\
 filter/uiconfig/ui/pdfuserinterfacepage \
 filter/uiconfig/ui/pdfviewpage \
filter/uiconfig/ui/testxmlfilter \
+   filter/uiconfig/ui/warnpdfdialog \
filter/uiconfig/ui/xmlfiltersettings \
filter/uiconfig/ui/xmlfiltertabpagegeneral \
filter/uiconfig/ui/xmlfiltertabpagetransformation \
diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index 9062ba5..1c18bce 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -1450,15 +1450,18 @@ IMPL_LINK_NOARG(ImpPDFTabLinksPage, 
ClickRbOpnLnksBrowserHdl)
 return 0;
 }
 
-ImplErrorDialog::ImplErrorDialog( const std::set vcl::PDFWriter::ErrorCode  
rErrors ) :
-ModalDialog( NULL, PDFFilterResId( RID_PDF_ERROR_DLG ) ),
-maFI( this, 0 ),
-maProcessText( this, PDFFilterResId( FT_PROCESS ) ),
-maErrors( this, WB_BORDER | WB_AUTOVSCROLL ),
-maExplanation( this, WB_WORDBREAK ),
-maButton( this, WB_DEFBUTTON )
-
+ImplErrorDialog::ImplErrorDialog(const std::set vcl::PDFWriter::ErrorCode  
rErrors)
+: MessageDialog(NULL, WarnPDFDialog, filter/ui/warnpdfdialog.ui)
 {
+get(m_pErrors, errors);
+get(m_pExplanation, message);
+
+Size aSize(LogicToPixel(Size(100, 75), MapMode(MAP_APPFONT)));
+m_pErrors-set_width_request(aSize.Width());
+m_pErrors-set_height_request(aSize.Height());
+m_pExplanation-set_width_request(aSize.Width());
+m_pExplanation-set_height_request(aSize.Height());
+
 // load images
 Image aWarnImg( BitmapEx( PDFFilterResId( IMG_WARN ) ) );
 Image aErrImg( BitmapEx( PDFFilterResId( IMG_ERR ) ) );
@@ -1470,30 +1473,30 @@ ImplErrorDialog::ImplErrorDialog( const std::set 
vcl::PDFWriter::ErrorCode  r
 {
 case vcl::PDFWriter::Warning_Transparency_Omitted_PDFA:
 {
-sal_uInt16 nPos = maErrors.InsertEntry( OUString( PDFFilterResId( 
STR_WARN_TRANSP_PDFA_SHORT ) ),
+sal_uInt16 nPos = m_pErrors-InsertEntry( OUString( 
PDFFilterResId( STR_WARN_TRANSP_PDFA_SHORT ) ),
 aWarnImg );
-maErrors.SetEntryData( nPos, new OUString( PDFFilterResId( 
STR_WARN_TRANSP_PDFA ) ) );
+m_pErrors-SetEntryData( nPos, new OUString( PDFFilterResId( 
STR_WARN_TRANSP_PDFA ) ) );
 }
 break;
 case vcl::PDFWriter::Warning_Transparency_Omitted_PDF13:
 {
-sal_uInt16 nPos = maErrors.InsertEntry( OUString( PDFFilterResId( 
STR_WARN_TRANSP_VERSION_SHORT ) ),
+sal_uInt16 nPos = m_pErrors-InsertEntry( OUString( 
PDFFilterResId( STR_WARN_TRANSP_VERSION_SHORT ) ),
 aWarnImg );
-maErrors.SetEntryData( nPos, new OUString( PDFFilterResId( 
STR_WARN_TRANSP_VERSION ) ) );
+m_pErrors-SetEntryData( nPos, new OUString( PDFFilterResId( 
STR_WARN_TRANSP_VERSION ) ) );
 }
 break;
 case vcl::PDFWriter::Warning_FormAction_Omitted_PDFA:
 {
-sal_uInt16 nPos = maErrors.InsertEntry( OUString( PDFFilterResId( 
STR_WARN_FORMACTION_PDFA_SHORT ) ),
+sal_uInt16 nPos = m_pErrors-InsertEntry( OUString( 
PDFFilterResId( STR_WARN_FORMACTION_PDFA_SHORT ) ),
 aWarnImg );
-maErrors.SetEntryData( nPos, new OUString( PDFFilterResId( 
STR_WARN_FORMACTION_PDFA ) ) );
+m_pErrors-SetEntryData( nPos, new OUString( PDFFilterResId( 
STR_WARN_FORMACTION_PDFA ) ) );
 }
 break;
 case

Re: is com.sun.star.comp.framework.License dead ?

On Fri, 2014-03-14 at 09:17 +0100, Stephan Bergmann wrote:
 On 03/13/2014 10:05 PM, Caolán McNamara wrote:
  Is com.sun.star.comp.framework.License something dead that can be
  removed ? I don't seem to see any use of it anywhere in our code and I
  don't see it documented anywhere for use by extensions or anything.
 
  (it has a old-school .src dialog in it that I want to get rid of)
 
 As dead as it gets, I'd say---apparently for 10 years now.  (The 
 Extension Mgr has its own 
 desktop/source/deployment/gui/license_dialog.hxx for displaying any 
 extension licenses.)

Gone now.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: spadmin, fax machines, etc. is this still useful ?

2014-03-14 Thread Khaled Hosny

On Fri, Mar 14, 2014 at 12:31:50PM +0100, Alex Thurgood wrote:
 Le 14/03/2014 11:45, Caolán McNamara a écrit :
 
 Hi Caolan,
 
 Judging from the posts I have seen on the user list since LO came into
 existence, there are still some use cases where CUPS does not provide
 the required support and people need to be able to fall back to spadmin
 for printing.

So the question is, how other applications are handled? Do those people
print exclusively using LibreOffice?

(I always export to PDF and print from the PDF viewer myself as I find
printing from LibreOffice to be too mysterious for my limited
understanding of how printers work.)

Regards,
Khaled
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 3 commits - sc/inc sc/qa sc/source sc/uiconfig

2014-03-14 Thread Eike Rathke

 sc/inc/calcconfig.hxx |   10 +
 sc/qa/unit/ucalc.cxx  |   77 +
 sc/source/core/tool/calcconfig.cxx|2 
 sc/source/core/tool/formulaopt.cxx|   66 +++-
 sc/source/core/tool/interpr4.cxx  |   99 
 sc/source/ui/optdlg/calcoptionsdlg.cxx|  174 --
 sc/source/ui/optdlg/calcoptionsdlg.hxx|   11 +
 sc/uiconfig/scalc/ui/formulacalculationoptions.ui |  104 +++--
 8 files changed, 469 insertions(+), 74 deletions(-)

New commits:
commit af88ab2ee9167279cb70a577fb399d23f2ce136f
Author: Eike Rathke er...@redhat.com
Date:   Fri Mar 14 13:27:22 2014 +0100

unit test for string conversion feature, related fdo#37132 fdo#74622

Change-Id: If7d9c032d6025a6c6bf850e338923296ba2590dd

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index c903f4f..68713df 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -1661,12 +1661,14 @@ void Test::testFuncParam()
 m_pDoc-SetString(0, 0, 0, OUString(=\\+3));// empty string
 m_pDoc-SetString(0, 1, 0, OUString(=\ \+3));   // only blank
 m_pDoc-SetString(0, 2, 0, OUString(=\ 4 \+3)); // number in blanks
-m_pDoc-SetString(0, 3, 0, OUString(=\ x \+3)); // non-numeric = 
#VALUE! error
+m_pDoc-SetString(0, 3, 0, OUString(=\ x \+3)); // non-numeric
+m_pDoc-SetString(0, 4, 0, OUString(=\4.4\+3)); // locale dependent
 
 OUString aVal;
 ScCalcConfig aConfig;
 
-// With Empty string as zero option.
+// With Convert also locale dependent and Empty string as zero=True 
option.
+aConfig.meStringConversion = 
ScCalcConfig::STRING_CONVERSION_LOCALE_DEPENDENT;
 aConfig.mbEmptyStringAsZero = true;
 ScInterpreter::SetGlobalConfig(aConfig);
 m_pDoc-CalcAll();
@@ -1678,8 +1680,11 @@ void Test::testFuncParam()
 CPPUNIT_ASSERT_MESSAGE(incorrect result, val == 7);
 aVal = m_pDoc-GetString( 0, 3, 0);
 CPPUNIT_ASSERT_MESSAGE(incorrect result, aVal == #VALUE!);
+m_pDoc-GetValue(0, 4, 0, val);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, val == 7.4);
 
-// Without Empty string as zero option.
+// With Convert also locale dependent and Empty string as zero=False 
option.
+aConfig.meStringConversion = 
ScCalcConfig::STRING_CONVERSION_LOCALE_DEPENDENT;
 aConfig.mbEmptyStringAsZero = false;
 ScInterpreter::SetGlobalConfig(aConfig);
 m_pDoc-CalcAll();
@@ -1691,6 +1696,72 @@ void Test::testFuncParam()
 CPPUNIT_ASSERT_MESSAGE(incorrect result, val == 7);
 aVal = m_pDoc-GetString( 0, 3, 0);
 CPPUNIT_ASSERT_MESSAGE(incorrect result, aVal == #VALUE!);
+m_pDoc-GetValue(0, 4, 0, val);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, val == 7.4);
+
+// With Convert only unambiguous and Empty string as zero=True option.
+aConfig.meStringConversion = ScCalcConfig::STRING_CONVERSION_UNAMBIGUOUS;
+aConfig.mbEmptyStringAsZero = true;
+ScInterpreter::SetGlobalConfig(aConfig);
+m_pDoc-CalcAll();
+m_pDoc-GetValue(0, 0, 0, val);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, val == 3);
+m_pDoc-GetValue(0, 1, 0, val);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, val == 3);
+m_pDoc-GetValue(0, 2, 0, val);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, val == 7);
+aVal = m_pDoc-GetString( 0, 3, 0);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, aVal == #VALUE!);
+aVal = m_pDoc-GetString( 0, 4, 0);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, aVal == #VALUE!);
+
+// With Convert only unambiguous and Empty string as zero=False option.
+aConfig.meStringConversion = ScCalcConfig::STRING_CONVERSION_UNAMBIGUOUS;
+aConfig.mbEmptyStringAsZero = false;
+ScInterpreter::SetGlobalConfig(aConfig);
+m_pDoc-CalcAll();
+aVal = m_pDoc-GetString( 0, 0, 0);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, aVal == #VALUE!);
+aVal = m_pDoc-GetString( 0, 1, 0);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, aVal == #VALUE!);
+m_pDoc-GetValue(0, 2, 0, val);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, val == 7);
+aVal = m_pDoc-GetString( 0, 3, 0);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, aVal == #VALUE!);
+aVal = m_pDoc-GetString( 0, 4, 0);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, aVal == #VALUE!);
+
+// With Treat as zero (Empty string as zero is ignored).
+aConfig.meStringConversion = ScCalcConfig::STRING_CONVERSION_AS_ZERO;
+aConfig.mbEmptyStringAsZero = true;
+ScInterpreter::SetGlobalConfig(aConfig);
+m_pDoc-CalcAll();
+m_pDoc-GetValue(0, 0, 0, val);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, val == 3);
+m_pDoc-GetValue(0, 1, 0, val);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, val == 3);
+m_pDoc-GetValue(0, 2, 0, val);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, val == 3);
+m_pDoc-GetValue(0, 3, 0, val);
+CPPUNIT_ASSERT_MESSAGE(incorrect result, val == 3);
+m_pDoc-GetValue(0, 4, 0, val);
+

[Libreoffice-commits] core.git: sw/qa writerfilter/source

 sw/qa/extras/rtfimport/data/dptxbx-relation.rtf |5 +
 sw/qa/extras/rtfimport/rtfimport.cxx|6 ++
 writerfilter/source/rtftok/rtfdocumentimpl.cxx  |   16 +++-
 3 files changed, 26 insertions(+), 1 deletion(-)

New commits:
commit 7c53577f325e5260c538f9ca42cda54ca1a24b7a
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Fri Mar 14 12:11:13 2014 +0100

RTF import: fix dobxpage before dptxbx

The problem was that dobxpage arrived first, set HoriOrientRelation to
FRAME, then dptxbx tried to apply defaults, which overwrote the already
set HoriOrientRelation. Fix this by only applying properties which are
not set yet.

Change-Id: I108f3363a2758eee0242533fe92e511e8c522b68

diff --git a/sw/qa/extras/rtfimport/data/dptxbx-relation.rtf 
b/sw/qa/extras/rtfimport/data/dptxbx-relation.rtf
new file mode 100644
index 000..82f0741
--- /dev/null
+++ b/sw/qa/extras/rtfimport/data/dptxbx-relation.rtf
@@ -0,0 +1,5 @@
+{\rtf1
+{\*\do\dobxpage\dobypara\dodhgt8192\dptxbx\dptxbxmar0
+{\dptxbxtext\ltrpar\f4\fs20\cf1\vertalc\qc\ltrch To:\par}
+\dpx941\dpy2114\dpxsize1349\dpysize221\dplinehollow0}
+}
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx 
b/sw/qa/extras/rtfimport/rtfimport.cxx
index 5965aae..01814b9 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -1528,6 +1528,12 @@ DECLARE_RTFIMPORT_TEST(testFdo69289, fdo69289.rtf)
 CPPUNIT_ASSERT_EQUAL(sal_Int32(2), getProperty 
uno::Sequencetext::TableColumnSeparator (xTableRows-getByIndex(0), 
TableColumnSeparators).getLength());
 }
 
+DECLARE_RTFIMPORT_TEST(testDptxbxRelation, dptxbx-relation.rtf)
+{
+// This was FRAME, not PAGE_FRAME, even if dobxpage is in the document.
+CPPUNIT_ASSERT_EQUAL(text::RelOrientation::PAGE_FRAME, 
getPropertysal_Int16(getShape(1), HoriOrientRelation));
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index 1f9306e..f5935f6 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -2237,6 +2237,17 @@ int RTFDocumentImpl::dispatchSymbol(RTFKeyword nKeyword)
 return 0;
 }
 
+// Checks if rName is contained at least once in rProperties as a key.
+bool lcl_findPropertyName(const std::vectorbeans::PropertyValue 
rProperties, const OUString rName)
+{
+for (std::vectorbeans::PropertyValue::const_iterator it = 
rProperties.begin(); it != rProperties.end(); ++it)
+{
+if (it-Name == rName)
+return true;
+}
+return false;
+}
+
 int RTFDocumentImpl::dispatchFlag(RTFKeyword nKeyword)
 {
 setNeedSect();
@@ -2848,7 +2859,10 @@ int RTFDocumentImpl::dispatchFlag(RTFKeyword nKeyword)
 
m_aStates.top().aDrawingObject.xShape.set(getModelFactory()-createInstance(com.sun.star.text.TextFrame),
 uno::UNO_QUERY);
 std::vectorbeans::PropertyValue aDefaults = 
m_pSdrImport-getTextFrameDefaults(false);
 for (size_t i = 0; i  aDefaults.size(); ++i)
-
m_aStates.top().aDrawingObject.aPendingProperties.push_back(aDefaults[i]);
+{
+if 
(!lcl_findPropertyName(m_aStates.top().aDrawingObject.aPendingProperties, 
aDefaults[i].Name))
+
m_aStates.top().aDrawingObject.aPendingProperties.push_back(aDefaults[i]);
+}
 checkFirstRun();
 
Mapper().startShape(m_aStates.top().aDrawingObject.xShape);
 m_aStates.top().aDrawingObject.bHadShapeText = 
true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: spadmin, fax machines, etc. is this still useful ?

On Fri, 2014-03-14 at 12:31 +0100, Alex Thurgood wrote:
 The fact that spadmin could be used to add Type1 PS fonts, which are no
 longer supported, if I understand correctly, has also been, and
 continues to be, an issue that crops up on the user list (and possibly
 also in BZ) for some people.

Have you a link to an example because type 1 fonts just work, there
was no removal of support for those. The add fonts ability of spadmin
was removed in 2012 and prior to that was only visible if your system
didn't support fontconfig which is a practically impossible situation
for many years now so I'd like to understand that comment a little more.

 This could previously be set up in a PPD and included via spadmin,
 including on Mac OSX. 

I'm a little baffled, spadmin on MacOSX ?, what version included spadmin
on MacOSX ? We certainly don't do it now.

If there are cases where fiddling with the ppd manually and adding that
via spadmin worked, would not the same solution work by using the system
tools to set the replacement ppd for the printer ? e.g. using
system-config-printer under Fedora and provide PPD file

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/source

 vcl/source/window/layout.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 51605bf98220d7e54dee20af17c33cebe23a0813
Author: Stephan Bergmann sberg...@redhat.com
Date:   Fri Mar 14 13:45:00 2014 +0100

fprintf - SAL_INFO

Change-Id: I8983404bc0d10051dcf5ad71842560a0f7eaf3ba

diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx
index bbac6a4..d8ab4c6 100644
--- a/vcl/source/window/layout.cxx
+++ b/vcl/source/window/layout.cxx
@@ -2208,7 +2208,7 @@ bool MessageDialog::set_property(const OString rKey, 
const OString rValue)
 }
 else if (rKey == buttons)
 {
-fprintf(stderr, vcl.layout buttons type mode %s,  rValue.getStr());
+SAL_INFO(vcl.layout, buttons type mode   rValue);
 VclButtonsType eMode = VCL_BUTTONS_NONE;
 if (rValue.equals(none))
 eMode = VCL_BUTTONS_NONE;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

 sc/qa/unit/ucalc.cxx |   10 +-
 1 file changed, 1 insertion(+), 9 deletions(-)

New commits:
commit 5bbaf3739a3d95ea3fe95e9cd25aead0c8f75709
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Fri Mar 14 09:16:18 2014 -0400

Clean up a little.

Change-Id: I0014cc8af22e4f2284d8e72b6b79fa300ad89028

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 68713df..cfc94e0 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -3763,10 +3763,6 @@ void Test::testMoveBlock()
 pNoteC1-SetText(aAddrC1, aHelloC1);
 ScAddress aAddrD1 (3, 0, 0);
 
-std::cout  B1 note before moveblock:   
m_pDoc-GetNote(aAddrB1)-GetText()  std::endl;
-std::cout  B1 note before moveblock pNoteB1:   pNoteB1-GetText()  
std::endl;
-std::cout  B1 note before moveblock should be:   aHelloB1  
std::endl;
-
 // previous tests on cell note content are ok. this one fails !!! :(
 //CPPUNIT_ASSERT_MESSAGE(Note content in B1 before move block, 
m_pDoc-GetNote(aAddrB1)-GetText() == aHelloB1);
 
@@ -3775,8 +3771,6 @@ void Test::testMoveBlock()
 ScDocFunc rDocFunc = getDocShell().GetDocFunc();
 bool bMoveDone = rDocFunc.MoveBlock(ScRange(0, 0 ,0 ,2 ,0 ,0), 
ScAddress(1, 0, 0), bCut, false, false, false);
 
-  //  std::cout  B1 note after moveblock:   
m_pDoc-GetNote(aAddrB1)-GetText()  std::endl;
-
 CPPUNIT_ASSERT_MESSAGE(Cells not moved, bMoveDone);
 
 //check cell content
@@ -3885,7 +3879,6 @@ void Test::testMergedCells()
 aMark.SetMarkArea(aRange);
 getDocShell().GetDocFunc().InsertCells(aRange, aMark, INS_INSROWS, true, 
true);
 m_pDoc-ExtendMerge(1, 1, nEndCol, nEndRow, 0, false);
-cout  nEndRow  nEndCol;
 CPPUNIT_ASSERT_MESSAGE(did not increase merge area, nEndCol == 3  
nEndRow == 4);
 m_pDoc-DeleteTab(0);
 }
@@ -4034,8 +4027,7 @@ void Test::testUpdateReference()
 m_pDoc-GetValue(2, 0, 2, aValue);
 OUString aFormula;
 m_pDoc-GetFormula(2,0,2, aFormula);
-std::cout  formel:   OUStringToOString(aFormula, 
RTL_TEXTENCODING_UTF8).getStr()  std::endl;
-std::cout  std::endl  aValue  std::endl;
+
 ASSERT_DOUBLES_EQUAL_MESSAGE(after inserting sheets formula does not 
return correct result, aValue, 3);
 m_pDoc-GetValue(2, 1, 2, aValue);
 ASSERT_DOUBLES_EQUAL_MESSAGE(after inserting sheets formula does not 
return correct result, aValue, 5);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: padmin/source padmin/uiconfig padmin/UIConfig_spa.mk

 padmin/UIConfig_spa.mk|1 
 padmin/source/helper.cxx  |   41 --
 padmin/source/helper.hxx  |   12 +---
 padmin/source/padialog.hrc|7 --
 padmin/source/padialog.src|   43 --
 padmin/uiconfig/ui/querydialog.ui |  109 ++
 6 files changed, 127 insertions(+), 86 deletions(-)

New commits:
commit 19007d5b1881e30ed5de671a0b84fe0592f8ccf4
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 13:22:46 2014 +

convert fax (etc) query dialog to .ui

Change-Id: I7de45a208d27ed1b680214808c64e090d9a199f4

diff --git a/padmin/UIConfig_spa.mk b/padmin/UIConfig_spa.mk
index 565f0cc..6ac5ba2 100644
--- a/padmin/UIConfig_spa.mk
+++ b/padmin/UIConfig_spa.mk
@@ -13,6 +13,7 @@ $(eval $(call gb_UIConfig_add_uifiles,spa,\
padmin/uiconfig/ui/printerdevicepage \
padmin/uiconfig/ui/printerpaperpage \
padmin/uiconfig/ui/printerpropertiesdialog \
+   padmin/uiconfig/ui/querydialog \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/padmin/source/helper.cxx b/padmin/source/helper.cxx
index 848da22..fdb974c 100644
--- a/padmin/source/helper.cxx
+++ b/padmin/source/helper.cxx
@@ -181,33 +181,18 @@ bool DelListBox::Notify( NotifyEvent rEvent )
  *  QueryString
  */
 
-QueryString::QueryString( Window* pParent, OUString rQuery, OUString rRet, 
const ::std::list OUString  rChoices ) :
-ModalDialog( pParent, PaResId( RID_STRINGQUERYDLG ) ),
-m_aOKButton( this, PaResId( RID_STRQRY_BTN_OK ) ),
-m_aCancelButton( this, PaResId( RID_STRQRY_BTN_CANCEL ) ),
-m_aFixedText( this, PaResId( RID_STRQRY_TXT_RENAME ) ),
-m_aEdit( this, PaResId( RID_STRQRY_EDT_NEWNAME ) ),
-m_aComboBox( this, PaResId( RID_STRQRY_BOX_NEWNAME ) ),
-m_rReturnValue( rRet )
+QueryString::QueryString(Window* pParent, OUString rQuery, OUString rRet)
+: ModalDialog(pParent, QueryDialog,
+spa/ui/querydialog.ui )
+, m_rReturnValue( rRet )
 {
-FreeResource();
-m_aOKButton.SetClickHdl( LINK( this, QueryString, ClickBtnHdl ) );
-m_aFixedText.SetText( rQuery );
-if( rChoices.begin() != rChoices.end() )
-{
-m_aComboBox.SetText( m_rReturnValue );
-m_aComboBox.InsertEntry( m_rReturnValue );
-for( ::std::listOUString::const_iterator it = rChoices.begin(); it 
!= rChoices.end(); ++it )
-m_aComboBox.InsertEntry( *it );
-m_aEdit.Show( false );
-m_bUseEdit = false;
-}
-else
-{
-m_aEdit.SetText( m_rReturnValue );
-m_aComboBox.Show( false );
-m_bUseEdit = true;
-}
+get(m_pOKButton, ok);
+get(m_pFixedText, label);
+get(m_pEdit, entry);
+
+m_pOKButton-SetClickHdl( LINK( this, QueryString, ClickBtnHdl ) );
+m_pFixedText-SetText( rQuery );
+m_pEdit-SetText( m_rReturnValue );
 SetText( Application::GetDisplayName() );
 }
 
@@ -217,9 +202,9 @@ QueryString::~QueryString()
 
 IMPL_LINK( QueryString, ClickBtnHdl, Button*, pButton )
 {
-if( pButton == m_aOKButton )
+if (pButton == m_pOKButton)
 {
-m_rReturnValue = m_bUseEdit ? m_aEdit.GetText() : 
m_aComboBox.GetText();
+m_rReturnValue = m_pEdit-GetText();
 EndDialog( 1 );
 }
 else
diff --git a/padmin/source/helper.hxx b/padmin/source/helper.hxx
index d229766..5a1279a 100644
--- a/padmin/source/helper.hxx
+++ b/padmin/source/helper.hxx
@@ -82,19 +82,15 @@ public:
 class QueryString : public ModalDialog
 {
 private:
-OKButton m_aOKButton;
-CancelButton m_aCancelButton;
-FixedTextm_aFixedText;
-Edit m_aEdit;
-ComboBox m_aComboBox;
-
+OKButton*m_pOKButton;
+FixedText*   m_pFixedText;
+Edit*m_pEdit;
 OUStringm_rReturnValue;
-bool m_bUseEdit;
 
 DECL_LINK( ClickBtnHdl, Button* );
 
 public:
-QueryString( Window*, OUString , OUString , const ::std::list OUString 
 rChoices = ::std::listOUString() );
+QueryString(Window*, OUString , OUString );
 // parent window, Query text, initial value
 ~QueryString();
 };
diff --git a/padmin/source/padialog.hrc b/padmin/source/padialog.hrc
index 206c6d8..f438d05 100644
--- a/padmin/source/padialog.hrc
+++ b/padmin/source/padialog.hrc
@@ -46,13 +46,6 @@
 #define RID_PA_FL_CUPSUSAGE 23
 #define RID_PA_CB_CUPSUSAGE 23
 
-#define RID_STRINGQUERYDLG 1003
-#define RID_STRQRY_TXT_RENAME 1
-#define RID_STRQRY_EDT_NEWNAME2
-#define RID_STRQRY_BTN_OK 3
-#define RID_STRQRY_BTN_CANCEL 4
-#define RID_STRQRY_BOX_NEWNAME 5
-
 #define RID_PPDIMPORT_DLG  1004
 #define RID_PPDIMP_BTN_OK 1
 #define RID_PPDIMP_BTN_CANCEL 2
diff --git a/padmin/source/padialog.src b/padmin/source/padialog.src
index a175e3b..3bfffa7 100644
--- a/padmin/source/padialog.src
+++ b/padmin/source/padialog.src
@@ -168,49 +168,6 @@ ModalDialog

[Libreoffice-commits] core.git: accessibility/source comphelper/source include/comphelper

 accessibility/source/extended/accessibleeditbrowseboxcell.cxx |6 ++---
 comphelper/source/misc/accessiblewrapper.cxx  |   12 +-
 include/comphelper/accessiblewrapper.hxx  |6 ++---
 3 files changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 36784563edd5f1107fca072c14eddc69fdf5957f
Author: Stephan Bergmann sberg...@redhat.com
Date:   Fri Mar 14 14:27:24 2014 +0100

OAccessibleContextWrapperHelper does not implement XAccessibleContext

...but rather some (non-virtual) base functionality for use in derived 
classes
(that do implement XAccessibleContext)

Change-Id: Idb0023906108db22bb9696245f07b9a4c053a0d1

diff --git a/accessibility/source/extended/accessibleeditbrowseboxcell.cxx 
b/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
index a595792..d5c3878 100644
--- a/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
+++ b/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
@@ -110,7 +110,7 @@ namespace accessibility
 Reference XAccessibleRelationSet  SAL_CALL 
EditBrowseBoxTableCell::getAccessibleRelationSet() throw ( RuntimeException, 
std::exception )
 {
 SolarMethodGuard aGuard( *this );
-return OAccessibleContextWrapperHelper::getAccessibleRelationSet( );
+return baseGetAccessibleRelationSet( );
 }
 
 ReferenceXAccessibleStateSet  SAL_CALL 
EditBrowseBoxTableCell::getAccessibleStateSet() throw ( RuntimeException, 
std::exception )
@@ -123,13 +123,13 @@ namespace accessibility
 sal_Int32 SAL_CALL EditBrowseBoxTableCell::getAccessibleChildCount(  ) 
throw (RuntimeException, std::exception)
 {
 SolarMethodGuard aGuard( *this );
-return OAccessibleContextWrapperHelper::getAccessibleChildCount();
+return baseGetAccessibleChildCount();
 }
 
 Reference XAccessible  SAL_CALL 
EditBrowseBoxTableCell::getAccessibleChild( sal_Int32 i ) throw 
(::com::sun::star::lang::IndexOutOfBoundsException, RuntimeException, 
std::exception)
 {
 SolarMethodGuard aGuard( *this );
-return OAccessibleContextWrapperHelper::getAccessibleChild( i );
+return baseGetAccessibleChild( i );
 }
 
 sal_Int16 SAL_CALL EditBrowseBoxTableCell::getAccessibleRole() throw ( 
RuntimeException, std::exception )
diff --git a/comphelper/source/misc/accessiblewrapper.cxx 
b/comphelper/source/misc/accessiblewrapper.cxx
index 70164fb..85a6c60 100644
--- a/comphelper/source/misc/accessiblewrapper.cxx
+++ b/comphelper/source/misc/accessiblewrapper.cxx
@@ -433,13 +433,13 @@ namespace comphelper
 IMPLEMENT_FORWARD_XTYPEPROVIDER2( OAccessibleContextWrapperHelper, 
OComponentProxyAggregationHelper, OAccessibleContextWrapperHelper_Base )
 
 
-sal_Int32 SAL_CALL 
OAccessibleContextWrapperHelper::getAccessibleChildCount(  ) throw 
(RuntimeException, std::exception)
+sal_Int32 OAccessibleContextWrapperHelper::baseGetAccessibleChildCount(  ) 
throw (RuntimeException, std::exception)
 {
 return m_xInnerContext-getAccessibleChildCount();
 }
 
 
-Reference XAccessible  SAL_CALL 
OAccessibleContextWrapperHelper::getAccessibleChild( sal_Int32 i ) throw 
(IndexOutOfBoundsException, RuntimeException, std::exception)
+Reference XAccessible  
OAccessibleContextWrapperHelper::baseGetAccessibleChild( sal_Int32 i ) throw 
(IndexOutOfBoundsException, RuntimeException, std::exception)
 {
 // get the child of the wrapped component
 Reference XAccessible  xInnerChild = 
m_xInnerContext-getAccessibleChild( i );
@@ -447,7 +447,7 @@ namespace comphelper
 }
 
 
-Reference XAccessibleRelationSet  SAL_CALL 
OAccessibleContextWrapperHelper::getAccessibleRelationSet(  ) throw 
(RuntimeException, std::exception)
+Reference XAccessibleRelationSet  
OAccessibleContextWrapperHelper::baseGetAccessibleRelationSet(  ) throw 
(RuntimeException, std::exception)
 {
 return m_xInnerContext-getAccessibleRelationSet();
 // TODO: if this relation set would contain relations to siblings, 
we would normally need
@@ -545,13 +545,13 @@ namespace comphelper
 
 sal_Int32 SAL_CALL OAccessibleContextWrapper::getAccessibleChildCount(  ) 
throw (RuntimeException, std::exception)
 {
-return OAccessibleContextWrapperHelper::getAccessibleChildCount();
+return baseGetAccessibleChildCount();
 }
 
 
 Reference XAccessible  SAL_CALL 
OAccessibleContextWrapper::getAccessibleChild( sal_Int32 i ) throw 
(IndexOutOfBoundsException, RuntimeException, std::exception)
 {
-return OAccessibleContextWrapperHelper::getAccessibleChild( i );
+return baseGetAccessibleChild( i );
 }
 
 
@@ -587,7 +587,7 @@ namespace comphelper
 
 Reference XAccessibleRelationSet  SAL_CALL 
OAccessibleContextWrapper::getAccessibleRelationSet(  ) throw 
(RuntimeException, std::exception)
 {
-return

Re: spadmin, fax machines, etc. is this still useful ?

Le 14/03/2014 13:40, Caolán McNamara a écrit :

Have you a link to an example because type 1 fonts just work, there
was no removal of support for those. The add fonts ability of spadmin
was removed in 2012 and prior to that was only visible if your system
didn't support fontconfig which is a practically impossible situation
for many years now so I'd like to understand that comment a little more.

Not off-hand, I'd have to trawl through the LO user mailing list - the
problems might have been linked to a particular OS or particular Type1
fonts, I don't remember exactly now.

This could previously be set up in a PPD and included via spadmin,
including on Mac OSX.

I'm a little baffled, spadmin on MacOSX ?, what version included spadmin
on MacOSX ? We certainly don't do it now.

Yes, I wasn't talking about LO, but during OOo times, before the switch
to CUPS printing, this was possible.

If there are cases where fiddling with the ppd manually and adding that
via spadmin worked, would not the same solution work by using the system
tools to set the replacement ppd for the printer ? e.g. using
system-config-printer under Fedora and provide PPD file

Unfortunately, I have no idea. My comments were made not to discourage
you from going ahead with your plan, just to relate what I had seen on
the LO mailing list and my own previous experience of before/after the
switch to CUPS printing, both on Linux and OSX.

Questions / bugs about PS Type1 support :

http://ask.libreoffice.org/en/question/2631/adobe-postscript-type-1-font-not-displaying-in-libreoffice-3532-mac/

https://bugs.freedesktop.org/show_bug.cgi?id=37453

http://listarchives.libreoffice.org/global/users/msg05099.html

https://forum.openoffice.org/nl/forum/viewtopic.php?f=5t=1197

http://forums.bodhilinux.com/index.php?/topic/6045-type-1-fonts-not-seen-by-libreoffice-36-bodhi-201/page__view__findpost__p__56029

The last one, in particular (seocnd to last comment), provides a
workaround for creating AFM/PFM files on Linux, but note that this
didn't used to be a requirement, before the switch to CUPS printing was
made - previously, Type1 fonts were recognized in OOo automagically.

Alex

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/inc sw/source

 sw/inc/swtable.hxx |3 +++
 sw/source/core/inc/cellfrm.hxx |1 +
 sw/source/core/inc/rowfrm.hxx  |1 +
 sw/source/core/inc/tabfrm.hxx  |1 +
 4 files changed, 6 insertions(+)

New commits:
commit 90dd0d37a5188ae05c8574a1eda7c7bb5d4e8b8f
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Fri Mar 14 14:26:12 2014 +0100

sw: deploy a couple of doxygen comments

Change-Id: Ibdacb2a5fa3abf28a2907924b4e438699f8b53ae

diff --git a/sw/inc/swtable.hxx b/sw/inc/swtable.hxx
index cd3d00a..47c5991 100644
--- a/sw/inc/swtable.hxx
+++ b/sw/inc/swtable.hxx
@@ -91,6 +91,7 @@ public:
 // (for calculation in table).
 class SwTableSortBoxes : public o3tl::sorted_vectorSwTableBox* {};
 
+/// SwTable is one table in the document model, containing rows (which contain 
cells).
 class SW_DLLPUBLIC SwTable: public SwClient  //Client of FrmFmt.
 {
 
@@ -336,6 +337,7 @@ public:
 bool HasLayout() const;
 };
 
+/// SwTableLine is one table row in the document model.
 class SW_DLLPUBLIC SwTableLine: public SwClient // Client of FrmFmt.
 {
 SwTableBoxes aBoxes;
@@ -375,6 +377,7 @@ public:
 void RegisterToFormat( SwFmt rFmt );
 };
 
+/// SwTableBox is one table cell in the document model.
 class SW_DLLPUBLIC SwTableBox: public SwClient  //Client of FrmFmt.
 {
 friend class SwNodes;   // Transpose index.
diff --git a/sw/source/core/inc/cellfrm.hxx b/sw/source/core/inc/cellfrm.hxx
index fa2bc1a..b362fc7 100644
--- a/sw/source/core/inc/cellfrm.hxx
+++ b/sw/source/core/inc/cellfrm.hxx
@@ -27,6 +27,7 @@ class SwTableBox;
 struct SwCrsrMoveState;
 class SwBorderAttrs;
 
+/// SwCellFrm is one table cell in the document layout.
 class SwCellFrm: public SwLayoutFrm
 {
 const SwTableBox* pTabBox;
diff --git a/sw/source/core/inc/rowfrm.hxx b/sw/source/core/inc/rowfrm.hxx
index 62beae4..083fda7 100644
--- a/sw/source/core/inc/rowfrm.hxx
+++ b/sw/source/core/inc/rowfrm.hxx
@@ -26,6 +26,7 @@
 class SwTableLine;
 class SwBorderAttrs;
 
+/// SwRowFrm is one table row in the document layout.
 class SwRowFrm: public SwLayoutFrm
 {
 virtual void Format( const SwBorderAttrs *pAttrs = 0 );
diff --git a/sw/source/core/inc/tabfrm.hxx b/sw/source/core/inc/tabfrm.hxx
index 7d8c15a..44ff0f3 100644
--- a/sw/source/core/inc/tabfrm.hxx
+++ b/sw/source/core/inc/tabfrm.hxx
@@ -27,6 +27,7 @@ class SwTable;
 class SwBorderAttrs;
 class SwAttrSetChg;
 
+/// SwTabFrm is one table in the document layout, containing rows (which 
contain cells).
 class SwTabFrm: public SwLayoutFrm, public SwFlowFrm
 {
 friend void CalcCntnt( SwLayoutFrm *pLay, bool bNoColl, bool bNoCalcFollow 
);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: spadmin, fax machines, etc. is this still useful ?

2014-03-14 Thread Khaled Hosny

On Fri, Mar 14, 2014 at 02:37:06PM +0100, Alex Thurgood wrote:
 The last one, in particular (seocnd to last comment), provides a
 workaround for creating AFM/PFM files on Linux, but note that this
 didn't used to be a requirement, before the switch to CUPS printing was
 made - previously, Type1 fonts were recognized in OOo automagically.

The code that requires AFM files for Type1 fonts have been there since
2001 with the introduction of PostSctipt printing in OpenOffice, so I
fail to see how it would have worked differently in the bast.

(I don’t really think we need the info contained in the AFM files,
though, but someone has to trace the code to verify this.)

Regards
Khaled
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: spadmin, fax machines, etc. is this still useful ?

Le 14/03/2014 11:45, Caolán McNamara a écrit :

We might want to get rid of this page too at the same time :

https://help.libreoffice.org/Common/Setting_up_Printer_and_Fax_Under_UNIX_Based_Platforms


Alex

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: writerfilter/source

 writerfilter/source/resourcemodel/resourcemodel.cxx |   88 
 1 file changed, 88 deletions(-)

New commits:
commit d5f0d2667412f79c2c5e5fe9f73891a865d14247
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Fri Mar 14 14:48:03 2014 +0100

writerfilter: unused WW8TableDataHandler

I guess this didn't show up in the unused method lists as all of its
methods are virtual.

Change-Id: I445e28cc47a85e499d12c0873fc19c217e3e9b88

diff --git a/writerfilter/source/resourcemodel/resourcemodel.cxx 
b/writerfilter/source/resourcemodel/resourcemodel.cxx
index 24b6aa1..c6779db 100644
--- a/writerfilter/source/resourcemodel/resourcemodel.cxx
+++ b/writerfilter/source/resourcemodel/resourcemodel.cxx
@@ -41,94 +41,6 @@ public:
 
 ResourceModelOutputWithDepth output;
 
-// --- WW8TableDataHandler -
-
-class TablePropsRef : public writerfilter::ReferenceProperties
-{
-public:
-typedef boost::shared_ptrTablePropsRef Pointer_t;
-
-TablePropsRef() {}
-virtual ~TablePropsRef() {}
-
-virtual void resolve(Properties  /*rHandler*/) {}
-
-virtual string getType() const { return TableProps; }
-void reset() {}
-void InsertProps(Pointer_t /* pTablePropsRef */) {}
-};
-
-typedef TablePropsRef::Pointer_t TablePropsRef_t;
-
-class WW8TableDataHandler : public TableDataHandlerstring,
-TablePropsRef_t
-{
-public:
-virtual ~WW8TableDataHandler() {}
-
-typedef boost::shared_ptrWW8TableDataHandler Pointer_t;
-virtual void startTable(unsigned int nRows, unsigned int nDepth,
-TablePropsRef_t pProps);
-virtual void endTable(unsigned int nestedTableLevel);
-virtual void startRow(unsigned int nCols,
-  TablePropsRef_t pProps);
-virtual void endRow();
-virtual void startCell(const string  start, TablePropsRef_t pProps);
-virtual void endCell(const string  end);
-};
-
-void WW8TableDataHandler::startTable(unsigned int nRows, unsigned int nDepth,
- TablePropsRef_t /*pProps*/)
-{
-char sBuffer[256];
-
-string tmpStr = tabledata.table rows=\;
-snprintf(sBuffer, sizeof(sBuffer), %u, nRows);
-tmpStr += sBuffer;
-tmpStr += \ depth=\;
-snprintf(sBuffer, sizeof(sBuffer), %u, nDepth);
-tmpStr += sBuffer;
-tmpStr += \;
-
-output.addItem(tmpStr);
-}
-
-void WW8TableDataHandler::endTable(unsigned int /*nestedTableLevel*/)
-{
-output.addItem(/tabledata.table);
-}
-
-void WW8TableDataHandler::startRow
-(unsigned int nCols, TablePropsRef_t /*pProps*/)
-{
-char sBuffer[256];
-
-snprintf(sBuffer, sizeof(sBuffer), %u, nCols);
-string tmpStr = tabledata.row cells=\;
-tmpStr += sBuffer;
-tmpStr += \;
-output.addItem(tmpStr);
-}
-
-void WW8TableDataHandler::endRow()
-{
-output.addItem(/tabledata.row);
-}
-
-void WW8TableDataHandler::startCell(const string  start,
-TablePropsRef_t /*pProps*/)
-{
-output.addItem(tabledata.cell);
-output.addItem(start);
-output.addItem(, );
-}
-
-void WW8TableDataHandler::endCell(const string  end)
-{
-output.addItem(end);
-output.addItem(/tabledata.cell);
-}
-
 // - WW8TableDataManager ---
 
 void WW8BinaryObjHandler::data
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: spadmin, fax machines, etc. is this still useful ?

On Fri, 2014-03-14 at 14:37 +0100, Alex Thurgood wrote:
 Questions / bugs about PS Type1 support :
 http://ask.libreoffice.org/en/question/2631/adobe-postscript-type-1-font-not-displaying-in-libreoffice-3532-mac/
 https://bugs.freedesktop.org/show_bug.cgi?id=37453
 http://listarchives.libreoffice.org/global/users/msg05099.html
 https://forum.openoffice.org/nl/forum/viewtopic.php?f=5t=1197
That block of reports seems to be about Type 1 fonts not being
recognized under MacOSX.

 http://forums.bodhilinux.com/index.php?/topic/6045-type-1-fonts-not-seen-by-libreoffice-36-bodhi-201/page__view__findpost__p__56029
This one is about Type 1 fonts under Linux not recognized without afms present
and it seems a little uncertain if that's the MacOSX issue as well

The old add-fonts stuff in spadmin wouldn't have had any effect on
either of those two issues.

 but note that this didn't used to be a requirement, before the switch
 to CUPS printing was made - previously, Type1 fonts were recognized in
 OOo automagically.

I don't see a connection between Type1 fonts not being recognized on
MacOSX and CUPS printing. Either way spadmin wouldn't help.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: spadmin, fax machines, etc. is this still useful ?

Le 14/03/2014 14:37, Alex Thurgood a écrit :

Let me add to the list :

https://www.libreoffice.org/bugzilla/show_bug.cgi?id=70184

Alex



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: spadmin, fax machines, etc. is this still useful ?

Le 14/03/2014 14:37, Alex Thurgood a écrit :

Call me a killjoy, but this one looks related too :

https://www.libreoffice.org/bugzilla/show_bug.cgi?id=38825

The user here, printing on older business printers, had to configure a
specific font directory containing only PS Type 1 fonts in order for the
conversion to PDF would work in a way allowing him to print his documents.


Alex


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: oox/source

2014-03-14 Thread Muthu Subramanian

 oox/source/drawingml/textcharacterpropertiescontext.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 19abfaffe74b925e4428943d14187a7008797982
Author: Muthu Subramanian sumu...@collabora.com
Date:   Fri Mar 14 15:31:53 2014 +0530

n#862510: Ignore baseline attributes with zero.

Change-Id: I1adc46e62c82c23645ccad0e11d5a7cb07114539

diff --git a/oox/source/drawingml/textcharacterpropertiescontext.cxx 
b/oox/source/drawingml/textcharacterpropertiescontext.cxx
index b432c80..5bb800c 100644
--- a/oox/source/drawingml/textcharacterpropertiescontext.cxx
+++ b/oox/source/drawingml/textcharacterpropertiescontext.cxx
@@ -53,7 +53,7 @@ 
TextCharacterPropertiesContext::TextCharacterPropertiesContext(
 mrTextCharacterProperties.moUnderline = rAttribs.getToken( XML_u );
 if ( rAttribs.hasAttribute( XML_strike ) )
 mrTextCharacterProperties.moStrikeout = rAttribs.getToken( XML_strike 
);
-if ( rAttribs.hasAttribute( XML_baseline ) )
+if ( rAttribs.hasAttribute( XML_baseline )  rAttribs.getInteger( 
XML_baseline ).get() != 0 )
 mrTextCharacterProperties.moBaseline = rAttribs.getInteger( 
XML_baseline );
 
 if ( rAttribs.hasAttribute( XML_b ) )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/suse/suse-4.0' - oox/source

2014-03-14 Thread Muthu Subramanian

 oox/source/drawingml/textcharacterpropertiescontext.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit df861737beaa883ccd2b11bfa896cd546dd51b6f
Author: Muthu Subramanian sumu...@collabora.com
Date:   Fri Mar 14 20:03:45 2014 +0530

n#862510: Ignore baseline attributes with zero.

Ported from 19abfaffe74b925e4428943d14187a7008797982

Change-Id: I5447c16193f7c3e619ce10658c9696014d3d5a22

diff --git a/oox/source/drawingml/textcharacterpropertiescontext.cxx 
b/oox/source/drawingml/textcharacterpropertiescontext.cxx
index 2119dc6..13af2cd 100644
--- a/oox/source/drawingml/textcharacterpropertiescontext.cxx
+++ b/oox/source/drawingml/textcharacterpropertiescontext.cxx
@@ -56,7 +56,7 @@ 
TextCharacterPropertiesContext::TextCharacterPropertiesContext(
 mrTextCharacterProperties.moUnderline = aAttribs.getToken( XML_u );
 if ( aAttribs.hasAttribute( XML_strike ) )
 mrTextCharacterProperties.moStrikeout = aAttribs.getToken( XML_strike 
);
-if ( aAttribs.hasAttribute( XML_baseline ) )
+if ( aAttribs.hasAttribute( XML_baseline )  aAttribs.getInteger( 
XML_baseline ).get() != 0 )
 mrTextCharacterProperties.moBaseline = aAttribs.getInteger( 
XML_baseline );
 
 //  mrTextCharacterProperties.moCaseMap = aAttribs.getToken( XML_cap );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.1' - oox/source

2014-03-14 Thread Muthu Subramanian

 oox/source/drawingml/textcharacterpropertiescontext.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 88faa076da606e8611aea4c4b2d10fee694943a5
Author: Muthu Subramanian sumu...@collabora.com
Date:   Fri Mar 14 20:03:45 2014 +0530

n#862510: Ignore baseline attributes with zero.

Ported from 19abfaffe74b925e4428943d14187a7008797982

Change-Id: I5447c16193f7c3e619ce10658c9696014d3d5a22

diff --git a/oox/source/drawingml/textcharacterpropertiescontext.cxx 
b/oox/source/drawingml/textcharacterpropertiescontext.cxx
index 19b54c6..6835149 100644
--- a/oox/source/drawingml/textcharacterpropertiescontext.cxx
+++ b/oox/source/drawingml/textcharacterpropertiescontext.cxx
@@ -55,7 +55,7 @@ 
TextCharacterPropertiesContext::TextCharacterPropertiesContext(
 mrTextCharacterProperties.moUnderline = aAttribs.getToken( XML_u );
 if ( aAttribs.hasAttribute( XML_strike ) )
 mrTextCharacterProperties.moStrikeout = aAttribs.getToken( XML_strike 
);
-if ( aAttribs.hasAttribute( XML_baseline ) )
+if ( aAttribs.hasAttribute( XML_baseline )  aAttribs.getInteger( 
XML_baseline ).get() != 0 )
 mrTextCharacterProperties.moBaseline = aAttribs.getInteger( 
XML_baseline );
 if( aAttribs.hasAttribute( XML_cap ) )
 mrTextCharacterProperties.moCaseMap = aAttribs.getToken( XML_cap );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Manmeet Singh license statement

2014-03-14 Thread Manmeet Singh

   All of my past  future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: cui/AllLangResTarget_cui.mk cui/source cui/uiconfig cui/UIConfig_cui.mk

 cui/AllLangResTarget_cui.mk |1 
 cui/UIConfig_cui.mk |1 
 cui/source/inc/cuires.hrc   |1 
 cui/source/inc/helpid.hrc   |1 
 cui/source/options/certpath.cxx |   84 ++---
 cui/source/options/certpath.hrc |   52 
 cui/source/options/certpath.hxx |   15 --
 cui/source/options/certpath.src |   90 --
 cui/uiconfig/ui/certdialog.ui   |  246 
 9 files changed, 293 insertions(+), 198 deletions(-)

New commits:
commit a83517bd1b99c170e7d3b2fd59af3e85d983c756
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 13:35:50 2014 +

convert certificate path dialog to .ui format

Change-Id: Ifb711805a37f7cd49b6063c5d17aa7a3f5dcfdaa

diff --git a/cui/AllLangResTarget_cui.mk b/cui/AllLangResTarget_cui.mk
index 10c80b0..e9ef5e8 100644
--- a/cui/AllLangResTarget_cui.mk
+++ b/cui/AllLangResTarget_cui.mk
@@ -39,7 +39,6 @@ $(eval $(call gb_SrsTarget_add_files,cui/res,\
 cui/source/dialogs/passwdomdlg.src \
 cui/source/dialogs/scriptdlg.src \
 cui/source/dialogs/svuidlg.src \
-cui/source/options/certpath.src \
 cui/source/options/connpooloptions.src \
 cui/source/options/dbregister.src \
 cui/source/options/doclinkdialog.src \
diff --git a/cui/UIConfig_cui.mk b/cui/UIConfig_cui.mk
index bedb80c..c619d78 100644
--- a/cui/UIConfig_cui.mk
+++ b/cui/UIConfig_cui.mk
@@ -32,6 +32,7 @@ $(eval $(call gb_UIConfig_add_uifiles,cui,\
cui/uiconfig/ui/calloutdialog \
cui/uiconfig/ui/calloutpage \
cui/uiconfig/ui/cellalignment \
+   cui/uiconfig/ui/certdialog \
cui/uiconfig/ui/charnamepage \
cui/uiconfig/ui/colorpage \
cui/uiconfig/ui/comment \
diff --git a/cui/source/inc/cuires.hrc b/cui/source/inc/cuires.hrc
index 15a6372..b64d9a3 100644
--- a/cui/source/inc/cuires.hrc
+++ b/cui/source/inc/cuires.hrc
@@ -374,7 +374,6 @@
 #define RID_SVXSTR_ROW  (RID_SVX_START + 
1201)
 #define RID_SVXSTR_COL  (RID_SVX_START + 
1202)
 #define RID_SVXSTR_AUTO_ENTRY   (RID_SVX_START + 
1203)
-#define RID_SVXDLG_CERTPATH (RID_SVX_START + 
1204)
 
 #define RID_SVXSTR_USE_REPLACE  (RID_SVX_START + 
1205)
 #define RID_SVXSTR_CPTL_STT_WORD(RID_SVX_START + 
1206)
diff --git a/cui/source/inc/helpid.hrc b/cui/source/inc/helpid.hrc
index 547e7b7..88e7848 100644
--- a/cui/source/inc/helpid.hrc
+++ b/cui/source/inc/helpid.hrc
@@ -216,7 +216,6 @@
 #define HID_MACRO_HEADERTABLISTBOX CUI_HID_MACRO_HEADERTABLISTBOX
 
 #define HID_HYPERLINK_DIALOG
CUI_HID_HYPERLINK_DIALOG
-#define HID_DLG_CERTPATH   
CUI_HID_DLG_CERTPATH
 
 #endif
 
diff --git a/cui/source/options/certpath.cxx b/cui/source/options/certpath.cxx
index 8f2023d..2d55e4e 100644
--- a/cui/source/options/certpath.cxx
+++ b/cui/source/options/certpath.cxx
@@ -16,7 +16,6 @@
 #include unotools/securityoptions.hxx
 #include cuires.hrc
 #include certpath.hxx
-#include certpath.hrc
 #include dialmgr.hxx
 
 #include com/sun/star/mozilla/MozillaBootstrap.hpp
@@ -26,39 +25,37 @@
 
 using namespace ::com::sun::star;
 
-CertPathDialog::CertPathDialog( Window* pParent ) :
- ModalDialog( pParent, CUI_RES( RID_SVXDLG_CERTPATH ) )
-, m_aCertPathFL   ( this, CUI_RES( FL_CERTPATH ) )
-, m_aCertPathFT   ( this, CUI_RES( FT_CERTPATH ) )
-, m_aCertPathListContainer( this, CUI_RES( LB_CERTPATH ) )
-, m_aCertPathList( m_aCertPathListContainer, WB_BORDER )
-, m_aAddBtn   ( this, CUI_RES( PB_ADD ) )
-, m_aButtonsFL   ( this, CUI_RES( FL_BUTTONS ) )
-, m_aOKBtn   ( this, CUI_RES( PB_OK ) )
-, m_aCancelBtn   ( this, CUI_RES( PB_CANCEL ) )
-, m_aHelpBtn ( this, CUI_RES( PB_HELP ) )
-, m_sAddDialogText(CUI_RESSTR(STR_ADDDLGTEXT))
-, m_sManual(CUI_RESSTR(STR_MANUAL))
+CertPathDialog::CertPathDialog(Window* pParent)
+: ModalDialog(pParent, CertDialog, cui/ui/certdialog.ui)
 {
+get(m_pOKBtn, ok);
+get(m_pAddBtn, add);
+get(m_pCertPathListContainer, paths);
+Size aSize(LogicToPixel(Size(210, 60), MAP_APPFONT));
+m_pCertPathListContainer-set_width_request(aSize.Width());
+m_pCertPathListContainer-set_height_request(aSize.Height());
+m_pCertPathList =
+new svx::SvxRadioButtonListBox(*m_pCertPathListContainer, 0);
+m_sAddDialogText = getFixedText(certdir)-GetText();
+m_sManual = getFixedText(manual)-GetText();
+
 static long aStaticTabs[]=
 {
 3, 0, 15, 75
 };
 
-m_aCertPathList.SvSimpleTable::SetTabs( aStaticTabs );
+m_pCertPathList-SvSimpleTable::SetTabs( aStaticTabs );
 
-OUString sProfile(CUI_RESSTR(STR_PROFILE));
-OUString sDirectory(CUI_RESSTR(STR_DIRECTORY));
+OUString

[Libreoffice-commits] core.git: sw/qa writerfilter/source

 sw/qa/extras/rtfimport/data/dprect-anchor.rtf  |4 
 sw/qa/extras/rtfimport/rtfimport.cxx   |6 ++
 writerfilter/source/rtftok/rtfdocumentimpl.cxx |4 
 3 files changed, 14 insertions(+)

New commits:
commit d05b67a7b9448c67c3a923ecb33dac74b52dd192
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Fri Mar 14 15:51:25 2014 +0100

RTF import: anchor drawing objects at-character by default

Change-Id: I292ab1a6f12a9372b1cfdd4e8e59fbae57c6ceca

diff --git a/sw/qa/extras/rtfimport/data/dprect-anchor.rtf 
b/sw/qa/extras/rtfimport/data/dprect-anchor.rtf
new file mode 100644
index 000..ac5675e
--- /dev/null
+++ b/sw/qa/extras/rtfimport/data/dprect-anchor.rtf
@@ -0,0 +1,4 @@
+{\rtf1
+{\colortbl\red255\green255\blue255; \red0\green0\blue0; }
+{\*\do\dobxpage\dobypara\dodhgt8192\dprect\dproundr\dpx9807\dpy3968\dpxsize1644\dpysize566\dplinecor255\dplinecog255\dplinecob255\dpfillbgcr0\dpfillbgcg0\dpfillbgcb0\dpfillpat1\dplinehollow0}
+}
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx 
b/sw/qa/extras/rtfimport/rtfimport.cxx
index 01814b9..f11f5ea 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -1534,6 +1534,12 @@ DECLARE_RTFIMPORT_TEST(testDptxbxRelation, 
dptxbx-relation.rtf)
 CPPUNIT_ASSERT_EQUAL(text::RelOrientation::PAGE_FRAME, 
getPropertysal_Int16(getShape(1), HoriOrientRelation));
 }
 
+DECLARE_RTFIMPORT_TEST(testDprectAnchor, dprect-anchor.rtf)
+{
+// This was at-page, which is not something Word supports, so clearly an 
import error.
+CPPUNIT_ASSERT_EQUAL(text::TextContentAnchorType_AT_CHARACTER, 
getPropertytext::TextContentAnchorType(getShape(1), AnchorType));
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index f5935f6..4eef7ea 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -19,6 +19,7 @@
 #include com/sun/star/text/VertOrientation.hpp
 #include com/sun/star/text/RelOrientation.hpp
 #include com/sun/star/text/WrapTextMode.hpp
+#include com/sun/star/text/TextContentAnchorType.hpp
 #include rtl/tencinfo.h
 #include svl/lngmisc.hxx
 #include unotools/ucbstreamhelper.hxx
@@ -4611,6 +4612,9 @@ int RTFDocumentImpl::popState()
 uno::Referencelang::XServiceInfo xServiceInfo(xShape, 
uno::UNO_QUERY);
 bool bTextFrame = 
xServiceInfo-supportsService(com.sun.star.text.TextFrame);
 
+// The default is certainly not inline, but then what Word 
supports is just at-character.
+xPropertySet-setPropertyValue(AnchorType, 
uno::makeAny(text::TextContentAnchorType_AT_CHARACTER));
+
 if (bTextFrame)
 {
 xPropertySet-setPropertyValue(HoriOrientPosition, 
uno::makeAny((sal_Int32)rDrawing.nLeft));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: spadmin, fax machines, etc. is this still useful ?

On Fri, 2014-03-14 at 15:13 +0100, Alex Thurgood wrote:
 Le 14/03/2014 14:37, Alex Thurgood a écrit :
 
 Call me a killjoy, but this one looks related too :
 
 https://www.libreoffice.org/bugzilla/show_bug.cgi?id=38825
 
 The user here, printing on older business printers, had to configure a
 specific font directory containing only PS Type 1 fonts in order for the
 conversion to PDF would work in a way allowing him to print his documents.

Again these don't have any connection to spadmin. Even when spadmin had
the ability to add stuff into your font dirs it wouldn't have been able
to be used to configure the dirs in the hacky way the reporter there
used to workaround whatever the problem he had back then.

C,

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/source

 sw/source/filter/ww8/ww8atr.cxx |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

New commits:
commit 7d53f81f0a88afcff0f60bbd066a5645ac2e6a8b
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 15:30:31 2014 +

Related: rhbz#1075951 abrt crash in MSWordExportBase::OutputFormat

Change-Id: I681fa40196eb04f4824e49458cba0acc15b26193

diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 7eb3134..da25acc 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -745,10 +745,13 @@ void MSWordExportBase::OutputFormat( const SwFmt rFmt, 
bool bPapFmt, bool bChpF
 case RES_TXTFMTCOLL:
 if( bPapFmt )
 {
+int nLvl = MAXLEVEL;
+
 if (((const 
SwTxtFmtColl)rFmt).IsAssignedToListLevelOfOutlineStyle())
-{
-int nLvl = ((const 
SwTxtFmtColl)rFmt).GetAssignedOutlineStyleLevel();
+nLvl = ((const 
SwTxtFmtColl)rFmt).GetAssignedOutlineStyleLevel();
 
+if (nLvl = 0  nLvl  MAXLEVEL)
+{
 //if outline numbered
 // if Write StyleDefinition then write the OutlineRule
 const SwNumFmt rNFmt = pDoc-GetOutlineNumRule()-Get( 
static_castsal_uInt16( nLvl ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 7 commits - stoc/source svl/source svl/unx

 stoc/source/corereflection/lrucache.hxx |2 ++
 stoc/source/security/lru_cache.h|1 +
 svl/source/items/itemset.cxx|   13 ++---
 svl/source/items/style.cxx  |2 ++
 svl/unx/source/svdde/ddedummy.cxx   |   12 
 5 files changed, 23 insertions(+), 7 deletions(-)

New commits:
commit 85543a2700bcb3100f07851b3173b3f218cadff0
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 15:57:40 2014 +

coverity#708238 Uninitialized pointer field

Change-Id: I83552efc825d54da9e00d4a9a637118565bd30ca

diff --git a/stoc/source/corereflection/lrucache.hxx 
b/stoc/source/corereflection/lrucache.hxx
index a4292a1..16ca8ae 100644
--- a/stoc/source/corereflection/lrucache.hxx
+++ b/stoc/source/corereflection/lrucache.hxx
@@ -97,6 +97,8 @@ inline LRU_Cache t_Key, t_Val, t_KeyHash, t_KeyEqual 
::LRU_Cache( sal_Int32 nC
 : _nCachedElements( nCachedElements )
 #endif
 , _pBlock( 0 )
+, _pHead( 0 )
+, _pTail( 0 )
 {
 if (_nCachedElements  0)
 {
commit a5cbf154df2e8d77f4971f5dafa76e9f8fcc9ca7
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 15:56:12 2014 +

coverity#708240 Uninitialized pointer field

Change-Id: I127cfc84412984e9c190f3e5b2e37cf76ebf82f1

diff --git a/stoc/source/security/lru_cache.h b/stoc/source/security/lru_cache.h
index 5033113..56f4710 100644
--- a/stoc/source/security/lru_cache.h
+++ b/stoc/source/security/lru_cache.h
@@ -127,6 +127,7 @@ inline lru_cache t_key, t_val, t_hashKey, t_equalKey 
::lru_cache(
 ::std::size_t size ) SAL_THROW(())
 : m_size( 0 )
 , m_block( 0 )
+, m_tail( 0 )
 {
 setSize( size );
 }
commit 3dd8bab3d07a35e2db33adbcdf25dcf80f46d3cd
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 15:54:59 2014 +

708253 Uninitialized pointer field

Change-Id: I9d00dd3020d7bc75b6047cf20da3926f10b3632a

diff --git a/svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx
index 7b1c14c..2ce1935 100644
--- a/svl/source/items/itemset.cxx
+++ b/svl/source/items/itemset.cxx
@@ -222,11 +222,12 @@ void SfxItemSet::InitRanges_Impl(const sal_uInt16 
*pWhichPairTable)
 
 
 
-SfxItemSet::SfxItemSet( SfxItemPool rPool, const sal_uInt16* pWhichPairTable 
):
-_pPool( rPool ),
-_pParent( 0 ),
-_pWhichRanges(0),
-_nCount( 0 )
+SfxItemSet::SfxItemSet( SfxItemPool rPool, const sal_uInt16* pWhichPairTable )
+: _pPool(rPool)
+, _pParent(0)
+, _aItems(0)
+, _pWhichRanges(0)
+, _nCount(0)
 {
 DBG_CTOR(SfxItemSet, 0);
 DBG_ASSERTWARNING( _pPool == _pPool-GetMasterPool(), kein Master-Pool );
@@ -237,8 +238,6 @@ SfxItemSet::SfxItemSet( SfxItemPool rPool, const 
sal_uInt16* pWhichPairTable ):
 InitRanges_Impl(pWhichPairTable);
 }
 
-
-
 SfxItemSet::SfxItemSet( const SfxItemSet rASet ):
 _pPool( rASet._pPool ),
 _pParent( rASet._pParent ),
commit 2de369e3717c2bf6d536649c9d8bd64726b6baf0
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 15:52:18 2014 +

coverity#708255 Uninitialized pointer field

Change-Id: Ic7fad54a0e39d007668e3fd3e2a857f9f9956d7d

diff --git a/svl/source/items/style.cxx b/svl/source/items/style.cxx
index b83e773..11a365f 100644
--- a/svl/source/items/style.cxx
+++ b/svl/source/items/style.cxx
@@ -399,6 +399,8 @@ struct DoesStyleMatchStyleSheetPredicate SAL_FINAL : public 
svl::StyleSheetPredi
 
 SfxStyleSheetIterator::SfxStyleSheetIterator(SfxStyleSheetBasePool *pBase,
  SfxStyleFamily eFam, sal_uInt16 n)
+: pAktStyle(NULL)
+, nAktPosition(0)
 {
 pBasePool=pBase;
 nSearchFamily=eFam;
commit 011e153bc4f3d086108e10a5b95ea6614d665d95
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 15:50:46 2014 +

coverity#708265 Uninitialized pointer field

Change-Id: I48afa08c5e1bb8a615901177e5baed20ea86d28e

diff --git a/svl/unx/source/svdde/ddedummy.cxx 
b/svl/unx/source/svdde/ddedummy.cxx
index 69f8a19..1fca271 100644
--- a/svl/unx/source/svdde/ddedummy.cxx
+++ b/svl/unx/source/svdde/ddedummy.cxx
@@ -106,6 +106,11 @@ DdeTransaction::DdeTransaction( DdeConnection 
rConnection, const OUString, lon
 
 DdeTransaction::DdeTransaction( const DdeTransaction rTransaction )
 : rDde( rTransaction.rDde )
+, pName(NULL)
+, nType(0)
+, nId(0)
+, nTime(0)
+, bBusy(false)
 {
 }
 
commit 1b26ba2307d24341cf73cf6fc4865b120eaf05b1
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 15:49:20 2014 +

coverity#708269 Uninitialized pointer field

Change-Id: If92b091d06e6de6f137d38a9fa28d4c8604b368c

diff --git a/svl/unx/source/svdde/ddedummy.cxx 
b/svl/unx/source/svdde/ddedummy.cxx
index 7a986d6..69f8a19 100644
--- a/svl/unx/source/svdde/ddedummy.cxx
+++ b/svl/unx/source/svdde/ddedummy.cxx
@@ -21,6 +21,7 @@
 #include rtl/instance.hxx
 
 DdeData::DdeData()
+: pImp(NULL)
 {
 }
 
@@ -30,10 +31,12 @@ DdeData::DdeData( const

[Libreoffice-commits] core.git: 2 commits - include/vcl sc/source vcl/unx

 include/vcl/ppdparser.hxx |3 ++-
 sc/source/filter/html/htmlpars.cxx|   12 
 vcl/unx/generic/printer/ppdparser.cxx |7 +++
 3 files changed, 9 insertions(+), 13 deletions(-)

New commits:
commit 79fa84ccb9b45b149843ac88e4d662f2a09e94bf
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 15:46:05 2014 +

coverity#705828 Dereference before null check

Change-Id: Ie76ee86f6ae48012c92a3f06ad1372f126f1ea29

diff --git a/sc/source/filter/html/htmlpars.cxx 
b/sc/source/filter/html/htmlpars.cxx
index e8f69e9..0260292 100644
--- a/sc/source/filter/html/htmlpars.cxx
+++ b/sc/source/filter/html/htmlpars.cxx
@@ -266,10 +266,8 @@ ScHTMLLayoutParser::~ScHTMLLayoutParser()
 delete pS-pLocalColOffset;
 delete pS;
 }
-if ( pLocalColOffset )
-delete pLocalColOffset;
-if ( pColOffset )
-delete pColOffset;
+delete pLocalColOffset;
+delete pColOffset;
 if ( pTables )
 {
 for( OuterMap::const_iterator it = pTables-begin(); it != 
pTables-end(); ++it)
@@ -1349,8 +1347,7 @@ void ScHTMLLayoutParser::TableOff( ImportInfo* pInfo )
 nColOffsetStart = pS-nColOffsetStart;
 bFirstRow = pS-bFirstRow;
 xLockedList = pS-xLockedList;
-if ( pLocalColOffset )
-delete pLocalColOffset;
+delete pLocalColOffset;
 pLocalColOffset = pS-pLocalColOffset;
 delete pActEntry;
 // pActEntry is kept around if a table is started in the same row
@@ -1370,8 +1367,7 @@ void ScHTMLLayoutParser::TableOff( ImportInfo* pInfo )
 {
 ScHTMLTableStackEntry* pS = aTableStack.top();
 aTableStack.pop();
-if ( pLocalColOffset )
-delete pLocalColOffset;
+delete pLocalColOffset;
 pLocalColOffset = pS-pLocalColOffset;
 delete pS;
 }
commit ab419e3df3f51991cc35b60144e57233bf7ac678
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 15:41:27 2014 +

Resolves: coverity#1078567 help coverity out

so it know that its the same rPPDCache in use to
avoid various warnings

Change-Id: I89cb7830f375f1907b2457bd05fd2df5d36c3696

diff --git a/include/vcl/ppdparser.hxx b/include/vcl/ppdparser.hxx
index 344b35c..a4df86d 100644
--- a/include/vcl/ppdparser.hxx
+++ b/include/vcl/ppdparser.hxx
@@ -34,6 +34,7 @@
 
 namespace psp {
 
+class PPDCache;
 class PPDParser;
 class PPDTranslator;
 
@@ -185,7 +186,7 @@ private:
 OUString handleTranslation(const OString i_rString, bool i_bIsGlobalized);
 
 static void scanPPDDir( const OUString rDir );
-static void initPPDFiles();
+static void initPPDFiles(PPDCache rPPDCache);
 static OUString getPPDFile( const OUString rFile );
 public:
 static const PPDParser* getParser( const OUString rFile );
diff --git a/vcl/unx/generic/printer/ppdparser.cxx 
b/vcl/unx/generic/printer/ppdparser.cxx
index cbfe171..121fa8f 100644
--- a/vcl/unx/generic/printer/ppdparser.cxx
+++ b/vcl/unx/generic/printer/ppdparser.cxx
@@ -455,9 +455,8 @@ void PPDParser::scanPPDDir( const OUString rDir )
 }
 }
 
-void PPDParser::initPPDFiles()
+void PPDParser::initPPDFiles(PPDCache rPPDCache)
 {
-PPDCache rPPDCache = thePPDCache::get();
 if( rPPDCache.pAllPPDFiles )
 return;
 
@@ -499,7 +498,7 @@ void PPDParser::getKnownPPDDrivers( std::list OUString  
o_rDrivers, bool bRef
 rPPDCache.pAllPPDFiles = NULL;
 }
 
-initPPDFiles();
+initPPDFiles(rPPDCache);
 o_rDrivers.clear();
 
 boost::unordered_map OUString, OUString, OUStringHash ::const_iterator 
it;
@@ -520,7 +519,7 @@ OUString PPDParser::getPPDFile( const OUString rFile )
 bool bRetry = true;
 do
 {
-initPPDFiles();
+initPPDFiles(rPPDCache);
 // some PPD files contain dots beside the extension, so try name 
first
 // and cut of points after that
 OUString aBase( rFile );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - sc/inc sc/qa sc/source

2014-03-14 Thread Michael Meeks

 sc/inc/formulacell.hxx  |1 
 sc/qa/unit/ucalc.cxx|   75 +---
 sc/qa/unit/ucalc.hxx|2 
 sc/source/core/data/column.cxx  |   31 +-
 sc/source/core/data/formulacell.cxx |   44 -
 5 files changed, 133 insertions(+), 20 deletions(-)

New commits:
commit ff89c120f5f5036c3792b9cfc3f0329de3ac0a43
Author: Michael Meeks michael.me...@collabora.com
Date:   Fri Mar 14 16:31:59 2014 +

fdo#72741 - write unit test for in formula group swapping.

Change-Id: I9da62b026b40b08784415e0421556946646d25e2

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index cfc94e0..e1e9529 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -4525,10 +4525,8 @@ void Test::testFindAreaPosColRight()
 void Test::testSortWithFormulaRefs()
 {
 ScDocument* pDoc = getDocShell().GetDocument();
-OUString aTabName1(List1);
-OUString aTabName2(List2);
-pDoc-InsertTab(0, aTabName1);
-pDoc-InsertTab(1, aTabName2);
+pDoc-InsertTab(0, List1);
+pDoc-InsertTab(1, List2);
 
 const char* aFormulaData[6] = {
 =IF($List1.A2\\,$List1.A2,\\),
@@ -4627,8 +4625,7 @@ void Test::testSortWithStrings()
 
 void Test::testSort()
 {
-OUString aTabName1(test1);
-m_pDoc-InsertTab(0, aTabName1);
+m_pDoc-InsertTab(0, test1);
 
 ScRange aDataRange;
 ScAddress aPos(0,0,0);
@@ -4717,6 +4714,72 @@ void Test::testSort()
 m_pDoc-DeleteTab(0);
 }
 
+void Test::testSortInFormulaGroup()
+{
+static struct {
+SCCOL nCol;
+SCROW nRow;
+const char *pData;
+} aEntries[] = {
+{ 0, 0, 3 },   { 1, 0, =A1 },
+{ 0, 1, 1 },   { 1, 1, =A2 },
+{ 0, 2, 20 },  { 1, 2, =A3 },
+{ 0, 3, 10 },  { 1, 3, =A4+1 }, // swap across groups
+{ 0, 4, 2  },  { 1, 4, =A5+1 },
+{ 0, 5, 101 }, { 1, 5, =A6 }, // swap inside contiguious group
+{ 0, 6, 100 }, { 1, 6, =A7 },
+{ 0, 7, 102 }, { 1, 7, =A8 },
+{ 0, 8, 104 }, { 1, 8, =A9 },
+{ 0, 9, 103 }, { 1, 9, =A10 },
+};
+
+m_pDoc-InsertTab(0, sorttest);
+
+for ( SCROW i = 0; i  (SCROW) SAL_N_ELEMENTS( aEntries ); ++i )
+m_pDoc-SetString( aEntries[i].nCol, aEntries[i].nRow, 0,
+   OUString::createFromAscii( aEntries[i].pData) );
+
+ScSortParam aSortData;
+aSortData.nCol1 = 0;
+aSortData.nCol2 = 1;
+aSortData.nRow1 = 0;
+aSortData.nRow2 = 9;
+aSortData.maKeyState[0].bDoSort = true;
+aSortData.maKeyState[0].nField = 0;
+aSortData.maKeyState[0].bAscending = true;
+
+m_pDoc-Sort(0, aSortData, false, NULL);
+
+static struct {
+SCCOL nCol;
+SCROW nRow;
+double fValue;
+} aResults[] = {
+{ 0, 0, 1.0 },   { 1, 0, 1.0 },
+{ 0, 1, 2.0 },   { 1, 1, 3.0 },
+{ 0, 2, 3.0 },   { 1, 2, 3.0 },
+{ 0, 3, 10.0 },  { 1, 3, 11.0 },
+{ 0, 4, 20.0 },  { 1, 4, 20.0 },
+{ 0, 5, 100.0 }, { 1, 5, 100.0 },
+{ 0, 6, 101.0 }, { 1, 6, 101.0 },
+{ 0, 7, 102.0 }, { 1, 7, 102.0 },
+{ 0, 8, 103.0 }, { 1, 8, 103.0 },
+{ 0, 9, 104.0 }, { 1, 9, 104.0 },
+};
+
+for ( SCROW i = 0; i  (SCROW) SAL_N_ELEMENTS( aEntries ); ++i )
+{
+double val = m_pDoc-GetValue( aEntries[i].nCol, aEntries[i].nRow, 0 );
+//fprintf(stderr, value at %d %d is %g = %g\n,
+//(int)aResults[i].nRow, (int)aResults[i].nCol,
+//val, aResults[i].fValue);
+CPPUNIT_ASSERT_MESSAGE(Mis-matching value after sort.,
+   rtl::math::approxEqual(val, 
aResults[i].fValue));
+}
+
+m_pDoc-DeleteTab( 0 );
+}
+
 void Test::testShiftCells()
 {
 m_pDoc-InsertTab(0, foo);
diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx
index 68f5bc4..8c3ec8f 100644
--- a/sc/qa/unit/ucalc.hxx
+++ b/sc/qa/unit/ucalc.hxx
@@ -315,6 +315,7 @@ public:
 void testSort();
 void testSortWithFormulaRefs();
 void testSortWithStrings();
+void testSortInFormulaGroup();
 void testShiftCells();
 
 void testNoteBasic();
@@ -460,6 +461,7 @@ public:
 CPPUNIT_TEST(testSort);
 CPPUNIT_TEST(testSortWithFormulaRefs);
 CPPUNIT_TEST(testSortWithStrings);
+CPPUNIT_TEST(testSortInFormulaGroup);
 CPPUNIT_TEST(testShiftCells);
 CPPUNIT_TEST(testNoteBasic);
 CPPUNIT_TEST(testNoteDeleteRow);
commit 0698c49ccdbf62dd84d3f9c5d25ee039f4fff722
Author: Michael Meeks michael.me...@collabora.com
Date:   Fri Mar 14 14:26:02 2014 +

fdo#72741 - swap values only inside a formula group.

Speeds up sorting large ranges containing formula groups by a
computational order or two: can sort 1 million rows of =A1 in sub 10s

Change-Id: I729c801e68154986956b1726e1c35ef973cc4248

diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx
index f2bc36c..9b47046 100644
--- a/sc/inc/formulacell.hxx
+++

[Libreoffice-commits] help.git: helpers/help_hid.lst

 helpers/help_hid.lst |1 -
 1 file changed, 1 deletion(-)

New commits:
commit b390ac000fe821b9c0587c7ae3145b6fe7876852
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 16:53:34 2014 +

drop help id that goes nowhere

Change-Id: I3b28181e3621b32b2c3714ee1c6c6c07e74e21b6

diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst
index 6ceb867..54c1833 100644
--- a/helpers/help_hid.lst
+++ b/helpers/help_hid.lst
@@ -1608,7 +1608,6 @@ HID_FILEDLG_INSERT_BTN,33290,
 HID_FILEDLG_LINK_CB,33344,
 HID_FILEDLG_LOADTEMPLATE,53064,
 HID_FILEDLG_MAILMRGE1,53066,
-HID_FILEDLG_MAILMRGE2,53067,
 HID_FILEDLG_MANAGER,33096,
 HID_FILEDLG_PATH_BTN,33291,
 HID_FILEDLG_PATH_FILENAME,33292,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ff71805cc5cb3024b3c3db1116f2cc3152b4e52b
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 16:53:34 2014 +

Updated core
Project: help  b390ac000fe821b9c0587c7ae3145b6fe7876852

diff --git a/helpcontent2 b/helpcontent2
index 4a7afcf..b390ac0 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 4a7afcf2c94a9267ddab51c9a3b58ff13102ea0b
+Subproject commit b390ac000fe821b9c0587c7ae3145b6fe7876852
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 7 commits - basctl/source comphelper/source connectivity/source dbaccess/source include/comphelper include/svtools include/toolkit svtools/source svx/source toolkit/sou

 basctl/source/basicide/basidectrlr.cxx|2 +-
 comphelper/source/property/propertycontainer.cxx  |2 +-
 connectivity/source/drivers/evoab2/NResultSet.cxx |2 +-
 dbaccess/source/core/api/column.cxx   |2 +-
 include/comphelper/interaction.hxx|2 +-
 include/comphelper/propagg.hxx|2 +-
 include/comphelper/propertycontainer.hxx  |2 +-
 include/comphelper/proxyaggregation.hxx   |2 +-
 include/svtools/toolbarmenu.hxx   |5 +++--
 include/toolkit/controls/geometrycontrolmodel.hxx |8 
 svtools/source/control/toolbarmenu.cxx|3 +--
 svtools/source/uno/genericunodialog.cxx   |2 +-
 svtools/source/uno/toolboxcontroller.cxx  |2 +-
 svx/source/tbxctrls/extrusioncontrols.cxx |8 
 svx/source/tbxctrls/extrusioncontrols.hxx |8 
 svx/source/tbxctrls/fontworkgallery.cxx   |8 
 toolkit/source/controls/geometrycontrolmodel.cxx  |2 +-
 vcl/source/window/layout.cxx  |1 -
 18 files changed, 31 insertions(+), 32 deletions(-)

New commits:
commit edab999feb2a51068725c69e8add9a897539e78a
Author: Stephan Bergmann sberg...@redhat.com
Date:   Fri Mar 14 17:57:04 2014 +0100

Remove SAL_INFO that was meant as a temporary SAL_DEBUG

Change-Id: I6d3b822c7a44a2cddb842266494a387ed693fd61

diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx
index d8ab4c6..4da3a8f 100644
--- a/vcl/source/window/layout.cxx
+++ b/vcl/source/window/layout.cxx
@@ -2208,7 +2208,6 @@ bool MessageDialog::set_property(const OString rKey, 
const OString rValue)
 }
 else if (rKey == buttons)
 {
-SAL_INFO(vcl.layout, buttons type mode   rValue);
 VclButtonsType eMode = VCL_BUTTONS_NONE;
 if (rValue.equals(none))
 eMode = VCL_BUTTONS_NONE;
commit e1d99bc0d52a7f03597a8d5400a3578dacf54bbf
Author: Stephan Bergmann sberg...@redhat.com
Date:   Fri Mar 14 17:56:03 2014 +0100

ToolbarMenu does not implement XStatusListener

Change-Id: Ia0195e794ac5e23905035738f0ab7e658c3bb92b

diff --git a/include/svtools/toolbarmenu.hxx b/include/svtools/toolbarmenu.hxx
index 52e4318..61853ac 100644
--- a/include/svtools/toolbarmenu.hxx
+++ b/include/svtools/toolbarmenu.hxx
@@ -100,8 +100,9 @@ protected:
 bool IsInPopupMode();
 void EndPopupMode();
 
-// XStatusListener (subclasses must override this one to get the status 
updates
-virtual void SAL_CALL statusChanged( const 
::com::sun::star::frame::FeatureStateEvent Event ) throw ( 
::com::sun::star::uno::RuntimeException );
+// Forwared from XStatusListener (subclasses must override this one to get
+// the status updates):
+virtual void statusChanged( const 
::com::sun::star::frame::FeatureStateEvent Event ) throw ( 
::com::sun::star::uno::RuntimeException );
 
 voidStateChanged( StateChangedType nType );
 voidDataChanged( const DataChangedEvent rDCEvt );
diff --git a/svtools/source/control/toolbarmenu.cxx 
b/svtools/source/control/toolbarmenu.cxx
index 9efa518..6fa1785 100644
--- a/svtools/source/control/toolbarmenu.cxx
+++ b/svtools/source/control/toolbarmenu.cxx
@@ -1568,8 +1568,7 @@ void ToolbarMenu::AddStatusListener( const OUString 
rCommandURL )
 
 
 
-// XStatusListener (subclasses must override this one to get the status updates
-void SAL_CALL ToolbarMenu::statusChanged( const 
::com::sun::star::frame::FeatureStateEvent /*Event*/ ) throw ( 
::com::sun::star::uno::RuntimeException )
+void ToolbarMenu::statusChanged( const 
::com::sun::star::frame::FeatureStateEvent /*Event*/ ) throw ( 
::com::sun::star::uno::RuntimeException )
 {
 }
 
diff --git a/svx/source/tbxctrls/extrusioncontrols.cxx 
b/svx/source/tbxctrls/extrusioncontrols.cxx
index c94dec0..1ae9cd8 100644
--- a/svx/source/tbxctrls/extrusioncontrols.cxx
+++ b/svx/source/tbxctrls/extrusioncontrols.cxx
@@ -168,7 +168,7 @@ void ExtrusionDirectionWindow::implSetProjection( sal_Int32 
nProjection, bool bE
 
 
 
-void SAL_CALL ExtrusionDirectionWindow::statusChanged(
+void ExtrusionDirectionWindow::statusChanged(
 const ::com::sun::star::frame::FeatureStateEvent Event
 )   throw ( ::com::sun::star::uno::RuntimeException )
 {
@@ -387,7 +387,7 @@ void ExtrusionDepthWindow::implFillStrings( FieldUnit eUnit 
)
 
 
 
-void SAL_CALL ExtrusionDepthWindow::statusChanged(
+void ExtrusionDepthWindow::statusChanged(
 const ::com::sun::star::frame::FeatureStateEvent Event
 )   throw ( ::com::sun::star::uno::RuntimeException )
 {
@@ -658,7 +658,7 @@ void ExtrusionLightingWindow::implSetDirection( int 
nDirection, bool bEnabled )
 
 
 
-void SAL_CALL ExtrusionLightingWindow::statusChanged(
+void ExtrusionLightingWindow::statusChanged(
 const ::com::sun::star::frame::FeatureStateEvent Event
 )   throw ( ::com::sun::star::uno::RuntimeException )
 {
@@ -853,7 +853,7 @@ void

[Libreoffice-commits] core.git: 2 commits - cui/Library_cui.mk cui/source include/svx sw/inc sw/source

 cui/Library_cui.mk |1 
 cui/source/dialogs/multifil.cxx|  167 -
 cui/source/dialogs/multipat.cxx|   61 ++--
 cui/source/dialogs/multipat.src|   12 --
 cui/source/factory/dlgfact.cxx |   52 --
 cui/source/factory/dlgfact.hxx |   21 
 cui/source/inc/cuires.hrc  |   10 -
 cui/source/inc/multifil.hxx|   50 -
 cui/source/inc/multipat.hxx|   10 -
 include/svx/svxdlg.hxx |3 
 sw/inc/helpid.h|1 
 sw/source/core/uibase/inc/mailmrge.hxx |1 
 sw/source/ui/envelp/mailmrge.cxx   |   27 -
 sw/source/ui/misc/glosbib.cxx  |1 
 14 files changed, 27 insertions(+), 390 deletions(-)

New commits:
commit 200cc2d20a21ceb5d176604f9c384f15c6a87570
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Mar 14 16:36:59 2014 +

SvxMultiFileDialog is never created

because the single caller of it is a hidden button
in the old mail merge dialog which was never completed
to allow attachments to emails (because it never was
able to send emails, the new one can FWIW)

all of which has logical knock on effects to shrink
things down substantially

Change-Id: I831cac8f670eaafc96b2ea4d78516f67b662fa7d

diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk
index 3d4edbc..28f4b64 100644
--- a/cui/Library_cui.mk
+++ b/cui/Library_cui.mk
@@ -105,7 +105,6 @@ $(eval $(call gb_Library_add_exception_objects,cui,\
 cui/source/dialogs/insdlg \
 cui/source/dialogs/insrc \
 cui/source/dialogs/linkdlg \
-cui/source/dialogs/multifil \
 cui/source/dialogs/multipat \
 cui/source/dialogs/newtabledlg \
 cui/source/dialogs/passwdomdlg \
diff --git a/cui/source/dialogs/multifil.cxx b/cui/source/dialogs/multifil.cxx
deleted file mode 100644
index a0b10a2..000
--- a/cui/source/dialogs/multifil.cxx
+++ /dev/null
@@ -1,167 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the License); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#include sal/config.h
-
-#include comphelper/processfactory.hxx
-#include tools/shl.hxx
-#include vcl/msgbox.hxx
-#include sfx2/filedlghelper.hxx
-
-#include tools/urlobj.hxx
-
-#include multipat.hxx
-#include multifil.hxx
-#include dialmgr.hxx
-
-#include multipat.hrc
-#include cuires.hrc
-
-// #97807# -
-#include com/sun/star/ucb/UniversalContentBroker.hpp
-
-#include com/sun/star/ui/dialogs/TemplateDescription.hpp
-
-using namespace com::sun::star::ucb;
-using namespace com::sun::star::uno;
-
-// class SvxMultiFileDialog --
-
-IMPL_LINK( SvxMultiFileDialog, AddHdl_Impl, PushButton *, pBtn )
-{
-sfx2::FileDialogHelper aDlg(
-com::sun::star::ui::dialogs::TemplateDescription::FILEOPEN_SIMPLE, 0 );
-
-if ( IsClassPathMode() )
-{
-aDlg.SetTitle( CUI_RES( RID_SVXSTR_ARCHIVE_TITLE ) );
-aDlg.AddFilter( CUI_RES( RID_SVXSTR_ARCHIVE_HEADLINE ), 
OUString(*.jar;*.zip) );
-}
-
-if ( aDlg.Execute() == ERRCODE_NONE )
-{
-// #97807# URL content comparison of entries ---
-INetURLObject aFile( aDlg.GetPath() );
-OUString sInsFile = aFile.getFSysPath( INetURLObject::FSYS_DETECT );
-::ucbhelper::Content aContent( aFile.GetMainURL( 
INetURLObject::NO_DECODE ), Reference XCommandEnvironment (), 
comphelper::getProcessComponentContext() );
-Reference XContent  xContent = aContent.get();
-OSL_ENSURE( xContent.is(), AddHdl_Impl: invalid content interface! );
-Reference XContentIdentifier  xID = xContent-getIdentifier();
-OSL_ENSURE( xID.is(), AddHdl_Impl: invalid ID interface! );
-// ensure the content of files are valid
-
-sal_uInt16 nCount = aPathLB.GetEntryCount();
-sal_Bool bDuplicated = sal_False;
-try
-{
-if( nCount  0 ) // start comparison
-{
-sal_uInt16 i;
-::ucbhelper::Content  VContent = aContent; // temporary 
Content reference
-Reference XContent  xVContent;

Re: spadmin, fax machines, etc. is this still useful ?

2014-03-14 Thread Rob Snelders


Hi All,

From my last job in retail-supplying I know a lot of Fax is still used 
in countries like Belgium, UK and a lot of African countries.
We wheren't communicating directly between the faxes and libreoffice, 
but I wouldn't say that Fax isn't used anymore.
Also in the legal the Fax is still used as a faxed document is legal in 
some countries but via email/internet isn't.


--
Greetings,
Rob Snelders

Caolán McNamara schreef op 14-03-2014 13:40:

On Fri, 2014-03-14 at 12:31 +0100, Alex Thurgood wrote:
The fact that spadmin could be used to add Type1 PS fonts, which are 
no

longer supported, if I understand correctly, has also been, and
continues to be, an issue that crops up on the user list (and possibly
also in BZ) for some people.


Have you a link to an example because type 1 fonts just work, there
was no removal of support for those. The add fonts ability of spadmin
was removed in 2012 and prior to that was only visible if your system
didn't support fontconfig which is a practically impossible situation
for many years now so I'd like to understand that comment a little 
more.



This could previously be set up in a PPD and included via spadmin,
including on Mac OSX.


I'm a little baffled, spadmin on MacOSX ?, what version included 
spadmin

on MacOSX ? We certainly don't do it now.

If there are cases where fiddling with the ppd manually and adding that
via spadmin worked, would not the same solution work by using the 
system

tools to set the replacement ppd for the printer ? e.g. using
system-config-printer under Fedora and provide PPD file

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: spadmin, fax machines, etc. is this still useful ?

2014-03-14 Thread Cor Nouws

Hi Caolán,

Caolán McNamara wrote (14-03-14 11:45)

 So the question is if any part of
 spadmin is still useful? Is there anyone still configuring fax machines
 or using the other options there, and if so for what purpose ?

I would not be surprised.. but will ask some contacts to be more sure
(for as far as my network is concerned).

thanks for asking,
Cor

-- 
Cor Nouws
GPD key ID: 0xB13480A6 - 591A 30A7 36A0 CE3C 3D28  A038 E49D 7365 B134 80A6
- vrijwilliger http://nl.libreoffice.org
- volunteer http://www.libreoffice.org
- The Document Foundation Membership Committee Member



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[no subject]

2014-03-14 Thread Manas Joshi


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/source

2014-03-14 Thread Eike Rathke

 sc/source/ui/app/scmod.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit cc847b5885f89e9292ba6aec1298f3261a966c66
Author: Eike Rathke er...@redhat.com
Date:   Fri Mar 14 18:52:54 2014 +0100

recalc for interpreter options changes

Change-Id: I6a6d0ba558d0aae075e2a00f76ce96990af882d3

diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index b4f2829..99492d1 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -1081,6 +1081,10 @@ void ScModule::ModifyOptions( const SfxItemSet rOptSet )
 bCompileErrorCells = true;
 }
 
+// Recalc for interpreter options changes.
+if (pFormulaCfg  pFormulaCfg-GetCalcConfig() != 
rOpt.GetCalcConfig())
+bCalcAll = true;
+
 SetFormulaOptions( rOpt );
 
 if ( pDocSh )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Libreoffice-qa] Disallow REOPEN on ancient bugs

2014-03-14 Thread Bjoern Michaelsen

On Thu, Mar 13, 2014 at 08:12:49PM -0400, Kohei Yoshida wrote:
 I'm just wondering whether it's possible to disallow reopening of bugs
 if they are at least more than a year old (or whatever some arbitrary
 time period)?  I've seen people re-opening bugs that were closed more
 than 2-3 years ago.  This happens quite often.

Not possible right now, but absolutely a good idea. We should look into that on
our own bugzilla ...

Best, Bjoern
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] Version field options way too fine grained

Hi there,

Another thing I'd like to inquire about is that currently we have way
too fine-grained version field options it's becoming increasingly
difficult to query for give me all bugs for 4.2 and similar.  For
instance, even for the 4.2 branch we have

4.2.0.0alpha0+Master,
4.2.0.0alpha1
4.2.0.0beta1
...
4.2.0.1rc
4.2.0.2rc
...

and so on. We have way too many to list all.  4.1 is in a similar
situation.

I have my saved query and try to select all relevant versions but it's
prone to errors.  Today I just discovered a regression that I didn't see
before because its version field was set to 4.2.0.0alpha0+Master which I
didn't include in my saved search.

IMO we should only have 4.0, 4.1, 4.2 etc as version.  All these too
fine grained version numbers only serve to make bugs discoverable.

What do you guys think about this?

Kohei

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Version field options way too fine grained

On Fri, 2014-03-14 at 09:58 -0400, Kohei Yoshida wrote:

 IMO we should only have 4.0, 4.1, 4.2 etc as version.  All these too
 fine grained version numbers only serve to make bugs discoverable.

I mean make bugs *un*-discoverable.


___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Version field options way too fine grained

2014-03-14 Thread Joel Madero


Hey Kohei,

 What do you guys think about this?

Well I see a few potential issues but all in all it's QA's job to make
it easier for the developers and users so if it's thought that doing
this would do so we can discuss. We have substantially reduced the
number of versions listed (I removed all of 3.5 essentially).

That being said potential problems:
(1) Confused users when they are reporting
(2) Stats become much harder to track
(3) Requires QA to do additional work to input field version in
whiteboard status (IMHO we already put too much in whiteboard)


I think those are my main concerns - but we can discuss a bit on Monday
on the call (within QA) and then Robinson can talk it over on Thursday
on ESC if that works for you. I suspect both Bjoern and Michael will
have opinions as well :)


Best,
Joel

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Version field options way too fine grained

2014-03-14 Thread m.a.riosv

Hi,
perhaps only two digits could be a bit short, IMO three can be a more
balanced option, because it has a good correspondence with public releases.

Miguel Ángel.




--
View this message in context: 
http://nabble.documentfoundation.org/Libreoffice-qa-Version-field-options-way-too-fine-grained-tp4101391p4101412.html
Sent from the QA mailing list archive at Nabble.com.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Version field options way too fine grained

On Fri, 2014-03-14 at 08:19 -0700, m.a.riosv wrote:
 Hi,
 perhaps only two digits could be a bit short, IMO three can be a more
 balanced option, because it has a good correspondence with public releases.

Yeah, I think I'd be happy with this.

Also, part of the problems comes from the total-unsorted-ness of version
items in the query page.  For instance,

* 3.5.1 release is followed by 3.4.6 RC1

* 4.2.00alpha0+Master comes between 4.1.0.0alpha1 and 4.1.0.0beta1 (the
reason why I missed it)

* 3.3 all versions comes after 3.6.7.1 rc

* 4.3.0.0alpha0+Master comes between 4.2.0.0beta1 and 4.2.0.0beta2

and so on.

Anyway, it appears that one can use a regular expression to filter
versions, which I was previously looking for but didn't realize it was
under the Custom Search section.  I can just use that to make it fit
my workflow.

Thanks,

Kohei

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Version field options way too fine grained

2014-03-14 Thread Bjoern Michaelsen

Hi Kohei,

On Fri, Mar 14, 2014 at 09:58:00AM -0400, Kohei Yoshida wrote:
 I have my saved query and try to select all relevant versions but it's
 prone to errors.  Today I just discovered a regression that I didn't see
 before because its version field was set to 4.2.0.0alpha0+Master which I
 didn't include in my saved search.

What I usually do is to simply use a regexp on the version field (in the custom
search section). Not pretty, usually a working workaround.

 IMO we should only have 4.0, 4.1, 4.2 etc as version.  All these too
 fine grained version numbers only serve to make bugs discoverable.
 What do you guys think about this?

Personally, I think that could work. We should then have a way to highlight a
bug via whiteboard status if it is indeed one of those rare regressions in a
point release (e.g. worked in 4.2.0, doesnt work in 4.2.1). Ubuntu uses
regression-release vs. regression-update to separate those -- we could do
something similar.

There is a social component to this though: Quite a few QA volunteers have many
LibreOffice versions installed to identify the earliest release this is in and
we would break their workflow (and some of the tools created for that, like
SI-GUI).

OTOH, ultimately for developers in almost all cases a bibisect that pins down a
regression to some 50-100 commits on master is almost always preferable for
debugging over testing rcs and official releases which end up at was
introduced somewhere between 4.0.6 and 4.1.0 beta or the like in 99% of the
cases as stuff really rarely rarely regresses on a release branch. A range of
4.0.6-4.1.0~beta isnt too helpful, as that is still a few thousand commits.

So IMHO we can consider doing that -- but we need to be careful to move people
from testing all the release branch versions (somewhat pointlessly) to testing
master version (via bibisect repos, lots of daily builds or whatever) instead
of losing them, which wouldnt be helpful. That likely needs quite a bit of
advertising to massage the message in and change the mindset.

Best,

Bjoern

P.S.: For the BSA it would make sense to still ask the whole version (and even
maybe where that version is from: distro or TDF), but not write it down
completely in the version field (just use 4.1/4.2 there), but put the rest in
the description so we dont loose it (not for querying, but when one walks
through the comments).
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Version field options way too fine grained

2014-03-14 Thread Michael Stahl

On 14/03/14 14:58, Kohei Yoshida wrote:

 IMO we should only have 4.0, 4.1, 4.2 etc as version.  All these too
 fine grained version numbers only serve to make bugs discoverable.

but then you can't easily tell what bugs are regressions on release
branches.

 What do you guys think about this?

definitely a problem, but i think it's a pretty fundamental limitation:
bugzilla simply has no concept of branches.

what would be great is if a bug could have a affected branches list,
and for _each_ entry in that a version; that would also allow to
represent bugs that were actually backported into release branches
properly...

... but bugzilla can't do that sort of thing.

one thing that could perhaps be done is to sort the versions somehow
alphabetically (not in order in which they are created), so that it's
easy to select a whole block of 4.2.* versions.


___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Version field options way too fine grained

2014-03-14 Thread bfoman

Michael Stahl-2 wrote
 definitely a problem, but i think it's a pretty fundamental limitation:
 bugzilla simply has no concept of branches.

Hi!
Bugzilla branch support (called sightings):
- progress - follow https://bugzilla.mozilla.org/show_bug.cgi?id=55970
- code -
http://git.mozilla.org/?p=bugzilla/bugzilla.git;a=shortlog;h=refs/heads/sightings
Unfortunately seems not finished yet but merged recently with up-to-date
code.
Best regards.




--
View this message in context: 
http://nabble.documentfoundation.org/Libreoffice-qa-Version-field-options-way-too-fine-grained-tp4101391p4101433.html
Sent from the QA mailing list archive at Nabble.com.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Version field options way too fine grained

2014-03-14 Thread Joel Madero


On 03/14/2014 10:11 AM, bfoman wrote:
 Michael Stahl-2 wrote
 definitely a problem, but i think it's a pretty fundamental limitation:
 bugzilla simply has no concept of branches.
I think we'll have the ability to add the additional version (branch)
once we have our own instance of bugzilla. My suggestion is three
version fields:
1. oldest version
2. latest version confirmed
3. branch (automated based on either 1 or 2)


Best,
Joel
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Version field options way too fine grained

2014-03-14 Thread Terrence Enger

Hello, all,

On Fri, 2014-03-14 at 10:11 -0700, bfoman wrote:
 Michael Stahl-2 wrote
  definitely a problem, but i think it's a pretty fundamental limitation:
  bugzilla simply has no concept of branches.
 
 Hi!
 Bugzilla branch support (called sightings):
 - progress - follow https://bugzilla.mozilla.org/show_bug.cgi?id=55970
 - code -
 http://git.mozilla.org/?p=bugzilla/bugzilla.git;a=shortlog;h=refs/heads/sightings
 Unfortunately seems not finished yet but merged recently with up-to-date
 code.

From the specification attached to that bug report
https://bug55970.bugzilla.mozilla.org/attachment.cgi?id=304328, the
basic idea is to have separate underlying bugs with an integrated
interface making it easy to clone off an also-associated bug or to
copy information between bugs in the set of also-associated bugs.

I do not find this attractive, but then I am an unimaginative old man
with a prejudice against keeping multiple copies of information. ( grin
attitude=wry/  And, yes, I am grumpy too. )

Perhaps more seriously, There is no way to record places where a bug
is *not* evident.  This matters to us not so much for versions--we
have bibisect for that--as it does for platforms, configration
parameters, and whatever.  For example, there is no easy way to
distinguish a Windows-only bug (I have nothing to offer), from a bug
reported on Windows and unconsidered elsewhere (I may have something
to offer).

enter object=the_weeds
  (*) Sighting is too positive a word for what I am talking about.
  Let us say observation for now.
  (*) Each observation is associated with a specific build running on
  a specific platform.  Because that is what is in front of the
  person reporting the observation, of course.
/enter

Just my C$0.02,
Terry.


___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 76106] File Corruption: RT gets corrupt since the target for hyperlink is exported incorrectly.

https://bugs.freedesktop.org/show_bug.cgi?id=76106

Chris Sherlock chris.sherloc...@gmail.com changed:

   What|Removed |Added

   Hardware|Other   |All
   Assignee|rajashri.udh...@synerzip.co |libreoffice-b...@lists.free
   |m   |desktop.org
  Component|Libreoffice |Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39983] [Feature Request] Support Mac OSX 10.7 (Lion) full-screen mode

https://bugs.freedesktop.org/show_bug.cgi?id=39983

Norbert Thiebaud nthieb...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #54 from Norbert Thiebaud nthieb...@gmail.com ---
works on master

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on OS X

https://bugs.freedesktop.org/show_bug.cgi?id=42082

Bug 42082 depends on bug 39983, which changed state.

Bug 39983 Summary: [Feature Request] Support Mac OSX 10.7 (Lion) full-screen 
mode
https://bugs.freedesktop.org/show_bug.cgi?id=39983

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76142] EU-conform digital signatures (XAdES, ASiC container) in Libre Office

https://bugs.freedesktop.org/show_bug.cgi?id=76142

Andras Timar tima...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||tima...@gmail.com
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76145] Currently not possible to file a bug

https://bugs.freedesktop.org/show_bug.cgi?id=76145

Andras Timar tima...@gmail.com changed:

   What|Removed |Added

 CC||website@global.libreoffice.
   ||org
  Component|Libreoffice |WWW

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76106] File Corruption: RT gets corrupt since the target for hyperlink is exported incorrectly.

https://bugs.freedesktop.org/show_bug.cgi?id=76106

Chris Sherlock chris.sherloc...@gmail.com changed:

   What|Removed |Added

  Attachment #95699|text/plain  |application/vnd.openxmlform
  mime type||ats-officedocument.wordproc
   ||essingml.document

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76106] File Corruption: RT gets corrupt since the target for hyperlink is exported incorrectly.

https://bugs.freedesktop.org/show_bug.cgi?id=76106

--- Comment #3 from Rajashri rajashri.udh...@synerzip.com ---
Created attachment 95775
  -- https://bugs.freedesktop.org/attachment.cgi?id=95775action=edit
Oroginal_file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76106] File Corruption: RT gets corrupt since the target for hyperlink is exported incorrectly.

https://bugs.freedesktop.org/show_bug.cgi?id=76106

Rajashri rajashri.udh...@synerzip.com changed:

   What|Removed |Added

  Attachment #95699|Original file   |Optimized file. The exact
description||area under
   ||'2094037651.docx' which
   ||highlights the corruption.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76106] File Corruption: RT gets corrupt since the target for hyperlink is exported incorrectly.

https://bugs.freedesktop.org/show_bug.cgi?id=76106

--- Comment #4 from Chris Sherlock chris.sherloc...@gmail.com ---
I didn't read that correctly. There is no greater than symbol. This has a
semi-colon in it. Sigh. My bad.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76106] File Corruption: RT gets corrupt since the target for hyperlink is exported incorrectly.

https://bugs.freedesktop.org/show_bug.cgi?id=76106

--- Comment #5 from Chris Sherlock chris.sherloc...@gmail.com ---
Semi-colon, of course, has the same issue. It should be escaped. I don't see
that it's an issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76159] New: FILEOPEN: IF() and INDIRECT() in formulae causes #REF!

https://bugs.freedesktop.org/show_bug.cgi?id=76159

  Priority: medium
Bug ID: 76159
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: FILEOPEN: IF() and INDIRECT() in formulae causes #REF!
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: amaste...@gmail.com
  Hardware: All
Status: UNCONFIRMED
   Version: 4.1.4.2 release
 Component: Spreadsheet
   Product: LibreOffice

Created attachment 95776
  -- https://bugs.freedesktop.org/attachment.cgi?id=95776action=edit
Test spreadsheet

See attached file.
You can see #REF! error in G3 cell when file is opened.
But changing B3 cell makes G3 to become 6 (As it must be).
But save/load returns to old situation: #REF! error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76159] FILEOPEN: IF() and INDIRECT() in formulae causes #REF!

https://bugs.freedesktop.org/show_bug.cgi?id=76159

Alex Masterov amaste...@gmail.com changed:

   What|Removed |Added

  Attachment #95776|0   |1
is obsolete||

--- Comment #1 from Alex Masterov amaste...@gmail.com ---
Created attachment 95777
  -- https://bugs.freedesktop.org/attachment.cgi?id=95777action=edit
Test spreadsheet (correct MIME type)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76106] File Corruption: RT gets corrupt since the target for hyperlink is exported incorrectly.

https://bugs.freedesktop.org/show_bug.cgi?id=76106

Chris Sherlock chris.sherloc...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |NOTABUG

--- Comment #6 from Chris Sherlock chris.sherloc...@gmail.com ---
I do not believe this is a problem. The issue here is not with us, in fact
Microsoft is not honouring the URI RFC. If a character is not reserved or
unreserved, they should be percentage encoding it, full stop. I'm very
surprised they have not for semi-colons. 

But that's sort of their problem, not ours. A browser should automatically
decode the URI when it sees the percentage encoding. 

Not a bug!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 59775] Character width scaling does not work

https://bugs.freedesktop.org/show_bug.cgi?id=59775

Norbert Thiebaud nthieb...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #7 from Norbert Thiebaud nthieb...@gmail.com ---
tested on master.. following the instruction of #1 - works fine

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76093] EDITING: INFO(version) doesn't give an understandable result.

https://bugs.freedesktop.org/show_bug.cgi?id=76093

Andras Timar tima...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #1 from Andras Timar tima...@gmail.com ---
On the contrary, it is the build number which did not make sense. Now
=INFO(release) returns the build identifier, the SHA256 hash in git, which
uniquely identifies the source code state from which the binary was built. The
build number did not identify anything in LibreOffice, it was a legacy from
Star Division.

=INFO(version) is identical to =INFO(release), because in fact
=INFO(version) is the French translation of =INFO(release) and we have it
for compatibility with MS Excel.

I think using INFO function is not very useful. It is there for compatibility
reasons. If you are interested in version number, you can query it from
configuration data with a few lines of Basic.

See e.g.:
http://www.oooforum.org/forum/viewtopic.phtml?t=10003highlight=getsolarversion

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62583] Text on a line inconsistently re-rendered while typing

https://bugs.freedesktop.org/show_bug.cgi?id=62583

Norbert Thiebaud nthieb...@gmail.com changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #7 from Norbert Thiebaud nthieb...@gmail.com ---
Matthew do you still see the problem on recent version ?
I can't seems to reproduce

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76160] New: VIEWING Calc zoom or print preview changes the position of images on the Y axis

https://bugs.freedesktop.org/show_bug.cgi?id=76160

  Priority: medium
Bug ID: 76160
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: VIEWING Calc zoom or print preview changes the
position of images on the Y axis
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: damien.cha...@gmail.com
  Hardware: All
Status: UNCONFIRMED
   Version: 4.3.0.0.alpha0+ Master
 Component: Spreadsheet
   Product: LibreOffice

Created attachment 95778
  -- https://bugs.freedesktop.org/attachment.cgi?id=95778action=edit
Spreadsheet with incorrect image position when you preview/zoom

When zooming in calc, image change position on the Y axis.

This incorrect image position appears when you have huge cell height, and
anchored picture fit inside. The more the cell is far from the top, the more
the problem is visible.

Print preview is affected too.

Step to reproduce :
- load Image_y_axis_zoom_preview_problem.xls
- Select the last image
- Zoom in and out, notice how the selection corners move on the Y axis
- Launch a preview, the pictures at the bottom are not at the right position

Expected result:
Images position should not be affected by zooming or previewing.

Tested on linux/ubuntu 64 , libreoffice 2014-03-13 4.3.0.0.alpha0+ 2014-Build
ID: ccd765079ae573d24ded2a07ec434e4e89b619a2 

Same bug in LibreOffice 4.1.5 (tested on windows XP), LibreOffice 4.2.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76160] VIEWING Calc zoom or print preview changes the position of images on the Y axis

https://bugs.freedesktop.org/show_bug.cgi?id=76160

Damien Chambe damien.cha...@gmail.com changed:

   What|Removed |Added

 CC||damien.cha...@gmail.com

--- Comment #1 from Damien Chambe damien.cha...@gmail.com ---
The fix for this bug appears in /sc/source/ui/view/drawview.cxx :
- if (nEndRow1000)
+ if (nEndRow20)

It has been corrected, see 31737.

But it has been reverted by :
http://cgit.freedesktop.org/libreoffice/core/commit/sc/source/ui/view/drawview.cxx?id=bc30ba74e880122b257cc6aa2965a79851fa4608

If you apply the attached patch correction (Same patch in bug #i116848#),
zooming and preview are correct. 
(Tested on linux 64 , libreoffice 4.3.0.0.alpha0+ Build ID:
ccd765079ae573d24ded2a07ec434e4e89b619a2 )

I don't know why the commit has been reverted, I don't understand the code,
I've just tracked the regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76160] VIEWING Calc zoom or print preview changes the position of images on the Y axis

https://bugs.freedesktop.org/show_bug.cgi?id=76160

--- Comment #2 from Damien Chambe damien.cha...@gmail.com ---
Created attachment 95779
  -- https://bugs.freedesktop.org/attachment.cgi?id=95779action=edit
patch for correct Y picture position with zoom/preview

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75715] EDITING: REGRESSION: LibO 4.2 displays low resolution bitmap with poor upscaling wrt 4.1

https://bugs.freedesktop.org/show_bug.cgi?id=75715

Andras Timar tima...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ke...@collabora.com,
   ||tima...@gmail.com
 Ever confirmed|0   |1

--- Comment #10 from Andras Timar tima...@gmail.com ---
Scaling of bitmaps has changed indeed in 4.2. CC-ing Kendy.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62583] Text on a line inconsistently re-rendered while typing

https://bugs.freedesktop.org/show_bug.cgi?id=62583

--- Comment #8 from Matthew Francis fdb...@neosheffield.co.uk ---
(In reply to comment #7)

I can still see it in Web Layout mode under 4.2.0.4, but it may possibly have
been fixed by the resolution of bug 64957 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57321] Math OLE cripples in document

https://bugs.freedesktop.org/show_bug.cgi?id=57321

Andras Timar tima...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #6 from Andras Timar tima...@gmail.com ---
It is still a problem in current master (4.3).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76161] New: [NEW] Import more than one spreadsheet ODS/XLS into BASE as separate tables