Re: [Libreoffice] Fwd: Re: patch for scan-diialog

2011-10-23 Thread Rob Snelders
I've tested the code as it is in git now. And it still works here. M.V.G. Rob Snelders On 21-10-11 22:31, Rob Snelders wrote: Hi, I have added the feature with screenshot to the ReleaseNotes. Stephan: I'm compiling the code and will test the patch when it is done. M.V.G. Rob Snelders On

Re: [Libreoffice] Fwd: Re: patch for scan-diialog

2011-10-21 Thread Michael Meeks
Hi Rob, On Thu, 2011-10-20 at 20:37 +0200, Rob Snelders wrote: Here are 3 patches that together make the code for adding the scan-button to the sanedlg. Great to see that :-) Any chance you could drop a nice screenshot / feature note and your name at:

Re: [Libreoffice] Fwd: Re: patch for scan-diialog

2011-10-21 Thread Rob Snelders
Hi, I have added the feature with screenshot to the ReleaseNotes. Stephan: I'm compiling the code and will test the patch when it is done. M.V.G. Rob Snelders On vr 21 okt 2011 17:53:31 CEST, Michael Meeks wrote: Hi Rob, On Thu, 2011-10-20 at 20:37 +0200, Rob Snelders wrote: Here are 3

Re: [Libreoffice] Fwd: Re: patch for scan-diialog

2011-10-20 Thread Stephan Bergmann
On 10/19/2011 10:30 PM, Rob Snelders wrote: I tried to add the XScannerManager2. But when I try with this patch then the menu-items are disabled. I have tried to search where the problem was but I can´t find it. Can you help me? Hi Rob, The new file

Re: [Libreoffice] Fwd: Re: patch for scan-diialog

2011-10-20 Thread Rob Snelders
Hi, Here are 3 patches that together make the code for adding the scan-button to the sanedlg. These patches are submitted under the LGPLv3+/MPL-licence. M.V.G. Rob Snelders On 20-10-11 09:39, Stephan Bergmann wrote: On 10/19/2011 10:30 PM, Rob Snelders wrote: I tried to add the

Re: [Libreoffice] Fwd: Re: patch for scan-diialog

2011-10-19 Thread Rob Snelders
Hi Stephan, I tried to add the XScannerManager2. But when I try with this patch then the menu-items are disabled. I have tried to search where the problem was but I can´t find it. Can you help me? M.V.G. Rob Snelders On 13-10-11 16:59, Stephan Bergmann wrote: On 10/12/2011 06:32 PM, Rob

Re: [Libreoffice] Fwd: Re: patch for scan-diialog

2011-10-19 Thread Markus Mohrhard
Hello Rob, I only did a quick check but it seems that you are missing the implementation. I think you need to adjust scanner.hxx:64 and the corresponding parts in this class. Then I saw that you are still using sal_Bool. We try to switch to bool where it is possible that means in most places

Re: [Libreoffice] Fwd: Re: patch for scan-diialog

2011-10-13 Thread Stephan Bergmann
On 10/12/2011 06:32 PM, Rob Snelders wrote: Can somebody add this patch to the git? Hi Rob, sorry for stepping in so late, just apparently missed your great patch somehow. One thing I'm uneasy with is changing (published) XScannerManager.idl incompatibly. The standard routine for doing

Re: [Libreoffice] Fwd: Re: patch for scan-diialog

2011-10-13 Thread Rob Snelders
Thank you for the reply and the explenation. I'll try to make the changes next week. M.V.G. Rob Snelders On do 13 okt 2011 16:59:58 CEST, Stephan Bergmann wrote: On 10/12/2011 06:32 PM, Rob Snelders wrote: Can somebody add this patch to the git? Hi Rob, sorry for stepping in so late, just

[Libreoffice] Fwd: Re: patch for scan-diialog

2011-10-12 Thread Rob Snelders
Can somebody add this patch to the git? Original Message Subject: Re: [Libreoffice] patch for scan-diialog Date: Thu, 06 Oct 2011 17:59:04 +0200 From: Rob Snelders r...@ertai.nl To: Miklos Vajna vmik...@frugalware.org CC: libreoffice@lists.freedesktop.org Here is the patch.