Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

2012-02-13 Thread Noel Power
On 09/02/12 14:53, Albert Thuswaldner wrote: Hi, [...] So I have improved the patch according to Kohei's suggestion above. Now I store the prefix at each key-stroke and check for illegal characters. When an illegal character is entered, the text is reverted back to the last good prefix. (So

Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

2012-02-13 Thread Noel Power
On 09/02/12 14:53, Albert Thuswaldner wrote: If it was up to me I would go for the visual bell. Any thoughts on this? actually thinking about it some more I don't find it unnatural to have the whole ( reverted ) prefix selected after entering an illegal character ( I think this is a technique

Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

2012-02-13 Thread Albert Thuswaldner
On Mon, Feb 13, 2012 at 12:23, Noel Power nopo...@suse.com wrote: On 09/02/12 14:53, Albert Thuswaldner wrote: 2) When trying to delete text in the edit box, the last character sticks (can't be deleted). well that would seem to be because your code thinks a blank prefix is illegal, I

Re: [Libreoffice-ux-advise] [Libreoffice][PUSHED] [PATCH] Making default tab prefix name configurable in Calc

2012-02-13 Thread Noel Power
On 13/02/12 14:52, Albert Thuswaldner wrote: Yes I vote for pushing this as you suggested. It is a cheap solution for now, and done elsewhere in the code, so at least we are consistent then. Saw the ideas from Markus and Stefan regarding the range name dialog: