Re: [PATCH 1/1] pki: add support for sk-ecdsa and sk-ed25519

2020-01-23 Thread Andreas Schneider
On Tuesday, 17 December 2019 06:48:01 CET Sebastian Kinne wrote: > Hi, > > > a) Could you please split the patch and put the pki_sha256() function into > > a separate commit? I would also use uint8_t instead of unsigend char in > > pki_sha256(). > > Done, please see attached. > > > b) Could you

Re: [PATCH 1/1] pki: add support for sk-ecdsa and sk-ed25519

2019-12-16 Thread Andreas Schneider
On Wednesday, 11 December 2019 01:42:42 CET Sebastian Kinne wrote: > Hi Andreas, Hi Sebastian, > Thanks for looking at this. Apologies for not using gitlab CI from > the beginning. no problem :-) > I have attached the updated patch, rebased on master, which > has all CI passing: >

Re: [PATCH 1/1] pki: add support for sk-ecdsa and sk-ed25519

2019-12-10 Thread Andreas Schneider
On Thursday, 5 December 2019 23:35:49 CET Sebastian Kinne wrote: > This adds server-side support for the newly introduced OpenSSH > keytypes sk-ecdsa-sha2-nistp...@openssh.com and sk-ed25...@openssh.com > (including their corresponding certificates), which are backed > by U2F/FIDO2 tokens. Hello