Re: Small patch for the QNX platform

2009-01-22 Thread Ralf Wildenhues
Hello Mike, * Mike Gorchak wrote on Fri, Jan 23, 2009 at 07:09:18AM CET: > This patch adds qnx as platform which supports library version information. Thanks for your patch. First off, I have almost no knowledge of QNX, so I rely on help. As far as I can see, this patch changes the versioning s

Small patch for the QNX platform

2009-01-22 Thread Mike Gorchak
Hello! This patch adds qnx as platform which supports library version information. diff -u -r ./libtool-2.2.6/libltdl/config/ltmain.m4sh ./libtool-2.2.6-qnx/libltdl/config/ltmain.m4sh --- ./libtool-2.2.6/libltdl/config/ltmain.m4sh 2008-09-07 20:54:53.0 +0300 +++ ./libtool-2.2.6-qnx/lib

Re: [PATCH] Add tests for cwrapper with -std=c89 and -std=c99

2009-01-22 Thread Ralf Wildenhues
* Charles Wilson wrote on Fri, Jan 23, 2009 at 12:36:57AM CET: > * tests/cwrapper.at: New file. > * Makefile.am: Add tests/cwrapper.at. > --- > Ok to push? Yes, with really minor nits: > --- /dev/null > +++ b/tests/cwrapper.at > @@ -0,0 +1,81 @@ > +AT_SETUP([wrapper for uninstalled dynamically l

Re: Unify line endings in localization test

2009-01-22 Thread Ralf Wildenhues
* Peter Rosin wrote on Fri, Jan 23, 2009 at 12:01:00AM CET: > Den 2009-01-22 21:54 skrev Ralf Wildenhues: >> >> 1) create, in your own repository, a new branch pr-tests-newline-fixes >> containing this one patch, then merge this patch into both >> pr-msvc-support and into master, then push the last

[PATCH] [cygwin|mingw] cwrapper cleanups.

2009-01-22 Thread Charles Wilson
libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) [file scope]: re-organized includes and portability macros. Avoid oldnames on MINGW32 and MSVC for setmode/stat/chmod/getcwd/putenv. Declare _putenv on MINGW32 when -ansi. Use namespaced macro LT_DEBUGWRAPPER. --- This patch contains the parts

Re: [PATCH] Add tests for cwrapper with -std=c89 and -std=c99

2009-01-22 Thread Charles Wilson
Charles Wilson wrote: > + sed "s/LTCFAGS=.*/&' $restrictive_flags'/" < "$orig_LIBTOOL" > ./libtool I've already fixed this typo s/LTCFAGS/LTCFLAGS/ -- Chuck

Re: testsuite performance

2009-01-22 Thread Charles Wilson
Ralf Wildenhues wrote: > * Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET: >> [...] EVERY separate patchset requires an independent full testsuite >> run. Until recently, that was 5 hours of sitting in front of my >> computer waiting for popups, while that computer was completely usel

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-22 Thread Charles Wilson
Charles Wilson wrote: > The bits removed from this commit are attached as > "cygwin-cwrapper-cleanups.patch". Will start a new thread with these cleanups. -- Chuck

[PATCH] Add tests for cwrapper with -std=c89 and -std=c99

2009-01-22 Thread Charles Wilson
* tests/cwrapper.at: New file. * Makefile.am: Add tests/cwrapper.at. --- Ok to push? Makefile.am |1 + tests/cwrapper.at | 81 + 2 files changed, 82 insertions(+), 0 deletions(-) create mode 100644 tests/cwrapper.at diff --git a/Ma

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-22 Thread Charles Wilson
Ralf Wildenhues wrote: > Can you test those changes for me, please (TESTSUITEFLAGS='-v -d -x -k > cwrapper') > and ensure that test passes, but only with your ltmain patch applied? Works fine, with a few additional changes. I'll post as a patch on a separate thread shortly. -- Chuck

Re: Unify line endings in localization test

2009-01-22 Thread Peter Rosin
Den 2009-01-22 21:54 skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Thu, Jan 22, 2009 at 10:57:20AM CET: Something like the attached? Yes, with nits below addressed. Ok, so push to master or pr-msvc-support? This change is ok for both. However, let's move away from manual additi

Re: spaces

2009-01-22 Thread Bob Friesenhahn
On Thu, 22 Jan 2009, Tim Rice wrote: Or maybe it just seems so because those that want a change are those that will speak up. I prefer tabs. If I want the text in the 25th column it's just 3 tab keys and start typing. I don't have to count out pressing the space bar 24 times and then wondering i

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-22 Thread Ralf Wildenhues
* Charles Wilson wrote on Thu, Jan 22, 2009 at 04:14:51AM CET: > Ralf Wildenhues wrote: > > > I don't see a need to skip the test elsewhere. Here's what I'd do: > > transform $LIBTOOL to have CFLAGS and LTCFLAGS also contain -std=c89 > > -Werror. (The test would be even cleaner with a re-configu

Re: "Run tests with low max_cmd_len" on MSYS/MSVC

2009-01-22 Thread Ralf Wildenhues
* Bob Friesenhahn wrote on Thu, Jan 22, 2009 at 02:04:07AM CET: > On Wed, 21 Jan 2009, Ralf Wildenhues wrote: >> >> We may need to think about speeding up func_to_host_path, e.g., by not >> forking for arguments that don't need conversion, or by converting >> several paths with a constant amount of

Re: Unify line endings in localization test

2009-01-22 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Thu, Jan 22, 2009 at 10:57:20AM CET: >>> Something like the attached? >> >> Yes, with nits below addressed. > Ok, so push to master or pr-msvc-support? This change is ok for both. However, let's move away from manual addition of the same change to more than one

Re: spaces

2009-01-22 Thread Tim Rice
On Thu, 22 Jan 2009, Peter Rosin wrote: > Den 2009-01-21 23:13, skrev Ralf Wildenhues: > > * Charles Wilson wrote on Tue, Jan 20, 2009 at 07:29:52PM CET: > > > Bob Friesenhahn wrote: > > > > For many years I have had my editor configured to always use > > > > spaces. This ensures WYSIWYG for ever

testsuite performance (was: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.)

2009-01-22 Thread Ralf Wildenhues
* Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET: > [...] EVERY separate patchset requires an independent full testsuite > run. Until recently, that was 5 hours of sitting in front of my > computer waiting for popups, while that computer was completely useless > for anything else (100

Re: spaces

2009-01-22 Thread Peter Rosin
Den 2009-01-21 23:13, skrev Ralf Wildenhues: * Charles Wilson wrote on Tue, Jan 20, 2009 at 07:29:52PM CET: Bob Friesenhahn wrote: For many years I have had my editor configured to always use spaces. This ensures WYSIWYG for everyone involved. Agree 100%. I try to manually match whatever sp/t

Re: spaces

2009-01-22 Thread Akim Demaille
Le 19 janv. 09 à 23:38, Ralf Wildenhues a écrit : Bonjour Ralf! It is true that I have been disturbed and even annoyed by tab vs. space in some patches that gave the impression of improper indentation. Therefore, for a year or so, I am now using spaces only. But it is not sufficient for Li

Re: "Run tests with low max_cmd_len" on MSYS/MSVC

2009-01-22 Thread Peter Rosin
Den 2009-01-21 22:54, skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Wed, Jan 21, 2009 at 02:26:36AM CET: This patch together with [1] and [2] will make "Run tests with low max_cmd_len" on MSYS/MSVC behave the same as the individual tests. The patch fixes a couple more of the /abs/pat

Re: Unify line endings in localization test

2009-01-22 Thread Peter Rosin
Den 2009-01-21 23:09, skrev Ralf Wildenhues: * Peter Rosin wrote on Tue, Jan 20, 2009 at 12:34:57AM CET: Den 2009-01-19 21:35 skrev Ralf Wildenhues: This looks a bit hackish. We already have a handful of places which we fixed up in order to avoid line ending issues. This one looks hackish eno