Re: another func_append inlining regression

2010-08-09 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Mon, Aug 09, 2010 at 10:55:25PM CEST: > Note the double colon after -blibpath, which is due to a regression in > v2.2.10-40-g0da7d80 fixed with the patch below. I wish I'd never > approved that patch, this one took me so long to find ... I did a re-review

another func_append inlining regression (was: libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit)

2010-08-09 Thread Ralf Wildenhues
* Rainer Tammer wrote on Thu, Aug 05, 2010 at 09:25:14AM CEST: > The new test suite still yields many failures in comparison to 2.2.8. I assume most if not all of the regressions are due to a single issue: > # grep FAILED check.log > 38: Link order of deplibs FAILED > (

autobuild logs for Libtool (was: Next Libtool Point Release Pending)

2010-08-09 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Mon, Aug 09, 2010 at 08:42:24PM CEST: > I do think however that it's time that our testing efforts become a bit > more coordinated, to make regression tracking easier and more apparent. > Will reply to this post with more details. I think Libtool should

Re: Next Libtool Point Release Pending

2010-08-09 Thread Ralf Wildenhues
Hello, * Peter O'Gorman wrote on Mon, Aug 09, 2010 at 05:38:44PM CEST: > I don't think having a stable and development branch worked well > with 1.5.x and 2.x. It added more work for us, and did not serve our > users well - they had to wait years for the development branch's > features to make it

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-08-08 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Sun, Aug 08, 2010 at 08:50:12AM CEST: > On 7 Aug 2010, at 18:15, Ralf Wildenhues wrote: > > <http://lists.gnu.org/archive/html/libtool-patches/2010-06/msg00190.html> > I don't see that the +=/func_append substitution is causing any additiona

finish mode (was: [RFT PATCH v4 0/8] Sysroot series)

2010-08-08 Thread Ralf Wildenhues
* Charles Wilson wrote on Mon, Aug 09, 2010 at 12:14:37AM CEST: > I think --mode=finish needs to accept additional arguments that are not > directories, somehow. Maybe mode=finish needs to iterate through its > arguments, and split them into "directories" and ".la files", and then > execute two di

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-08 Thread Ralf Wildenhues
* Charles Wilson wrote on Mon, Aug 09, 2010 at 12:14:37AM CEST: > On 8/7/2010 2:36 AM, Ralf Wildenhues wrote: > > FWIW, I didn't find any more objectionable things in the rest of this > > patch series, so whenever you have something that addresses the known > > issue

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-08 Thread Ralf Wildenhues
* Charles Wilson wrote on Sun, Aug 08, 2010 at 10:40:56PM CEST: > So, you suggesting *possibly* a test where: > > if not cross-compiling > if (the native) ld supports --sysroot > 1. create a fake sysroot (contents TBD?) > 2. execute sysroot.at contents as a subtest, with >native

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-08-08 Thread Ralf Wildenhues
Hi Gary, * Ralf Wildenhues wrote on Mon, Jun 28, 2010 at 07:34:35AM CEST: > * Gary V. Vaughan wrote on Mon, Jun 28, 2010 at 01:24:39AM CEST: > > Looking through the XSI substitutions, or more correctly the bash/ksh > > func_append usage, there's room here to consiste

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-08 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Sat, Aug 07, 2010 at 06:06:14PM CEST: > configure:2917: checking whether the C compiler works > configure:2939: gcc --sysroot=/tmp/sysroot conftest.c >&5 > /usr/bin/ld: this linker was not configured to use sysroots > collect2: ld returned 1 exit status >

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-08 Thread Ralf Wildenhues
FWIW, I didn't find any more objectionable things in the rest of this patch series, so whenever you have something that addresses the known issues, I think a public branch would be fine. If merely additional testsuite items are missing, that shouldn't hold up creating a branch, only merging it. A

Re: libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit

2010-08-08 Thread Ralf Wildenhues
* Rainer Tammer wrote on Thu, Aug 05, 2010 at 09:25:14AM CEST: > I just refreshed my source from git and rerun the test suit on AIX 5.3. > 75: lt_dlopenext error messages FAILED > (lt_dlopenext.at:202) > 76: libdir of installed modules FAILED > (ltdl-libdi

Avoid unwanted error message in configure output.

2010-08-08 Thread Ralf Wildenhues
There might be no 'print' program available, and some shells (like FreeBSD sh) redirect that stderr only when you call the program from a subshell. I'm installing this to beautify configure output. The second 'print' instance should be fine, and 'printf' can be assumed to at least be present ever

Allow running pic_flag test with different shell.

2010-08-08 Thread Ralf Wildenhues
I'd like to ensure that $CONFIG_SHELL and $configure_options are used consistently throughout the testsuite. So I'm fixing the pic_flag test to also use LT_AT_CONFIGURE, after making that macro accept a second argument to specify another configure script location. Hope this is trivial enough to j

Do not call toplevel configure in non-VPATH build. (was: libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit)

2010-08-08 Thread Ralf Wildenhues
* Rainer Tammer wrote on Thu, Aug 05, 2010 at 09:25:14AM CEST: > 112. pic_flag.at:24: testing override pic_flag at configure time ... > ./pic_flag.at:36: $CC $CPPFLAGS $CFLAGS $C_pic_flag -c foo.c || exit 77 > stderr: > stdout: > ./pic_flag.at:39: grep fpic stdout stderr && exit 77 > ./pic_flag.at:

revert unwanted enabling of libtool tracing (was: libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit)

2010-08-06 Thread Ralf Wildenhues
Rainer, I'm going through things in some random order, and it will take me at least a little while to get through them all. * Rainer Tammer wrote on Thu, Aug 05, 2010 at 09:25:14AM CEST: > 38. link-order2.at:46: testing Link order of deplibs ... > libtool: compile: cc_r -qlanglvl=extc89 -g -c a0.

versioning test on AIX (was: libtool-2.2.8 on AIX 6.1)

2010-08-06 Thread Ralf Wildenhues
* Rainer Tammer wrote on Tue, Aug 03, 2010 at 09:40:23AM CEST: > On 02.08.2010 20:40, Ralf Wildenhues wrote: > > * Rainer Tammer wrote on Mon, Aug 02, 2010 at 05:40:13PM CEST: > >> 56: versioning FAILED > >> (versioning.at:169) &g

Fix AC_NO_EXECUTABLES test failure on AIX. (was: libtool-2.2.8 on AIX 6.1)

2010-08-06 Thread Ralf Wildenhues
> On 02.08.2010 20:40, Ralf Wildenhues wrote: > > * Rainer Tammer wrote on Mon, Aug 02, 2010 at 05:40:13PM CEST: > >> I just have tested libtool 2.2.8 on AIX 6.1. > >> 95: AC_NO_EXECUTABLES FAILED > >> (no-executables.at:76)

Fix ltdl-libdir test for C++ compilers.

2010-08-06 Thread Ralf Wildenhues
Pushed as obvious to let 'configure CC=g++' pass the testsuite again. Cheers, Ralf Fix ltdl-libdir test for C++ compilers. * tests/ltdl-libdir.at (libdir of installed modules): Declare module function as extern "C". diff --git a/tests/ltdl-libdir.at b/tests/ltdl-libdir.at index

Re: Next Libtool Point Release Pending

2010-08-06 Thread Ralf Wildenhues
Hello, * Gary V. Vaughan wrote on Fri, Aug 06, 2010 at 08:53:15PM CEST: > Another viable compromise might be to call the next release > 2.3.0? Maybe it's early enough to finalize a decision on this when we know a bit better which patches are in, and which features can be advertised. There is als

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-06 Thread Ralf Wildenhues
* Charles Wilson wrote on Fri, Aug 06, 2010 at 02:47:59PM CEST: > On 8/6/2010 1:19 AM, Ralf Wildenhues wrote: > > Wrt. lib and lib32, lib64, can we find out all files GCC needs by asking > > it several -print-* questions? Plus maybe optimistically searching for > > libc and

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-05 Thread Ralf Wildenhues
* Charles Wilson wrote on Fri, Aug 06, 2010 at 03:26:30AM CEST: > But a STEP in that direction is to reduce the current pain experienced > by cross compiles for $host=mingw even with --prefix=/unixish; pain > caused by the current lack of sysroot support in libtool (and some other > utilities). >

Re: Next Libtool Point Release Pending

2010-08-05 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Fri, Aug 06, 2010 at 06:01:37AM CEST: > I promised to roll a 2.2.12 release this month. But looking at the > huge progress we've made so far with Windows since 2.2.10, I'm > wondering if we would be better to roll 2.2.12 sooner rather than > later? I am sti

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-05 Thread Ralf Wildenhues
Hi Charles, thanks for the elaborate explanations. * Charles Wilson wrote on Thu, Aug 05, 2010 at 08:10:10AM CEST: > On 8/4/2010 2:15 PM, Ralf Wildenhues wrote: > > * Charles Wilson wrote on Tue, Aug 03, 2010 at 07:22:46AM CEST: [...] > >> Thanks to a quirk in window'

Re: libtool-2.2.11a on AIX 5.3 / 5.3 current git master - tests/nomode.test

2010-08-04 Thread Ralf Wildenhues
* Rainer Tammer wrote on Wed, Aug 04, 2010 at 08:41:26AM CEST: > FAIL: tests/nomode.test > > This failure is due to the following error: > > $ ./libtool > ./libtool[1591]: shift: bad number > > -> code > # save first non-option argument > nonopt="$opt"; shift > > But there is nothing in $1,

Re: Fix testsuite errors due to shell quoted parameter expansion issue.

2010-08-04 Thread Ralf Wildenhues
* Eric Blake wrote on Tue, Aug 03, 2010 at 10:55:36PM CEST: > On 08/03/2010 02:32 PM, Ralf Wildenhues wrote: > > Interesting shell unportability: > > > > $ bash -c 'f=" val" e=; echo "$e"$f' > > val > > $ ksh -c 'f=" val&quo

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-04 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Tue, Aug 03, 2010 at 07:22:46AM CEST: > For instance, suppose I have a cross compiler for mingw whose sysroot is > /usr/i686-pc-mingw32/sys-root. Suppose I want to build the gtk2 stack, > for win32. Well, that means I need to build gettext, and libiconv, and

Fix testsuite errors due to shell quoted parameter expansion issue.

2010-08-03 Thread Ralf Wildenhues
Interesting shell unportability: $ bash -c 'f=" val" e=; echo "$e"$f' val $ ksh -c 'f=" val" e=; echo "$e"$f' val ksh93, dash, zsh all do it like ksh. Is that a bug in bash? Anyway, the patch below seems to fix it, but I may want to fix the log entry to pinpoing the culprit correctly. Thanks,

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-08-03 Thread Ralf Wildenhues
* Peter Rosin wrote on Thu, Jul 01, 2010 at 07:38:45PM CEST: > Den 2010-06-28 01:24 skrev Gary V. Vaughan: > >@@ -704,15 +710,14 @@ func_mode_compile () > > save_ifs="$IFS"; IFS=',' > > for arg in $args; do > > IFS="$save_ifs" > >-func_quote_for_eval "$arg" > >-l

Re: [RFT PATCH v3 3/9] add --with-sysroot

2010-08-03 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Tue, Aug 03, 2010 at 10:04:08AM CEST: > On 08/01/2010 12:48 PM, Ralf Wildenhues wrote: > [ other packages that already use --with-sysroot ] > >I'm not sure how to address these (not even sure > >they use Libtool) except for a big sign in NEWS, and

Re: [RFT PATCH v4 6/8] emit sysrooted paths when installing .la files

2010-08-03 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Tue, Aug 03, 2010 at 09:52:54AM CEST: > On 08/01/2010 08:31 PM, Ralf Wildenhues wrote: > >Although it is fairly unlikely, I prefer not relying on :+ support, so > >please replace with 'if test -z "$lt_sysroot"...'. Two instances. >

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-02 Thread Ralf Wildenhues
* Charles Wilson wrote on Tue, Aug 03, 2010 at 07:30:28AM CEST: > On 8/2/2010 4:51 PM, Paolo Bonzini wrote: > > On Mon, Aug 2, 2010 at 22:13, Ralf Wildenhues wrote: > >> - is it intended that the = remain in the .la files after these are > >> moved to their final locat

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-02 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Mon, Aug 02, 2010 at 10:51:30PM CEST: > On Mon, Aug 2, 2010 at 22:13, Ralf Wildenhues wrote: > > > - is it intended that the = remain in the .la files after these are > > moved to their final location on the host system?  Or should > > --mode=fi

fix pic_flag test (was: [RFT PATCH v4 0/8] Sysroot series)

2010-08-02 Thread Ralf Wildenhues
* Charles Wilson wrote on Mon, Aug 02, 2010 at 05:23:28AM CEST: > The "unexpected" failure was > 112: override pic_flag at configure time FAILED (pic_flag.at:48) > which isn't a regression on cygwin. I'm pushing this patch to fix two issues with the test case. Really should've known better than t

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-02 Thread Ralf Wildenhues
More issues: - the part of ltmain starting with # Collect and forward deplibs of preopened libtool libs will source .la files but looks like it mistreats = in $dependency_libs - is it intended that the = remain in the .la files after these are moved to their final location on the host sy

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-02 Thread Ralf Wildenhues
* Charles Wilson wrote on Mon, Aug 02, 2010 at 08:00:47PM CEST: > On 8/2/2010 1:55 PM, Ralf Wildenhues wrote: > >What about the w32 users that use --prefix=C:/mingw and then cannot use > >DESTDIR because that will not concatenate? > > According to the GNU Standards, you can

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-02 Thread Ralf Wildenhues
* Charles Wilson wrote on Sun, Aug 01, 2010 at 10:04:16PM CEST: > support, use --prefix=/mingw + DESTDIR=/the-sysroot. What about the w32 users that use --prefix=C:/mingw and then cannot use DESTDIR because that will not concatenate? Also, in 'ln -sf' in the testsuite addition, the -f is non-port

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-02 Thread Ralf Wildenhues
* Charles Wilson wrote on Mon, Aug 02, 2010 at 06:15:29AM CEST: > > On 8/1/2010 2:43 PM, Ralf Wildenhues wrote: > >> I can't really give a good review of the rest without a sysrooted > >> compiler, and I don't have time to build one any more this weekend, > &

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:26PM CEST: > handle sysroot flags > add --with-sysroot > teach libtool -L= and -R= > handle sysrooted paths when reading dependencies to la files > process postdeps to include sysrooted paths > emit sysrooted paths when installing .la

Re: [RFT PATCH v4 6/8] emit sysrooted paths when installing .la files

2010-08-01 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:32PM CEST: > * libltdl/config/ltmain.m4sh (func_replace_sysroot): New. > (func_mode_link): Prepend paths in $libdir with the sysroot. Further, > replace the sysroot with = (using func_replace_sysroot) whenever > such a path is written in a .la fi

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Ralf Wildenhues
* Charles Wilson wrote on Sun, Aug 01, 2010 at 08:03:11PM CEST: > On 8/1/2010 10:47 AM, Paolo Bonzini wrote: > >> 112: override pic_flag at configure time FAILED (pic_flag.at:48) > >> > >> 112 has been discussed before and should be > >> skipped on non-ELF. > > > > Since I wasn't around, why is

Re: [RFT PATCH v4 0/8] Sysroot series

2010-08-01 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:26PM CEST: > This should, and I say "should" :) pass all tests. Thanks for the repost. Did anything change beside the discussion attached to the last patch series post? This passes for me on GNU/Linux with a non sysrooted GCC. How come there i

using ld for linking non-C code (was: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes)

2010-08-01 Thread Ralf Wildenhues
* Charles Wilson wrote on Mon, Jul 26, 2010 at 01:57:57PM CEST: > As an aside, WHY is it that libtool tries to figure out what the language > driver > does, and use ld directly, rather than just trust the language driver and use > it > to link instead? It seems that the current libtool behavior

Re: using ld for linking non-C code

2010-08-01 Thread Ralf Wildenhues
* Charles Wilson wrote on Sun, Aug 01, 2010 at 02:10:36PM CEST: > On 8/1/2010 6:46 AM, Ralf Wildenhues wrote: > > Because that allows it to set run paths to the compiler libs? > > (I don't know either.) > > Hmm. If so, what use case does that capability have? You want t

Re: [RFT PATCH v3 3/9] add --with-sysroot

2010-08-01 Thread Ralf Wildenhues
Next one: 3/9. This is a bit of a preliminary review, because I haven't read all patches and all of the discussion yet. * Paolo Bonzini wrote on Thu, Jul 29, 2010 at 01:23:16AM CEST: > * libltdl/m4/libtool.m4 (_LT_HOST_NONCANONICAL, _LT_WITH_SYSROOT): New. > (LT_SETUP): Require _LT_WITH_SYSROOT.

Re: [RFT PATCH v3 2/9] handle sysroot flags

2010-08-01 Thread Ralf Wildenhues
Hi Paolo, patch 1/9 is OK right away. Thanks! * Paolo Bonzini wrote on Thu, Jul 29, 2010 at 01:23:15AM CEST: > * libltdl/config/ltmain.m4sh (func_mode_link): Recognize --sysroot > option. This patch 2/9 is OK but please commit together with the rest. Thanks, Ralf

Re: [PATCH RFC] Add sysroot support.

2010-07-21 Thread Ralf Wildenhues
Hello, * Paolo Bonzini wrote on Wed, Jul 21, 2010 at 06:04:43PM CEST: > On 07/21/2010 03:58 PM, Charles Wilson wrote: > >On 7/8/2010 1:02 PM, Paolo Bonzini wrote: > > > >>I have another sysroot patch that seems (from a first cursory view) > >>pretty different. I'll rebase and send. > > > >Ping? >

Re: MSVC: Support for response files with $NM.

2010-07-19 Thread Ralf Wildenhues
Hi Peter, a little while ago: * Peter Rosin wrote on Wed, Jul 07, 2010 at 10:15:53PM CEST: > No problem, but I was initially very confused (and still am) by the > fact that > > make check-local TESTSUITEFLAGS='-v -d -k max_cmd_len' \ > INNER_TESTSUITEFLAGS=',export -v -d export' | grep cre

Re: MSVC: stresstest.at fixes

2010-07-19 Thread Ralf Wildenhues
Hello Peter, * Peter Rosin wrote on Sun, Jul 18, 2010 at 06:45:53PM CEST: > Next in the MSVC queue. It's getting short quickly! > > These two patches are commits > ee8c181987478752a9432a903cf7febbf761d034 > dllimport when the lib is shared and not linking with -static > > and > > 5ff2e6e4e5a1f0

Re: MSVC: Always dllimport the variable for MSVC in link-order.at

2010-07-19 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Sat, Jul 17, 2010 at 04:33:07AM CEST: > Den 2010-07-16 05:36 skrev Ralf Wildenhues: > >>The manual already says that it is not portable to export data items from > >>a libtool library. At least I think it does. > > > >The "Li

Re: MSVC: Always dllimport the variable for MSVC in link-order.at

2010-07-15 Thread Ralf Wildenhues
Hi Peter, Charles, * Peter Rosin wrote on Thu, Jul 15, 2010 at 10:39:42PM CEST: > Den 2010-07-12 07:46 skrev Ralf Wildenhues: > >* Peter Rosin wrote on Sat, Jul 10, 2010 at 10:15:09AM CEST: > >the patch looks fairly innocent at first sight, but your description > >makes me

Re: MSVC: Always dllimport the variable for MSVC in link-order.at

2010-07-11 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Sat, Jul 10, 2010 at 10:15:09AM CEST: > Next in to MSVC queue... > > This is a variation of > 95bdbc456f7c5d6d669121cf20d62a9c28bec2bf > "Always dllimport the variable for MSVC in link-order.at" > > Patch previously discussed here: > http://lists.gnu.org/archive/

Re: [SCM] GNU Libtool branch, master, updated. v2.2.10-59-g8c4dae1

2010-07-08 Thread Ralf Wildenhues
[ moving from -commit ] Hi Gary, * Gary V. Vaughan wrote on Thu, Jul 08, 2010 at 03:37:23PM CEST: > commit 8c4dae1232958c24989f31ab5b5768d00be2ef03 > Author: Gary V. Vaughan > Date: Thu Jul 8 18:47:59 2010 +0700 > > Fix a spurious trailing space and a botched merge. > > * libltdl

verbose test output (was: MSVC: Preloading in ltdl doesn't heed libname_spec.)

2010-07-08 Thread Ralf Wildenhues
Hello Bob, * Bob Friesenhahn wrote on Thu, Jul 08, 2010 at 06:34:46PM CEST: > On Tue, 6 Jul 2010, Ralf Wildenhues wrote: > >> > >>Perhaps things are not all that bad. While 35 of 110 tests fail > >>under Debian Linux, only these two extra are failing under

Re: [PATCH RFC] Add sysroot support.

2010-07-07 Thread Ralf Wildenhues
Hello Thierry, thanks for your patch and explanations. * Thierry Reding wrote on Wed, Jul 07, 2010 at 11:51:58AM CEST: > the following patch adds support for gcc's --sysroot argument to libtool. > I'll post the patch first and will reply to it, giving more details where > needed. > > I've been b

Re: MSVC: Support for response files with $NM.

2010-07-06 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Tue, Jul 06, 2010 at 11:27:31AM CEST: > Den 2010-07-06 08:07 skrev Ralf Wildenhues: > >Did you confirm that the debian/gcc case actually uses the @FILE code > >path in the testsuite (should be in the low_cmd_len tests)? > > No I didn

Re: MSVC: Preloading in ltdl doesn't heed libname_spec.

2010-07-05 Thread Ralf Wildenhues
Hi Bob, * Bob Friesenhahn wrote on Tue, Jul 06, 2010 at 06:48:56AM CEST: > On Mon, 5 Jul 2010, Bob Friesenhahn wrote: > >Yesterday's libtool was doing quite good with the tests but I am > >seeing plenty of failures now for all Unixish targets. Even Linux > >blows failures all over the place. Not

Re: MSVC: Support for response files with $NM.

2010-07-05 Thread Ralf Wildenhues
e debian/gcc case actually uses the @FILE code path in the testsuite (should be in the low_cmd_len tests)? > 2010-07-01 Ralf Wildenhues > Peter Rosin > > Support for response files with $NM. > * libltdl/m4/libtool.m4 (_LT_CMD_GLOBAL_SYMBOLS) > : New

Re: MSVC: Preloading in ltdl doesn't heed libname_spec.

2010-07-05 Thread Ralf Wildenhues
Hi Peter, any chance you could post your patches inline? Thanks. * Peter Rosin wrote on Mon, Jul 05, 2010 at 02:45:28PM CEST: > http://lists.gnu.org/archive/html/libtool-patches/2009-01/msg00152.html This is ok with nits below addressed, thanks. > Make preloading heed libname_spec. >

*_cmds file name expansion bug (was: MSVC: For MSVC, embed the manifest as a resource in the executable.)

2010-07-04 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Thu, Jul 01, 2010 at 10:30:56PM CEST: > I.e. *.exe get expanded. That doesn't happen with "*.[eE][xX][eE])": > [...] > This all seems awfully fragile. I don't know how to quote > this expression in libtool.m4 and need help. Someone please? Ouch. Our expansion co

Re: MSVC: Fix ccache test for MSVC.

2010-07-04 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Wed, Jun 30, 2010 at 09:10:02PM CEST: > Can you please cherry-pick this commit of yours into master? > "Fix ccache test for MSVC." > 563c2406deb4d5ed0ebf5faf5c8b798d52ee6ac2 Done, thanks for the reminder. > I could do it myself but I don't know what to do about t

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static (take 8?)

2010-07-04 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Sat, Jul 03, 2010 at 06:10:57PM CEST: > On 6/28/2010 2:10 AM, Ralf Wildenhues wrote: > > * Charles Wilson wrote on Mon, Jun 28, 2010 at 12:05:40AM CEST: > >> It obviously isn't SUPPOSED to be dead -- or it wouldn't be there. >

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static (take 7)

2010-07-04 Thread Ralf Wildenhues
* Charles Wilson wrote on Sun, Jul 04, 2010 at 06:15:06AM CEST: > On 6/26/2010 2:51 PM, Ralf Wildenhues wrote: > > OK. Here's my take on this: if you fix all nits I noted inline below, > > post the updated and tested patch (you decide what testing is needed), > > then

Re: [SCM] GNU Libtool branch, master, updated. v2.2.10-49-gc13532a

2010-07-04 Thread Ralf Wildenhues
[ moving from -commit to -patches, I think the former was for commits only; maybe it should have reply-to set? ] Hi Gary, Peter, * Gary V. Vaughan wrote on Sat, Jul 03, 2010 at 10:23:12AM CEST: > On 3 Jul 2010, at 15:15, Peter Rosin wrote: > >Fix typo in "Add func_append_quoted and do..." >

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-29 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Tue, Jun 29, 2010 at 08:30:43PM CEST: > On 30 Jun 2010, at 01:22, Ralf Wildenhues wrote: > > I think m4sh can simply use code like > > > > if ( eval '$smart_works' ) >/dev/null 2>&1; then > >func_foo () { smart c

Re: checking for header/library mismatch, rpath problem?

2010-06-29 Thread Ralf Wildenhues
[ please elide autoconf@ from followups, thanks ] Hi Peter, * Peter Breitenlohner wrote on Tue, Jun 29, 2010 at 10:36:32AM CEST: > Here the macro we are using in TeX Live for such tests (C and C++). Our > purpose is to test properties of libraries that can be either > (1) uninstalled libtool lib

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-29 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Tue, Jun 29, 2010 at 05:09:29PM CEST: > On 29 Jun 2010, at 21:03, Eric Blake wrote: > > Ultimately, I'd like to fix m4sh to make it easier to probe/require XSI > > support, but that will have to wait until after autoconf 2.66. > > While that might turn out to b

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

2010-06-28 Thread Ralf Wildenhues
Hello Vincent, * Ralf Wildenhues wrote on Sat, Jun 19, 2010 at 12:08:29PM CEST: > I would like to commit the patch quoted below, on the way of support for > LTO with GCC. For that, I need to know from somebody who is willing to > help out with the Windows CE port of Libtool whether the

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-28 Thread Ralf Wildenhues
Hi Eric, thanks for the suggestion. I had considered the idea for a second, but failed to see the nontrivial half. * Eric Blake wrote on Mon, Jun 28, 2010 at 02:49:40PM CEST: > tmp=${1#?} > patt= > i=2 > while test $i -lt ${#1}; do > patt="?$patt" If the parameter may be expected to be very l

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static (take 8?)

2010-06-27 Thread Ralf Wildenhues
Hello Charles, * Charles Wilson wrote on Mon, Jun 28, 2010 at 12:05:40AM CEST: > On 6/27/2010 4:43 PM, Ralf Wildenhues wrote: > > * Charles Wilson wrote on Sun, Jun 27, 2010 at 02:51:21PM CEST: > >> So...can I get a verdict? Is -dlpreopen not-an-la-file supposed to work

Re: [PATCH] Add func_append_quoted and do inline func_append substitutions.

2010-06-27 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Mon, Jun 28, 2010 at 01:24:39AM CEST: > Looking through the XSI substitutions, or more correctly the bash/ksh > func_append usage, there's room here to consistently use func_append > everywhere to make for easier maintenance... but rather than take the > additio

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static (take 8?)

2010-06-27 Thread Ralf Wildenhues
* Charles Wilson wrote on Sun, Jun 27, 2010 at 02:51:21PM CEST: > > In that case, Ralf's suggested libfile_$(transliterated implib name) > > is used, because we have the .la file available which allows that > > shortcut. The only time we need `dlltool --identify' is when > > dlpreopening a non-lib

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-27 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Sun, Jun 27, 2010 at 12:58:03PM CEST: > Okay to push? No, ${parameter:offset} and ${parameter:offset:length} are bash specific not XSI mandated. IIRC we already have a separate test for bash features that won't regress on non-bash XSI shells. Please add the test there.

Re: [SCM] GNU Libtool branch, master, updated. v2.2.10-35-gee2dde8

2010-06-27 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Sun, Jun 27, 2010 at 12:53:39PM CEST: > On 27 Jun 2010, at 17:23, Ralf Wildenhues wrote: > > The warning is almost never the last line I'd see, because for me, > > configure gets triggered by 'make' which then happily proceeds t

Re: [SCM] GNU Libtool branch, master, updated. v2.2.10-35-gee2dde8

2010-06-27 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Sun, Jun 27, 2010 at 11:52:32AM CEST: > On 27 Jun 2010, at 15:49, Ralf Wildenhues wrote: > >> --- a/libltdl/m4/libtool.m4 > >> +++ b/libltdl/m4/libtool.m4 > >> +} # XSI $1 implementation' "$cfgfile" > $cfgfile

Re: [SCM] GNU Libtool branch, master, updated. v2.2.10-35-gee2dde8

2010-06-27 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Sun, Jun 27, 2010 at 08:57:58AM CEST: > commit ee2dde86ba2f1bdc0638726c6580b96800ad4b39 > Author: Gary V. Vaughan > Date: Sun Jun 27 13:57:50 2010 +0700 > > Fix portability regressions in today's earlier changeset. > > * libltdl/m4/libtool.m4

Re: [PATCH] getopt.m4sh generated libtool option parser, and XSI improvements.

2010-06-26 Thread Ralf Wildenhues
Hi Gary, another partial review: * Gary V. Vaughan wrote on Tue, Jun 22, 2010 at 10:23:39PM CEST: > --- a/libltdl/config/general.m4sh > +++ b/libltdl/config/general.m4sh > +func_stripname () > +{ Trailing whitespace. > +case ${2} in > + .*) func_stripname_result=`$ECHO "${3}" | $SED

Re: MSVC: For MSVC, embed the manifest as a resource in the executable.

2010-06-26 Thread Ralf Wildenhues
* Peter Rosin wrote on Fri, Jun 25, 2010 at 12:20:53AM CEST: > Den 2010-06-24 20:17 skrev Ralf Wildenhues: > >I guess. Wait. Will mt be needed for programs also in packages using > >only static libraries on w32, that maybe won't (or don't want to) use > >the win3

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static (take 7)

2010-06-26 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Fri, Jun 25, 2010 at 04:57:15AM CEST: [...] > Without this patch, when --disable-static on PE/COFF platforms, > dlpreopen symbols are extracted incorrectly (because libtool uses > the same algorithm for extracting symbols from import libs as > from static libs

Re: [PATCH] getopt.m4sh generated libtool option parser, and XSI improvements.

2010-06-26 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Tue, Jun 22, 2010 at 10:23:39PM CEST: > This is the improved (and renamed) `Use getopt.m4sh to generate libtool > option parser.' patch I promised yesterday. I'm pretty happy with this, > save that even though _LT_PROG_XSI_REPLACE correctly generates sed > scripts in con

Re: [SCM] GNU Libtool branch, master, updated. v2.2.10-34-gb8dd17a

2010-06-26 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Sat, Jun 26, 2010 at 07:14:34PM CEST: > commit b8dd17aeba9ae235d189b30ce38d64ba0ff2a309 > Author: Gary V. Vaughan > Date: Sat Jun 12 00:12:09 2010 +0700 > > getopt.m4sh generated libtool option parser, and XSI improvements. > > * libltdl/m4/l

Re: [PATCH] Avoid false failures caused by filesystem interaction

2010-06-26 Thread Ralf Wildenhues
* Charles Wilson wrote on Sat, Jun 26, 2010 at 06:19:32PM CEST: > How's this: > > Avoid false failures caused by filesystem interaction > > * tests/dlloader-api.at (dlloader API) [main.c:first_open]: Use uglified > name when "opening" pseudo-module. > (dlloader API) [main.c:last_open]: Ditto. > (

Re: [PATCH] Avoid false failures caused by filesystem interaction

2010-06-26 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Fri, Jun 25, 2010 at 06:06:30AM CEST: > * tests/dlloader-api.at (main.c:first_open): Use uglified Please mention the test name in parentheses. I'm not sure how to deal with the function names within, partly I think we've just omitted all that if it's very sh

Re: MSVC: For MSVC, embed the manifest as a resource in the executable.

2010-06-24 Thread Ralf Wildenhues
* Peter Rosin wrote on Thu, Jun 24, 2010 at 02:05:23PM CEST: > Den 2010-06-23 21:02 skrev Ralf Wildenhues: > >This patch assumes that 'mt' is present, is what you think it is, and > >doesn't allow an override. On my GNU/Linux, mt is part of cpio and > &g

Re: MSVC: Add MSVC support.

2010-06-23 Thread Ralf Wildenhues
* Peter Rosin wrote on Wed, Jun 23, 2010 at 11:43:41PM CEST: > Den 2010-06-23 20:29 skrev Ralf Wildenhues: > >Please rewrite this ChangeLog entry to be a good one, mentioning the > >macros you change, the systems, compilers affected, in the format > >used otherwise in the

Re: MSVC: For MSVC, embed the manifest as a resource in the executable.

2010-06-23 Thread Ralf Wildenhues
* Peter Rosin wrote on Wed, Jun 23, 2010 at 06:12:43PM CEST: > While I didn't see any regressions, I did notice that it didn't > go too well with MSVC either. So, I dug around and found a > forgotten gem [1], and updated it to apply on top of the previous > patch. Result attached. > > So, I'm aski

Re: MSVC: For MSVC, embed the manifest as a resource in the executable.

2010-06-23 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Wed, Jun 23, 2010 at 04:47:45PM CEST: > "For MSVC, embed the manifest as a resource in the executable." > 9f550cb81d4dfe4fc8962f23a7eccb1152e5c4a5 > > and the relevant part of > > "patch msvc-documentation.patch" > 06cfce005204bb8ca212aadab38b38c0202ea04e This p

Re: MSVC: Add MSVC support.

2010-06-23 Thread Ralf Wildenhues
* Peter Rosin wrote on Wed, Jun 23, 2010 at 04:26:22PM CEST: > For this patch I'm looking for an ok to commit, but > I'm going to hold the actual commit until I have done > a couple of more things: > > * I have a similar ok for one more patch (.manifest > related, 9f550cb81d4dfe4fc8962f23a7eccb1

Re: MSVC: MSVC needs a hint to force it to compile either as C or C++.

2010-06-23 Thread Ralf Wildenhues
* Peter Rosin wrote on Wed, Jun 23, 2010 at 09:57:54AM CEST: > For those that didn't know, we have these cl options to play with: One reference: http://msdn.microsoft.com/en-us/library/19z1t1wy.aspx > My patches went with -TP/-TC. IIUC AC_FC_SRCEXT outputs FCFLAGS_ext which > can be used as this:

Re: [PATCH] [cygwin] Refactor C++ exception handling for Win32 correctness

2010-06-22 Thread Ralf Wildenhues
* Charles Wilson wrote on Wed, Jun 23, 2010 at 06:17:41AM CEST: > On 6/20/2010 1:33 PM, Ralf Wildenhues wrote: > > This can go. Please mention in the comment that not using a common lib > > represents an ODR violation (mentioning relevant terms from standards is > > helpful

Re: MSVC: MSVC needs a hint to force it to compile either as C or C++.

2010-06-22 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Tue, Jun 22, 2010 at 03:07:30PM CEST: > Den 2010-06-22 13:54 skrev Gary V. Vaughan: > >But compile_tag is never set, so the patch is a NOP! > >If this has to be fudged into the libtool tag settings by hand to > >support MSVC (or some other nefarious means I'm miss

Re: [PATCH] Use getopt.m4sh to generate libtool option parser.

2010-06-22 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Tue, Jun 22, 2010 at 07:42:27AM CEST: > On 22 Jun 2010, at 00:59, Ralf Wildenhues wrote: > > However, this makes me more cautious > > about your other patch for using this machinery for the libtool script > > itself: that is created in packages us

Re: [PATCH] Use getopt.m4sh to generate libtool option parser.

2010-06-22 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Tue, Jun 22, 2010 at 07:42:27AM CEST: > # First we set _m4go_xsi_shell if the standard shell supports XSI features > # that allow us to avoid (expensive on Windows) forks: BTW, the number of forks in libtool is even measureable for builds on GNU/Linux. The list archive

Re: [PATCH] Ensure getopts.m4sh is compatible with Autoconf-2.61 and newer.

2010-06-21 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Mon, Jun 21, 2010 at 02:56:12PM CEST: > This fixes the FreeBSD bootstrap problem. Okay to push? Okay if it passes the testsuite. However, this makes me more cautious about your other patch for using this machinery for the libtool script itself: that is create

Re: [PATCH] [cygwin] Refactor C++ exception handling for Win32 correctness

2010-06-20 Thread Ralf Wildenhues
* Charles Wilson wrote on Sun, Jun 20, 2010 at 06:59:02AM CEST: > There are ODR issues with the definition of the exception class(es). > While on linux, the code may technically be in violation, in practice > it is ok and works. But that's not OK. As much as possible, we want our tests to abide b

Fix clean mode for HP-UX 11.31 sh.

2010-06-20 Thread Ralf Wildenhues
This fixes a test failure on ia64-hp-hpux11.31 with /bin/sh, and a couple of other systems. Pushing to master. The underlying issue here is that this shell's case doesn't like parameter expansion of an empty variable within double-quotes in a case pattern, as in $ empty= foo=bar; case " $foo "

Re: [PATCH] [cygwin] Fix segfault in C++ exception handling test

2010-06-20 Thread Ralf Wildenhues
* Charles Wilson wrote on Sat, Jun 19, 2010 at 10:29:45PM CEST: > * tests/exceptions.at (main.cpp:exceptions_in_module): > Move dlclose outside catch block; otherwise __cxa_end_catch > (part of the cygwin g++ ABI) accesses pointers to data inside > unloaded DLL. This is a platform ABI-specific bug,

Fix flags test failure when ld is used as linker.

2010-06-19 Thread Ralf Wildenhues
The flags.at tests were still not right. Gosh. I tested this one on GNU/Linux, without and with --disable-shared, and on HP-UX 10.20 (which uses $LD for linking). I'm still afraid I might have overlooked one case, so I'll appreciate a look over but will otherwise apply in a couple of days. Than

Fix srcdir computation for manual runs of old tests.

2010-06-19 Thread Ralf Wildenhues
When we moved to nonrecursive makefile setup in Libtool, running the old testsuite tests manually ceased to work: $ VERBOSE=yes ../libtool/tests/sh.test ; echo $? sh.test: === Running sh.test /bin/grep: /tmp/libtool/tests/libltdl/config/ltmain.m4sh: No such file or directory [...] 1 I'm pushing

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

2010-06-19 Thread Ralf Wildenhues
ttp://thread.gmane.org/gmane.comp.gnu.libtool.general/10794/focus=9769>. Thanks, Ralf * Ralf Wildenhues wrote on Sun, Apr 04, 2010 at 10:56:47AM CEST: > On some systems, lt_preloaded_symbols may not be declared > const due to relocation issues. C99 requires qualification to > match

<    1   2   3   4   5   6   7   8   9   10   >