Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-02-21 Thread Charles Wilson
Ralf Wildenhues wrote: > * Charles Wilson wrote on Sun, Feb 21, 2010 at 06:34:02AM CET: >> So, open issues, to be addressed if necessary in additional patches: >> 1) "(func) ..." ---> '"(%s) ...", __func__' ? >> 2) chmod in cwrapper.at? > > Naah, ignore both. Thanks. > > strerror(errno) can retu

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-02-21 Thread Ralf Wildenhues
* Charles Wilson wrote on Sun, Feb 21, 2010 at 06:34:02AM CET: > So, open issues, to be addressed if necessary in additional patches: > 1) "(func) ..." ---> '"(%s) ...", __func__' ? > 2) chmod in cwrapper.at? Naah, ignore both. Thanks. strerror(errno) can return NULL for unknown errors on some s

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-02-20 Thread Charles Wilson
Ralf Wildenhues wrote: > This patch is ok to commit with nits below addressed as you see fit; > no need for further review. Thanks for the review. > >> --- a/libltdl/config/ltmain.m4sh >> +++ b/libltdl/config/ltmain.m4sh >> >> -const char *program_name = NULL; >> +const char *program_name = "

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-02-20 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Fri, Feb 19, 2010 at 03:48:40AM CET: > Enable runtime cwrapper debugging; add tests > * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src): > Update comments. Initialize program_name. Eliminate _LENGTH > variables for string constan

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-02-18 Thread Charles Wilson
Squashed together and reposted from: http://lists.gnu.org/archive/html/libtool-patches/2009-12/msg00014.html and followon: http://lists.gnu.org/archive/html/libtool-patches/2010-01/msg00047.html This (combination) was the first of the two patches whose /first/ 72hour rule invocation was here: htt

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-02-14 Thread Charles Wilson
Bob Friesenhahn wrote: > Within the bounds of technical recommendations/comments made already (by > Ralf and perhaps others), I recommend that you commit your log-jammed > Cygwin patches according to the 72 hour rule. Otherwise it is unlikely > that there will be any forward progress. If anything

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-02-14 Thread Bob Friesenhahn
Charles, Within the bounds of technical recommendations/comments made already (by Ralf and perhaps others), I recommend that you commit your log-jammed Cygwin patches according to the 72 hour rule. Otherwise it is unlikely that there will be any forward progress. If anything becomes broken

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-02-14 Thread Charles Wilson
Charles Wilson wrote: > Charles Wilson wrote: >> Charles Wilson wrote: >>> Ralf Wildenhues wrote: * Charles Wilson wrote on Mon, Jun 22, 2009 at 03:50:42AM CEST: > * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) > [ltwrapper_debugprintf]: Renamed to... I think functions s

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-01-29 Thread Charles Wilson
Charles Wilson wrote: > Charles Wilson wrote: >> Ralf Wildenhues wrote: >>> * Charles Wilson wrote on Mon, Jun 22, 2009 at 03:50:42AM CEST: * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) [ltwrapper_debugprintf]: Renamed to... >>> I think functions should still be put in (parens)

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-01-15 Thread Charles Wilson
Charles Wilson wrote: > [*] Testing with these two patches, plus the two shell wrapper patches > referenced above, plus the wrapper documentation patch: > http://lists.gnu.org/archive/html/libtool-patches/2009-12/msg00016.html > > ... > actually, the linux test already finished. Results: > Old: Al

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-01-15 Thread Charles Wilson
Charles Wilson wrote: > Ralf Wildenhues wrote: >> * Charles Wilson wrote on Mon, Jun 22, 2009 at 03:50:42AM CEST: >>> * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) >>> [ltwrapper_debugprintf]: Renamed to... >> I think functions should still be put in (parens) in the ChangeLog >> entry, n

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-01-12 Thread Ralf Wildenhues
* Charles Wilson wrote on Mon, Jan 11, 2010 at 03:54:01AM CET: > Ralf Wildenhues wrote: > > That's not how these ancient shells work. > [snip long explanation] > > Oh, that's just...evil. How could that EVER have been expected to work > properly, except in the most trivial of scripts? Good quest

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-01-10 Thread Charles Wilson
Ralf Wildenhues wrote: > That's not how these ancient shells work. [snip long explanation] Oh, that's just...evil. How could that EVER have been expected to work properly, except in the most trivial of scripts? >> Oh yeah...ping? Is the HPUX problem a blocker for these three patches, > > No. G

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-01-10 Thread Charles Wilson
Ralf Wildenhues wrote: > * Charles Wilson wrote on Mon, Jun 22, 2009 at 03:50:42AM CEST: >> * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) >> [ltwrapper_debugprintf]: Renamed to... > > I think functions should still be put in (parens) in the ChangeLog > entry, not in [brackets], accordin

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-01-10 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Mon, Jun 22, 2009 at 03:50:42AM CEST: > * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) > [ltwrapper_debugprintf]: Renamed to... I think functions should still be put in (parens) in the ChangeLog entry, not in [brackets], according to GCS. > [lt_deb

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2010-01-10 Thread Ralf Wildenhues
Hello Charles, * Charles Wilson wrote on Wed, Dec 23, 2009 at 09:28:49PM CET: > Ralf Wildenhues wrote: > > * Charles Wilson wrote on Mon, Dec 14, 2009 at 06:47:10PM CET: > >> Finally, it's not clear in your message: are you saying that *existing* > >> win32 "changes" currently in master are causin

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-12-23 Thread Charles Wilson
Ralf Wildenhues wrote: > * Charles Wilson wrote on Mon, Dec 14, 2009 at 06:47:10PM CET: >> Finally, it's not clear in your message: are you saying that *existing* >> win32 "changes" currently in master are causing problems on HP-UX, or >> just that some of the win32 changes /in this patch/ are caus

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-12-15 Thread Tim Rice
Hi Chuck, On Tue, 15 Dec 2009, Charles Wilson wrote: > On Mon, 14 Dec 2009 15:06 -0800, "Tim Rice" wrote: > > I would strongly advocate testing at least one System V based system. > > Non bash shells sometimes have issues. > > During the release process, certainly testing on as many supported >

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-12-15 Thread Charles Wilson
On Mon, 14 Dec 2009 15:06 -0800, "Tim Rice" wrote: > On Mon, 14 Dec 2009, Charles Wilson wrote: > > > Two related lines of inquiry: > > 1) Under *normal* development rules -- e.g not a pre-release > > bug-fix-only phase, nor a not-quite-pre-release code slush like (I > > think) we're in right now,

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-12-14 Thread Tim Rice
On Mon, 14 Dec 2009, Charles Wilson wrote: > Two related lines of inquiry: > 1) Under *normal* development rules -- e.g not a pre-release > bug-fix-only phase, nor a not-quite-pre-release code slush like (I > think) we're in right now, for 2.2.8 -- surely you aren't suggesting > that EVERY contrib

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-12-14 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Mon, Dec 14, 2009 at 07:37:31PM CET: > * Charles Wilson wrote on Mon, Dec 14, 2009 at 06:47:10PM CET: > > Finally, it's not clear in your message: are you saying that *existing* > > win32 "changes" currently in master are causing problems on HP-UX, or > > just that some o

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-12-14 Thread Ralf Wildenhues
* Charles Wilson wrote on Mon, Dec 14, 2009 at 06:47:10PM CET: > > Two related lines of inquiry: > 1) Under *normal* development rules -- e.g not a pre-release > bug-fix-only phase, nor a not-quite-pre-release code slush like (I > think) we're in right now, for 2.2.8 -- surely you aren't suggestin

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-12-14 Thread Bob Friesenhahn
On Mon, 14 Dec 2009, Charles Wilson wrote: Two related lines of inquiry: 1) Under *normal* development rules -- e.g not a pre-release bug-fix-only phase, nor a not-quite-pre-release code slush like (I think) we're in right now, for 2.2.8 -- surely you aren't suggesting that EVERY contribution mu

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-12-14 Thread Charles Wilson
On Sun, 13 Dec 2009 11:23 +0100, "Ralf Wildenhues" wrote: > * Charles Wilson wrote on Sat, Dec 12, 2009 at 07:57:02PM CET: > > > > This has been in the cygwin distro for five months (over a year, in one > > form or another), and heavily tested. > > Just to let you know, I am currently trying to s

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-12-13 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Sat, Dec 12, 2009 at 07:57:02PM CET: > > This has been in the cygwin distro for five months (over a year, in one > form or another), and heavily tested. Just to let you know, I am currently trying to sort out build regressions on HP-UX systems, which are cau

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-12-12 Thread Charles Wilson
Charles Wilson wrote: > This one, I think is OK for pre-2.2.8 -- what do you guys think? > OK to push? I forgot: the mingw libtool distribution includes this patch, but with the following small change. Obviously I'd merge these two together and commit as one. -- Chuck diff -u a/tests/cwrapper

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-12-12 Thread Charles Wilson
Charles Wilson wrote: > * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) > [ltwrapper_debugprintf]: Renamed to... > [lt_debugprintf]: this. Only print messages if lt_debug != 0. > [file scope]: Add constants and variables to support new --lt-debug > option. Remove LTWRAPPER_DEBUGPRINTF macr

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-07-12 Thread Charles Wilson
Charles Wilson wrote: >> I'll follow up this patch with another to add "support" for >> --lt-debug >> --lt-dump-script >> to the shell wrapper. --lt-debug will do very little other than $ECHO >> the full path to the program executable and its arguments. >> --lt-dump-script will simply { cat $0

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-07-11 Thread Charles Wilson
Charles Wilson wrote: > Charles Wilson wrote: >> * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) >> [ltwrapper_debugprintf]: Renamed to... >> [lt_debugprintf]: this. Only print messages if lt_debug != 0. >> [file scope]: Add constants and variables to support new --lt-debug >> option. Remo

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-06-27 Thread Charles Wilson
Charles Wilson wrote: > * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) > [ltwrapper_debugprintf]: Renamed to... > [lt_debugprintf]: this. Only print messages if lt_debug != 0. > [file scope]: Add constants and variables to support new --lt-debug > option. Remove LTWRAPPER_DEBUGPRINTF macr

[PATCH] Enable runtime cwrapper debugging; add tests

2009-06-21 Thread Charles Wilson
* libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) [ltwrapper_debugprintf]: Renamed to... [lt_debugprintf]: this. Only print messages if lt_debug != 0. [file scope]: Add constants and variables to support new --lt-debug option. Remove LTWRAPPER_DEBUGPRINTF macro. [main]: Consolidate option pa