Re: [Libusbx-devel] [PATCH] Add HID capability detection for all backends

2013-03-19 Thread Xiaofan Chen
On Wed, Mar 20, 2013 at 6:43 AM, Pete Batard wrote: > Oh, and for what is worth, I think over at libusb we discussed the idea > of having a _detach() call that did nothing but returned success on > Windows, to avoid #ifdefs, but that idea was rejected at the time. I > think I proposed a patch for

Re: [Libusbx-devel] [PATCH] Add HID capability detection for all backends

2013-03-19 Thread Pete Batard
Oh, and for what is worth, I think over at libusb we discussed the idea of having a _detach() call that did nothing but returned success on Windows, to avoid #ifdefs, but that idea was rejected at the time. I think I proposed a patch for that actually. As long as we have a detach call in libusb

Re: [Libusbx-devel] [PATCH] Add HID capability detection for all backends

2013-03-19 Thread Pete Batard
On 2013.03.19 22:11, Ludovic Rousseau wrote: > What would a real program look like? Not sure about "real", but our own xusb sample has it, since, of course, we want it to access HID devices on both Linux and Windows: https://github.com/libusbx/libusbx/blob/master/examples/xusb.c#L836 Regards, /

Re: [Libusbx-devel] [PATCH] Add HID capability detection for all backends

2013-03-19 Thread Ludovic Rousseau
Hello, 2013/3/19 Pete Batard : > So once more, LIBUSBX_HAS_HID_ACCESS is only meant to answer the > question: "Can libusbx access an HID device on this platform?". No less. > _NO MORE_. I am not sure how this capability is supposed to be used in a cross-platform program. Do we need to have platef

Re: [Libusbx-devel] [PATCH] Add HID capability detection for all backends

2013-03-19 Thread Pete Batard
On 2013.03.19 18:07, Tim Roberts wrote: > I'm not sure I buy that argument. I don't by that argument, but not for the same reason as Tim (though I think that's a valid point on its own). But let's me first start by the most worrying statement of Hans' reply: On 2013.03.19 07:41, Hans de Goede w

Re: [Libusbx-devel] [PATCH] Add HID capability detection for all backends

2013-03-19 Thread Tim Roberts
Hans de Goede wrote: > > Let me try to explain why, just as there is a huge difference between > internal functionality and something only available when doing extra > stuff outside of libusbx, there is a huge difference between being > able to access a device without detaching the driver, and acce

Re: [Libusbx-devel] [PATCH] Add HID capability detection for all backends

2013-03-19 Thread Hans de Goede
Hi, On 03/18/2013 09:24 PM, Pete Batard wrote: > On 2013.03.18 10:32, Hans de Goede wrote: >> Hmm, I'm not sure about claiming LIBUSB_CAP_HAS_HID_ACCESS in Linux, I >> would rather not >> actually, as on Linux there is no special hid code. > > This is not what the capability is about. See below. >