Re: [Libusbx-devel] Coverity: static analysis of libusbx

2013-08-26 Thread Nathan Hjelm
On Aug 26, 2013, at 8:18 PM, Nathan Hjelm wrote: > > On Aug 26, 2013, at 5:12 PM, Sean McBride wrote: > >> On Mon, 26 Aug 2013 22:33:10 +, Nathan Hjelm said: >> >>> Hmm, the conclusion is wrong. If ret > -1 the cached_device is always >>> not NULL. I should probably change: >>> >>> if (

Re: [Libusbx-devel] Reading device descriptor and config descriptor from WinUsb

2013-08-26 Thread Juan Lang
2013/8/26 Xiaofan Chen > On Sat, Aug 24, 2013 at 10:30 AM, Juan Lang wrote: > > It's not as scary as it looks, but I thought I'd first send one big > patch to > > show where it's headed. If it's easier I can break it up into several > > different patches, something like: > > 1. Move initializing

Re: [Libusbx-devel] Coverity: static analysis of libusbx

2013-08-26 Thread Nathan Hjelm
On Aug 26, 2013, at 5:12 PM, Sean McBride wrote: > On Mon, 26 Aug 2013 22:33:10 +, Nathan Hjelm said: > >> Hmm, the conclusion is wrong. If ret > -1 the cached_device is always >> not NULL. I should probably change: >> >> if (ret < 0 || (cached_device && !cached_device->can_enumerate)) { >

Re: [Libusbx-devel] Reading device descriptor and config descriptor from WinUsb

2013-08-26 Thread Xiaofan Chen
On Sat, Aug 24, 2013 at 10:30 AM, Juan Lang wrote: > It's not as scary as it looks, but I thought I'd first send one big patch to > show where it's headed. If it's easier I can break it up into several > different patches, something like: > 1. Move initializing a device from a USB_NODE_CONNECTION_

Re: [Libusbx-devel] Need help with openbsd backend (was Re: Doing a libusbx 1.0.17-rc1 release)

2013-08-26 Thread Xiaofan Chen
On Mon, Aug 26, 2013 at 7:32 PM, Martin Pieuchot wrote: > But assuming there are some people crazy enough to build their > own libusbx on OpenBSD for real use instead of using the official > packages, I would bet they are running -current. OpenBSD doesn't > have a "development branch", instead we

Re: [Libusbx-devel] Coverity: static analysis of libusbx

2013-08-26 Thread Sean McBride
On Mon, 26 Aug 2013 22:33:10 +, Nathan Hjelm said: >Hmm, the conclusion is wrong. If ret > -1 the cached_device is always >not NULL. I should probably change: > >if (ret < 0 || (cached_device && !cached_device->can_enumerate)) { > >to: > >if (ret < 0 || !cached_device->can_enumerate) { > >to r

Re: [Libusbx-devel] Coverity: static analysis of libusbx

2013-08-26 Thread Nathan Hjelm
On Aug 26, 2013, at 04:22 PM, Sean McBride wrote:On Mon, 26 Aug 2013 20:47:33 +0200, Ludovic Rousseau said: I use Coverity as _another_ static analysis tool for my free softwareprojects. The clang static analyzer also gives one error in current git master: libusbx/libusb/os/darwin_usb.c:533:34: A

[Libusbx-devel] Coverity: static analysis of libusbx

2013-08-26 Thread Ludovic Rousseau
Hello, I registered the libusbx project at Coverity scan [1]. Coverity found 18 "problems". I exported a CSV list (attached) but the line numbers are missing so the results are not really usable in this form. If you are interested by the results it is best to create an account on Coverity and ask

Re: [Libusbx-devel] Need help with openbsd backend (was Re: Doing a libusbx 1.0.17-rc1 release)

2013-08-26 Thread Martin Pieuchot
Hello, On 26/08/13(Mon) 14:08, Hans de Goede wrote: > > Ok, since you are the most knowledgeably person on OpenBSD I'm going > to trust you on this. What I'll do is add a note to the changelog > with this in there: > > * Update OpenBSD backend with various bug-fixes and improvements, > note that

Re: [Libusbx-devel] Need help with openbsd backend (was Re: Doing a libusbx 1.0.17-rc1 release)

2013-08-26 Thread Hans de Goede
Hi, On 08/26/2013 01:32 PM, Martin Pieuchot wrote: > On 24/08/13(Sat) 12:01, Hans de Goede wrote: >> After adding your openbsd backend improvements patch, libusb >> no longer builds on released openbsd versions, see below, > > Indeed these ioctls were added just after 5.3, so if you only plan > to

Re: [Libusbx-devel] Need help with openbsd backend (was Re: Doing a libusbx 1.0.17-rc1 release)

2013-08-26 Thread Martin Pieuchot
On 24/08/13(Sat) 12:01, Hans de Goede wrote: > After adding your openbsd backend improvements patch, libusb > no longer builds on released openbsd versions, see below, Indeed these ioctls were added just after 5.3, so if you only plan to test the backend on a released version you'll have to wait f

Re: [Libusbx-devel] Doing a libusbx 1.0.17-rc1 release

2013-08-26 Thread Hans de Goede
Hi, On 08/25/2013 04:13 AM, Xiaofan Chen wrote: > On Fri, Aug 23, 2013 at 9:36 PM, Xiaofan Chen wrote: >>> As per OpenBSD changelog, USB_DEVICE_GET_DDESC, >>> USB_DEVICE_GET_FDESC and USB_DEVICE_GET_FDESC >>> are new IOCTLs added to OpenBSD-Current beyong the current >>> stable 5.3 release. >> >>