Hi, On 08/26/2013 01:32 PM, Martin Pieuchot wrote: > On 24/08/13(Sat) 12:01, Hans de Goede wrote: >> After adding your openbsd backend improvements patch, libusb >> no longer builds on released openbsd versions, see below, > > Indeed these ioctls were added just after 5.3, so if you only plan > to test the backend on a released version you'll have to wait for > 5.4 in November. > >> Can you write a patch with some #ifdef-s in there to check for >> the openbsd version, so that it will build on openbsd 5.2 and >> higher? > > I see little benefit of doing this. Mainly because I see the > libusbx as a dependency for other applications present in our > packages and ports system [0]. I'm not sure if you are familiar > with OpenBSD packaging policy, but in our case what matters is > that previous supported OpenBSD releases come with a package of > libusb and that we currently don't directly provide newer > packages for such releases. The only things that we "backport" > are security fixes. > >> We cannot ship this code as is, as we cannot expect openbsd >> users who want to use the latest libusb releases to be running >> the development branch of openbsd. > > I'm not sure to understand what kind of OpenBSD users you are > talking about. > > From my point of view, non-developer users using OpenBSD stick > with released packages, they shouldn't have to compile anything. > > If some users are doing some userland USB development on OpenBSD > releases (I would be really happy the hear about then btw!), I > would bet they are using the official packages because I see no > advantage in compiling their own non-widely tested, non-patched, > libusbx. The reason why I asked for this diff to be integrated > is to reduce the diffs we have since mid-2012 [1]! > > But assuming there are some people crazy enough to build their > own libusbx on OpenBSD for real use instead of using the official > packages, I would bet they are running -current. OpenBSD doesn't > have a "development branch", instead we have a "trunk" which must > always be stable [1]. That's why we provide almost daily snapshots > suitable for almost any uses and generally people doing development > on OpenBSD run them. > > So if you were worried about the people that might try the last > libusbx release on stable OpenBSD releases, I hope that my point > of view, as one of the USB developers in OpenBSD, helped you to > understand that there's almost certainly no such risk ;) > > But if you want to be really paranoid, we can either add a note > in the ChangLog or a configure check for the new ioctls.
Ok, since you are the most knowledgeably person on OpenBSD I'm going to trust you on this. What I'll do is add a note to the changelog with this in there: * Update OpenBSD backend with various bug-fixes and improvements, note that using this libusbx version on OpenBSD requires using OpenBSD-current. Users who are not on -current are advised to stay with the libusb shipped with OpenBSD (mpieuchot) Improvements to the text, esp. the "various bug-fixes and improvements" are welcome. Note I plan to do a libusb-1.0.17-rc1 release today, with something like this text in its ChangeLog later today. Regards, Hans ------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
