Re: [Libusbx-devel] [PATCH 1/3] libusb: Add auto-detach-kernel-driver functionality

2013-06-19 Thread Hans de Goede
Hi, Thanks for the review! On 06/18/2013 11:49 PM, Pete Batard wrote: > Nothing much to report on that one. > > On 2013.06.13 21:39, Hans de Goede wrote: >> + * dev is 0, otherwise the kernel driver will be re-attached when >> you >> + * release the interface(s)! > > I would just avoid exclamati

Re: [Libusbx-devel] [PATCH 1/3] libusb: Add auto-detach-kernel-driver functionality

2013-06-18 Thread Pete Batard
Nothing much to report on that one. On 2013.06.13 21:39, Hans de Goede wrote: > + * dev is 0, otherwise the kernel driver will be re-attached when > you > + * release the interface(s)! I would just avoid exclamation marks in comment (which is something I removed from the strerror() patch on com

[Libusbx-devel] [PATCH 1/3] libusb: Add auto-detach-kernel-driver functionality

2013-06-13 Thread Hans de Goede
Add auto-detach-kernel-driver functionality, and a libusb_set_auto_detach_kernel_driver() function. Note that I went with a libusb_set_auto_detach_kernel_driver() function, rather then with a libusb_enable_auto_detach_kernel_driver(), so that apps can also disable it again. This is necessary to ha