Re: [Libusbx-devel] Windows warning fixes

2013-02-20 Thread Pete Batard
On 2013.02.20 14:45, Xiaofan Chen wrote: > Still see one warning under MinGW-w64 with default compiler option > (./autogen.sh --prefix=/mingw; make). I did mention that I saw it on cygwin with default options, and that I was planning to look into it when I had a chance. In case it wasn't clear,

Re: [Libusbx-devel] Windows warning fixes

2013-02-20 Thread Xiaofan Chen
On Tue, Feb 19, 2013 at 3:33 AM, Ludovic Rousseau wrote: > 2013/2/17 Pete Batard : >> On 2013.02.16 17:50, Ludovic Rousseau wrote: > >>> ../../libusb/os/threads_windows.c:137:1: warning: '__inline' is not at >>> beginning of declaration [-Wold-style-declaration] >> >> The compiler's probably right

Re: [Libusbx-devel] Windows warning fixes

2013-02-18 Thread Pete Batard
On 2013.02.18 23:02, Sean McBride wrote: > gcc's -Wmissing-field-initializers is overly noisy; good discussion here: > Thanks Sean. Looks like this is a gcc acknowledged bug, th

Re: [Libusbx-devel] Windows warning fixes

2013-02-18 Thread Sean McBride
On Mon, 18 Feb 2013 22:40:23 +, Pete Batard said: >> You should have a value for _each_ field to initialize. >> >> A correct patch is something like: >> - SP_DEVINFO_DATA dev_info_data = { 0 }; >> + SP_DEVINFO_DATA dev_info_data = { 0, {0, 0, 0, {0, 0, 0, 0, 0, 0, >> 0, 0}}, 0, 0 }; > >I'm

Re: [Libusbx-devel] Windows warning fixes

2013-02-18 Thread Pete Batard
On 2013.02.18 18:56, Ludovic Rousseau wrote: >> Of course, you're free to push them yourself if you feel like it. > > Ok. Pushed now. Alright, thanks. And for the subsequent commits as well. Note that I just pushed a fix for broken compilation on WDK (that was broken ever since WinCE integration

Re: [Libusbx-devel] Windows warning fixes

2013-02-18 Thread Ludovic Rousseau
2013/2/17 Pete Batard : > On 2013.02.16 17:50, Ludovic Rousseau wrote: >> ../../libusb/os/threads_windows.c:137:1: warning: '__inline' is not at >> beginning of declaration [-Wold-style-declaration] > > The compiler's probably right on that one. Easy to fix. Fixed in https://github.com/libusbx/l

Re: [Libusbx-devel] Windows warning fixes

2013-02-18 Thread Ludovic Rousseau
2013/2/17 Pete Batard : > On 2013.02.16 17:50, Ludovic Rousseau wrote: >> I installed MinGW on Debian. And the compiler reported warnings and >> potential bugs. > > Because you're using pedantic options, right? No. Not yet :-) > Can you provide the extra compiler options are you using? $ echo $C

Re: [Libusbx-devel] Windows warning fixes

2013-02-17 Thread Pete Batard
On 2013.02.16 17:50, Ludovic Rousseau wrote: > I installed MinGW on Debian. And the compiler reported warnings and > potential bugs. Because you're using pedantic options, right? Can you provide the extra compiler options are you using? > I fixed most of the warnings. See the pull request [1]. G

[Libusbx-devel] Windows warning fixes

2013-02-16 Thread Ludovic Rousseau
Hello, I installed MinGW on Debian. And the compiler reported warnings and potential bugs. I fixed most of the warnings. See the pull request [1]. The remaining warnings are: ../../libusb/os/windows_usb.c: In function 'windows_init': ../../libusb/os/windows_usb.c:879:18: warning: cast from functi