Re: [Libusbx-devel] [PATCH 1/2] Core: Fix Clang warnings

2012-06-14 Thread Pete Batard
On 2012.06.13 19:19, Sean McBride wrote: > Have you looked at the HTML that scan-build generates? Good point. Now that looked at it more closely, it is possible to fix the issue at core.c:647 by switching a malloc to a calloc. What happens there is that Clang sees a path where we may have a devl

Re: [Libusbx-devel] [PATCH 1/2] Core: Fix Clang warnings

2012-06-14 Thread Sean McBride
On Wed, 13 Jun 2012 14:03:22 +0100, Pete Batard said: >Now, I am still getting the following warnings, that look like false >positives, but that I have no clue how to address yet. > >--- >$ scan-build make >make all-recursiv

Re: [Libusbx-devel] [PATCH 1/2] Core: Fix Clang warnings v2

2012-06-14 Thread Xiaofan Chen
On Thu, Jun 14, 2012 at 7:50 PM, Pete Batard wrote: > The 2 Clang patches as well as the speed designation patch suggested by > Xiaofan have now been pushed to git. > > As changes were applied to core, if you have an opportunity to test > before release, please do so. These warning fixes should be

Re: [Libusbx-devel] [PATCH 1/2] Core: Fix Clang warnings v2

2012-06-14 Thread Pete Batard
The 2 Clang patches as well as the speed designation patch suggested by Xiaofan have now been pushed to git. As changes were applied to core, if you have an opportunity to test before release, please do so. These warning fixes should be fairly safe, but you never know... Official v1.0.12 relea