Re: [Libusbx-devel] Move #pragma warning(disable:4200) from config.h to libusb.h?

2013-01-11 Thread Ludovic Rousseau
2013/1/10 Jie Zhang : > Hi, Hello, > I think we should move this #pragma closer to the place where it's > used. Otherwise user program will need the same thing to disable the > warning. Move #pragma from msvc/config.h to libusb/libusb.h ? I am against this change. The #pragma is for Windows so s

[Libusbx-devel] What about pull request #59: Fix compiler warnings when building with CLANG_WARN_IMPLICIT_SIGN_CONVERSION = YES;

2013-01-11 Thread Ludovic Rousseau
Hello, I proposed some minor changes in [1] 3 months ago. I got no comments. The idea is to fix compiler warnings. The changes should be harmless. I can rebase the changes against master is requested. May I merge the changes myself? Bye [1] https://github.com/libusbx/libusbx/pull/59 -- Dr. L

Re: [Libusbx-devel] Isochronous test problem

2013-01-11 Thread Wander Lairson Costa
2013/1/11 Xiaofan Chen : > On Fri, Jan 11, 2013 at 8:46 AM, Wander Lairson Costa > wrote: >> The successfully transfer is the write one, the failed one is the read >> request. Source code for my test app can be found at [1]. The firmware >> code [2] is a customized version of the libusbK benchmark

Re: [Libusbx-devel] Isochronous test problem

2013-01-11 Thread Wander Lairson Costa
2013/1/11 Tim Roberts : > Wander Lairson Costa wrote: >> I am trying to do a isochronous loop transfer, I can write the data >> but I am getting an error when trying to read it. Following are the >> logs: > Hi Tim, First of all, thanks for the explanation. > Isochronous endpoints have peculiar r

Re: [Libusbx-devel] Move #pragma warning(disable:4200) from config.h to libusb.h?

2013-01-11 Thread Jie Zhang
On Fri, Jan 11, 2013 at 4:00 AM, Ludovic Rousseau wrote: > 2013/1/10 Jie Zhang : >> I think we should move this #pragma closer to the place where it's >> used. Otherwise user program will need the same thing to disable the >> warning. > > Move #pragma from msvc/config.h to libusb/libusb.h ? > I am

Re: [Libusbx-devel] What about pull request #59: Fix compiler warnings when building with CLANG_WARN_IMPLICIT_SIGN_CONVERSION = YES;

2013-01-11 Thread Pete Batard
On 2013.01.11 09:03, Ludovic Rousseau wrote: > I can rebase the changes against master is requested. > May I merge the changes myself? Please don't for now. I need to run - will elaborate when I'm back. Regards, /Pete ---

Re: [Libusbx-devel] What about pull request #59: Fix compiler warnings when building with CLANG_WARN_IMPLICIT_SIGN_CONVERSION = YES;

2013-01-11 Thread Pete Batard
OK, Just to elaborate, I'd rather you don't merge the changes right now, as we're dealing with the WinCE integration, and I told Toby earlier that I would keep mainline frozen until we were through with it. Now if Toby is okay with rebasing off your changes, I don't really mind if you push the

Re: [Libusbx-devel] Move #pragma warning(disable:4200) from config.h to libusb.h?

2013-01-11 Thread Pete Batard
Hi Jie, On 2013.01.11 13:42, Jie Zhang wrote: >> Move #pragma from msvc/config.h to libusb/libusb.h ? >> I am against this change. The #pragma is for Windows so should be in a >> Windows only file. >> > If msvc/config.h is installed and included automatically in libusb.h > when compiled by MSVC, I

Re: [Libusbx-devel] libusb_claim_interface failing on OSX 10.8

2013-01-11 Thread Xiaofan Chen
On Fri, Jan 11, 2013 at 11:17 PM, Trey Harrison wrote: > Greetings, > > I've got a usb dongle type device which I have used for a few years > without problems on OSX 10.6 and 10.7. Even machines upgraded from > 10.7 to 10.8 seem to be fine. But brand new fresh machines running > 10.8 fail work wit

Re: [Libusbx-devel] Move #pragma warning(disable:4200) from config.h to libusb.h?

2013-01-11 Thread Jie Zhang
On Fri, Jan 11, 2013 at 7:27 PM, Pete Batard wrote: > Hi Jie, > > On 2013.01.11 13:42, Jie Zhang wrote: >>> Move #pragma from msvc/config.h to libusb/libusb.h ? >>> I am against this change. The #pragma is for Windows so should be in a >>> Windows only file. >>> >> If msvc/config.h is installed an