Hi,
I think we should move this #pragma closer to the place where it's
used. Otherwise user program will need the same thing to disable the
warning.
Regards,
Jie
--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012
On Fri, Jan 11, 2013 at 4:00 AM, Ludovic Rousseau
wrote:
> 2013/1/10 Jie Zhang :
>> I think we should move this #pragma closer to the place where it's
>> used. Otherwise user program will need the same thing to disable the
>> warning.
>
> Move #pragma from msvc/c
On Fri, Jan 11, 2013 at 7:27 PM, Pete Batard wrote:
> Hi Jie,
>
> On 2013.01.11 13:42, Jie Zhang wrote:
>>> Move #pragma from msvc/config.h to libusb/libusb.h ?
>>> I am against this change. The #pragma is for Windows so should be in a
>>> Windows only file.
On Sat, Jan 12, 2013 at 6:20 PM, Pete Batard wrote:
> On 2013.01.12 03:23, Jie Zhang wrote:
>> But this warning is introduced by libusb, not by user
>
> Not really. The warning is introduced by the compiler as a result of
> libusbx using zero sized arrays, which may *or m
On Sun, Jan 13, 2013 at 4:47 AM, Ludovic Rousseau
wrote:
> 2013/1/13 Pete Batard :
>>> As I said above, this piece of code is safe.
>>
>> Can you prove it?
>
> Some remarks
> 1- a zero sized array is illegal in C. It is a GCC extension. See [1]
>
It's also a MSC extension.
> 2- zero sized arrays
k something interesting to comment. See below:
On Sun, Jan 13, 2013 at 3:37 PM, Pete Batard wrote:
> On 2013.01.13 18:17, Jie Zhang wrote:
> The problem I have is that the libusb.h header is not used to compile
> our code only. It is also used to compile user code, whose safety with
> r
Hi Pete,
On Mon, Jan 14, 2013 at 4:33 PM, Pete Batard wrote:
> OK, let's refocus the debate to try to make the situation more clear to
> everybody then.
>
> The first thing I need to point out, which I think may help
> understanding what we are really dealing with here, is that the 4200
> warning
Parallel build fails. See below for the log.
Jie
jie@elf:~/sources/libusb-1.0.20-rc3$ ./configure
[...]
jie@elf:~/sources/libusb-1.0.20-rc3$ make -j4
make all-recursive
make[1]: Entering directory `/home/jie/sources/libusb-1.0.20-rc3'
Making all in libusb
make[2]: Entering directory `/home/jie/
