[Libvir] [PATCH]check NULL of mac

2008-02-26 Thread S.Sakamoto
Hi, attach-device become the segmentation fault, when it uses following xml. (There is no address='xx') ++ |interface type='bridge' | | source bridge='xenbr0'/ | | mac/

Re: [Libvir] [PATCH] default hypervisor selection

2008-02-26 Thread Daniel Veillard
On Mon, Feb 25, 2008 at 09:32:48AM -0500, Daniel Veillard wrote: On Sun, Feb 24, 2008 at 10:12:05PM +, Daniel P. Berrange wrote: On Fri, Feb 22, 2008 at 10:59:43AM -0500, Daniel Veillard wrote: Okay, first patch enclosed, it seems to work for me: + /* + *

[Libvir] [PATCH]Change MAC address to case insensitive

2008-02-26 Thread S.Sakamoto
Hi, xenXMDomainAttachDevice and xenXMDomainDetachDevice treats case sensitve for MAC address of stopping domain. This patch changes from case sensitive to case insensitive. Thanks, Shigeki Sakamoto. Index: src/xm_internal.c ===

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-26 Thread Richard W.M. Jones
I'll apply this today (using our STRCASEEQ macros) if no one else objects. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen

Re: [Libvir] [PATCH 1/2] Add internal API for managing capabilities data

2008-02-26 Thread Richard W.M. Jones
Yes, this all looks good. Another advantage of doing this is that we can be sure that the capabilities XML generated by each driver will have the same schema. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual

Re: [Libvir] [PATCH 2/2] Refactor drivers to use capabilities API

2008-02-26 Thread Richard W.M. Jones
On Tue, Feb 26, 2008 at 05:13:51AM +, Daniel P. Berrange wrote: This patch refactors the Xen, QEMU and Test drivers to use the new API for dealing with capabilities data. Yes, +1 to this patch as well. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones

Re: [Libvir] [PATCH]check NULL of mac

2008-02-26 Thread Richard W.M. Jones
+1. I'll apply this today if no one else objects. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc.

Re: [Libvir] [PATCH] (for discussion) DHCP host mappings using 3 arrays API

2008-02-26 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: This patch is an evolution of the previous patch for implementing DHCP ... +if (maxmappings == 0) return 0; ... +if (col == 0) hwaddr = token; ... +if (!(*hwaddrs)[lines]) goto mem_error; Hi Rich, Is there a

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-26 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: I'll apply this today (using our STRCASEEQ macros) if no one else objects. Hi, What do you think about using a MAC-address-specific comparison function? I.e., one that is not only case-independent, but that also knows leading zeros are unnecessary?

[Libvir] How to stop 'make install' clobbering /etc/libvirt/libvirtd.conf

2008-02-26 Thread Richard W.M. Jones
Currently 'make install' clobbers configuration files, in particular /etc/libvirt/libvirtd.conf. It shouldn't. Does anyone know how to persuade automake to stop it from doing this? As far as I can see the only way would be to write a custom install rule. Rich. -- Richard Jones, Emerging

[Libvir] [PATCH] Implement virDomainBlockStats for QEMU/KVM

2008-02-26 Thread Richard W.M. Jones
This little patch just implements the virDomainBlockStats call for qemu kvm. It does this by using the new 'info blockstats' monitor command which I added to qemu KVM upstream some months back, and (hopefully) it does the right thing if this command is not available. Rich. -- Richard Jones,

Re: [Libvir] [PATCH] (for discussion) DHCP host mappings using 3 arrays API

2008-02-26 Thread Richard W.M. Jones
On Tue, Feb 26, 2008 at 11:43:59AM +0100, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: This patch is an evolution of the previous patch for implementing DHCP ... +if (maxmappings == 0) return 0; ... +if (col == 0) hwaddr = token; ... +

Re: [Libvir] [PATCH] default hypervisor selection

2008-02-26 Thread Daniel P. Berrange
On Tue, Feb 26, 2008 at 03:34:56AM -0500, Daniel Veillard wrote: Okay, commited, seems to work well for me as root and as normal user on RHEL-5.1 , but on Fedora-8 as non-root this doesn't work the debug shows DEBUG: libvirt.c: do_open (Probed qemu:///session) DEBUG: libvirt.c:

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-26 Thread Daniel P. Berrange
On Tue, Feb 26, 2008 at 12:13:43PM +0100, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: I'll apply this today (using our STRCASEEQ macros) if no one else objects. Hi, What do you think about using a MAC-address-specific comparison function? I.e., one that is not only

Re: [Libvir] [PATCH 1/2] Add internal API for managing capabilities data

2008-02-26 Thread Daniel P. Berrange
On Tue, Feb 26, 2008 at 09:39:49AM +, Richard W.M. Jones wrote: Yes, this all looks good. Another advantage of doing this is that we can be sure that the capabilities XML generated by each driver will have the same schema. Yes indeed - this is a very good benefit, particularly as we

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-26 Thread Richard W.M. Jones
On Tue, Feb 26, 2008 at 12:54:15PM +, Daniel P. Berrange wrote: On Tue, Feb 26, 2008 at 12:13:43PM +0100, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: I'll apply this today (using our STRCASEEQ macros) if no one else objects. Hi, What do you think about

Re: [Libvir] [PATCH] (for discussion) DHCP host mappings using 3 arrays API

2008-02-26 Thread Daniel Veillard
On Tue, Feb 26, 2008 at 12:01:04PM +, Richard W.M. Jones wrote: On Tue, Feb 26, 2008 at 11:43:59AM +0100, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: This patch is an evolution of the previous patch for implementing DHCP ... +if (maxmappings == 0) return 0;

Re: [Libvir] [PATCH 1/2] Add internal API for managing capabilities data

2008-02-26 Thread Daniel Veillard
On Tue, Feb 26, 2008 at 12:52:32PM +, Daniel P. Berrange wrote: On Tue, Feb 26, 2008 at 09:39:49AM +, Richard W.M. Jones wrote: Yes, this all looks good. Another advantage of doing this is that we can be sure that the capabilities XML generated by each driver will have the

Re: [Libvir] [PATCH 0/2] Re-organize generation / handling of capabilities data

2008-02-26 Thread Daniel Veillard
On Tue, Feb 26, 2008 at 04:57:56AM +, Daniel P. Berrange wrote: Earlier today I started the 'simple' task of extending the QEMU driver to support Xenner for running Xen paravirt guests under KVM. This was at first glance easy because it basically looks like QEMU - in fact all we needed was

Re: [Libvir] [PATCH]check NULL of mac

2008-02-26 Thread Daniel Veillard
On Tue, Feb 26, 2008 at 09:44:33AM +, Richard W.M. Jones wrote: +1. I'll apply this today if no one else objects. looks fine to me too +1 Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ [EMAIL

[Libvir] Re: RFC: Supporting serial parallel ports for QEMU (and improving Xen)

2008-02-26 Thread Charles Duffy
Daniel P. Berrange wrote: Lots of difficult bits, but I'm starting to get onto coding it. Was this ever completed and merged? I don't see it documented at http://libvirt.org/format.html -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [Libvir] How to stop 'make install' clobbering /etc/libvirt/libvirtd.conf

2008-02-26 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: Currently 'make install' clobbers configuration files, in particular /etc/libvirt/libvirtd.conf. It shouldn't. Does anyone know how to persuade automake to stop it from doing this? As far as I can see the only way would be to write a custom install

Re: [Libvir] [PATCH] Implement virDomainBlockStats for QEMU/KVM

2008-02-26 Thread Daniel Veillard
On Tue, Feb 26, 2008 at 11:32:20AM +, Richard W.M. Jones wrote: This little patch just implements the virDomainBlockStats call for qemu kvm. It does this by using the new 'info blockstats' monitor command which I added to qemu KVM upstream some months back, and (hopefully) it does the

Re: [Libvir] [PATCH 1/2] Add internal API for managing capabilities data

2008-02-26 Thread Daniel P. Berrange
On Tue, Feb 26, 2008 at 08:24:53AM -0500, Daniel Veillard wrote: On Tue, Feb 26, 2008 at 12:52:32PM +, Daniel P. Berrange wrote: On Tue, Feb 26, 2008 at 09:39:49AM +, Richard W.M. Jones wrote: Yes, this all looks good. Another advantage of doing this is that we can be sure

Re: [Libvir] Re: RFC: Supporting serial parallel ports for QEMU (and improving Xen)

2008-02-26 Thread Daniel P. Berrange
On Tue, Feb 26, 2008 at 08:01:11AM -0600, Charles Duffy wrote: Daniel P. Berrange wrote: Lots of difficult bits, but I'm starting to get onto coding it. Was this ever completed and merged? I don't see it documented at http://libvirt.org/format.html No, I never got a nice solution to the

Re: [Libvir] [PATCH] Implement virDomainBlockStats for QEMU/KVM

2008-02-26 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Tue, Feb 26, 2008 at 03:38:56PM +0100, Jim Meyering wrote: diff --git a/src/qemu_driver.c b/src/qemu_driver.c index f97ef18..d9a7aca 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -1315,8 +1315,9 @@ static void

Re: [Libvir] [PATCH]check NULL of mac

2008-02-26 Thread Richard W.M. Jones
Committed. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -- Libvir-list

Re: [Libvir] [PATCH] Implement virDomainBlockStats for QEMU/KVM

2008-02-26 Thread Richard W.M. Jones
Thanks everyone. I've committed that with the suggested changes. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc.

Re: [Libvir] [PATCH 0/2] Re-organize generation / handling of capabilities data

2008-02-26 Thread Daniel P. Berrange
On Tue, Feb 26, 2008 at 08:29:54AM -0500, Daniel Veillard wrote: On Tue, Feb 26, 2008 at 04:57:56AM +, Daniel P. Berrange wrote: Earlier today I started the 'simple' task of extending the QEMU driver to support Xenner for running Xen paravirt guests under KVM. This was at first glance

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-26 Thread S.Sakamoto
OK, try this patch. I tried this patch. It works fine to me. Shigeki Sakamoto. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list