Re: [Libvir] [PATCH] Fix MAC address parsing for 1-digit case

2008-03-18 Thread Jim Meyering
Hiroyuki Kaguchi [EMAIL PROTECTED] wrote: libvirt fails in parsing when MAC address like 00:16:3e:12:3:61 is specified for installation. This is because virt-install can pass 1-digit (like 3) for MAC address from Cset:316 for Solaris But libvirt cannot support this MAC 1-digit (like 3)

Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-18 Thread Richard W.M. Jones
On Mon, Mar 17, 2008 at 04:21:04PM -0400, Cole Robinson wrote: The attached patch implements the following operations for the qemu driver: virDomainGetMaxMemory virDomainSetMaxMemory virDomainSetMemory The patch itself, +1. Maybe we should investigate whether qemu/kvm does or will support

Re: [Libvir] [PATCH] Fix MAC address parsing for 1-digit case

2008-03-18 Thread Richard W.M. Jones
On Tue, Mar 18, 2008 at 02:36:02PM +0900, Hiroyuki Kaguchi wrote: Index: src/xml.c [...] + * parseMacAddr: Since all hypervisors support MAC addresses, and we already have a shared MAC address function (__virMacAddrCompare), this should go in file src/util.c. Rich. -- Richard Jones, Emerging

Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-18 Thread Jim Meyering
Cole Robinson [EMAIL PROTECTED] wrote: The attached patch implements the following operations for the qemu driver: ... +qemudReportError(dom-conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, + no domain with matching uuid '%s', dom-uuid); ... +

Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-18 Thread Cole Robinson
Richard W.M. Jones wrote: 2) Should SetMaxMem be able to be called on a running guest? This code allows it, since maxmem is basically a metavalue that doesn't directly affect a guest. 3) Should maxmem be able to be set lower than the currently allocated mem? This code does not

Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-18 Thread Cole Robinson
Jim Meyering wrote: Cole Robinson [EMAIL PROTECTED] wrote: The attached patch implements the following operations for the qemu driver: ... +qemudReportError(dom-conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, + no domain with matching uuid '%s', dom-uuid); ... +

Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-18 Thread Daniel Veillard
On Tue, Mar 18, 2008 at 10:05:48AM -0400, Cole Robinson wrote: Jim Meyering wrote: Cole Robinson [EMAIL PROTECTED] wrote: The attached patch implements the following operations for the qemu driver: ... +qemudReportError(dom-conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, +

Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-18 Thread Cole Robinson
Cole Robinson wrote: The attached patch implements the following operations for the qemu driver: virDomainGetMaxMemory virDomainSetMaxMemory virDomainSetMemory A few questions/comments: 1) I changed maxmem and memory in the qemu_vm_def struct to unsigned long to match the public

Re: [libvir] How to seek a running QEMU instance

2008-03-18 Thread Richard W.M. Jones
On Tue, Mar 18, 2008 at 05:47:38PM +0300, Anton Protopopov wrote: I have the following question. How can virsh (or, more accurately, libvirt) detect a running QEMU vm, when latter was already started? For example, I have got the following: As Dan says, it doesn't, but this is kind of a bug in

Re: [libvir] How to seek a running QEMU instance

2008-03-18 Thread Daniel P. Berrange
On Tue, Mar 18, 2008 at 06:38:44PM +, Richard W.M. Jones wrote: On Tue, Mar 18, 2008 at 05:47:38PM +0300, Anton Protopopov wrote: I have the following question. How can virsh (or, more accurately, libvirt) detect a running QEMU vm, when latter was already started? For example, I have