Evgeniy Sokolov [EMAIL PROTECTED] wrote:
This really needs to be changed to pass through gettext, eg
error(dom-conn, VIR_ERR_INTERNAL_ERROR,
_(Could not exec %s), VZCTL);
NB, we have to use a %s format string when going via gettext rather than
just allowing the preprocessor to
On Thu, Jul 10, 2008 at 12:07:18AM +0100, John Levon wrote:
Why is it NULL instead of the path to pygrub? On Solaris, the path is
different.
Loader is refering specifically to the loader tag which is a BIOS
firmware blob. It seems we've not specified any tag in the capabilities
for bootloader
On Thu, Jul 10, 2008 at 12:07:18AM +0100, John Levon wrote:
Why is it NULL instead of the path to pygrub? On Solaris, the path is
different.
You mean that when dumping the capabilities on a Xen host
the sections
guest
os_typexen/os_type
arch ...
don't have a loader section under
function error() was renamed to openvzError() to don't conflict with
other functions with the same name.
other
- openvzError() is added to msg_gen_function
- fixed to pass make syntax-check
Thanks to Jim Meyering for review.
Index: src/openvz_conf.c
On Thu, Jul 10, 2008 at 04:09:14PM +0400, Evgeniy Sokolov wrote:
function error() was renamed to openvzError() to don't conflict with
other functions with the same name.
other
- openvzError() is added to msg_gen_function
- fixed to pass make syntax-check
Thanks to Jim Meyering for
On Thu, Jul 10, 2008 at 09:23:36AM +0200, Jim Meyering wrote:
Evgeniy Sokolov [EMAIL PROTECTED] wrote:
[...]
+void
+error (virConnectPtr conn, virErrorNumber code, const char *fmt, ...)
Now that you've given it external scope, please use a different name.
There are already at least two
On Thu, Jul 10, 2008 at 09:08:33AM +0100, Daniel P. Berrange wrote:
On Thu, Jul 10, 2008 at 12:07:18AM +0100, John Levon wrote:
Why is it NULL instead of the path to pygrub? On Solaris, the path is
different.
Loader is refering specifically to the loader tag which is a BIOS
firmware
Attached is a small fix to get libvirt working w/ autobuild. Autobuild
attempts to create and test the RPM, which lists the PolicyKit as one of
the files to be installed, and thus if it is not installed, autobuild
reports an error and fails. The was to get this file installed is to
specify
On Thu, Jul 10, 2008 at 10:10:25AM -0400, Mohammed Morsi wrote:
Attached is a small fix to get libvirt working w/ autobuild. Autobuild
attempts to create and test the RPM, which lists the PolicyKit as one of
the files to be installed, and thus if it is not installed, autobuild
reports an
Daniel P. Berrange wrote:
On Thu, Jul 10, 2008 at 10:10:25AM -0400, Mohammed Morsi wrote:
Attached is a small fix to get libvirt working w/ autobuild. Autobuild
attempts to create and test the RPM, which lists the PolicyKit as one of
the files to be installed, and thus if it is not
On Thu, Jul 10, 2008 at 10:20:26AM -0400, Mohammed Morsi wrote:
Daniel P. Berrange wrote:
On Thu, Jul 10, 2008 at 10:10:25AM -0400, Mohammed Morsi wrote:
Attached is a small fix to get libvirt working w/ autobuild. Autobuild
attempts to create and test the RPM, which lists the PolicyKit
for (i = 0; i virNetworkDriverTabCount; i++) {
if ((virDriverTab[i]-probe != NULL)
((latest = virDriverTab[i]-probe()) != NULL)) {
probes++;
.
}
}
We use array virDriverTab, but cicle is to
On Thu, Jul 10, 2008 at 06:49:22PM +0400, Evgeniy Sokolov wrote:
for (i = 0; i virNetworkDriverTabCount; i++) {
if ((virDriverTab[i]-probe != NULL)
((latest = virDriverTab[i]-probe()) != NULL)) {
probes++;
.
On Thu, Jul 10, 2008 at 06:49:22PM +0400, Evgeniy Sokolov wrote:
for (i = 0; i virNetworkDriverTabCount; i++) {
if ((virDriverTab[i]-probe != NULL)
((latest = virDriverTab[i]-probe()) != NULL)) {
probes++;
.
There were 3 places with the same code.
I moved it to separate function.
other:
use O_RDONLY to read config file
Index: src/openvz_conf.c
===
RCS file: /data/cvs/libvirt/src/openvz_conf.c,v
retrieving revision 1.28
diff -u -a -r1.28
15 matches
Mail list logo
