Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-06 Thread Jim Meyering
Atsushi SAKAI <[EMAIL PROTECTED]> wrote: > I have a question about inet_pton(). > I try to compile libvirt on MinGW after some modification. > The error message says follows. > C:/msys/1.0/home/sakaia/work/libvirt/src/network_conf.c:290: undefined > reference to `inet_pton' > C:/msys/1.0/home/saka

Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-06 Thread Atsushi SAKAI
Hi, Jim I have a question about inet_pton(). I try to compile libvirt on MinGW after some modification. The error message says follows. C:/msys/1.0/home/sakaia/work/libvirt/src/network_conf.c:290: undefined reference to `inet_pton' C:/msys/1.0/home/sakaia/work/libvirt/src/network_conf.c:296: unde

[libvirt] Is CVS server working?

2008-08-06 Thread Atsushi SAKAI
Hi, CVS server [EMAIL PROTECTED]:2401/data/cvs is working? I can see git repository but CVS repository are not. Thanks Atsushi SAKAI -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Install default storage pool

2008-08-06 Thread Cole Robinson
The attached patch adds a default pool definition to install with libvirt. The pool is a directory pool, hardcoded to use /var/lib/libvirt/images, though this is replaced with %{_localstatedir}/lib/libvirt/images if installing via rpm. Since /var/lib/libvirt/images may not exist if installing from

[libvirt] [ANNOUNCE] virt-mem tools version 0.2.8 released

2008-08-06 Thread Richard W.M. Jones
I'm pleased to announce the latest release of the virt-mem tools, version 0.2.8. These are tools for system administrators which let you find things like kernel messages, process lists and network information of your guests. For example: virt-uname 'uname' command, shows OS version, archit

Re: [libvirt] [PATCH] storage pool discovery

2008-08-06 Thread David Lively
Thanks much for your comments, Jim. They all look reasonable (though I may be intentionally trimming a NL in one of these cases -- I'm checking). And I'll start following the HACKING file recommendations before submitting my next attempt :-) (Though note I'm not yet submitting tests since we hav

Re: [libvirt] [PATCH] storage pool discovery

2008-08-06 Thread David Lively
On Fri, 2008-08-01 at 10:40 +0100, Daniel P. Berrange wrote: > On Wed, Jul 30, 2008 at 04:30:01PM -0400, David Lively wrote: > > Finally, there's an underspecification issue. The XML pool > > descriptions returned are supposed to be usable as valid input to > > virStoragePoolDefineXML. But the

[libvirt] [PATCH] The logic in veth.c that searches for free interface names takes into account

2008-08-06 Thread Dan Smith
only current devices, but not device names already planned for the other half of a container's device pair. Thus, the search can result in attempting to create a pair of devices such as veth1 and veth1, which obviously does not work. This patch augments the logic to be a little smarter in this re

Re: [libvirt] PATCH: 5/7: Remove paths from virDomainObjPtr

2008-08-06 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... ACK, modulo two questions: > diff -r a204a9425afd src/domain_conf.c > int virDomainDeleteConfig(virConnectPtr conn, > - virDomainObjPtr dom) > + const char *configDir, > +

Re: [libvirt] PATCH: 0/7: Re-factor LXC driver

2008-08-06 Thread Daniel P. Berrange
On Wed, Aug 06, 2008 at 10:41:42AM +0100, Daniel P. Berrange wrote: > On Tue, Aug 05, 2008 at 02:17:27PM -0700, Dan Smith wrote: > > DB> This is a long overdue followup to my previous set of patches to > > DB> make the LXC driver use the new domain XML apis. > > > > Have you been able to test this

Re: [libvirt] "static" ip address

2008-08-06 Thread Olivier Deckmyn
Le 4 août 08 à 12:46, "Olivier Deckmyn" <[EMAIL PROTECTED]> a écrit : On Mon, Aug 4, 2008 at 9:12 AM, <[EMAIL PROTECTED]> wrote: > Patch on qemu_conf.c doesn't apply to 0.4.4 released version. > > Any reason why this feature wasn't commited ? Just that I didn't have the time to follow it

Re: [libvirt] [PATCH] fix failing "make syntax-check"

2008-08-06 Thread Jim Meyering
Daniel Veillard <[EMAIL PROTECTED]> wrote: > On Wed, Aug 06, 2008 at 02:26:52PM +0200, Jim Meyering wrote: >> "make syntax-check" just started failing. > > strange it works for me on CVS head It was so small/obvious, that after waiting half an hour, I went ahead and committed it. If you add bac

Re: [libvirt] [PATCH] fix failing "make syntax-check"

2008-08-06 Thread Daniel Veillard
On Wed, Aug 06, 2008 at 02:26:52PM +0200, Jim Meyering wrote: > "make syntax-check" just started failing. strange it works for me on CVS head > This fixes it: > > fix failing "make syntax-check" > * src/stats_linux.c: Don't include no longer used. +1 sure Daniel -- Red Hat Virtualizat

[libvirt] [PATCH] fix failing "make syntax-check"

2008-08-06 Thread Jim Meyering
"make syntax-check" just started failing. This fixes it: fix failing "make syntax-check" * src/stats_linux.c: Don't include no longer used. --- ChangeLog |3 +++ src/stats_linux.c |1 - 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog inde

Re: [libvirt] PATCH: 6/7: Persist live domain config across restarts

2008-08-06 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > Internally the drivers track the current live configuration, and the new > inactive config for running domains. When the libvirtd process is restarted > though, this data is lost for any active LXC domains. This patch makes the > LXC driver persist

[libvirt] Memory corruption with CVS tip + python

2008-08-06 Thread Chris Lalancette
All, FYI, I'm running into some memory corruption when using CVS tip and trying to use an older virt-install command. I won't have time to debug this today, so I thought I would mention it on-list in case someone else wants to take a crack at it. My system is an AMD system running RHEL-5.2 x8

Re: [libvirt] incorrect data in online documentation (I think)

2008-08-06 Thread Daniel Veillard
On Tue, Aug 05, 2008 at 06:43:04PM -0400, matthew chan wrote: > Hi > > The online documentation mentions that the XML node units are > in byte, but from the example code I have observed, it seems more likely > to be in kilobytes. > > Could someone verify + change if necessary please? Hum, rig

Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-06 Thread Daniel Veillard
On Wed, Aug 06, 2008 at 11:52:20AM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > >> If you don't object, I'll go for the simpler interface (and smaller > >> change). However I've just noticed that that will require an adjustment > >> of the gnulib license for the i

Re: [libvirt] [PATCH]: Fix sexpr generation again

2008-08-06 Thread Daniel Veillard
On Wed, Aug 06, 2008 at 12:20:50PM +0200, Chris Lalancette wrote: > DanB pointed out that my sexpr xend_internal patch from yesterday broke one of > the regression tests. The problem is that the xenDaemonFormatSxpr{Disk,Net} > functions are shared between domain creation time and attaching disk ti

Re: [libvirt] [PATCH]: Fix sexpr generation again

2008-08-06 Thread Daniel P. Berrange
On Wed, Aug 06, 2008 at 12:20:50PM +0200, Chris Lalancette wrote: > DanB pointed out that my sexpr xend_internal patch from yesterday broke one of > the regression tests. The problem is that the xenDaemonFormatSxpr{Disk,Net} > functions are shared between domain creation time and attaching disk ti

[libvirt] [PATCH]: Fix sexpr generation again

2008-08-06 Thread Chris Lalancette
DanB pointed out that my sexpr xend_internal patch from yesterday broke one of the regression tests. The problem is that the xenDaemonFormatSxpr{Disk,Net} functions are shared between domain creation time and attaching disk time. Unfortunately, though, Xend expects something different during these

Re: [libvirt] PATCH: 7/7: Allow replacing root filesystem

2008-08-06 Thread Daniel P. Berrange
On Wed, Aug 06, 2008 at 11:00:05AM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > ... > > -static int lxcContainerSetStdio(int control, const char *ttyPath) > > +static int lxcContainerSetStdio(int control, int ttyfd) > > { > > Hi Dan, > > Not a big deal, but sinc

[libvirt] incorrect data in online documentation (I think)

2008-08-06 Thread matthew chan
Hi The online documentation mentions that the XML node units are in byte, but from the example code I have observed, it seems more likely to be in kilobytes. Could someone verify + change if necessary please? Thanks, Matt -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.co

Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-06 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Wed, Aug 06, 2008 at 09:10:04AM +0200, Jim Meyering wrote: >> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: >> > On Tue, Aug 05, 2008 at 01:52:58PM +0200, Jim Meyering wrote: >> >> Atsushi SAKAI <[EMAIL PROTECTED]> wrote: >> >> ... >> >> > netw

Re: [libvirt] PATCH: 0/7: Re-factor LXC driver

2008-08-06 Thread Daniel P. Berrange
On Tue, Aug 05, 2008 at 02:17:27PM -0700, Dan Smith wrote: > DB> This is a long overdue followup to my previous set of patches to > DB> make the LXC driver use the new domain XML apis. > > Have you been able to test this with NET_NS support enabled yet? > > I am hitting the same issue I was befor

Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-06 Thread Daniel P. Berrange
On Wed, Aug 06, 2008 at 09:10:04AM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > On Tue, Aug 05, 2008 at 01:52:58PM +0200, Jim Meyering wrote: > >> Atsushi SAKAI <[EMAIL PROTECTED]> wrote: > >> ... > >> > network_conf.c:290: warning: implicit declaration of functi

Re: [libvirt] PATCH: 7/7: Allow replacing root filesystem

2008-08-06 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... > -static int lxcContainerSetStdio(int control, const char *ttyPath) > +static int lxcContainerSetStdio(int control, int ttyfd) > { Hi Dan, Not a big deal, but since ttyfd is now an input to this function, it'd be less surprising if the caller

Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-06 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: >> On Tue, Aug 05, 2008 at 01:52:58PM +0200, Jim Meyering wrote: >>> Atsushi SAKAI <[EMAIL PROTECTED]> wrote: >>> ... >>> > network_conf.c:290: warning: implicit declaration of function `inet_aton' >>> > netw

Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-06 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Tue, Aug 05, 2008 at 01:52:58PM +0200, Jim Meyering wrote: >> Atsushi SAKAI <[EMAIL PROTECTED]> wrote: >> ... >> > network_conf.c:290: warning: implicit declaration of function `inet_aton' >> > network_conf.c:290: warning: nested extern declarati