[libvirt] [PATCH] (virCgroupSetValueStr): Use safe_write, not write.

2008-10-07 Thread Jim Meyering
"make syntax-check" was failing. This fixes it: >From 155aea5141553fd9fab19aedc4df1613abae771c Mon Sep 17 00:00:00 2001 From: Jim Meyering <[EMAIL PROTECTED]> Date: Tue, 7 Oct 2008 23:10:03 +0200 Subject: [PATCH] Tue Oct 7 23:08:51 CEST 2008 Jim Meyering <[EMAIL PROTECTED]> * src/cgroup.c (virCg

Re: [libvirt] [PATCH] Reboot support for QEMU/KVM

2008-10-07 Thread Eduardo Habkost
On Tue, Oct 07, 2008 at 09:58:47PM +0100, Daniel P. Berrange wrote: > On Tue, Oct 07, 2008 at 05:55:37PM -0300, Eduardo Habkost wrote: > > This patch implements reboot support on qemu_driver. > > > > It is so simple that I am wondering if there is some problem I am missing, > > that would be the r

Re: [libvirt] [PATCH] Reboot support for QEMU/KVM

2008-10-07 Thread Daniel P. Berrange
On Tue, Oct 07, 2008 at 05:55:37PM -0300, Eduardo Habkost wrote: > This patch implements reboot support on qemu_driver. > > It is so simple that I am wondering if there is some problem I am missing, > that would be the reason it wasn't implemented yet. I hope not. :) The reboot command is intend

[libvirt] [PATCH] Reboot support for QEMU/KVM

2008-10-07 Thread Eduardo Habkost
This patch implements reboot support on qemu_driver. It is so simple that I am wondering if there is some problem I am missing, that would be the reason it wasn't implemented yet. I hope not. :) Signed-off-by: Eduardo Habkost <[EMAIL PROTECTED]> --- src/qemu_driver.c | 23

[libvirt] [PATCH] Fix qemudDomainShutdown() memory leak

2008-10-07 Thread Eduardo Habkost
qemudDomainShutdown() currently doesn't free the returned reply from qemudMonitorCommand(). Signed-off-by: Eduardo Habkost <[EMAIL PROTECTED]> --- src/qemu_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 806608d..a88cb7

[libvirt] [PATCH] Add generic parameter=value support for virsh's schedinfo command

2008-10-07 Thread Dan Smith
This patch maintains the two Xen-specific --weight and --cap options, but adds support for setting arbitrary parameters by specifying them in param=value syntax. Changes to the virsh manual are included. diff -r 51fd150edd42 -r aae58f42bd4a docs/virsh.pod --- a/docs/virsh.podTue Oct 07 11:45:

Re: [libvirt] [PATCH] qemu: fix block stats for virtio and scsi

2008-10-07 Thread Cole Robinson
Guido Günther wrote: > On Thu, Oct 02, 2008 at 09:06:25PM +0100, Daniel P. Berrange wrote: >> I think this needs to use the virDiskNameToIndex() method to >> extract the index instead. > Corrected pach attached. I don't know how devices are called when using > xenner so I left that out. > -- Guido

Re: [libvirt] [PATCH 2 of 3] Add scheduling parameter support for LXC domains

2008-10-07 Thread Dan Smith
DB> cgroups isn't really the schedular here - its just the mechanism DB> for supplying the cpu_shares parameter to the schedular. That's true, although I was thinking along the lines of how kconfig asks you for the method for grouping tasks, of which "cgroups" is an option. But, yeah. DB> I sort

[libvirt] input on F10 virtualization release notes

2008-10-07 Thread Dale Bewley
I've been working on the virtualization release notes[1] for Fedora 10 these past several days, and I'm looking for input from those in the know. The advances coming out of the Emerging Technologies projects and Fedora in general are very impressive, and I'd like to do them justice. I added a lot

Re: [libvirt] [PATCH]: (trivial) handle OOM as everywhere else

2008-10-07 Thread Daniel Veillard
On Tue, Oct 07, 2008 at 05:44:42PM +0200, Guido Günther wrote: > Hi, > we print an error message on OOM conditions in qemudStartup() at the end > of the function, no need to do it differently in one place. This one actually change the behaviour, but the old one wasn't correct as base is used on

[libvirt] Re: [PATCH/RFC] kvm/qemu vs libvirtd restarts

2008-10-07 Thread Daniel P. Berrange
Moving thread to libvir-list On Tue, Oct 07, 2008 at 06:12:33PM +0200, Guido G?nther wrote: > On Fri, Sep 26, 2008 at 04:47:05PM +0100, Daniel P. Berrange wrote: > > On Fri, Sep 26, 2008 at 05:41:02PM +0200, Guido G?nther wrote: > > > > We've got this problem sorted in the 'lxc' driver and ne

Re: [libvirt] [PATCH 3 of 3] Add cpu_shares support to virsh schedinfo

2008-10-07 Thread Dan Smith
DB> Not your fault, but this schedinfo command is a really dumb wrt to DB> option handling. Requiring that we add new options for every DB> possible schedular param for every possible hypervisor is just DB> crazy. Agreed. I actually just wrote this patch for my own testing, but decided to send it

Re: [libvirt] [PATCH 2 of 3] Add scheduling parameter support for LXC domains

2008-10-07 Thread Daniel P. Berrange
On Tue, Oct 07, 2008 at 08:30:21AM -0700, Dan Smith wrote: > diff -r 6fb284fa200a -r ebecbe5caa03 src/lxc_driver.c > --- a/src/lxc_driver.cTue Oct 07 08:21:49 2008 -0700 > +++ b/src/lxc_driver.cTue Oct 07 08:21:50 2008 -0700 > @@ -35,6 +35,7 @@ > #include > #include > > +#incl

Re: [libvirt] [PATCH 3 of 3] Add cpu_shares support to virsh schedinfo

2008-10-07 Thread Daniel P. Berrange
On Tue, Oct 07, 2008 at 08:30:22AM -0700, Dan Smith wrote: > diff -r ebecbe5caa03 -r b07cd92a30e9 src/virsh.c > --- a/src/virsh.c Tue Oct 07 08:21:50 2008 -0700 > +++ b/src/virsh.c Tue Oct 07 08:21:50 2008 -0700 > @@ -1114,6 +1114,7 @@ > {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, gettext_n

Re: [libvirt] [PATCH]: (trivial) getpwuid is not OOM

2008-10-07 Thread Daniel Veillard
On Tue, Oct 07, 2008 at 05:45:56PM +0200, Guido Günther wrote: > Hi, > we shouldn't print an oom error message when actually getpwuid failed. > Cheers, Heh ! good catch :-) Applied and commited, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ [

[libvirt] [PATCH]: (trivial) getpwuid is not OOM

2008-10-07 Thread Guido Günther
Hi, we shouldn't print an oom error message when actually getpwuid failed. Cheers, -- Guido [PATCH] don't report OOM when it's not --- src/qemu_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index b5ba723..806608d 100644

[libvirt] [PATCH]: (trivial) handle OOM as everywhere else

2008-10-07 Thread Guido Günther
Hi, we print an error message on OOM conditions in qemudStartup() at the end of the function, no need to do it differently in one place. Cheers, -- Guido [PATCH] handle OOM as everywhere else --- src/qemu_driver.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/src/q

[libvirt] [PATCH 0 of 3] Add cpu.shares support to LXC driver

2008-10-07 Thread Dan Smith
This set adds {Get,Set}SchedulerParameters support to the LXC driver. A single parameter of "cpu_shares" is added, which gets/sets the cpu.shares key in the domain's cgroup. I also added bits to "virsh schedinfo" to support this. -- Libvir-list mailing list Libvir-list@redhat.com https://www.red

[libvirt] [PATCH 3 of 3] Add cpu_shares support to virsh schedinfo

2008-10-07 Thread Dan Smith
diff -r ebecbe5caa03 -r b07cd92a30e9 src/virsh.c --- a/src/virsh.c Tue Oct 07 08:21:50 2008 -0700 +++ b/src/virsh.c Tue Oct 07 08:21:50 2008 -0700 @@ -1114,6 +1114,7 @@ {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, gettext_noop("domain name, id or uuid")}, {"weight", VSH_OT_INT, VSH

[libvirt] [PATCH 1 of 3] Add get/set of cpu.shares to cgroup implementation

2008-10-07 Thread Dan Smith
This brings get/set of U64 out of the #if 0, which looks messier than it is. diff -r 64f19f607bc6 -r 6fb284fa200a src/cgroup.c --- a/src/cgroup.c Fri Oct 03 17:58:02 2008 + +++ b/src/cgroup.c Tue Oct 07 08:21:49 2008 -0700 @@ -224,26 +224,6 @@ return rc; } -#if 0 -/* This is

[libvirt] [PATCH 2 of 3] Add scheduling parameter support for LXC domains

2008-10-07 Thread Dan Smith
diff -r 6fb284fa200a -r ebecbe5caa03 src/lxc_driver.c --- a/src/lxc_driver.c Tue Oct 07 08:21:49 2008 -0700 +++ b/src/lxc_driver.c Tue Oct 07 08:21:50 2008 -0700 @@ -35,6 +35,7 @@ #include #include +#include "internal.h" #include "lxc_conf.h" #include "lxc_container.h" #include "lxc_driv

[libvirt] When bridge doesn't exist

2008-10-07 Thread Anton Protopopov
Assume that we want to add a bridge to LAN to a guest. We saying to libvirt: ... ... What is the right behaviour of libvirt in case bridge BRIDGE doesn't exist---return an error or try to create that bridge? If it is the former, then who must create that bridge? -- Libvir-list mailing list

Re: [libvirt] virDomanMigrate on kvm fails

2008-10-07 Thread Daniel P. Berrange
On Tue, Oct 07, 2008 at 09:55:00AM +0200, Kenneth Nagin wrote: > > virDomainMigrate fails when the domain is a kvm guest. > The error message is "this function is not supported by the hypervisor: > virDomainMigrate." This error message indicates the problem. Migration is not yet supported. Curre

[libvirt] virDomanMigrate on kvm fails

2008-10-07 Thread Kenneth Nagin
virDomainMigrate fails when the domain is a kvm guest. The error message is "this function is not supported by the hypervisor: virDomainMigrate." I tried migrating with virsh but it says it can not connected to the destination host. I have successfully created copies of the same image on both so

Re: [libvirt] Routed Networking - Ubuntu Hardy KVM and LibVirt

2008-10-07 Thread Mads Chr. Olesen
tir, 07 10 2008 kl. 16:33 +0930, skrev Barry Robinson: > I have tried using the option (under the bridge > name option). This does add the forward rules, but for some reason > still applies the MASQUERADE rule to the 192.168.17.0/24 network. (eg. > 0 0 MASQUERADE all -- * * 192.1

[libvirt] Routed Networking - Ubuntu Hardy KVM and LibVirt

2008-10-07 Thread Barry Robinson
Gday, I have been searching for information on how to configure KVM guest OS' to do simple routing from their associated vnetX address to the host machine's ethernet network subnet (lets say eth0/192.168.0.0/24). I understand that by default the clients are NAT'ed to the Host's adapter. This is